Skip to contentSkip to conversation

Add qemu_vga.ndrv to build/pc-bios folder

PATCH Applied John Arbuckle 3 participants 4 messages Aug 31, 2021 – Sep 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add qemu_vga.ndrv to build/pc-bios folder

Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.

---
 configure | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
configure +3 -1
index 9a79a004d7..281577e46f 100755
@@ -5056,7 +5056,9 @@ for bios_file in \
     $source_path/pc-bios/openbios-* \
     $source_path/pc-bios/u-boot.* \
     $source_path/pc-bios/edk2-*.fd.bz2 \
-    $source_path/pc-bios/palcode-*
+    $source_path/pc-bios/palcode-* \
+    $source_path/pc-bios/qemu_vga.ndrv
+
 do
     LINKS="$LINKS pc-bios/$(basename $bios_file)"
 done
Signature · 1 line
2.24.3 (Apple Git-128)
#1 lore raw
Quoted 12 lines · John Arbuckle

Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.

---
  configure | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index 9a79a004d7..281577e46f 100755

configure for bios_file in \ · line 5064

Quoted 10 lines
configure +3 -1
@@ -5056,7 +5056,9 @@ for bios_file in \
      $source_path/pc-bios/openbios-* \
      $source_path/pc-bios/u-boot.* \
      $source_path/pc-bios/edk2-*.fd.bz2 \
-    $source_path/pc-bios/palcode-*
+    $source_path/pc-bios/palcode-* \
+    $source_path/pc-bios/qemu_vga.ndrv
+
  do
      LINKS="$LINKS pc-bios/$(basename $bios_file)"
  done

I think the patch looks correct, however the commit message and subject aren't quite right. How about something like:

[PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree

Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory.

ATB,

Mark.

#2 lore raw
Quoted 29 lines · Mark Cave-Ayland
Quoted 10 lines · John Arbuckle

Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.

---
 configure | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index 9a79a004d7..281577e46f 100755

configure for bios_file in \ · line 5064

Quoted 10 lines
configure +3 -1
@@ -5056,7 +5056,9 @@ for bios_file in \
     $source_path/pc-bios/openbios-* \
     $source_path/pc-bios/u-boot.* \
     $source_path/pc-bios/edk2-*.fd.bz2 \
-    $source_path/pc-bios/palcode-*
+    $source_path/pc-bios/palcode-* \
+    $source_path/pc-bios/qemu_vga.ndrv
+
 do
     LINKS="$LINKS pc-bios/$(basename $bios_file)"
 done

I think the patch looks correct, however the commit message and subject aren't quite right. How about something like:

Quoted 8 lines

[PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree

Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory.

ATB,

Mark.

Ok. I will create a new patch with these changes.

#3 lore raw

Le 31/08/2021 à 22:52, Programmingkid a écrit :

Quoted 31 lines
Quoted 31 lines · Mark Cave-Ayland
Quoted 10 lines · John Arbuckle

Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.

---
 configure | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index 9a79a004d7..281577e46f 100755

configure for bios_file in \ · line 5064

Quoted 10 lines
configure +3 -1
@@ -5056,7 +5056,9 @@ for bios_file in \
     $source_path/pc-bios/openbios-* \
     $source_path/pc-bios/u-boot.* \
     $source_path/pc-bios/edk2-*.fd.bz2 \
-    $source_path/pc-bios/palcode-*
+    $source_path/pc-bios/palcode-* \
+    $source_path/pc-bios/qemu_vga.ndrv
+
 do
     LINKS="$LINKS pc-bios/$(basename $bios_file)"
 done

I think the patch looks correct, however the commit message and subject aren't quite right. How about something like:

[PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree

Quoted 9 lines
Quoted 6 lines

Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory.

ATB,

Mark.

Ok. I will create a new patch with these changes.

Applied to my trivial-patches branch with Mark's commit message rewording and Peter's R-b.

Thanks,
Laurent