Skip to contentSkip to conversation

clk: versatile: Rename ICST to CLK_ICST

PATCH Applied Jean Delvare 3 participants 6 messages Sep 1, 2021 – Oct 15, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 clk: versatile: Rename ICST to CLK_ICST

For consistency, prefix the ICST config option with CLK as all other clock source drivers have.

Cc Linus Walleij <[email protected]>
Cc Michael Turquette <[email protected]>
Cc Stephen Boyd <[email protected]>
---
 arch/arm/mach-integrator/Kconfig |    2 +-
 arch/arm/mach-realview/Kconfig   |    2 +-
 arch/arm/mach-versatile/Kconfig  |    2 +-
 arch/arm/mach-vexpress/Kconfig   |    2 +-
 drivers/clk/versatile/Kconfig    |    2 +-
 drivers/clk/versatile/Makefile   |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/mach-integrator/Kconfig +1 -1
@@ -6,7 +6,7 @@ menuconfig ARCH_INTEGRATOR
 	select CMA
 	select DMA_CMA
 	select HAVE_TCM
-	select ICST
+	select CLK_ICST
 	select MFD_SYSCON
 	select PLAT_VERSATILE
 	select POWER_RESET
arch/arm/mach-realview/Kconfig +1 -1
@@ -11,7 +11,7 @@ menuconfig ARCH_REALVIEW
 	select HAVE_ARM_TWD if SMP
 	select HAVE_PATA_PLATFORM
 	select HAVE_TCM
-	select ICST
+	select CLK_ICST
 	select MACH_REALVIEW_EB if ARCH_MULTI_V5
 	select MFD_SYSCON
 	select PLAT_VERSATILE
arch/arm/mach-versatile/Kconfig +1 -1
@@ -7,7 +7,7 @@ config ARCH_VERSATILE
 	select ARM_VIC
 	select CLKSRC_VERSATILE
 	select CPU_ARM926T
-	select ICST
+	select CLK_ICST
 	select MFD_SYSCON
 	select PLAT_VERSATILE
 	select POWER_RESET
arch/arm/mach-vexpress/Kconfig +1 -1
@@ -11,7 +11,7 @@ menuconfig ARCH_VEXPRESS
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select HAVE_PATA_PLATFORM
-	select ICST
+	select CLK_ICST
 	select NO_IOPORT_MAP
 	select PLAT_VERSATILE
 	select POWER_RESET
drivers/clk/versatile/Kconfig +1 -1
@@ -3,7 +3,7 @@
 menu "Clock driver for ARM Reference designs"
 	depends on HAS_IOMEM
 
-config ICST
+config CLK_ICST
 	bool "Clock driver for ARM Reference designs ICST"
 	select REGMAP_MMIO
 	help
drivers/clk/versatile/Makefile +1 -1
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 # Makefile for Versatile-specific clocks
-obj-$(CONFIG_ICST)		+= icst.o clk-icst.o clk-versatile.o
+obj-$(CONFIG_CLK_ICST)		+= icst.o clk-icst.o clk-versatile.o
 obj-$(CONFIG_INTEGRATOR_IMPD1)	+= clk-impd1.o
 obj-$(CONFIG_CLK_SP810)		+= clk-sp810.o
 obj-$(CONFIG_CLK_VEXPRESS_OSC)	+= clk-vexpress-osc.o
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw

PATCH 2/2 clk: versatile: hide clock drivers from non-ARM users

Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") made the whole menu of ARM reference clock drivers visible on all architectures. I can't see how this is an improvement for non-ARM users. Unless build-testing, there is no point on presenting ARM-only clock drivers on other architectures.

Cc Peter Collingbourne <[email protected]>
Cc Lee Jones <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Stephen Boyd <[email protected]>
---
 drivers/clk/versatile/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/versatile/Kconfig +1 -0
@@ -2,6 +2,7 @@
 
 menu "Clock driver for ARM Reference designs"
 	depends on HAS_IOMEM
+	depends on ARM || ARM64 || COMPILE_TEST
 
 config CLK_ICST
 	bool "Clock driver for ARM Reference designs ICST"
Signature · 2 lines
Jean Delvare
SUSE L3 Support
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users

Quoted 11 lines · Jean Delvare

Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") made the whole menu of ARM reference clock drivers visible on all architectures. I can't see how this is an improvement for non-ARM users. Unless build-testing, there is no point on presenting ARM-only clock drivers on other architectures.

Cc Peter Collingbourne <[email protected]>
Cc Lee Jones <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Stephen Boyd <[email protected]>

OK then:

Yours,
Linus Walleij

maintainer Applied
#3 lore raw

Re: [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users

In reply to Jean Delvare

Quoting Jean Delvare (2021-09-01 09:09:53)

Quoted 6 lines

Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*") made the whole menu of ARM reference clock drivers visible on all architectures. I can't see how this is an improvement for non-ARM users. Unless build-testing, there is no point on presenting ARM-only clock drivers on other architectures.

Quoted 6 lines
Cc Peter Collingbourne <[email protected]>
Cc Lee Jones <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Stephen Boyd <[email protected]>

---

Applied to clk-next