Skip to contentSkip to conversation

test/gem_exec_suspend: Enable the test for discrete GPUs

PATCH Superseded Thomas Hellström 4 participants 6 messages Sep 3, 2021 – Sep 6, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/gem_exec_suspend: Enable the test for discrete GPUs

Discrete GPUs don't support gem_set_caching() and uses a single, kernel provided mapping mode, FIXED. Adjust the test accordingly.

This makes the test run on DG1.

---
 tests/i915/gem_exec_suspend.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
tests/i915/gem_exec_suspend.c +16 -1
index dbe0c8a7..5f17e600 100644
@@ -114,7 +114,8 @@ static void run_test(int fd, const intel_ctx_t *ctx,
 
 	memset(obj, 0, sizeof(obj));
 	obj[0].handle = gem_create(fd, 4096);
-	gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
+	if (!gem_has_lmem(fd))
+		gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
 	obj[0].flags |= EXEC_OBJECT_WRITE;
 	obj[1].handle = gem_create(fd, 4096);
 	gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe));
@@ -293,6 +294,7 @@ igt_main
 	const struct intel_execution_engine2 *e;
 	igt_hang_t hang;
 	const intel_ctx_t *ctx;
+	bool has_lmem;
 	int fd;
 
 	igt_fixture {
@@ -302,6 +304,7 @@ igt_main
 		ctx = intel_ctx_create_all_physical(fd);
 
 		igt_fork_hang_detector(fd);
+		has_lmem = gem_has_lmem(fd);
 	}
 
 	igt_subtest("basic")
@@ -318,6 +321,18 @@ igt_main
 		run_test(fd, ctx, ALL_ENGINES, HIBERNATE);
 
 	for (m = modes; m->suffix; m++) {
+		if (has_lmem) {
+			igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
+				for_each_ctx_engine(fd, ctx, e) {
+					if (!gem_class_can_store_dword(fd, e->class))
+						continue;
+					igt_dynamic_f("%s", e->name)
+						run_test(fd, ctx, e->flags, m->mode);
+				}
+			}
+			continue;
+		}
+
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			for_each_ctx_engine(fd, ctx, e) {
 				if (!gem_class_can_store_dword(fd, e->class))
Signature · 1 line
2.31.1
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for test/gem_exec_suspend: Enable the test for discrete GPUs

== Series Details ==

== Series Details ==

Series: test/gem_exec_suspend: Enable the test for discrete GPUs
URL : https://patchwork.freedesktop.org/series/94325/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10549 -> IGTPW_6195
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/index.html

Known issues
------------

Here are the changes found in IGTPW_6195 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/fi-rkl-guc/igt@amdgpu/[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][2] -> [SKIP][3] ([fdo#109271])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/fi-kbl-guc/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/fi-kbl-guc/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: NOTRUN -> [DMESG-WARN][4] ([i915#3958])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: NOTRUN -> [DMESG-WARN][5] ([i915#3967])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/fi-rkl-guc/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-rkl-guc: [DMESG-WARN][6] ([i915#3925]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/fi-rkl-guc/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/fi-rkl-guc/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#3925]: https://gitlab.freedesktop.org/drm/intel/issues/3925
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958
[i915#3967]: https://gitlab.freedesktop.org/drm/intel/issues/3967

Participating hosts (46 -> 39)
------------------------------

Missing (7): bat-adls-5 fi-hsw-4200u bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6197 -> IGTPW_6195

CI-20190529: 20190529
CI_DRM_10549: cd8e346a0b56ce66f94a9908c7a068bbee8f1829 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6195: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/index.html
IGT_6197: 40888f97a6ad219f4ed48a1830d0ef3c9617d006 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/index.html

#3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for test/gem_exec_suspend: Enable the test for discrete GPUs

In reply to Thomas Hellström
== Series Details ==

== Series Details ==

Series: test/gem_exec_suspend: Enable the test for discrete GPUs
URL : https://patchwork.freedesktop.org/series/94325/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10549_full -> IGTPW_6195_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/index.html

Known issues
------------

Here are the changes found in IGTPW_6195_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@chamelium:
- shard-tglb: NOTRUN -> [SKIP][1] ([fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb6/igt@[email protected]

* igt@feature_discovery@display-2x:
- shard-iclb: NOTRUN -> [SKIP][2] ([i915#1839])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb1/igt@[email protected]

* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#1839])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb1/igt@[email protected]

* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-snb5/igt@[email protected]

* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-snb6/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-iclb: [PASS][6] -> [TIMEOUT][7] ([i915#3070])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-iclb5/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-kbl4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl3/igt@[email protected]
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2846])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk2/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk5/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: NOTRUN -> [FAIL][12] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][13] -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-apl8/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][15] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk9/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-tglb3/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@secure-non-master:
- shard-iclb: NOTRUN -> [SKIP][20] ([fdo#112283])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#112283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb5/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#2190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl3/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][23] ([i915#2658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl7/igt@[email protected]

* igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271]) +140 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk7/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#768]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb5/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109312])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb8/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk3/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][28] ([i915#3002])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl3/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][29] ([i915#3318])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk9/igt@[email protected]

* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109289]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb1/igt@gen3_render_tiledy_blits.html
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109289]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb5/igt@gen3_render_tiledy_blits.html

* igt@gen9_exec_parse@bb-oversize:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#2856]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@unaligned-access:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#2856]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#1904])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb1/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: NOTRUN -> [WARN][35] ([i915#2681])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][36] ([i915#1804] / [i915#2684])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb3/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111644] / [i915#1397] / [i915#2411])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb2/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109293] / [fdo#109506])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109506] / [i915#2411])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb1/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][40] -> [DMESG-WARN][41] ([i915#180])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-apl3/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl6/igt@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#404])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#404])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb8/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111614]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb5/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: NOTRUN -> [DMESG-WARN][45] ([i915#118] / [i915#95])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk3/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#110725] / [fdo#111614]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3777])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk2/igt@[email protected]

* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3777]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271]) +270 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#110723]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][52] ([i915#2705])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb5/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278] / [i915#3886]) +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3689] / [i915#3886]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#3886]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +18 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3689]) +13 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#3886]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@hdmi-cmp-planar-formats:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109284] / [fdo#111827]) +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +27 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-glk: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +10 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk4/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-negative:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +9 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl1/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +19 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-snb6/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109300] / [fdo#111066])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][66] ([i915#2105])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278] / [fdo#109279]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#109279] / [i915#3359]) +4 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3319]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3359]) +5 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb6/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge:
- shard-glk: [PASS][71] -> [DMESG-WARN][72] ([i915#118] / [i915#95])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk8/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109274] / [fdo#109278]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb8/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#2346])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk8/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk4/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk3/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-move:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109278]) +27 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]

* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#3840])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109274]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-glk: NOTRUN -> [FAIL][80] ([i915#2546])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-snb: NOTRUN -> [SKIP][81] ([fdo#109271]) +368 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-snb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109280]) +26 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#111825]) +37 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][84] -> [SKIP][85] ([i915#433])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-tglb2/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@[email protected]

* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#1187])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#1187])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][90] ([fdo#108145] / [i915#265])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl1/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3536]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#112054])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb3/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#1836])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#658]) +4 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2920]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-glk: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +5 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk8/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#658]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb6/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#658]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl3/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][99] ([i915#132] / [i915#3467])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb8/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109441]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][101] -> [SKIP][102] ([fdo#109441]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-iclb2/igt@kms_psr@psr2_suspend.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb1/igt@kms_psr@psr2_suspend.html

* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#533]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109502])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb4/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2437]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][106] ([i915#2437])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb8/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2437])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][108] ([i915#2437]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2437])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk8/igt@[email protected]

* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#2530])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb6/igt@[email protected]

* igt@nouveau_crc@pipe-c-source-rg:
- shard-iclb: NOTRUN -> [SKIP][111] ([i915#2530]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb8/igt@[email protected]

* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][112] ([fdo#109271]) +87 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl3/igt@[email protected]

* igt@prime_nv_test@nv_write_i915_cpu_mmap_read:
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109291]) +5 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb5/igt@prime_nv_test@nv_write_i915_cpu_mmap_read.html

* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][114] ([fdo#109291]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@prime_udl.html

* igt@sysfs_clients@recycle-many:
- shard-glk: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2994]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk9/igt@[email protected]

* igt@sysfs_clients@sema-10:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2994]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl1/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#2994])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-kbl: [DMESG-WARN][118] ([i915#180]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl7/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][120] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-tglb6/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][122] ([i915#2842]) -> [PASS][123] +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-kbl3/igt@gem_exec_fair@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][124] ([i915#2842]) -> [PASS][125] +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-tglb6/igt@gem_exec_fair@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][126] ([i915#2842]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk1/igt@gem_exec_fair@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][128] ([i915#307]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-iclb3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-iclb6/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][130] ([i915#180]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-apl3/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-apl2/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][132] ([i915#1436] / [i915#716]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10549/shard-glk2/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/shard-glk2/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][134] ([i915#118] / [i915#95]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_105

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6195/index.html

#4 lore raw
In reply to Thomas Hellström
Quoted 41 lines · Thomas Hellström

Discrete GPUs don't support gem_set_caching() and uses a single, kernel provided mapping mode, FIXED. Adjust the test accordingly.

This makes the test run on DG1.

---
 tests/i915/gem_exec_suspend.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
tests/i915/gem_exec_suspend.c +4 -1
index dbe0c8a7..5f17e600 100644
@@ -114,7 +114,8 @@ static void run_test(int fd, const intel_ctx_t *ctx,
 
 	memset(obj, 0, sizeof(obj));
 	obj[0].handle = gem_create(fd, 4096);
-	gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
+	if (!gem_has_lmem(fd))
+		gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
 	obj[0].flags |= EXEC_OBJECT_WRITE;
 	obj[1].handle = gem_create(fd, 4096);
 	gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe));
@@ -293,6 +294,7 @@ igt_main
 	const struct intel_execution_engine2 *e;
 	igt_hang_t hang;
 	const intel_ctx_t *ctx;
+	bool has_lmem;
 	int fd;
 
 	igt_fixture {
@@ -302,6 +304,7 @@ igt_main
 		ctx = intel_ctx_create_all_physical(fd);
 
 		igt_fork_hang_detector(fd);
+		has_lmem = gem_has_lmem(fd);
 	}
 
 	igt_subtest("basic")

tests/i915/gem_exec_suspend.c igt_main · line 325

Quoted 5 lines
tests/i915/gem_exec_suspend.c +2 -0
@@ -318,6 +321,18 @@ igt_main
 		run_test(fd, ctx, ALL_ENGINES, HIBERNATE);
 
 	for (m = modes; m->suffix; m++) {
+		if (has_lmem) {
+			igt_subtest_with_dynamic_f("fixed%s", m->suffix) {

You can't do

if (something_that_depends_on_the_running_system)
igt_subtest_of_any_kind(...)

Instead you need to do

igt_subtest_of_any_kind(...) {
igt_require(something_that_depends_on_the_running_system);
...
}

Signature · 1 line
Petri Latvala
Quoted 16 lines
tests/i915/gem_exec_suspend.c +10 -0
+				for_each_ctx_engine(fd, ctx, e) {
+					if (!gem_class_can_store_dword(fd, e->class))
+						continue;
+					igt_dynamic_f("%s", e->name)
+						run_test(fd, ctx, e->flags, m->mode);
+				}
+			}
+			continue;
+		}
+
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			for_each_ctx_engine(fd, ctx, e) {
 				if (!gem_class_can_store_dword(fd, e->class))
Signature · 1 line
2.31.1
#5 lore raw
Quoted 53 lines · Petri Latvala
Quoted 41 lines · Thomas Hellström

Discrete GPUs don't support gem_set_caching() and uses a single, kernel provided mapping mode, FIXED. Adjust the test accordingly.

This makes the test run on DG1.

---
  tests/i915/gem_exec_suspend.c | 17 ++++++++++++++++-
  1 file changed, 16 insertions(+), 1 deletion(-)
tests/i915/gem_exec_suspend.c +4 -1
index dbe0c8a7..5f17e600 100644
@@ -114,7 +114,8 @@ static void run_test(int fd, const intel_ctx_t *ctx,
 
  	memset(obj, 0, sizeof(obj));
  	obj[0].handle = gem_create(fd, 4096);
-	gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
+	if (!gem_has_lmem(fd))
+		gem_set_caching(fd, obj[0].handle, !!(flags & CACHED));
  	obj[0].flags |= EXEC_OBJECT_WRITE;
  	obj[1].handle = gem_create(fd, 4096);
  	gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe));
@@ -293,6 +294,7 @@ igt_main
  	const struct intel_execution_engine2 *e;
  	igt_hang_t hang;
  	const intel_ctx_t *ctx;
+	bool has_lmem;
  	int fd;
 
  	igt_fixture {
@@ -302,6 +304,7 @@ igt_main
  		ctx = intel_ctx_create_all_physical(fd);
 
  		igt_fork_hang_detector(fd);
+		has_lmem = gem_has_lmem(fd);
  	}
 
  	igt_subtest("basic")

tests/i915/gem_exec_suspend.c igt_main · line 325

Quoted 5 lines
tests/i915/gem_exec_suspend.c +2 -0
@@ -318,6 +321,18 @@ igt_main
  		run_test(fd, ctx, ALL_ENGINES, HIBERNATE);
 
  	for (m = modes; m->suffix; m++) {
+		if (has_lmem) {
+			igt_subtest_with_dynamic_f("fixed%s", m->suffix) {

You can't do

if (something_that_depends_on_the_running_system)
igt_subtest_of_any_kind(...)

Quoted 8 lines

Instead you need to do

igt_subtest_of_any_kind(...) {
   igt_require(something_that_depends_on_the_running_system);
   ...
}

Thanks. I'll respin.

/Thomas