Skip to contentSkip to conversation

tests/i915/gem_ctx_persistence: modified test_saturated_hostile subtest

PATCH In review Arjun Melkaveri 3 participants 3 messages Sep 4, 2021 – Sep 9, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/i915/gem_ctx_persistence: modified test_saturated_hostile subtest

Applying saturated_hostile to support for twiddling the scheduling parameters via sysfs to tune timeouts.

New Context is created in for_each_ctx_cfg_engine and passed to get_reloc_ahnd.

v2 : Added DRM issue id.

Cc Zbigniew Kempczyński <[email protected]>
Cc Ashutosh Dixit <[email protected]>
---
 tests/i915/gem_ctx_persistence.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)
tests/i915/gem_ctx_persistence.c +12 -9
index fafd8bb2..251c0037 100644
@@ -876,13 +876,13 @@ static void test_process_mixed(int pfd, const intel_ctx_cfg_t *cfg,
 }
 
 static void
-test_saturated_hostile(int i915, const intel_ctx_t *base_ctx,
-		       const struct intel_execution_engine2 *engine)
+test_saturated_hostile(int i915, const intel_ctx_cfg_t *cfg,
+		       unsigned int engine_flags)
 {
 	const struct intel_execution_engine2 *other;
 	igt_spin_t *spin;
 	const intel_ctx_t *ctx;
-	uint64_t ahnd = get_reloc_ahnd(i915, base_ctx->id);
+	uint64_t ahnd;
 	int fence = -1;
 
 	cleanup(i915);
@@ -899,11 +899,13 @@ test_saturated_hostile(int i915, const intel_ctx_t *base_ctx,
 	 * reset other users whenever they chose.]
 	 */
 
-	for_each_ctx_engine(i915, base_ctx, other) {
-		if (other->flags == engine->flags)
+	for_each_ctx_cfg_engine(i915, cfg, other) {
+		if (other->flags == engine_flags)
 			continue;
 
-		spin = igt_spin_new(i915, .ahnd = ahnd, .ctx = base_ctx,
+		ctx = intel_ctx_create(i915, cfg);
+		ahnd = get_reloc_ahnd(i915, ctx->id);
+		spin = igt_spin_new(i915, .ahnd = ahnd, .ctx = ctx,
 				   .engine = other->flags,
 				   .flags = (IGT_SPIN_NO_PREEMPTION |
 					     IGT_SPIN_FENCE_OUT));
@@ -924,10 +926,10 @@ test_saturated_hostile(int i915, const intel_ctx_t *base_ctx,
 	put_ahnd(ahnd);
 	igt_require(fence != -1);
 
-	ctx = ctx_create_persistence(i915, &base_ctx->cfg, false);
+	ctx = ctx_create_persistence(i915, cfg, false);
 	ahnd = get_reloc_ahnd(i915, ctx->id);
 	spin = igt_spin_new(i915, .ahnd = ahnd, .ctx = ctx,
-			    .engine = engine->flags,
+			    .engine = engine_flags,
 			    .flags = (IGT_SPIN_NO_PREEMPTION |
 				      IGT_SPIN_POLL_RUN |
 				      IGT_SPIN_FENCE_OUT));
@@ -1310,7 +1312,8 @@ igt_main
 		igt_subtest_with_dynamic_f("saturated-hostile") {
 			for_each_ctx_engine(i915, ctx, e) {
 				igt_dynamic_f("%s", e->name)
-					test_saturated_hostile(i915, ctx, e);
+					do_test(test_saturated_hostile, i915,
+						&ctx->cfg, e->flags, e->name);
 			}
 		}
 
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/gem_ctx_persistence: modified test_saturated_hostile subtest (rev2)

== Series Details ==

== Series Details ==

Series: tests/i915/gem_ctx_persistence: modified test_saturated_hostile subtest (rev2)
URL : https://patchwork.freedesktop.org/series/94290/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10550 -> IGTPW_6199
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6199 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6199, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6199:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@basic-flip-vs-dpms:
- fi-rkl-11600: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-rkl-11600: [PASS][2] -> [SKIP][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6199 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@fbdev@write:
- fi-rkl-11600: [PASS][4] -> [SKIP][5] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-rkl-11600: [PASS][6] -> [SKIP][7] ([fdo#109308]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][8] -> [DMESG-WARN][9] ([i915#3958])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@gt_pm:
- fi-icl-y: [PASS][10] -> [DMESG-FAIL][11] ([i915#2291])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-icl-y/igt@i915_selftest@live@gt_pm.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-icl-y/igt@i915_selftest@live@gt_pm.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-rkl-11600: [PASS][12] -> [SKIP][13] ([fdo#111825]) +7 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@kms_flip@basic-flip-vs-modeset:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#3669]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-rkl-11600: [PASS][15] -> [SKIP][16] ([i915#3180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
- fi-rkl-11600: [PASS][17] -> [SKIP][18] ([i915#3919]) +9 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- fi-rkl-11600: [PASS][19] -> [SKIP][20] ([i915#1845])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-rkl-11600/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-rkl-11600/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-icl-y: [DMESG-FAIL][21] ([i915#1993]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-icl-y/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-icl-y/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-7500u: [FAIL][23] ([i915#3449]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10550/fi-kbl-7500u/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/fi-kbl-7500u/igt@[email protected]

[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180
[i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449
[i915#3669]: https://gitlab.freedesktop.org/drm/intel/issues/3669
[i915#3919]: https://gitlab.freedesktop.org/drm/intel/issues/3919
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958

Participating hosts (45 -> 39)
------------------------------

Missing (6): bat-adls-5 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6197 -> IGTPW_6199

CI-20190529: 20190529
CI_DRM_10550: 07f6ce3dba287a2aa8a62cdd3b7d46ea0676007f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6199: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/index.html
IGT_6197: 40888f97a6ad219f4ed48a1830d0ef3c9617d006 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6199/index.html

#2 lore raw
In reply to Arjun Melkaveri

tests/i915/gem_ctx_persistence.c igt_main · line 1316

Quoted 8 lines · Arjun Melkaveri
tests/i915/gem_ctx_persistence.c +2 -1
@@ -1310,7 +1312,8 @@ igt_main
 		igt_subtest_with_dynamic_f("saturated-hostile") {
 			for_each_ctx_engine(i915, ctx, e) {
 				igt_dynamic_f("%s", e->name)
-					test_saturated_hostile(i915, ctx, e);
+					do_test(test_saturated_hostile, i915,
+						&ctx->cfg, e->flags, e->name);

I think I am missing something but I am trying to understand how does this patch solves the failure in Gitlab #1551
(https://gitlab.freedesktop.org/drm/intel/-/issues/1551). Could you explain:

(a) the cause of the timeout that is being seen in Gitlab #1551, and
(b) how this patch (using do_test) resolves that.

Thanks.