staging: r8188eu: remove useless check
PATCH 1/1 staging: r8188eu: remove useless check
smatch says:
usb_intf.c:326 rtw_hw_suspend() warn: variable dereferenced before check 'padapter' (see line 323) usb_intf.c:387 rtw_hw_resume() warn: variable dereferenced before check 'padapter' (see line 385)
There is only one caller of rtw_hw_suspend() and it does not check padapter pointer, so let's just omit this check to make smatch happy.
Signed-off-by Pavel Skripkin <[email protected]>
--- drivers/staging/r8188eu/os_dep/usb_intf.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/r8188eu/os_dep/usb_intf.c +0 -3
@@ -322,9 +322,6 @@ int rtw_hw_suspend(struct adapter *padapter)struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;struct net_device *pnetdev = padapter->pnetdev; - -if (!padapter) - goto error_exit;if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { DBG_88E("padapter->bup=%d bDriverStopped=%d bSurpriseRemoved = %d\n",
Signature · 1 line
2.33.0