Skip to contentSkip to conversation

tests/i915/i915_pm_lpsp : Close fd after igt_display_fini execution.

PATCH In review Mohammed Thasleem 3 participants 5 messages Mar 10, 2022 – Mar 11, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 tests/i915/i915_pm_lpsp : Close fd after igt_display_fini execution.

Close fd after igt_display_fini to avoid bad fd failure.

---
 tests/i915/i915_pm_lpsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/i915_pm_lpsp.c +1 -1
index b3b1561e..3ad8b260 100644
@@ -210,7 +210,7 @@ igt_main
 
 	igt_fixture {
 		free(data.pwr_dmn_info);
-		close(data.drm_fd);
 		igt_display_fini(&data.display);
+		close(data.drm_fd);
 	}
 }
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 2/2 tests/i915/kms_dsc : Close fd after igt_display_fini execution.

Close fd after igt_display_fini to avoid bad fd failure.

---
 tests/i915/kms_dsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/kms_dsc.c +1 -1
index ee52ffcc..22d2216e 100644
@@ -354,7 +354,7 @@ igt_main
 			drmModeFreeConnector(connector);
 		test_cleanup(&data);
 		drmModeFreeResources(res);
-		close(data.drm_fd);
 		igt_display_fini(&data.display);
+		close(data.drm_fd);
 	}
 }
Signature · 1 line
2.25.1
Reviewed-by on v2 2/2
#2 lore raw

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915/kms_dsc : Close fd after igt_display_fini execution.

Quoted 3 lines · Mohammed Thasleem

Close fd after igt_display_fini to avoid bad fd failure.

Quoted 17 lines
---
  tests/i915/kms_dsc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/kms_dsc.c +1 -1
index ee52ffcc..22d2216e 100644
@@ -354,7 +354,7 @@ igt_main
  			drmModeFreeConnector(connector);
  		test_cleanup(&data);
  		drmModeFreeResources(res);
-		close(data.drm_fd);
  		igt_display_fini(&data.display);
+		close(data.drm_fd);
  	}
  }
#3 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/2] tests/i915/i915_pm_lpsp : Close fd after igt_display_fini execution.

In reply to Mohammed Thasleem
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/i915/i915_pm_lpsp : Close fd after igt_display_fini execution.
URL : https://patchwork.freedesktop.org/series/101235/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11348 -> IGTPW_6771
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6771 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6771, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/index.html

Participating hosts (45 -> 42)
------------------------------

Additional (2): fi-kbl-soraka fi-pnv-d510
Missing (5): shard-tglu fi-tgl-1115g4 fi-bsw-cyan shard-rkl shard-dg1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6771:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-icl-u2: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-icl-u2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6771 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][6] ([fdo#109271]) +58 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-pnv-d510/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][9] -> [INCOMPLETE][10] ([i915#2940])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-bsw-n3050/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-bsw-n3050/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@kms_chamelium@dp-edid-read:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#533])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-kbl-soraka/igt@[email protected]

* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][14] ([i915#1814] / [i915#2722] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-icl-u2/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-bsw-n3050/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [FAIL][16] ([i915#2426] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@guc_multi_lrc:
- {bat-rpls-2}: [DMESG-WARN][17] ([i915#4391]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/bat-rpls-2/igt@i915_selftest@live@guc_multi_lrc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/bat-rpls-2/igt@i915_selftest@live@guc_multi_lrc.html

* igt@kms_busy@basic@flip:
- {bat-adlp-6}: [DMESG-WARN][19] ([i915#3576]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/bat-adlp-6/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/bat-adlp-6/igt@kms_busy@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6373 -> IGTPW_6771

CI-20190529: 20190529
CI_DRM_11348: 896acee3ca564ae87ab881c4805a600271a128b2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6771: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/index.html
IGT_6373: 82306f1903c0fee8371f43a156d8b63163ca61c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6771/index.html

Reviewed-by on v2 1/2
#4 lore raw
In reply to Mohammed Thasleem
Quoted 3 lines · Mohammed Thasleem

Close fd after igt_display_fini to avoid bad fd failure.

Quoted 17 lines
---
  tests/i915/i915_pm_lpsp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/i915_pm_lpsp.c +1 -1
index b3b1561e..3ad8b260 100644
@@ -210,7 +210,7 @@ igt_main
 
  	igt_fixture {
  		free(data.pwr_dmn_info);
-		close(data.drm_fd);
  		igt_display_fini(&data.display);
+		close(data.drm_fd);
  	}
  }