Skip to contentSkip to conversation

configs/ordeidc2: increase image size to 256M

PATCH In review Dagg Stompler 2 participants 6 messages Sep 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/ordeidc2: increase image size to 256M

following Commit 9f127cc4, the resulting image is bigger than possible. so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/odroidc2_defconfig +1 -0
index 5f97fc3dd8..daa818e036 100644
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
 

--
2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#1 lore raw

Dagg, All,

On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:

Quoted 1 line

following Commit 9f127cc4, the resulting image is bigger than possible.

I fail to see how commit 9f127cc4 can be the culprit:

9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding

Quoted 1 line

so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

The default is 60M; bumping to 256M is surely a big jump. Can't we settle for something smaller, like 128M?

Also, note that the default is 60M, as we consider a 64M SDCard, and thus some space is reserved at the begining for the boot blobs; see board/hardkernel/odroidc2/genimage.cfg

And as a consequence, the size of the SDCard must also be updated in board/hardkernel/odroidc2/genimage.cfg.

So, maybe:
- update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
- update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/odroidc2_defconfig +1 -1
index 5f97fc3dd8..daa818e036 100644
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
 
--

2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Dagg, All,

On 2021-09-11 11:27 +0200, Yann E. MORIN spake thusly:

Quoted 5 lines

On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:

Quoted 4 lines

following Commit 9f127cc4, the resulting image is bigger than possible. so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

In fact, that error is about another issue that was recently fixed:

    https://git.buildroot.org/buildroot/commit/?id=4ad23552c6

Can you verify that the test still works with the current master, before increasing the fs size?

Regards,
Yann E. MORIN.

Quoted 36 lines
Quoted 24 lines
---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/odroidc2_defconfig +1 -1
index 5f97fc3dd8..daa818e036 100644
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
 
--

2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#3 lore raw

Greetings Yann,

Quoted 17 lines

Sent: Saturday, September 11, 2021 at 12:30 PM
From: "Yann E. MORIN" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: [email protected]
Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M

Dagg, All,

On 2021-09-11 11:27 +0200, Yann E. MORIN spake thusly:

Quoted 5 lines

On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:

Quoted 4 lines

following Commit 9f127cc4, the resulting image is bigger than possible. so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

In fact, that error is about another issue that was recently fixed:

Quoted 8 lines
    https://git.buildroot.org/buildroot/commit/?id=4ad23552c6

Can you verify that the test still works with the current master, before increasing the fs size?

Regards,
Yann E. MORIN.

as said in previous mail it reproduced on my setup with today's master
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

author
#4 lore raw
In reply to Yann E. MORIN

Greeting Yann,

Quoted 27 lines

Sent: Saturday, September 11, 2021 at 12:27 PM
From: "Yann E. MORIN" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: [email protected]
Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M

Dagg, All,

On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:

Quoted 1 line

following Commit 9f127cc4, the resulting image is bigger than possible.

I fail to see how commit 9f127cc4 can be the culprit:

9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding

Quoted 1 line

so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

The default is 60M; bumping to 256M is surely a big jump. Can't we settle for something smaller, like 128M?

Also, note that the default is 60M, as we consider a 64M SDCard, and thus some space is reserved at the begining for the boot blobs; see board/hardkernel/odroidc2/genimage.cfg

And as a consequence, the size of the SDCard must also be updated in board/hardkernel/odroidc2/genimage.cfg.

Quoted 7 lines

So, maybe:
- update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
- update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

Regards,
Yann E. MORIN.

if you open the link stated in the commit msg and look at the right, you see the commit stated in it. I didn't thought I should verify if it is that commit.
this is the first error the autobuild finds which I can reproduce, so I assumed it is related to that commit.

I bumped it to 256M because I assumed the minimum is 60M, I'll test with 128M and report back

I'll adjust the commit based on our suggestions above.

Dagg.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Dagg, All,

On 2021-09-11 16:29 +0200, daggs spake thusly:

Quoted 32 lines
Quoted 24 lines

Sent: Saturday, September 11, 2021 at 12:27 PM
From: "Yann E. MORIN" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: [email protected]
Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:

Quoted 1 line

following Commit 9f127cc4, the resulting image is bigger than possible.

I fail to see how commit 9f127cc4 can be the culprit:

9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding

Quoted 1 line

so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

The default is 60M; bumping to 256M is surely a big jump. Can't we settle for something smaller, like 128M?

Also, note that the default is 60M, as we consider a 64M SDCard, and thus some space is reserved at the begining for the boot blobs; see board/hardkernel/odroidc2/genimage.cfg

And as a consequence, the size of the SDCard must also be updated in board/hardkernel/odroidc2/genimage.cfg.

Quoted 7 lines

So, maybe:
- update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
- update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

Regards,
Yann E. MORIN.

Quoted 5 lines

if you open the link stated in the commit msg and look at the right, you see the commit stated in it.
I didn't thought I should verify if it is that commit. this is the first error the autobuild finds which I can reproduce, so I assumed it is related to that commit.

Ah, the gitlab-ci job that tests the defconfigs only runs once a week, so you'd get the commit that was current by that time.

Also, the e2fsprogs bump to 1.46.3, which had the regression, was applied to the 'next' branch, which is not tested by the gitlab-ci infra, and thus the first issue to be reported was when next was eventually merged into master last week.

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot