Skip to contentSkip to conversation

configs/odroidc2: increase rootfs size to 124M

PATCH In review Dagg Stompler 2 participants 5 messages Sep 11, 2021 – Sep 13, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 configs/odroidc2: increase rootfs size to 124M

as result of e2fsprogs version bump, the image size required was increased.
so to fix it and make sure there is enough size, set BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

---

v1 -> v2:
reduce size from 256 to 124 (Yann E. MORIN)

 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/odroidc2_defconfig +1 -0
index 5f97fc3dd8..70e539d6f9 100644
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="124M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
 

--
2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#1 lore raw

PATCH 2/2 genimae/odroidc2: increase image size to 128M

as a result of BR2_TARGET_ROOTFS_EXT2_SIZE's increase to 124M, increase the image size to 128M

Thanks to Yann E. MORIN <[email protected]> for pointing it out

---
 board/hardkernel/odroidc2/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/hardkernel/odroidc2/genimage.cfg +1 -1
index f49c1deaf3..4ef229024a 100644
@@ -6,7 +6,7 @@ image boot.vfat {
 			"boot.scr"
 		}
 	}
-	size = 64M
+	size = 128M
 }
 
 image sdcard.img {

--
2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Re: [Buildroot] [PATCH 2/2] genimae/odroidc2: increase image size to 128M

Dagg, All,

On 2021-09-11 19:25 +0300, Dagg Stompler spake thusly:

Quoted 15 lines

as a result of BR2_TARGET_ROOTFS_EXT2_SIZE's increase to 124M, increase the image size to 128M

Thanks to Yann E. MORIN <[email protected]> for pointing it out

---
 board/hardkernel/odroidc2/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/hardkernel/odroidc2/genimage.cfg +0 -0
index f49c1deaf3..4ef229024a 100644

board/hardkernel/odroidc2/genimage.cfg image boot.vfat { · line 9

Quoted 5 lines
board/hardkernel/odroidc2/genimage.cfg +1 -1
@@ -6,7 +6,7 @@ image boot.vfat {
 			"boot.scr"
 		}
 	}
-	size = 64M
+	size = 128M

Arg, I was completely off on that one; this size only applies to the vfat partition, not to the whole SDcard image. My deepest apologies about this...

Regards,
Yann E. MORIN.

Quoted 10 lines
board/hardkernel/odroidc2/genimage.cfg +0 -1
 }
 
 image sdcard.img {
--

2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
In reply to Dagg Stompler

Dagg,

On 2021-09-11 19:25 +0300, Dagg Stompler spake thusly:

Quoted 4 lines

as result of e2fsprogs version bump, the image size required was increased.
so to fix it and make sure there is enough size, set BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

So, I was wondering what the reason for the size increase was, so I spawned a build in three conditions:

- my server's Ubuntu 16.04
- my laptop's Ubuntu 21.04
- a docker Bullseye on my server (so, minus the kernel, a stock Debian Bullseye)

In all three cases, the build succeeded with current master. The sice of the target/ directory is roughly 40MiB in all three cases, which is still far enoiugh from 60MiB that it should not cause any issue.

So, I'm still not sure that the reason is "Debian Bullseye", or that the solution is "increase the filesystem size".

Could you please try by aplying this patch to master, and rerun the build, and share the error message, please:

    diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
    index 74c99bd7b1..83c967c9df 100644
    --- a/fs/ext2/ext2.mk
    +++ b/fs/ext2/ext2.mk
    @@ -16,7 +16,7 @@ EXT2_MKFS_OPTS = $(call qstrip,$(BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS))
     EXT2_LABEL = $(subst ",,$(BR2_TARGET_ROOTFS_EXT2_LABEL))
     #" Syntax highlighting... :-/ )
     
    -EXT2_OPTS = \
    +EXT2_OPTS = -v \
     	-d $(TARGET_DIR) \
     	-r $(BR2_TARGET_ROOTFS_EXT2_REV) \
     	-N $(BR2_TARGET_ROOTFS_EXT2_INODES) \
Quoted 14 lines

---

v1 -> v2:
reduce size from 256 to 124 (Yann E. MORIN)

 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/odroidc2_defconfig +0 -0
index 5f97fc3dd8..70e539d6f9 100644

configs/odroidc2_defconfig BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0" · line 13

Quoted 4 lines
configs/odroidc2_defconfig +1 -0
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="124M"

If only this patch is applied, then the build *will* fail, becasue the size in genimage.cfg is still not fixed. Both sizes must be changed in the same patch.

Regards,
Yann E. MORIN.

Quoted 10 lines
configs/odroidc2_defconfig +0 -1
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
 
--

2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#4 lore raw

Greetings Yan,

Quoted 32 lines

Sent: Saturday, September 11, 2021 at 10:44 PM
From: "Yann E. MORIN" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: [email protected]
Subject: Re: [Buildroot] [PATCH v2 1/2] configs/odroidc2: increase rootfs size to 124M

Dagg,

On 2021-09-11 19:25 +0300, Dagg Stompler spake thusly:

Quoted 4 lines

as result of e2fsprogs version bump, the image size required was increased.
so to fix it and make sure there is enough size, set BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

So, I was wondering what the reason for the size increase was, so I spawned a build in three conditions:

- my server's Ubuntu 16.04
- my laptop's Ubuntu 21.04
- a docker Bullseye on my server (so, minus the kernel, a stock Debian Bullseye)

In all three cases, the build succeeded with current master. The sice of the target/ directory is roughly 40MiB in all three cases, which is still far enoiugh from 60MiB that it should not cause any issue.

So, I'm still not sure that the reason is "Debian Bullseye", or that the solution is "increase the filesystem size".

Could you please try by aplying this patch to master, and rerun the build, and share the error message, please:

Quoted 14 lines
    diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
    index 74c99bd7b1..83c967c9df 100644
    --- a/fs/ext2/ext2.mk
    +++ b/fs/ext2/ext2.mk
    @@ -16,7 +16,7 @@ EXT2_MKFS_OPTS = $(call qstrip,$(BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS))
     EXT2_LABEL = $(subst ",,$(BR2_TARGET_ROOTFS_EXT2_LABEL))
     #" Syntax highlighting... :-/ )

    -EXT2_OPTS = \
    +EXT2_OPTS = -v \
     	-d $(TARGET_DIR) \
     	-r $(BR2_TARGET_ROOTFS_EXT2_REV) \
     	-N $(BR2_TARGET_ROOTFS_EXT2_INODES) \

it doesn't reproduces anymore with latest master

Dagg.

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot