Skip to contentSkip to conversation

Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

PATCH In review Julian Sikorski 3 participants 3 messages Sep 13, 2021 – Sep 14, 2021

Subsystems (2)
USB USB mass storage driver
lore
Share & tools
lore

Julian Sikorski

author
#0 lore raw

PATCH 1/1 Re-enable UAS for LaCie Rugged USB3-FW with fk quirk

Further testing has revealed that LaCie Rugged USB3-FW does work with uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.

Signed-off-by Julian Sikorski <[email protected]>
Suggested-by Hans de Goede <[email protected]>
Link https://lore.kernel.org/linux-usb/[email protected]/ open here
---
 drivers/usb/storage/unusual_uas.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/storage/unusual_uas.h +1 -1
index c35a6db993f1..4051c8cd0cd8 100644
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
 		"LaCie",
 		"Rugged USB3-FW",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_IGNORE_UAS),
+		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
 
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Julian Sikorski

Hi,

Quoted 6 lines · Julian Sikorski

Further testing has revealed that LaCie Rugged USB3-FW does work with uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.

Signed-off-by Julian Sikorski <[email protected]>
Suggested-by Hans de Goede <[email protected]>
Link https://lore.kernel.org/linux-usb/[email protected]/ open here

Thanks, patch looks good to me:

Reviewed-by Hans de Goede <[email protected]>

Regards,

Hans

Quoted 18 lines
---
 drivers/usb/storage/unusual_uas.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/storage/unusual_uas.h +1 -1
index c35a6db993f1..4051c8cd0cd8 100644
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
 		"LaCie",
 		"Rugged USB3-FW",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_IGNORE_UAS),
+		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
 
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI