net/ice: remove support for IP fragment default RSS
PATCH 1/2 net/ice: remove support for IP fragment default RSS
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly.
Signed-off-by Wenjun Wu <[email protected]>
--- drivers/net/ice/ice_ethdev.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-)
drivers/net/ice/ice_ethdev.c +1 -21
@@ -2822,9 +2822,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) ETH_RSS_NONFRAG_IPV4_TCP | \ ETH_RSS_NONFRAG_IPV6_TCP | \ ETH_RSS_NONFRAG_IPV4_SCTP | \ - ETH_RSS_NONFRAG_IPV6_SCTP | \ - ETH_RSS_FRAG_IPV4 | \ - ETH_RSS_FRAG_IPV6) + ETH_RSS_NONFRAG_IPV6_SCTP) ret =ice_rem_vsi_rss_cfg (hw, vsi->idx);if (ret)
@@ -2979,24 +2977,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) __func__, ret); } -if (rss_hf Ð_RSS_FRAG_IPV4 ) { - cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; - ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg); -if (ret) -PMD_DRV_LOG (ERR ,"%s IPV4_FRAG rss flow fail %d" , - __func__, ret); - } - -if (rss_hf Ð_RSS_FRAG_IPV6 ) { - cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; - ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg); -if (ret) -PMD_DRV_LOG (ERR ,"%s IPV6_FRAG rss flow fail %d" , - __func__, ret); - } - pf->rss_hf = rss_hf &ICE_RSS_HF_ALL ; }
Signature · 1 line
2.25.1
PATCH v2 1/2 net/ice: remove support for IP fragment default RSS
To support independent IP fragment default RSS, considerable additional work need to be done, so we decide to remove this feature to avoid some unexpected behavior we have observed, meanwhile user always can use rte_flow to create RSS for IP fragment packet explicitly.
Signed-off-by Wenjun Wu <[email protected]>
--- drivers/net/ice/ice_ethdev.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-)
drivers/net/ice/ice_ethdev.c +1 -21
@@ -2822,9 +2822,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) ETH_RSS_NONFRAG_IPV4_TCP | \ ETH_RSS_NONFRAG_IPV6_TCP | \ ETH_RSS_NONFRAG_IPV4_SCTP | \ - ETH_RSS_NONFRAG_IPV6_SCTP | \ - ETH_RSS_FRAG_IPV4 | \ - ETH_RSS_FRAG_IPV6) + ETH_RSS_NONFRAG_IPV6_SCTP) ret =ice_rem_vsi_rss_cfg (hw, vsi->idx);if (ret)
@@ -2979,24 +2977,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) __func__, ret); } -if (rss_hf Ð_RSS_FRAG_IPV4 ) { - cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; - ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg); -if (ret) -PMD_DRV_LOG (ERR ,"%s IPV4_FRAG rss flow fail %d" , - __func__, ret); - } - -if (rss_hf Ð_RSS_FRAG_IPV6 ) { - cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; - ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg); -if (ret) -PMD_DRV_LOG (ERR ,"%s IPV6_FRAG rss flow fail %d" , - __func__, ret); - } - pf->rss_hf = rss_hf &ICE_RSS_HF_ALL ; }
Signature · 1 line
2.25.1