Skip to contentSkip to conversation

ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

PATCH Applied [email protected] 2 participants 4 messages Sep 16, 2021 – Sep 24, 2021

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

From: Bastien Roucariès <[email protected]>

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") sets the RX/TX delay according to the phy-mode property in the device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the wrong setting.

Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets the Ethernet working again on this board.

Signed-off-by Bastien Roucariès <[email protected]>
---
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +1 -1
index 8077f1716fbc..ecb91fb899ff 100644
@@ -112,7 +112,7 @@ &gmac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
Signature · 1 line
2.33.0
#1 lore raw

Hi,

Quoted 7 lines · On Thu, Sep 16, 2021 at 08:17:21AM +0000, [email protected] wrote:

From: Bastien Roucariès <[email protected]>

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") sets the RX/TX delay according to the phy-mode property in the device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the wrong setting.

Quoted 5 lines

Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets the Ethernet working again on this board.

Signed-off-by Bastien Roucariès <[email protected]>

It's the third time you've sent it since yesterday, what are the differences and which one am I supposed to apply?

Maxime

author
#2 lore raw
Quoted 10 lines · Le jeudi 16 septembre 2021, 11:03:05 UTC Maxime Ripard a écrit :

Hi,

Quoted 7 lines · On Thu, Sep 16, 2021 at 08:17:21AM +0000, [email protected] wrote:

From: Bastien Roucariès <[email protected]>

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") sets the RX/TX delay according to the phy-mode property in the device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the wrong setting.

Quoted 8 lines
Quoted 5 lines

Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets the Ethernet working again on this board.

Signed-off-by Bastien Roucariès <[email protected]>

It's the third time you've sent it since yesterday, what are the differences and which one am I supposed to apply?

apply the first, my infra is falky sorry for the three messages send

Bastien

Quoted 2 lines

Maxime

Applied
#3 lore raw

Re: (subset) [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

In reply to [email protected]
Quoted 8 lines · On Thu, 16 Sep 2021 08:17:21 +0000, [email protected] wrote:

From: Bastien Roucariès <[email protected]>

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") sets the RX/TX delay according to the phy-mode property in the device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the wrong setting.

[...]

Applied, thanks!

[1/1] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

      commit: 55dd7e059098ce4bd0a55c251cb78e74604abb57

Best regards,

Signature · 1 line
Maxime Ripard <[email protected]>