Skip to contentSkip to conversation

scsi: lpfc: fix sprintf() overflow in lpfc_display_fpin_wwpn()

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 16, 2021 – Sep 22, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: lpfc: fix sprintf() overflow in lpfc_display_fpin_wwpn()

This scnprintf() uses the wrong limit. It should be "LPFC_FPIN_WWPN_LINE_SZ - len" instead of LPFC_FPIN_WWPN_LINE_SZ.

Fixes 428569e66fa7 ("scsi: lpfc: Expand FPIN and RDF receive logging")
---
 drivers/scsi/lpfc/lpfc_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_els.c +1 -1
index f3fc79b99165..052c0e5b1119 100644
@@ -9387,7 +9387,7 @@ lpfc_display_fpin_wwpn(struct lpfc_hba *phba, __be64 *wwnlist, u32 cnt)
 		/* Extract the next WWPN from the payload */
 		wwn = *wwnlist++;
 		wwpn = be64_to_cpu(wwn);
-		len += scnprintf(buf + len, LPFC_FPIN_WWPN_LINE_SZ,
+		len += scnprintf(buf + len, LPFC_FPIN_WWPN_LINE_SZ - len,
 				 " %016llx", wwpn);
 
 		/* Log a message if we are on the last WWPN
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Dan Carpenter

This scnprintf() uses the wrong limit. It should be "LPFC_FPIN_WWPN_LINE_SZ - len" instead of LPFC_FPIN_WWPN_LINE_SZ.

Fixes 428569e66fa7 ("scsi: lpfc: Expand FPIN and RDF receive logging")
---
  drivers/scsi/lpfc/lpfc_els.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

looks good. Thank you

-- james