usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
PATCH v2 1/1 usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
This is writing to the first 1 - 3 bytes of "val" and then writing all four bytes to musb_writel(). The last byte is always going to be garbage. Zero out the last bytes instead.
Fixes 550a7375fe72 ("USB: Add MUSB and TUSB support")
Signed-off-by Dan Carpenter <[email protected]>
---
v2: I mixed up "len" and "val". Thanks for catching that Christophe JAILLET!
drivers/usb/musb/tusb6010.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/musb/tusb6010.c +1 -0
@@ -190,6 +190,7 @@ tusb_fifo_write_unaligned(void __iomem *fifo, const u8 *buf, u16 len) }if (len >0 ) {/* Write the rest 1 - 3 bytes to FIFO */ + val =0 ;memcpy (&val, buf, len);musb_writel (fifo,0 , val); }
Signature · 1 line
2.20.1