drm/tegra: Use correct property for BO size
Mikko Perttunen
maintainerPATCH 1/1 drm/tegra: Use correct property for BO size
The size property is not always populated, while the gem.size property is.
--- drivers/gpu/drm/tegra/uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/uapi.c +1 -1
@@ -222,7 +222,7 @@ int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f mapping->iova =sg_dma_address (mapping->sgt->sgl); } - mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->size; + mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->gem.size; err =xa_alloc (&context->mappings, &args->mapping, mapping,XA_LIMIT (1 ,U32_MAX ),GFP_KERNEL );
Signature · 1 line
2.32.0
16.09.2021 17:13, Mikko Perttunen пишет:
Quoted 15 lines
The size property is not always populated, while the gem.size property is.
Fixes d7c591bc1a3f ("drm/tegra: Implement new UAPI")Signed-off-by Mikko Perttunen <[email protected]>--- drivers/gpu/drm/tegra/uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/tegra/uapi.c +0
-0
drivers/gpu/drm/tegra/uapi.c int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f · line 228
Quoted 8 lines
drivers/gpu/drm/tegra/uapi.c +1
-1@@ -222,7 +222,7 @@ int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f mapping->iova =sg_dma_address (mapping->sgt->sgl); } - mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->size; + mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->gem.size; err =xa_alloc (&context->mappings, &args->mapping, mapping,XA_LIMIT (1 ,U32_MAX ),GFP_KERNEL );
Did something bad happened to [1]? Thierry fetched patches, but didn't make the fixes-PR yet, AFAICS.
[1]
https://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/
Quoted 21 lines · Dmitry Osipenko
16.09.2021 17:13, Mikko Perttunen пишет:
Quoted 20 lines
The size property is not always populated, while the gem.size property is.
Fixes d7c591bc1a3f ("drm/tegra: Implement new UAPI")Signed-off-by Mikko Perttunen <[email protected]>--- drivers/gpu/drm/tegra/uapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/tegra/uapi.c +1
-1@@ -222,7 +222,7 @@ int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f mapping->iova =sg_dma_address (mapping->sgt->sgl); } - mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->size; + mapping->iova_end = mapping->iova +host1x_to_tegra_bo (mapping->bo)->gem.size;
Quoted 6 lines
drivers/gpu/drm/tegra/uapi.c int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f · line 228
Quoted 3 lines
drivers/gpu/drm/tegra/uapi.c +0
-0err =xa_alloc (&context->mappings, &args->mapping, mapping,XA_LIMIT (1 ,U32_MAX ),GFP_KERNEL );Did something bad happened to [1]? Thierry fetched patches, but didn't make the fixes-PR yet, AFAICS.
Oh, didn't remember you had already fixed it. Let's disregard my patch then.
Thanks,
Mikko