Skip to contentSkip to conversation

KVM: SVM: fix missing sev_decommission() in sev_receive_start()

PATCH New Mingwei Zhang 1 participant 1 message Sep 16, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 KVM: SVM: fix missing sev_decommission() in sev_receive_start()

DECOMMISSION the current SEV context if binding an ASID fails after RECEIVE_START. Per AMD's SEV API, RECEIVE_START generates a new guest context and thus needs to be paired with DECOMMISSION:

AMD SEV API v0.24 Section 1.3.3

"The RECEIVE_START command is the only command other than the LAUNCH_START command that generates a new guest context and guest handle."

The missing DECOMMISSION can result in subsequent SEV launch failures due to insufficient resource. In particular, both LAUNCH_START and RECEIVE_START command will fail with SEV_RET_RESOURCE_LIMIT error.

Note, LAUNCH_START suffered from the same bug, but was previously fixed by [1]. However, the same bug could come back to LAUNCH_START if RECEIVE_START part was not fixed.

So add the sev_decommission() function in sev_receive_start.

[1] commit 934002cd660b ("KVM: SVM: Call SEV Guest Decommission if ASID binding fails").

Cc Alper Gun <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Brijesh Singh <[email protected]>
Cc David Rienjes <[email protected]>
Cc Marc Orr <[email protected]>
Cc John Allen <[email protected]>
Cc Peter Gonda <[email protected]>
Cc Sean Christopherson <[email protected]>
Cc Tom Lendacky <[email protected]>
Cc Vipin Sharma <[email protected]>
Fixes af43cbbf954b ("KVM: SVM: Add support for KVM_SEV_RECEIVE_START command")
---
 arch/x86/kvm/svm/sev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/kvm/svm/sev.c +3 -1
index 75e0b21ad07c..55d8b9c933c3 100644
@@ -1397,8 +1397,10 @@ static int sev_receive_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
 
 	/* Bind ASID to this guest */
 	ret = sev_bind_asid(kvm, start.handle, error);
-	if (ret)
+	if (ret) {
+		sev_decommission(start.handle);
 		goto e_free_session;
+	}
 
 	params.handle = start.handle;
 	if (copy_to_user((void __user *)(uintptr_t)argp->data,
Signature · 1 line
2.33.0.464.g1972c5931b-goog