Skip to contentSkip to conversation

tools/vm/page-types: remove dependency on opt_file for idle page tracking

PATCH New Changbin Du 1 participant 1 message Sep 17, 2021 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/vm/page-types: remove dependency on opt_file for idle page tracking

Idle page tracking can also be used for process address space, not only file mappings.

Without this change, using with '-i' option for process address space encounters below errors reported.

$ sudo ./page-types -p $(pidof bash) -i
mark page idle: Bad file descriptor
mark page idle: Bad file descriptor
mark page idle: Bad file descriptor
mark page idle: Bad file descriptor
mark page idle: Bad file descriptor
mark page idle: Bad file descriptor
....
---
 tools/vm/page-types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/vm/page-types.c +1 -1
index 0517c744b04e..f62f10c988db 100644
@@ -1331,7 +1331,7 @@ int main(int argc, char *argv[])
 	if (opt_list && opt_list_mapcnt)
 		kpagecount_fd = checked_open(PROC_KPAGECOUNT, O_RDONLY);
 
-	if (opt_mark_idle && opt_file)
+	if (opt_mark_idle)
 		page_idle_fd = checked_open(SYS_KERNEL_MM_PAGE_IDLE, O_RDWR);
 
 	if (opt_list && opt_pid)
Signature · 1 line
2.32.0