Skip to contentSkip to conversation

Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

PATCH In review [email protected] 2 participants 5 messages Sep 17, 2021 – Sep 22, 2021 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as comments

---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +3 -3
index 7951bd63816f..f03dc1e59db1 100644
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
 	{ .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
 	WLAN_CIPHER_SUITE_WEP40,
 	WLAN_CIPHER_SUITE_WEP104
Signature · 1 line
2.25.1
#1 lore raw
Quoted 36 lines · On Fri, Sep 17, 2021 at 11:25:42AM -0700, [email protected] wrote:

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as comments

---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +3 -3
index 7951bd63816f..f03dc1e59db1 100644
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
 	{ .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
 	WLAN_CIPHER_SUITE_WEP40,
 	WLAN_CIPHER_SUITE_WEP104
Signature · 1 line
2.25.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

A message that is not in the archive (sent off-list or not yet received): CACYKDtieSGhL45vofCZaY=CajYqFvHaFU1Yu4OK8nJfT6wr91g@mail.gmail.com

#3 lore raw
Quoted 80 lines · Usman S. Ansari
Quoted 78 lines · Greg KH
Quoted 6 lines · On Fri, Sep 17, 2021 at 11:25:42AM -0700, [email protected] wrote:

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as

comments

Review

Quoted 5 lines
---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/wlan-ng/cfg80211.c

Quoted 23 lines

index 7951bd63816f..f03dc1e59db1 100644

drivers/staging/wlan-ng/cfg80211.c +3 -4
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
      { .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
      WLAN_CIPHER_SUITE_WEP40,
      WLAN_CIPHER_SUITE_WEP104
--
Quoted 2 lines

2.25.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

Quoted 7 lines
Quoted 2 lines

greg k-h's patch email bot

Hi Greg,

I think I have covered all the items listed in your email bot reply. Please let me know if the patch is not meeting the expectations.

It is not, sorry. Please read the documentation.

Also look at your patch itself, it is not correct.

good luck!

greg k-h

#4 lore raw
Quoted 85 lines · Greg KH
Quoted 83 lines · Usman S. Ansari
Quoted 80 lines · Greg KH
Quoted 6 lines · On Fri, Sep 17, 2021 at 11:25:42AM -0700, [email protected] wrote:

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as

comments

Review

Quoted 5 lines
---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/wlan-ng/cfg80211.c

Quoted 23 lines

index 7951bd63816f..f03dc1e59db1 100644

drivers/staging/wlan-ng/cfg80211.c +3 -4
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
      { .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
      WLAN_CIPHER_SUITE_WEP40,
      WLAN_CIPHER_SUITE_WEP104
--
Quoted 2 lines

2.25.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

Quoted 6 lines
Quoted 4 lines

Hi Greg,

I think I have covered all the items listed in your email bot reply. Please let me know if the patch is not meeting the expectations.

It is not, sorry. Please read the documentation.

This is more for learning and not arguing:
- I do have signed-off in my patch
- I do have a Description of the patch
- I do have a subject describing the patch

Anyone, please let me know, what are the expectations not fulfilled?

Quoted 1 line

Also look at your patch itself, it is not correct.

Please let me know what is not correct, I tried to follow the patch guidance.

Quoted 1 line

good luck!

Thanks for your guidance in advance.

Quoted 1 line

greg k-h

#5 lore raw
Quoted 91 lines · Usman S. Ansari
Quoted 90 lines · Greg KH
Quoted 87 lines · Usman S. Ansari
Quoted 71 lines · Greg KH
Quoted 6 lines · On Fri, Sep 17, 2021 at 11:25:42AM -0700, [email protected] wrote:

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as

comments

Review

Quoted 5 lines
---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/wlan-ng/cfg80211.c

Quoted 23 lines

index 7951bd63816f..f03dc1e59db1 100644

drivers/staging/wlan-ng/cfg80211.c +3 -4
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
      { .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
      WLAN_CIPHER_SUITE_WEP40,
      WLAN_CIPHER_SUITE_WEP104
--
Quoted 2 lines

2.25.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

Quoted 9 lines

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

Hi Greg,

I think I have covered all the items listed in your email bot reply. Please let me know if the patch is not meeting the expectations.

Quoted 8 lines
Quoted 1 line

It is not, sorry. Please read the documentation.

This is more for learning and not arguing:
- I do have signed-off in my patch
- I do have a Description of the patch
- I do have a subject describing the patch

Anyone, please let me know, what are the expectations not fulfilled?

Here is what you have in your changelog, from above:

From: Usman Ansari <[email protected]>

Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as comments

Now look at any of the thousands of commits in the kernel tree, are they also in this format? Or are they in a different format?

Look at the documentation that my bot pointed you at for what the structure of a changelog comment should be. Notably look _where_ the information should be in the changelog commit (top? middle? bottom?) and compare it to what you did here.

Try to rewrite it to match what has been accepted in the past.

hope this helps,

greg k-h