staging: r8188eu: remove unused code
cover staging: r8188eu: remove unused code
This series removes some unused functions and the unused struct rf_shadow.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (8):
staging: r8188eu: remove odm_ConfigRF_RadioB_8188E()
staging: r8188eu: remove ODM_DIG_LowerBound_88E()
staging: r8188eu: remove rtl8188e_RF_ChangeTxPath()
staging: r8188eu: remove unused struct rf_shadow
staging: r8188eu: remove HalDetectPwrDownMode88E()
staging: r8188eu: remove rtw_IOL_cmd_tx_pkt_buf_dump()
staging: r8188eu: remove rtl8188e_set_rssi_cmd()
staging: r8188eu: remove EFUSE_Read1Byte()
drivers/staging/r8188eu/core/rtw_efuse.c | 58 ------------------- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 9 --- .../staging/r8188eu/hal/odm_RegConfig8188E.c | 8 --- drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 15 ----- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 51 ---------------- drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 43 -------------- .../staging/r8188eu/include/odm_RTL8188E.h | 2 - .../r8188eu/include/odm_RegConfig8188E.h | 3 - .../staging/r8188eu/include/rtl8188e_cmd.h | 1 - .../staging/r8188eu/include/rtl8188e_hal.h | 3 - drivers/staging/r8188eu/include/rtl8188e_rf.h | 1 - drivers/staging/r8188eu/include/rtw_efuse.h | 1 - 12 files changed, 195 deletions(-)
Signature · 1 line
2.33.0
PATCH 1/8 staging: r8188eu: remove odm_ConfigRF_RadioB_8188E()
Function odm_ConfigRF_RadioB_8188E() is not used, remove it.
--- drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 8 -------- drivers/staging/r8188eu/include/odm_RegConfig8188E.h | 3 --- 2 files changed, 11 deletions(-)
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +0 -8
@@ -34,14 +34,6 @@ void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Dataodm_ConfigRFReg_8188E (pDM_Odm, Addr, Data,RF_PATH_A , Addr | maskforPhySet); } -void odm_ConfigRF_RadioB_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Data) -{ -u32 content =0x1001 ;/* RF_Content: radiob_txt */ -u32 maskforPhySet = (u32)(content &0xE000 ); - -odm_ConfigRFReg_8188E (pDM_Odm, Addr, Data,RF_PATH_B , Addr | maskforPhySet); -} -void odm_ConfigMAC_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u8 Data) {ODM_Write1Byte (pDM_Odm, Addr, Data);
drivers/staging/r8188eu/include/odm_RegConfig8188E.h +0 -3
@@ -10,9 +10,6 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data,void odm_ConfigRF_RadioA_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Data); -void odm_ConfigRF_RadioB_8188E (struct odm_dm_struct *pDM_Odm, -u32 Addr,u32 Data); -void odm_ConfigMAC_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u8 Data); void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
Signature · 1 line
2.33.0
PATCH 2/8 staging: r8188eu: remove ODM_DIG_LowerBound_88E()
In reply to Michael StraubeFunction ODM_DIG_LowerBound_88E() is not used, remove it.
--- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 9 --------- drivers/staging/r8188eu/include/odm_RTL8188E.h | 2 -- 2 files changed, 11 deletions(-)
drivers/staging/r8188eu/hal/odm_RTL8188E.c +0 -9
@@ -3,15 +3,6 @@#include "../include/odm_precomp.h" -void ODM_DIG_LowerBound_88E (struct odm_dm_struct *dm_odm) -{ -struct rtw_dig *pDM_DigTable = &dm_odm->DM_DigTable; - -if (dm_odm->AntDivType ==CG_TRX_HW_ANTDIV ) - pDM_DigTable->rx_gain_range_min = (u8 )pDM_DigTable->AntDiv_RSSI_max; -/* If only one Entry connected */ -} -static void odm_RX_HWAntDivInit (struct odm_dm_struct *dm_odm) {u32 value32;
drivers/staging/r8188eu/include/odm_RTL8188E.h +0 -2
@@ -11,8 +11,6 @@#define MAIN_ANT_CGCS_RX 0#define AUX_ANT_CGCS_RX 1 -void ODM_DIG_LowerBound_88E (struct odm_dm_struct *pDM_Odm); -void ODM_AntennaDiversityInit_88E (struct odm_dm_struct *pDM_Odm);void ODM_AntennaDiversity_88E (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.33.0
PATCH 3/8 staging: r8188eu: remove rtl8188e_RF_ChangeTxPath()
In reply to Michael StraubeFunction rtl8188e_RF_ChangeTxPath() is not used, remove it.
--- drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 22 ------------------- drivers/staging/r8188eu/include/rtl8188e_rf.h | 1 - 2 files changed, 23 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_rf6052.c +0 -22
@@ -50,28 +50,6 @@ struct rf_shadow {/*------------------------Define local variable------------------------------*/ -/*----------------------------------------------------------------------------- -* Function: RF_ChangeTxPath -* -* Overview: For RL6052, we must change some RF settign for 1T or 2T. -* -* Input: u16 DataRate 0x80-8f, 0x90-9f -* -* Output: NONE -* -* Return: NONE -* -* Revised History: -* When Who Remark -* 09/25/2008 MHC Create Version 0. -* Firmwaer support the utility later. -* -*---------------------------------------------------------------------------*/ -void rtl8188e_RF_ChangeTxPath (struct adapter *Adapter,u16 DataRate) -{ -/* We do not support gain table change inACUT now !!!! Delete later !!! */ -}/* RF_ChangeTxPath */ -/*----------------------------------------------------------------------------- * Function: PHY_RF6052SetBandwidth() *
drivers/staging/r8188eu/include/rtl8188e_rf.h +0 -1
@@ -9,7 +9,6 @@#define RF6052_MAX_PATH 2int PHY_RF6052_Config8188E (struct adapter *Adapter); -void rtl8188e_RF_ChangeTxPath (struct adapter *Adapter,u16 DataRate);void rtl8188e_PHY_RF6052SetBandwidth (struct adapter *Adapter,enum ht_channel_width Bandwidth);void rtl8188e_PHY_RF6052SetCckTxPower (struct adapter *Adapter,u8 *level);
Signature · 1 line
2.33.0
PATCH 4/8 staging: r8188eu: remove unused struct rf_shadow
In reply to Michael StraubeRemove unused struct rf_shadow.
--- drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 21 ------------------- 1 file changed, 21 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_rf6052.c +0 -21
@@ -29,27 +29,6 @@#include "../include/drv_types.h" #include "../include/rtl8188e_hal.h" -/*---------------------------Define Local Constant---------------------------*/ -/* Define local structure for debug!!!!! */ -struct rf_shadow { -/* Shadow register value */ -u32 Value; -/* Compare or not flag */ -u8 Compare; -/* Record If it had ever modified unpredicted */ -u8 ErrorOrNot; -/* Recorver Flag */ -u8 Recorver; -/* */ -u8 Driver_Write; -}; - -/*---------------------------Define Local Constant---------------------------*/ - -/*------------------------Define global variable-----------------------------*/ - -/*------------------------Define local variable------------------------------*/ -/*----------------------------------------------------------------------------- * Function: PHY_RF6052SetBandwidth() *
Signature · 1 line
2.33.0
PATCH 5/8 staging: r8188eu: remove HalDetectPwrDownMode88E()
In reply to Michael StraubeFunction HalDetectPwrDownMode88E() is not used, remove it.
--- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 19 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 2 -- 2 files changed, 21 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +0 -19
@@ -2154,22 +2154,3 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter, u8 *PROMContent, bool Aut }DBG_88E ("ThermalMeter = 0x%x\n" , pHalData->EEPROMThermalMeter); } - -bool HalDetectPwrDownMode88E (struct adapter *Adapter) -{ -u8 tmpvalue =0 ; -struct hal_data_8188e *pHalData =GET_HAL_DATA (Adapter); -struct pwrctrl_priv *pwrctrlpriv = &Adapter->pwrctrlpriv; - -EFUSE_ShadowRead (Adapter,1 ,EEPROM_RF_FEATURE_OPTION_88E , (u32 *)&tmpvalue); - -/* 2010/08/25 MH INF priority > PDN Efuse value. */ -if (tmpvalue &BIT (4 ) && pwrctrlpriv->reg_pdnmode) - pHalData->pwrdown = true; -else - pHalData->pwrdown = false; - -DBG_88E ("HalDetectPwrDownMode(): PDN =%d\n" , pHalData->pwrdown); - -return pHalData->pwrdown; -}/* HalDetectPwrDownMode */
drivers/staging/r8188eu/include/rtl8188e_hal.h +0 -2
@@ -407,8 +407,6 @@ void Hal_EfuseParseBoardType88E(struct adapter *pAdapter, u8 *hwinfo,void Hal_ReadPowerSavingMode88E (struct adapter *pAdapter,u8 *hwinfo,bool AutoLoadFail); -bool HalDetectPwrDownMode88E (struct adapter *Adapter); -void rtl8188e_read_chip_version (struct adapter *padapter);void rtw_IOL_cmd_tx_pkt_buf_dump (struct adapter *Adapter,int len);
Signature · 1 line
2.33.0
PATCH 6/8 staging: r8188eu: remove rtw_IOL_cmd_tx_pkt_buf_dump()
In reply to Michael StraubeFunction rtw_IOL_cmd_tx_pkt_buf_dump() is not used, remove it.
--- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 32 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 33 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +0 -32
@@ -336,38 +336,6 @@ int rtl8188e_IOL_exec_cmds_sync(struct adapter *adapter, struct xmit_frame *xmitreturn ret; } -void rtw_IOL_cmd_tx_pkt_buf_dump (struct adapter *Adapter,int data_len) -{ -u32 fifo_data, reg_140; -u32 addr, rstatus, loop =0 ; -u16 data_cnts = (data_len /8 ) +1 ; -u8 *pbuf =vzalloc (data_len +10 ); -DBG_88E ("###### %s ######\n" , __func__); - -rtw_write8 (Adapter,REG_PKT_BUFF_ACCESS_CTRL ,TXPKT_BUF_SELECT ); -if (pbuf) { -for (addr =0 ; addr < data_cnts; addr++) { -rtw_write32 (Adapter,0x140 , addr); -rtw_usleep_os (2 ); - loop =0 ; -do { - rstatus = (reg_140 =rtw_read32 (Adapter,REG_PKTBUF_DBG_CTRL ) &BIT (24 )); -if (rstatus) { - fifo_data =rtw_read32 (Adapter,REG_PKTBUF_DBG_DATA_L ); -memcpy (pbuf + (addr *8 ), &fifo_data,4 ); - - fifo_data =rtw_read32 (Adapter,REG_PKTBUF_DBG_DATA_H ); -memcpy (pbuf + (addr *8 +4 ), &fifo_data,4 ); - } -rtw_usleep_os (2 ); - }while (!rstatus && (loop++ <10 )); - } -rtw_IOL_cmd_buf_dump (data_len, pbuf); -vfree (pbuf); - } -DBG_88E ("###### %s ######\n" , __func__); -} -static void _FWDownloadEnable (struct adapter *padapter,bool enable) {u8 tmp;
drivers/staging/r8188eu/include/rtl8188e_hal.h +0 -1
@@ -409,7 +409,6 @@ void Hal_ReadPowerSavingMode88E(struct adapter *pAdapter, u8 *hwinfo,void rtl8188e_read_chip_version (struct adapter *padapter); -void rtw_IOL_cmd_tx_pkt_buf_dump (struct adapter *Adapter,int len);s32 rtl8188e_iol_efuse_patch (struct adapter *padapter);void rtw_cancel_all_timer (struct adapter *padapter);void _ps_open_RF (struct adapter *adapt);
Signature · 1 line
2.33.0
PATCH 7/8 staging: r8188eu: remove rtl8188e_set_rssi_cmd()
In reply to Michael StraubeFunction rtl8188e_set_rssi_cmd() is not used, remove it.
--- drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 15 --------------- drivers/staging/r8188eu/include/rtl8188e_cmd.h | 1 - 2 files changed, 16 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_cmd.c +0 -15
@@ -109,21 +109,6 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *preturn ret; } -u8 rtl8188e_set_rssi_cmd (struct adapter *adapt,u8 *param) -{ -u8 res = _SUCCESS; -struct hal_data_8188e *haldata =GET_HAL_DATA (adapt); - -if (haldata->fw_ractrl) { - ; - }else { -DBG_88E ("==>%s fw dont support RA\n" , __func__); - res = _FAIL; - } - -return res; -} -u8 rtl8188e_set_raid_cmd (struct adapter *adapt,u32 mask) {u8 buf[3 ];
drivers/staging/r8188eu/include/rtl8188e_cmd.h +0 -1
@@ -91,7 +91,6 @@ struct P2P_PS_CTWPeriod_t {/* host message to firmware cmd */ void rtl8188e_set_FwPwrMode_cmd (struct adapter *padapter,u8 Mode);void rtl8188e_set_FwJoinBssReport_cmd (struct adapter *padapter,u8 mstatus); -u8 rtl8188e_set_rssi_cmd (struct adapter *padapter,u8 *param);u8 rtl8188e_set_raid_cmd (struct adapter *padapter,u32 mask);void rtl8188e_Add_RateATid (struct adapter *padapter,u32 bitmap,u8 arg,u8 rssi_level);
Signature · 1 line
2.33.0
PATCH 8/8 staging: r8188eu: remove EFUSE_Read1Byte()
In reply to Michael StraubeFunction EFUSE_Read1Byte() is not used, remove it.
--- drivers/staging/r8188eu/core/rtw_efuse.c | 58 --------------------- drivers/staging/r8188eu/include/rtw_efuse.h | 1 - 2 files changed, 59 deletions(-)
drivers/staging/r8188eu/core/rtw_efuse.c +0 -58
@@ -127,64 +127,6 @@ ReadEFuseByte( *pbuf = (u8)(value32 &0xff ); } -/*----------------------------------------------------------------------------- -* Function: EFUSE_Read1Byte -* -* Overview: Copy from WMAC fot EFUSE read 1 byte. -* -* Input: NONE -* -* Output: NONE -* -* Return: NONE -* -* Revised History: -* When Who Remark -* 09/23/2008 MHC Copy from WMAC. -* -*---------------------------------------------------------------------------*/ -u8 EFUSE_Read1Byte (struct adapter *Adapter,u16 Address) -{ -u8 data; -u8 Bytetemp = {0x00 }; -u8 temp = {0x00 }; -u32 k =0 ; -u16 contentLen =0 ; - -rtl8188e_EFUSE_GetEfuseDefinition (Adapter,EFUSE_WIFI ,TYPE_EFUSE_REAL_CONTENT_LEN , (void *)&contentLen, false); - -if (Address < contentLen) {/* E-fuse 512Byte */ -/* Write E-fuse Register address bit0~7 */ - temp = Address &0xFF ; -rtw_write8 (Adapter,EFUSE_CTRL +1 , temp); - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +2 ); -/* Write E-fuse Register address bit8~9 */ - temp = ((Address >>8 ) &0x03 ) | (Bytetemp &0xFC ); -rtw_write8 (Adapter,EFUSE_CTRL +2 , temp); - -/* Write 0x30[31]= 0 */ - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); - temp = Bytetemp &0x7F ; -rtw_write8 (Adapter,EFUSE_CTRL +3 , temp); - -/* Wait Write-ready (0x30[31]= 1) */ - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); -while (!(Bytetemp &0x80 )) { - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); - k++; -if (k ==1000 ) { - k =0 ; -break ; - } - } - data =rtw_read8 (Adapter,EFUSE_CTRL ); -return data; - }else { -return 0xFF ; - } - -}/* EFUSE_Read1Byte */ -/* 11/16/2008 MH Read one byte from real Efuse. */ u8 efuse_OneByteRead (struct adapter *pAdapter,u16 addr,u8 *data,bool pseudo) {
drivers/staging/r8188eu/include/rtw_efuse.h +0 -1
@@ -118,7 +118,6 @@ u8 efuse_OneByteWrite(struct adapter *adapter, u16 addr, u8 data, bool test);void efuse_WordEnableDataRead (u8 word_en,u8 *sourdata,u8 *targetdata); -u8 EFUSE_Read1Byte (struct adapter *adapter,u16 address);void EFUSE_ShadowMapUpdate (struct adapter *adapter,u8 efusetype,bool test);void EFUSE_ShadowRead (struct adapter *adapt,u8 type,u16 offset,u32 *val);
Signature · 1 line
2.33.0