Skip to contentSkip to conversation

arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio

PATCH Superseded Anand Moon 2 participants 2 messages Sep 19, 2021 – Sep 20, 2021

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio

As described in the Odroid-n2 & Odroid-n2-plus schematics, the 5V regulator is controlled by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.

Cc Neil Armstrong <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +2 -0
index 4f33820aba1f..e8a00a2f8812 100644
@@ -99,6 +99,8 @@ vcc_5v: regulator-vcc_5v {
 		regulator-max-microvolt = <5000000>;
 		regulator-always-on;
 		vin-supply = <&main_12v>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+		enable-active-high;
 	};
 
 	vcc_1v8: regulator-vcc_1v8 {
Signature · 1 line
2.33.0
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Anand Moon

As described in the Odroid-n2 & Odroid-n2-plus schematics, the 5V regulator is controlled by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.

Fixes c35f6dc5c377 ("arm64: dts: meson: Add minimal support for Odroid-N2")
Fixes ef599f5f3e10 ("arm64: dts: meson: convert ODROID-N2 to dtsi")
Quoted 12 lines
Cc Neil Armstrong <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +0 -0
index 4f33820aba1f..e8a00a2f8812 100644

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi vcc_5v: regulator-vcc_5v { · line 106

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +2 -0
@@ -99,6 +99,8 @@ vcc_5v: regulator-vcc_5v {
 		regulator-max-microvolt = <5000000>;
 		regulator-always-on;
 		vin-supply = <&main_12v>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+		enable-active-high;
 	};
 
 	vcc_1v8: regulator-vcc_1v8 {

Exact

I wonder how I missed this....

Acked-by Neil Armstrong <[email protected]>

Thanks,
Neil