Skip to contentSkip to conversation

soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

PATCH In review Arnd Bergmann 2 participants 2 messages Sep 20, 2021 Arm Samsung Exynos

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

From: Arnd Bergmann <[email protected]>

Using devm_mfd_add_devices() fails if no driver selects the MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Add the missing select statement.

Fixes 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/samsung/Kconfig +1 -0
index 5745d7e5908e..1f643c0f5c93 100644
@@ -25,6 +25,7 @@ config EXYNOS_PMU
 	bool "Exynos PMU controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
 	select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+	select MFD_CORE
 
 # There is no need to enable these drivers for ARMv8
 config EXYNOS_PMU_ARM_DRIVERS
Signature · 1 line
2.29.2
#1 lore raw
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Using devm_mfd_add_devices() fails if no driver selects the MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Quoted 8 lines

Add the missing select statement.

Fixes 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Hi Arnd,

Thanks for the patch but this was already committed few days ago from different author:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/drivers&id=e37ef6dcdb1f4738b01cec7fb7be46af07816af9

Best regards,
Krzysztof