Skip to contentSkip to conversation

ARM: dts: dra7: enable BB2D module

PATCH Superseded Neil Armstrong 2 participants 7 messages Sep 20, 2021 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: dra7: enable BB2D module

The DRA7 & variant SoCs contains a BB2D module which is a Vivante GC320 2D accelerator.

This patchset adds the GPU node and enables it on the DRA7, DRA72 & AM57xx platforms.

This is a follow-up of [1] & [2] but:
- using the vivante,gc bindings only
- using ti,sysc instead of hwmod

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Gowtham Tammana (4):
ARM: dts: dra7: add entry for bb2d module
ARM: dts: dra7-evm: Enable BB2D node
ARM: dts: dra72-evm-common: Enable BB2D node
ARM: dts: am57xx-evm: Enable BB2D node

 .../boot/dts/am57xx-beagle-x15-common.dtsi    |  4 ++++
 arch/arm/boot/dts/am57xx-idk-common.dtsi      |  4 ++++
 arch/arm/boot/dts/dra7-evm.dts                |  4 ++++
 arch/arm/boot/dts/dra7.dtsi                   | 20 +++++++++++++++++++
 arch/arm/boot/dts/dra72-evm-common.dtsi       |  4 ++++
 5 files changed, 36 insertions(+)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/4 ARM: dts: dra7: add entry for bb2d module

From: Gowtham Tammana <[email protected]>

BB2D is a Vivante GC 2D Accelerator.
This adds the node to the dts file within a target module node. Crossbar index number is used for interrupt mapping.

---
 arch/arm/boot/dts/dra7.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/dra7.dtsi +20 -0
index dfc1ef8ef6ae..8a9df5ed5439 100644
@@ -965,6 +965,26 @@ hdmi: encoder@0 {
 			};
 		};
 
+		target-module@59000000 {
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0x59000020 0x4>;
+			reg-names = "rev";
+			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0x0 0x59000000 0x1000>;
+
+			bb2d: gpu@0 {
+				compatible = "vivante,gc";
+				reg = <0x0 0x0700>;
+				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
+				clock-names = "core";
+				status = "disabled";
+			};
+		};
+
 		aes1_target: target-module@4b500000 {
 			compatible = "ti,sysc-omap2", "ti,sysc";
 			reg = <0x4b500080 0x4>,
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

Hi,

Quoted 19 lines · Neil Armstrong
arch/arm/boot/dts/dra7.dtsi +13 -0
@@ -965,6 +965,26 @@ hdmi: encoder@0 {
 			};
 		};
 
+		target-module@59000000 {
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0x59000020 0x4>;
+			reg-names = "rev";
+			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0x0 0x59000000 0x1000>;
+
+			bb2d: gpu@0 {
+				compatible = "vivante,gc";
+				reg = <0x0 0x0700>;

arch/arm/boot/dts/dra7.dtsi hdmi: encoder@0 { · line 990

Quoted 10 lines
arch/arm/boot/dts/dra7.dtsi +7 -0
+				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
+				clock-names = "core";
+				status = "disabled";
+			};
+		};
+
 		aes1_target: target-module@4b500000 {
 			compatible = "ti,sysc-omap2", "ti,sysc";
 			reg = <0x4b500080 0x4>,

How about just use the default for the bb2d node with is "okay"? That way there's no need set status = "okay" for each board file.

If there is no driver loaded, we idle the target-module anyways.

Regards,

Tony

#3 lore raw

Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

Quoted 36 lines · Tony Lindgren

Hi,

Quoted 19 lines · Neil Armstrong
arch/arm/boot/dts/dra7.dtsi +13 -0
@@ -965,6 +965,26 @@ hdmi: encoder@0 {
 			};
 		};
 
+		target-module@59000000 {
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0x59000020 0x4>;
+			reg-names = "rev";
+			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0x0 0x59000000 0x1000>;
+
+			bb2d: gpu@0 {
+				compatible = "vivante,gc";
+				reg = <0x0 0x0700>;

arch/arm/boot/dts/dra7.dtsi hdmi: encoder@0 { · line 990

Quoted 10 lines
arch/arm/boot/dts/dra7.dtsi +7 -0
+				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
+				clock-names = "core";
+				status = "disabled";
+			};
+		};
+
 		aes1_target: target-module@4b500000 {
 			compatible = "ti,sysc-omap2", "ti,sysc";
 			reg = <0x4b500080 0x4>,

How about just use the default for the bb2d node with is "okay"? That way there's no need set status = "okay" for each board file.

Quoted 1 line

If there is no driver loaded, we idle the target-module anyways.

Yes you're right, I'll resend only this patch with no status property on bb2d node.

thanks,
Neil

Quoted 5 lines

Regards,

Tony

#4 lore raw

PATCH 2/4 ARM: dts: dra7-evm: Enable BB2D node

In reply to Neil Armstrong

From: Gowtham Tammana <[email protected]>

This enables the BB2D graphics accelerator for DRA7 EVM board.

---
 arch/arm/boot/dts/dra7-evm.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/dra7-evm.dts +4 -0
index 87deb6a76eff..63a29caa4c8c 100644
@@ -590,3 +590,7 @@ &dsp2 {
 	status = "okay";
 	memory-region = <&dsp2_memory_region>;
 };
+
+&bb2d {
+	status = "okay";
+};
Signature · 1 line
2.25.1
#5 lore raw

PATCH 3/4 ARM: dts: dra72-evm-common: Enable BB2D node

In reply to Neil Armstrong

From: Gowtham Tammana <[email protected]>

This enables the BB2D graphics accelerator for DRA72 EVM family boards.

---
 arch/arm/boot/dts/dra72-evm-common.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/dra72-evm-common.dtsi +4 -0
index f12825268188..6f1236b80b40 100644
@@ -535,6 +535,10 @@ &dss {
 	status = "okay";
 };
 
+&bb2d {
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 
Signature · 1 line
2.25.1
#6 lore raw

PATCH 4/4 ARM: dts: am57xx-evm: Enable BB2D node

In reply to Neil Armstrong

From: Gowtham Tammana <[email protected]>

This enables the BB2D graphics accelerator for the AM57x based Beagle-X15 (GPEVM) and IDK platforms.

---
 arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi | 4 ++++
 arch/arm/boot/dts/am57xx-idk-common.dtsi        | 4 ++++
 2 files changed, 8 insertions(+)
arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi +4 -0
index 994e69ab38d7..151b3d5775cc 100644
@@ -645,3 +645,7 @@ &pruss1_mdio {
 &pruss2_mdio {
 	status = "disabled";
 };
+
+&bb2d {
+	status = "okay";
+};
arch/arm/boot/dts/am57xx-idk-common.dtsi +4 -0
index 9fcb8944aa3e..cbab72a4c8b6 100644
@@ -606,3 +606,7 @@ dpi_out: endpoint {
 		};
 	};
 };
+
+&bb2d {
+	status = "ok";
+};
Signature · 1 line
2.25.1