Skip to contentSkip to conversation

linux-next: Fixes tag needs some work in the ntfs3 tree

DISCUSSION Stephen Rothwell 3 participants 5 messages Sep 21, 2021 – Sep 26, 2021 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

In commit

0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")

Fixes tag

Fixes 203c2b3a406a ("fs/ntfs3: Add initialization of super block")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 10 lines · Stephen Rothwell

Hi all,

In commit

0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")

Fixes tag

Fixes 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
Quoted 8 lines

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")

Hello.

You are right, correct SHA is 82cae269cfa9.
Sorry, I've missed this while applying patch.

As far as I know there is no way to fix this now - commit is already in linux-next.

#2 lore raw
Quoted 19 lines · Konstantin Komarov
Quoted 16 lines · Stephen Rothwell

Hi all,

In commit

0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")

Fixes tag

Fixes 203c2b3a406a ("fs/ntfs3: Add initialization of super block")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Quoted 7 lines
Quoted 2 lines
Fixes 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")

Hello.

You are right, correct SHA is 82cae269cfa9.
Sorry, I've missed this while applying patch.

Sorry also from my part.

Quoted 2 lines

As far as I know there is no way to fix this now - commit is already in linux-next.

But these things needs fixing. Rebase is needed.

#3 lore raw
In reply to Konstantin Komarov
Quoted 22 lines · Konstantin Komarov
Quoted 10 lines · Stephen Rothwell

Hi all,

In commit

0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")

Fixes tag

Fixes 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
Quoted 8 lines

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Quoted 7 lines

Hello.

You are right, correct SHA is 82cae269cfa9.
Sorry, I've missed this while applying patch.

As far as I know there is no way to fix this now - commit is already in linux-next.

This still is not fixed. Can you Stephen verify that rebase is ok in situatian like this? Also now we have situation that this thing is 6 day old already. I actually also do not know if it is ok to rebase anymore, but, probably is. I have checked every follow up patches which has been applied after this and they are not affected if we rebase.

Argillander

#4 lore raw

Hi Kari,

Quoted 27 lines · On Mon, 27 Sep 2021 00:47:00 +0300 Kari Argillander…
Quoted 25 lines · Konstantin Komarov
Quoted 9 lines · Stephen Rothwell

In commit

0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")

Fixes tag

Fixes 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
Quoted 8 lines

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")

Hello.

You are right, correct SHA is 82cae269cfa9.
Sorry, I've missed this while applying patch.

Quoted 8 lines
Quoted 2 lines

As far as I know there is no way to fix this now - commit is already in linux-next.

This still is not fixed. Can you Stephen verify that rebase is ok in situatian like this? Also now we have situation that this thing is 6 day old already. I actually also do not know if it is ok to rebase anymore, but, probably is. I have checked every follow up patches which has been applied after this and they are not affected if we rebase.

A rebase is probably not necessary, as the commit is easy to find using its subject line (as I did). However, it would be better to avoid such situations in the future.

Signature · 2 lines
Cheers,
Stephen Rothwell