Skip to contentSkip to conversation

usb: usb-skeleton: remove obsolete comment

PATCH In review Philipp Hortmann 2 participants 2 messages Sep 21, 2021 – Sep 22, 2021 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: usb-skeleton: remove obsolete comment

This patch fixes the checkpatch.pl warning:
WARNING: It's generally not useful to have the filename in the file 7: FILE: drivers/usb/usb-skeleton.c:7:
+ * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c

Deleting both lines as the -2.6.3- makes the reader belief this is an unusable old file and the -rewritten to be easier ...- is only of value for the reader that knows what the driver was before.

---
 drivers/usb/usb-skeleton.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/usb-skeleton.c +0 -2
index d87deee3e26e..91da019a1171 100644
@@ -4,8 +4,6 @@
  *
  * Copyright (C) 2001-2004 Greg Kroah-Hartman ([email protected])
  *
- * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
- * but has been rewritten to be easier to read and use.
  */
 
 #include <linux/kernel.h>
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 19 lines · Philipp Hortmann

This patch fixes the checkpatch.pl warning:
WARNING: It's generally not useful to have the filename in the file 7: FILE: drivers/usb/usb-skeleton.c:7:
+ * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c

Deleting both lines as the -2.6.3- makes the reader belief this is an unusable old file and the -rewritten to be easier ...- is only of value for the reader that knows what the driver was before.

---
 drivers/usb/usb-skeleton.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/usb-skeleton.c +0 -0
index d87deee3e26e..91da019a1171 100644

drivers/usb/usb-skeleton.c line 8

Quoted 5 lines
drivers/usb/usb-skeleton.c +0 -2
@@ -4,8 +4,6 @@
  *
  * Copyright (C) 2001-2004 Greg Kroah-Hartman ([email protected])
  *
- * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
- * but has been rewritten to be easier to read and use.

No, this is fine to keep in the source code, checkpatch is telling you something else in the above "hint".

thanks,

greg k-h