leds: gpio: Always provide cdev->brightness_set_blocking()
PATCH 1/1 leds: gpio: Always provide cdev->brightness_set_blocking()
Even if the GPIO driver will never sleep, setting cdev->brightness_set_blocking() makes sense so led_set_brightness_sync() can be used with such LEDs.
Internally, both gpio_led_set_blocking() and gpio_led_set() call the same implementation anyway.
Cc Jacek Anaszewski <[email protected]>
Signed-off-by Harald Seiler <[email protected]>
--- drivers/leds/leds-gpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/leds/leds-gpio.c +3 -2
@@ -79,11 +79,12 @@ static int create_gpio_led(const struct gpio_led *template,int ret, state; led_dat->cdev.default_trigger = template->default_trigger; + led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking; + led_dat->can_sleep =gpiod_cansleep (led_dat->gpiod);if (!led_dat->can_sleep) led_dat->cdev.brightness_set = gpio_led_set; -else - led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking; + led_dat->blinking =0 ;if (blink_set) { led_dat->platform_gpio_blink_set = blink_set;
Signature · 1 line
2.33.0
Hi Pavel,
Quoted 10 lines · Harald Seiler
Even if the GPIO driver will never sleep, setting
cdev->brightness_set_blocking()makes sense soled_set_brightness_sync()can be used with such LEDs.Internally, both
gpio_led_set_blocking()andgpio_led_set()call the same implementation anyway.Cc Jacek Anaszewski <[email protected]>Signed-off-by Harald Seiler <[email protected]>---
Any chance you can pick this up? This fix is needed to use gpio leds with, for example, the tty trigger.
Signature · 1 line
Harald
Quoted 22 lines
drivers/leds/leds-gpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-gpio.c +3
-2@@ -79,11 +79,12 @@ static int create_gpio_led(const struct gpio_led *template,int ret, state; led_dat->cdev.default_trigger = template->default_trigger; + led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking; + led_dat->can_sleep =gpiod_cansleep (led_dat->gpiod);if (!led_dat->can_sleep) led_dat->cdev.brightness_set = gpio_led_set; -else - led_dat->cdev.brightness_set_blocking = gpio_led_set_blocking; + led_dat->blinking =0 ;if (blink_set) { led_dat->platform_gpio_blink_set = blink_set;