Skip to contentSkip to conversation

tests/core_hotunplug: Drop log level for preventively unloading snd driver

PATCH Superseded Jeevan B 3 participants 3 messages Sep 23, 2021 – Oct 5, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jeevan B

author
#0 lore raw

PATCH 1/1 tests/core_hotunplug: Drop log level for preventively unloading snd driver

change igt_warn to igt_info when unloading the snd module before unbinding i915 until WA is fixed. As this "todo reminder" is flagged as BAT failure and showing up in all sorts of top-bugs lists for various platforms.

---
 tests/core_hotunplug.c | 2 +-
 tests/device_reset.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/core_hotunplug.c +1 -1
index 2d73e27f..b3661668 100644
@@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char *prefix,
 			igt_lsof("/dev/snd");
 			igt_skip("Audio is in use, skipping\n");
 		} else {
-			igt_warn("Preventively unloaded snd_hda_intel\n");
+			igt_info("Preventively unloaded snd_hda_intel\n");
 		}
 	}
 
tests/device_reset.c +1 -1
index e6a468e6..982ba5ef 100644
@@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
 			igt_lsof("/dev/snd");
 			igt_skip("Audio is in use, skipping\n");
 		} else {
-			igt_warn("Preventively unloaded snd_hda_intel\n");
+			igt_info("Preventively unloaded snd_hda_intel\n");
 		}
 	}
 
Signature · 1 line
2.19.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/core_hotunplug: Drop log level for preventively unloading snd driver

== Series Details ==

== Series Details ==

Series: tests/core_hotunplug: Drop log level for preventively unloading snd driver
URL : https://patchwork.freedesktop.org/series/94978/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10629 -> IGTPW_6249
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6249 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6249, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6249:

### IGT changes ###

#### Possible regressions ####

* igt@kms_busy@basic@modeset:
- fi-rkl-11600: [PASS][1] -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-rkl-11600/igt@kms_busy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/fi-rkl-11600/igt@kms_busy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6249 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-tgl-1115g4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/fi-tgl-1115g4/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-hsw-4770: [WARN][5] ([i915#3718]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-hsw-4770/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/fi-hsw-4770/igt@[email protected]
- fi-bdw-5557u: [WARN][7] ([i915#3718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-bdw-5557u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/fi-bdw-5557u/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-r: [DMESG-FAIL][9] ([i915#2291] / [i915#541]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10629/fi-kbl-r/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/fi-kbl-r/igt@i915_selftest@live@gt_heartbeat.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (42 -> 29)
------------------------------

Missing (13): fi-ilk-m540 bat-dg1-6 bat-dg1-5 fi-bsw-cyan fi-bwr-2160 fi-ilk-650 fi-ctg-p8600 fi-kbl-x1275 fi-pnv-d510 fi-bsw-kefka fi-bdw-samus fi-bsw-nick bat-jsl-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6214 -> IGTPW_6249

CI-20190529: 20190529
CI_DRM_10629: ce6974ec90355ddef78e6bc2221cb2296e5ba349 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6249: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/index.html
IGT_6214: 13550e92c6c7bd825abb6c9b087d12a524b4674c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6249/index.html

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jeevan B
Quoted 10 lines

-----Original Message-----
From: B, Jeevan <[email protected]>
Sent: Thursday, September 23, 2021 12:15 PM
To: [email protected]
Cc: Shankar, Uma <[email protected]>; B, Jeevan <[email protected]>
Subject: [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively unloading snd driver

Quoted 3 lines

change igt_warn to igt_info when unloading the snd module before unbinding i915 until WA is fixed. As this "todo reminder" is flagged as BAT failure and showing up in all sorts of top-bugs lists for various platforms.

Seems ok to clear the BAT noise, till the proper fix is done in audio driver.

Note: Since this is a v2, you should add this and what changed in this version.

Quoted 35 lines
---
 tests/core_hotunplug.c | 2 +-
 tests/device_reset.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/core_hotunplug.c index renamed from tests/core_hotunplug.c +0 -0

2d73e27f..b3661668 100644

tests/core_hotunplug.c +1 -1
@@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char
 *prefix,
 			igt_lsof("/dev/snd");
 			igt_skip("Audio is in use, skipping\n");
 		} else {
-			igt_warn("Preventively unloaded snd_hda_intel\n");
+			igt_info("Preventively unloaded snd_hda_intel\n");
 		}
 	}
tests/device_reset.c index e6a468e6..982ba5ef renamed from tests/device_reset.c +0 -0

100644

tests/device_reset.c +1 -2
@@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
 			igt_lsof("/dev/snd");
 			igt_skip("Audio is in use, skipping\n");
 		} else {
-			igt_warn("Preventively unloaded snd_hda_intel\n");
+			igt_info("Preventively unloaded snd_hda_intel\n");
 		}
 	}
 
--

2.19.1