Skip to contentSkip to conversation

USB: phy: tahvo:remove unnecessary debug log

PATCH In review Zhiwei Yang 3 participants 4 messages Sep 24, 2021 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: phy: tahvo:remove unnecessary debug log

Remove the debug info which should be instead with ftrace

---
 drivers/usb/phy/phy-tahvo.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/usb/phy/phy-tahvo.c +0 -4
index 5dc600fadc5f..468151496d23 100644
@@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
-
 	mutex_lock(&tu->serialize);
 
 	if (host == NULL) {
@@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
-
 	mutex_lock(&tu->serialize);
 
 	if (!gadget) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 12 lines · Zhiwei Yang

Remove the debug info which should be instead with ftrace

---
  drivers/usb/phy/phy-tahvo.c | 4 ----
  1 file changed, 4 deletions(-)
drivers/usb/phy/phy-tahvo.c +0 -0
index 5dc600fadc5f..468151496d23 100644

drivers/usb/phy/phy-tahvo.c static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host) · line 198

Quoted 5 lines
drivers/usb/phy/phy-tahvo.c +0 -2
@@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
  	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
  					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
-

Moreover, "%p" doesn't print a real address since 4.15.

[...]

MBR, Sergey

#2 lore raw
In reply to Zhiwei Yang

Hi,

Quoted 1 line · Zhiwei Yang

Remove the debug info which should be instead with ftrace

why?

Quoted 19 lines
---
 drivers/usb/phy/phy-tahvo.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/usb/phy/phy-tahvo.c +0 -2
index 5dc600fadc5f..468151496d23 100644
@@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
-
 	mutex_lock(&tu->serialize);
 
 	if (host == NULL) {

drivers/usb/phy/phy-tahvo.c static int tahvo_usb_set_peripheral(struct usb_otg *otg, · line 227

Quoted 4 lines
drivers/usb/phy/phy-tahvo.c +0 -1
@@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);

is this causing any problems? What sort of problems? Why should we take this patch?

Signature · 1 line
balbi
Acked-by
#3 lore raw

Hi,

Quoted 28 lines · Felipe Balbi
Quoted 1 line · Zhiwei Yang

Remove the debug info which should be instead with ftrace

why?

Quoted 22 lines
---
 drivers/usb/phy/phy-tahvo.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/usb/phy/phy-tahvo.c +0 -2
index 5dc600fadc5f..468151496d23 100644
@@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
-
 	mutex_lock(&tu->serialize);
 
 	if (host == NULL) {
@@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
 	struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
 					    phy);
 
Quoted 4 lines

drivers/usb/phy/phy-tahvo.c static int tahvo_usb_set_peripheral(struct usb_otg *otg, · line 227

Quoted 1 line
drivers/usb/phy/phy-tahvo.c +0 -1
-	dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);

is this causing any problems? What sort of problems? Why should we take this patch?

nevermind, I saw that your original patch was simply replacing %p with %pK but Greg asked you to just remove the lines.

Thank you.

Signature · 1 line
balbi