Skip to contentSkip to conversation

package/python-attrs: depends on python3

PATCH Applied Asaf Kahlon 3 participants 4 messages Sep 24, 2021 – Sep 26, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-attrs: depends on python3

python-attrs contains a file with API for python 3.6+. Although we can make a "tweak" and remove this specific file for python2, we prefer to make this package available only for python3, because the day this package (and many others) will drop support for python2 is probably very close.

In addition, update python-attrs recursive dependencies to depend on python3 too (python-automat is the only one left).

Fixes:
- http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/

---
 package/python-attrs/Config.in   | 1 +
 package/python-automat/Config.in | 1 +
 2 files changed, 2 insertions(+)
package/python-attrs/Config.in +1 -0
index fb0ab248fa..b658d20ec9 100644
@@ -1,4 +1,5 @@
 config BR2_PACKAGE_PYTHON_ATTRS
+	depends on BR2_PACKAGE_PYTHON3
 	bool "python-attrs"
 	help
 	  attrs is the Python package that will bring back the joy of
package/python-automat/Config.in +1 -0
index ee02d22b5b..9d22276c2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_AUTOMAT
 	bool "python-automat"
+	depends on BR2_PACKAGE_PYTHON3 # python-attrs
 	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Asaf, All,

On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:

Quoted 23 lines

python-attrs contains a file with API for python 3.6+. Although we can make a "tweak" and remove this specific file for python2, we prefer to make this package available only for python3, because the day this package (and many others) will drop support for python2 is probably very close.

In addition, update python-attrs recursive dependencies to depend on python3 too (python-automat is the only one left).

Fixes:
- http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/

---
 package/python-attrs/Config.in   | 1 +
 package/python-automat/Config.in | 1 +
 2 files changed, 2 insertions(+)
package/python-attrs/Config.in +0 -0
index fb0ab248fa..b658d20ec9 100644

package/python-attrs/Config.in line 2

Quoted 2 lines
package/python-attrs/Config.in +1 -0
@@ -1,4 +1,5 @@
 config BR2_PACKAGE_PYTHON_ATTRS
+	depends on BR2_PACKAGE_PYTHON3
    $ make check-package
    package/python-attrs/Config.in:3: attributes order: type, default,
    depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 21 lines
package/python-attrs/Config.in +0 -0
 	bool "python-attrs"
 	help
 	  attrs is the Python package that will bring back the joy of
package/python-automat/Config.in +1 -0
index ee02d22b5b..9d22276c2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_AUTOMAT
 	bool "python-automat"
+	depends on BR2_PACKAGE_PYTHON3 # python-attrs
 	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Asaf, All,

Le 25/09/2021 à 18:33, Yann E. MORIN a écrit :

Quoted 11 lines

Asaf, All,

On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:

Quoted 8 lines

python-attrs contains a file with API for python 3.6+. Although we can make a "tweak" and remove this specific file for python2, we prefer to make this package available only for python3, because the day this package (and many others) will drop support for python2 is probably very close.

In addition, update python-attrs recursive dependencies to depend on python3 too (python-automat is the only one left).

Please Asaf, take care of python tests in the Buildroot testsuite.

Since python-attrs is now python3 only we can remove (at least) two tests:

TestPythonPy2Attrs
TestPythonPy2Automat

Best regards,
Romain

Quoted 44 lines
Quoted 15 lines

Fixes:
- http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/

---
 package/python-attrs/Config.in   | 1 +
 package/python-automat/Config.in | 1 +
 2 files changed, 2 insertions(+)
package/python-attrs/Config.in +0 -0
index fb0ab248fa..b658d20ec9 100644

package/python-attrs/Config.in line 2

Quoted 2 lines
package/python-attrs/Config.in +1 -0
@@ -1,4 +1,5 @@
 config BR2_PACKAGE_PYTHON_ATTRS
+	depends on BR2_PACKAGE_PYTHON3
    $ make check-package
    package/python-attrs/Config.in:3: attributes order: type, default,
    depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 17 lines
package/python-attrs/Config.in +0 -0
 	bool "python-attrs"
 	help
 	  attrs is the Python package that will bring back the joy of
package/python-automat/Config.in +1 -0
index ee02d22b5b..9d22276c2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_AUTOMAT
 	bool "python-automat"
+	depends on BR2_PACKAGE_PYTHON3 # python-attrs
 	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
Signature · 1 line
2.30.2
Quoted 5 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Ramain,

Quoted 16 lines · Romain Naour

Asaf, All,

Quoted 11 lines · Yann E. MORIN

Asaf, All,

On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:

Quoted 8 lines

python-attrs contains a file with API for python 3.6+. Although we can make a "tweak" and remove this specific file for python2, we prefer to make this package available only for python3, because the day this package (and many others) will drop support for python2 is probably very close.

In addition, update python-attrs recursive dependencies to depend on python3 too (python-automat is the only one left).

Quoted 6 lines

Please Asaf, take care of python tests in the Buildroot testsuite.

Since python-attrs is now python3 only we can remove (at least) two tests:

TestPythonPy2Attrs
TestPythonPy2Automat

You're right, thanks.
I'll take a look and send a proper patch.

Quoted 55 lines

Best regards,
Romain

Quoted 49 lines
Quoted 15 lines

Fixes:
- http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/

---
 package/python-attrs/Config.in   | 1 +
 package/python-automat/Config.in | 1 +
 2 files changed, 2 insertions(+)
package/python-attrs/Config.in +0 -0
index fb0ab248fa..b658d20ec9 100644

package/python-attrs/Config.in line 2

Quoted 2 lines
package/python-attrs/Config.in +1 -0
@@ -1,4 +1,5 @@
 config BR2_PACKAGE_PYTHON_ATTRS
+    depends on BR2_PACKAGE_PYTHON3
    $ make check-package
    package/python-attrs/Config.in:3: attributes order: type, default,
    depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 21 lines
package/python-attrs/Config.in +0 -0
     bool "python-attrs"
     help
       attrs is the Python package that will bring back the joy of
package/python-automat/Config.in +1 -1
index ee02d22b5b..9d22276c2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_AUTOMAT
     bool "python-automat"
+    depends on BR2_PACKAGE_PYTHON3 # python-attrs
     select BR2_PACKAGE_PYTHON_ATTRS # runtime
     select BR2_PACKAGE_PYTHON_SIX # runtime
     help
--

2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Thanks,
Asaf
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot