qla2xxx: Fix excessive messages during device logout
Subsystems (2)
Nilesh Javali
maintainerPATCH 1/1 qla2xxx: Fix excessive messages during device logout
From: Arun Easi <[email protected]>
Disable default logging of some IO path messages which can be turned back on by setting ql2xextended_error_logging.
--- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +2 -2
@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, }if (unlikely (logit)) - ql_log(ql_log_warn, fcport->vha, 0x5060, + ql_log(ql_dbg_io, fcport->vha, 0x5060, "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x ox_id=%x\n", sp->name, sp->handle, comp_status, fd->transferred_length, le32_to_cpu(sts->residual_len),
@@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) out:if (logit) - ql_log(ql_log_warn, fcport->vha, 0x3022, + ql_log(ql_dbg_io, fcport->vha, 0x3022, "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n", comp_status, scsi_status, res, vha->host_no, cp->device->id, cp->device->lun, fcport->d_id.b.domain,
Signature · 1 line
2.19.0.rc0
Thanks for posting this. Martin, can we get this in soon? The logging could be overwhelming.
Quoted 37 lines · Nilesh Javali
From: Arun Easi <[email protected]>
Disable default logging of some IO path messages which can be turned back on by setting
ql2xextended_error_logging.Signed-off-by Arun Easi <[email protected]>Signed-off-by Nilesh Javali <[email protected]>--- drivers/scsi/qla2xxx/qla_isr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/qla2xxx/qla_isr.c +2
-3@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, }if (unlikely (logit)) - ql_log(ql_log_warn, fcport->vha, 0x5060, + ql_log(ql_dbg_io, fcport->vha, 0x5060, "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x ox_id=%x\n", sp->name, sp->handle, comp_status, fd->transferred_length, le32_to_cpu(sts->residual_len),@@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) out:if (logit) - ql_log(ql_log_warn, fcport->vha, 0x3022, + ql_log(ql_dbg_io, fcport->vha, 0x3022, "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n", comp_status, scsi_status, res, vha->host_no, cp->device->id, cp->device->lun, fcport->d_id.b.domain, --2.19.0.rc0
Quoted 34 lines · Nilesh Javali
From: Arun Easi <[email protected]>
Disable default logging of some IO path messages which can be turned back on by setting
ql2xextended_error_logging.Signed-off-by Arun Easi <[email protected]>Signed-off-by Nilesh Javali <[email protected]>---
drivers/scsi/qla2xxx/qla_isr.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/qla2xxx/qla_isr.c +1
-1@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, }if (unlikely (logit)) - ql_log(ql_log_warn, fcport->vha, 0x5060, + ql_log(ql_dbg_io, fcport->vha, 0x5060, "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x ox_id=%x\n", sp->name, sp->handle, comp_status, fd->transferred_length, le32_to_cpu(sts->residual_len),@@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)out:
if (logit)drivers/scsi/qla2xxx/qla_isr.c +1
-1- ql_log(ql_log_warn, fcport->vha, 0x3022, + ql_log(ql_dbg_io, fcport->vha, 0x3022,
Quoted 5 lines
"FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n", comp_status, scsi_status, res, vha->host_no, cp->device->id, cp->device->lun, fcport->d_id.b.domain,Signature · 1 line
2.19.0.rc0
Looks Good. Indeed a much needed fix.
--
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Nilesh Javali
From: Arun Easi <[email protected]>
Disable default logging of some IO path messages which can be turned back on by setting
ql2xextended_error_logging.
Applied to 5.15/scsi-fixes, thanks!
[1/1] qla2xxx: Fix excessive messages during device logout
https://git.kernel.org/mkp/scsi/c/8e2d81c6b5be
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering