Remove uneccessary parantheas
PATCH 1/1 Remove uneccessary parantheas
Fix to be conform with the checkpatch style requirements
--- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/pi433/rf69.c +3 -3
@@ -470,9 +470,9 @@ static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg,return -EINVAL ; } -if ((mantisse != mantisse16) && - (mantisse != mantisse20) && - (mantisse != mantisse24)) { +if (mantisse != mantisse16 && + mantisse != mantisse20 && + mantisse != mantisse24) {dev_dbg (&spi->dev,"set: illegal input param" );return -EINVAL ; }
--
2.25.1
Greg Kroah-Hartman
maintainerQuoted 25 lines · Michael Estner
Fix to be conform with the checkpatch style requirements
Signed-off-by Michael Estner <[email protected]>--- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/pi433/rf69.c +3
-4@@ -470,9 +470,9 @@ static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg,return -EINVAL ; } -if ((mantisse != mantisse16) && - (mantisse != mantisse20) && - (mantisse != mantisse24)) { +if (mantisse != mantisse16 && + mantisse != mantisse20 && + mantisse != mantisse24) {dev_dbg (&spi->dev,"set: illegal input param" );return -EINVAL ; } --
Quoted 2 lines
2.25.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 1 line · CEST Michael Estner
Fix to be conform with the checkpatch style requirements
Greg K-H's "friendly patch bot" has already been triggered and sent you a message. Usually, according to Greg's style :), this is all you get and then you are left alone to figure out what you did wrong and eventually submit a new version.
However, as this is your very first patch, I would like to give you some additional information that may help you.
1) Where is the name of the driver your fixing? You must place it in the subject and its position and formatting must comply with this subsystem rules. Please, read other patches for staging among those that have already been accepted.
2) What language are you using in the subject? "Remove uneccessary parantheas" has no meaning in English. Typos can happen, but you have not made any typos: your "Subject line" is a completely incomprehensible sequence of characters. :)
3) "Fix to be conform[]" (sigh). Fix what? Changelogs (or "Commits messages") must be self-contained, so write them like if you expected that the Reviewers immediately forget what they read in the "Subject" line. While you are at it, please also correct grammar.
(Finally, it is the Linux kernel maintainers and developers who have "style requirements", listed in the "Linux kernel coding style" document, instead checkpatch.pl has no requirements (it just checks for style violations)).
Thanks,
Fabio
Quoted 2 lines
Signed-off-by Michael Estner <[email protected]>---