5.10.70-rc1 review
Subsystems (5)
Greg Kroah-Hartman
maintainerPATCH 32/103 comedi: Fix memory leak in compat_insnlist()
In reply to Greg Kroah-HartmanFrom: Ian Abbott <[email protected]>
commit bb509a6ffed2c8b0950f637ab5779aa818ed1596 upstream.
compat_insnlist() handles the 32-bit version of the COMEDI_INSNLIST ioctl (whenwhen CONFIG_COMPAT is enabled). It allocates memory to temporarily hold an array of struct comedi_insn converted from the 32-bit version in user space. This memory is only being freed if there is a fault while filling the array, otherwise it is leaked.
Add a call to kfree() to fix the leak.
--- drivers/staging/comedi/comedi_fops.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/comedi/comedi_fops.c +1 -0
@@ -3090,6 +3090,7 @@ static int compat_insnlist(struct file *mutex_lock (&dev->mutex); rc =do_insnlist_ioctl (dev, insns, insnlist32.n_insns, file);mutex_unlock (&dev->mutex); +kfree (insns);return rc; }
Greg Kroah-Hartman
maintainerPATCH 1/103 PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response
In reply to Greg Kroah-HartmanFrom: Pali Rohár <[email protected]>
commit 2b58db229eb617d97d5746113b77045f1f884bcb upstream.
Measurements in different conditions showed that aardvark hardware PIO response can take up to 1.44s. Increase wait timeout from 1ms to 1.5s to ensure that we do not miss responses from hardware. After 1.44s hardware returns errors (e.g. Completer abort).
The previous two patches fixed checking for PIO status, so now we can use it to also catch errors which are reported by hardware after 1.44s.
After applying this patch, kernel can detect and print PIO errors to dmesg:
[ 6.879999] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100004
[ 6.896436] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100004
[ 6.913049] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100010
[ 6.929663] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100010
[ 6.953558] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100014
[ 6.970170] advk-pcie d0070000.pcie: Non-posted PIO Response Status: CA, 0xe00 @ 0x100014
[ 6.994328] advk-pcie d0070000.pcie: Posted PIO Response Status: COMP_ERR, 0x804 @ 0x100004Without this patch kernel prints only a generic error to dmesg:
[ 5.246847] advk-pcie d0070000.pcie: config read/write timed out
--- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-aardvark.c +1 -1
@@ -214,7 +214,7 @@ (PCIE_CONF_BUS (bus) |PCIE_CONF_DEV (PCI_SLOT (devfn)) | \ PCIE_CONF_FUNC(PCI_FUNC(devfn)) | PCIE_CONF_REG(where)) -#define PIO_RETRY_CNT 500 +#define PIO_RETRY_CNT 750000/* 1.5 s */ #define PIO_RETRY_DELAY 2/* 2 us*/ #define LINK_WAIT_MAX_RETRIES 10
Greg Kroah-Hartman
maintainerPATCH 10/103 usb-storage: Add quirk for ScanLogic SL11R-IDE older than 2.6c
In reply to Greg Kroah-HartmanFrom: Ondrej Zary <[email protected]>
commit b55d37ef6b7db3eda9b4495a8d9b0a944ee8c67d upstream.
ScanLogic SL11R-IDE with firmware older than 2.6c (the latest one) has broken tag handling, preventing the device from working at all:
usb 1-1: new full-speed USB device number 2 using uhci_hcd
usb 1-1: New USB device found, idVendor=04ce, idProduct=0002, bcdDevice= 2.60 usb 1-1: New USB device strings: Mfr=1, Product=1, SerialNumber=0 usb 1-1: Product: USB Device
usb 1-1: Manufacturer: USB Device
usb-storage 1-1:1.0: USB Mass Storage device detected
scsi host2: usb-storage 1-1:1.0
usbcore: registered new interface driver usb-storage
usb 1-1: reset full-speed USB device number 2 using uhci_hcd
usb 1-1: reset full-speed USB device number 2 using uhci_hcd
usb 1-1: reset full-speed USB device number 2 using uhci_hcd
usb 1-1: reset full-speed USB device number 2 using uhci_hcd
Add US_FL_BULK_IGNORE_TAG to fix it. Also update my e-mail address.
2.6c is the only firmware that claims Linux compatibility. The firmware can be upgraded using ezotgdbg utility:
https://github.com/asciilifeform/ezotgdbg
--- drivers/usb/storage/unusual_devs.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/usb/storage/unusual_devs.h +8 -1
@@ -416,9 +416,16 @@ UNUSUAL_DEV( 0x04cb, 0x0100, 0x0000, 0x USB_SC_UFI, USB_PR_DEVICE, NULL, US_FL_FIX_INQUIRY | US_FL_SINGLE_LUN),/* -* Reported by Ondrej Zary <[email protected]> +* Reported by Ondrej Zary <[email protected]> * The device reports one sector more and breaks when that sector is accessed +* Firmwares older than 2.6c (the latest one and the only that claims Linux +* support) have also broken tag handling */ +UNUSUAL_DEV (0x04ce ,0x0002 ,0x0000 ,0x026b , +"ScanLogic" , +"SL11R-IDE" , +USB_SC_DEVICE ,USB_PR_DEVICE ,NULL , +US_FL_FIX_CAPACITY |US_FL_BULK_IGNORE_TAG ), UNUSUAL_DEV( 0x04ce, 0x0002, 0x026c, 0x026c, "ScanLogic", "SL11R-IDE",
Greg Kroah-Hartman
maintainerPATCH 11/103 USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter
In reply to Greg Kroah-HartmanFrom: Uwe Brandt <[email protected]>
commit 3bd18ba7d859eb1fbef3beb1e80c24f6f7d7596c upstream.
Add the USB serial device ID for the GW Instek GDM-834x Digital Multimeter.
--- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/serial/cp210x.c +1 -0
@@ -237,6 +237,7 @@ static const struct usb_device_id id_tab { USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power Supply */ { USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM Controller */ { USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix */ + { USB_DEVICE(0x2184, 0x0030) }, /* GW Instek GDM-834x Digital Multimeter */ { USB_DEVICE(0x2626, 0xEA60) }, /* Aruba Networks 7xxx USB Serial Console */ { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */ { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */
Greg Kroah-Hartman
maintainerPATCH 12/103 USB: cdc-acm: fix minor-number release
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 91fac0741d4817945c6ee0a17591421e7f5ecb86 upstream.
If the driver runs out of minor numbers it would release minor 0 and allow another device to claim the minor while still in use.
Fortunately, registering the tty class device of the second device would fail (with a stack dump) due to the sysfs name collision so no memory is leaked.
--- drivers/usb/class/cdc-acm.c | 7 +++++-- drivers/usb/class/cdc-acm.h | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-)
drivers/usb/class/cdc-acm.c +5 -2
@@ -726,7 +726,8 @@ static void acm_port_destruct(struct tty { struct acm *acm = container_of(port, struct acm, port); -acm_release_minor (acm); +if (acm->minor !=ACM_MINOR_INVALID ) +acm_release_minor (acm);usb_put_intf (acm->control);kfree (acm->country_codes);kfree (acm);
@@ -1343,8 +1344,10 @@ made_compressed_probe:usb_get_intf (acm->control);/* undone in destruct() */ minor =acm_alloc_minor (acm); -if (minor <0 ) +if (minor <0 ) { + acm->minor =ACM_MINOR_INVALID ; goto alloc_fail1; + } acm->minor = minor; acm->dev = usb_dev;
drivers/usb/class/cdc-acm.h +2 -0
@@ -22,6 +22,8 @@#define ACM_TTY_MAJOR 166#define ACM_TTY_MINORS 256 +#define ACM_MINOR_INVALID ACM_TTY_MINORS +/* * Requests. */
Greg Kroah-Hartman
maintainerPATCH 13/103 Revert "USB: bcma: Add a check for devm_gpiod_get"
In reply to Greg Kroah-HartmanFrom: Rafał Miłecki <[email protected]>
commit d91adc5322ab53df4b6d1989242bfb6c63163eb2 upstream.
This reverts commit f3de5d857bb2362b00e2a8d4bc886cd49dcb66db.
That commit broke USB on all routers that have USB always powered on and don't require toggling any GPIO. It's a majority of devices actually.
The original code worked and seemed safe: vcc GPIO is optional and bcma_hci_platform_power_gpio() takes care of checking the pointer before using it.
This revert fixes:
[ 10.801127] bcma_hcd: probe of bcma0:11 failed with error -2
--- drivers/usb/host/bcma-hcd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/host/bcma-hcd.c +1 -4
@@ -406,12 +406,9 @@ static int bcma_hcd_probe(struct bcma_dereturn -ENOMEM ; usb_dev->core = core; -if (core->dev.of_node) { +if (core->dev.of_node) usb_dev->gpio_desc =devm_gpiod_get (&core->dev,"vcc" ,GPIOD_OUT_HIGH ); -if (IS_ERR (usb_dev->gpio_desc)) -return PTR_ERR (usb_dev->gpio_desc); - }switch (core->id.id) {case BCMA_CORE_USB20_HOST :
Greg Kroah-Hartman
maintainerPATCH 14/103 binder: make sure fd closes complete
In reply to Greg Kroah-HartmanFrom: Todd Kjos <[email protected]>
commit 5fdb55c1ac9585eb23bb2541d5819224429e103d upstream.
During BC_FREE_BUFFER processing, the BINDER_TYPE_FDA object cleanup may close 1 or more fds. The close operations are completed using the task work mechanism -- which means the thread needs to return to userspace or the file object may never be dereferenced -- which can lead to hung processes.
Force the binder thread back to userspace if an fd is closed during BC_FREE_BUFFER handling.
--- drivers/android/binder.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-)
drivers/android/binder.c +17 -6
@@ -2236,6 +2236,7 @@ static void binder_deferred_fd_close(int }static void binder_transaction_buffer_release (struct binder_proc *proc, +struct binder_thread *thread,struct binder_buffer *buffer,binder_size_t failed_at,bool is_failure)
@@ -2395,8 +2396,16 @@ static void binder_transaction_buffer_re &proc->alloc, &fd, buffer, offset, sizeof(fd));WARN_ON (err); -if (!err) +if (!err) {binder_deferred_fd_close (fd); +/* +* Need to make sure the thread goes +* back to userspace to complete the +* deferred close +*/ +if (thread) + thread->looper_need_return = true; + } } }break ;default :
@@ -3465,7 +3474,7 @@ err_bad_parent: err_copy_data_failed:binder_free_txn_fixups (t);trace_binder_transaction_failed_buffer_release (t->buffer); -binder_transaction_buffer_release (target_proc, t->buffer, +binder_transaction_buffer_release (target_proc,NULL , t->buffer, buffer_offset, true);if (target_node)binder_dec_node_tmpref (target_node);
@@ -3542,7 +3551,9 @@ err_invalid_target_handle:* Cleanup buffer and free it. */ static void -binder_free_buf (struct binder_proc *proc,struct binder_buffer *buffer) +binder_free_buf (struct binder_proc *proc, +struct binder_thread *thread, +struct binder_buffer *buffer) {binder_inner_proc_lock (proc);if (buffer->transaction) {
@@ -3570,7 +3581,7 @@ binder_free_buf(struct binder_proc *procbinder_node_inner_unlock (buf_node); }trace_binder_transaction_buffer_release (buffer); -binder_transaction_buffer_release (proc, buffer,0 , false); +binder_transaction_buffer_release (proc, thread, buffer,0 , false);binder_alloc_free_buf (&proc->alloc, buffer); }
@@ -3771,7 +3782,7 @@ static int binder_thread_write(struct bi proc->pid, thread->pid, (u64 )data_ptr, buffer->debug_id, buffer->transaction ? "active" : "finished"); -binder_free_buf (proc, buffer); +binder_free_buf (proc, thread, buffer);break ; }
@@ -4459,7 +4470,7 @@ retry: buffer->transaction =NULL ;binder_cleanup_transaction (t,"fd fixups failed" ,BR_FAILED_REPLY ); -binder_free_buf (proc, buffer); +binder_free_buf (proc, thread, buffer); binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, "%d:%d %stransaction %d fd fixups failed %d/%d, line %d\n", proc->pid, thread->pid,
Greg Kroah-Hartman
maintainerPATCH 15/103 staging: greybus: uart: fix tty use after free
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit 92dc0b1f46e12cfabd28d709bb34f7a39431b44f upstream.
User space can hold a tty open indefinitely and tty drivers must not release the underlying structures until the last user is gone.
Switch to using the tty-port reference counter to manage the life time of the greybus tty state to avoid use after free after a disconnect.
--- drivers/staging/greybus/uart.c | 62 +++++++++++++++++++++-------------------- 1 file changed, 32 insertions(+), 30 deletions(-)
drivers/staging/greybus/uart.c +32 -30
@@ -778,6 +778,17 @@ out:gbphy_runtime_put_autosuspend (gb_tty->gbphy_dev); } +static void gb_tty_port_destruct (struct tty_port *port) +{ + struct gb_tty *gb_tty = container_of(port, struct gb_tty, port); + +if (gb_tty->minor !=GB_NUM_MINORS ) +release_minor (gb_tty); +kfifo_free (&gb_tty->write_fifo); +kfree (gb_tty->buffer); +kfree (gb_tty); +} +static const struct tty_operations gb_ops = { .install = gb_tty_install, .open = gb_tty_open,
@@ -803,6 +814,7 @@ static const struct tty_port_operations .dtr_rts = gb_tty_dtr_rts, .activate = gb_tty_port_activate, .shutdown = gb_tty_port_shutdown, + .destruct = gb_tty_port_destruct, }; static int gb_uart_probe(struct gbphy_device *gbphy_dev,
@@ -815,17 +827,11 @@ static int gb_uart_probe(struct gbphy_deint retval;int minor; - gb_tty =kzalloc (sizeof (*gb_tty),GFP_KERNEL ); -if (!gb_tty) -return -ENOMEM ; - connection =gb_connection_create (gbphy_dev->bundle,le16_to_cpu (gbphy_dev->cport_desc->id), gb_uart_request_handler); -if (IS_ERR (connection)) { - retval =PTR_ERR (connection); - goto exit_tty_free; - } +if (IS_ERR (connection)) +return PTR_ERR (connection); max_payload =gb_operation_get_payload_size_max (connection);if (max_payload <sizeof (struct gb_uart_send_data_request )) {
@@ -833,13 +839,23 @@ static int gb_uart_probe(struct gbphy_de goto exit_connection_destroy; } + gb_tty =kzalloc (sizeof (*gb_tty),GFP_KERNEL ); +if (!gb_tty) { + retval = -ENOMEM ; + goto exit_connection_destroy; + } + +tty_port_init (&gb_tty->port); + gb_tty->port.ops = &gb_port_ops; + gb_tty->minor =GB_NUM_MINORS ; + gb_tty->buffer_payload_max = max_payload -sizeof (struct gb_uart_send_data_request ); gb_tty->buffer =kzalloc (gb_tty->buffer_payload_max,GFP_KERNEL );if (!gb_tty->buffer) { retval = -ENOMEM ; - goto exit_connection_destroy; + goto exit_put_port; }INIT_WORK (&gb_tty->tx_work, gb_uart_tx_write_work);
@@ -847,7 +863,7 @@ static int gb_uart_probe(struct gbphy_de retval =kfifo_alloc (&gb_tty->write_fifo,GB_UART_WRITE_FIFO_SIZE ,GFP_KERNEL );if (retval) - goto exit_buf_free; + goto exit_put_port; gb_tty->credits =GB_UART_FIRMWARE_CREDITS ;init_completion (&gb_tty->credits_complete);
@@ -861,7 +877,7 @@ static int gb_uart_probe(struct gbphy_de }else { retval = minor; } - goto exit_kfifo_free; + goto exit_put_port; } gb_tty->minor = minor;
@@ -870,9 +886,6 @@ static int gb_uart_probe(struct gbphy_deinit_waitqueue_head (&gb_tty->wioctl);mutex_init (&gb_tty->mutex); -tty_port_init (&gb_tty->port); - gb_tty->port.ops = &gb_port_ops; - gb_tty->connection = connection; gb_tty->gbphy_dev = gbphy_dev;gb_connection_set_data (connection, gb_tty);
@@ -880,7 +893,7 @@ static int gb_uart_probe(struct gbphy_de retval =gb_connection_enable_tx (connection);if (retval) - goto exit_release_minor; + goto exit_put_port;send_control (gb_tty, gb_tty->ctrlout);
@@ -907,16 +920,10 @@ static int gb_uart_probe(struct gbphy_de exit_connection_disable:gb_connection_disable (connection); -exit_release_minor: -release_minor (gb_tty); -exit_kfifo_free: -kfifo_free (&gb_tty->write_fifo); -exit_buf_free: -kfree (gb_tty->buffer); +exit_put_port: +tty_port_put (&gb_tty->port); exit_connection_destroy:gb_connection_destroy (connection); -exit_tty_free: -kfree (gb_tty);return retval; }
@@ -947,15 +954,10 @@ static void gb_uart_remove(struct gbphy_gb_connection_disable_rx (connection);tty_unregister_device (gb_tty_driver, gb_tty->minor); -/* FIXME - free transmit / receive buffers */ -gb_connection_disable (connection); -tty_port_destroy (&gb_tty->port);gb_connection_destroy (connection); -release_minor (gb_tty); -kfifo_free (&gb_tty->write_fifo); -kfree (gb_tty->buffer); -kfree (gb_tty); + +tty_port_put (&gb_tty->port); }static int gb_tty_init (void )
Greg Kroah-Hartman
maintainerPATCH 16/103 Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
In reply to Greg Kroah-HartmanFrom: Julian Sikorski <[email protected]>
commit ce1c42b4dacfe7d71c852d8bf3371067ccba865c upstream.
Further testing has revealed that LaCie Rugged USB3-FW does work with uas as long as US_FL_NO_REPORT_OPCODES and US_FL_NO_SAME are enabled.
--- drivers/usb/storage/unusual_uas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/storage/unusual_uas.h +1 -1
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x99"LaCie" ,"Rugged USB3-FW" ,USB_SC_DEVICE ,USB_PR_DEVICE ,NULL , - US_FL_IGNORE_UAS), + US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),/* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
Greg Kroah-Hartman
maintainerPATCH 17/103 usb: dwc3: core: balance phy init and exit
In reply to Greg Kroah-HartmanFrom: Li Jun <[email protected]>
commit 8cfac9a6744fcb143cb3e94ce002f09fd17fadbb upstream.
After we start to do core soft reset while usb role switch, the phy init is invoked at every switch to device mode, but its counter part de-init is missing, this causes the actual phy init can not be done when we really want to re-init phy like system resume, because the counter maintained by phy core is not 0. considering phy init is actually redundant for role switch, so move out the phy init from core soft reset to dwc3 core init where is the only place required.
--- drivers/usb/dwc3/core.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-)
drivers/usb/dwc3/core.c +13 -17
@@ -264,19 +264,6 @@ static int dwc3_core_soft_reset(struct d {u32 reg;int retries =1000 ; -int ret; - -usb_phy_init (dwc->usb2_phy); -usb_phy_init (dwc->usb3_phy); - ret =phy_init (dwc->usb2_generic_phy); -if (ret <0 ) -return ret; - - ret =phy_init (dwc->usb3_generic_phy); -if (ret <0 ) { -phy_exit (dwc->usb2_generic_phy); -return ret; - }/* * We're resetting only the device side because, if we're in host mode,
@@ -310,9 +297,6 @@ static int dwc3_core_soft_reset(struct dudelay (1 ); }while (--retries); -phy_exit (dwc->usb3_generic_phy); -phy_exit (dwc->usb2_generic_phy); -return -ETIMEDOUT ; done:
@@ -979,9 +963,21 @@ static int dwc3_core_init(struct dwc3 *d dwc->phys_ready = true; } +usb_phy_init (dwc->usb2_phy); +usb_phy_init (dwc->usb3_phy); + ret =phy_init (dwc->usb2_generic_phy); +if (ret <0 ) + goto err0a; + + ret =phy_init (dwc->usb3_generic_phy); +if (ret <0 ) { +phy_exit (dwc->usb2_generic_phy); + goto err0a; + } + ret =dwc3_core_soft_reset (dwc);if (ret) - goto err0a; + goto err1;if (hw_mode ==DWC3_GHWPARAMS0_MODE_DRD && !DWC3_VER_IS_WITHIN(DWC3, ANY, 194A)) {
Greg Kroah-Hartman
maintainerPATCH 18/103 usb: core: hcd: Add support for deferring roothub registration
In reply to Greg Kroah-HartmanFrom: Kishon Vijay Abraham I <[email protected]>
commit 58877b0824da15698bd85a0a9dbfa8c354e6ecb7 upstream.
It has been observed with certain PCIe USB cards (like Inateck connected to AM64 EVM or J7200 EVM) that as soon as the primary roothub is registered, port status change is handled even before xHC is running leading to cold plug USB devices not detected. For such cases, registering both the root hubs along with the second HCD is required. Add support for deferring roothub registration in usb_add_hcd(), so that both primary and secondary roothubs are registered along with the second HCD.
--- drivers/usb/core/hcd.c | 29 +++++++++++++++++++++++------ include/linux/usb/hcd.h | 2 ++ 2 files changed, 25 insertions(+), 6 deletions(-)
drivers/usb/core/hcd.c +23 -6
@@ -2640,6 +2640,7 @@ int usb_add_hcd(struct usb_hcd *hcd, {int retval;struct usb_device *rhdev; +struct usb_hcd *shared_hcd;if (!hcd->skip_phy_initialization &&usb_hcd_is_primary_hcd (hcd)) { hcd->phy_roothub =usb_phy_roothub_alloc (hcd->self.sysdev);
@@ -2796,13 +2797,26 @@ int usb_add_hcd(struct usb_hcd *hcd, goto err_hcd_driver_start; } +/* starting here, usbcore will pay attention to the shared HCD roothub */ + shared_hcd = hcd->shared_hcd; +if (!usb_hcd_is_primary_hcd (hcd) && shared_hcd &&HCD_DEFER_RH_REGISTER (shared_hcd)) { + retval =register_root_hub (shared_hcd); +if (retval !=0 ) + goto err_register_root_hub; + +if (shared_hcd->uses_new_polling &&HCD_POLL_RH (shared_hcd)) +usb_hcd_poll_rh_status (shared_hcd); + } +/* starting here, usbcore will pay attention to this root hub */ - retval =register_root_hub (hcd); -if (retval !=0 ) - goto err_register_root_hub; +if (!HCD_DEFER_RH_REGISTER (hcd)) { + retval =register_root_hub (hcd); +if (retval !=0 ) + goto err_register_root_hub; -if (hcd->uses_new_polling &&HCD_POLL_RH (hcd)) -usb_hcd_poll_rh_status (hcd); +if (hcd->uses_new_polling &&HCD_POLL_RH (hcd)) +usb_hcd_poll_rh_status (hcd); + }return retval;
@@ -2845,6 +2859,7 @@ EXPORT_SYMBOL_GPL(usb_add_hcd);void usb_remove_hcd (struct usb_hcd *hcd) {struct usb_device *rhdev = hcd->self.root_hub; +bool rh_registered;dev_info (hcd->self.controller,"remove, state %x\n" , hcd->state);
@@ -2855,6 +2870,7 @@ void usb_remove_hcd(struct usb_hcd *hcd)dev_dbg (hcd->self.controller,"roothub graceful disconnect\n" );spin_lock_irq (&hcd_root_hub_lock); + rh_registered = hcd->rh_registered; hcd->rh_registered =0 ;spin_unlock_irq (&hcd_root_hub_lock);
@@ -2864,7 +2880,8 @@ void usb_remove_hcd(struct usb_hcd *hcd)cancel_work_sync (&hcd->died_work);mutex_lock (&usb_bus_idr_lock); -usb_disconnect (&rhdev);/* Sets rhdev to NULL */ +if (rh_registered) +usb_disconnect (&rhdev);/* Sets rhdev to NULL */ mutex_unlock (&usb_bus_idr_lock);/*
include/linux/usb/hcd.h +2 -0
@@ -124,6 +124,7 @@ struct usb_hcd {#define HCD_FLAG_RH_RUNNING 5/* root hub is running? */ #define HCD_FLAG_DEAD 6/* controller has died? */ #define HCD_FLAG_INTF_AUTHORIZED 7/* authorize interfaces? */ +#define HCD_FLAG_DEFER_RH_REGISTER 8/* Defer roothub registration */ /* The flags can be tested using these macros; they are likely to * be slightly faster than test_bit().
@@ -134,6 +135,7 @@ struct usb_hcd {#define HCD_WAKEUP_PENDING (hcd) ((hcd)->flags & (1U << HCD_FLAG_WAKEUP_PENDING))#define HCD_RH_RUNNING (hcd) ((hcd)->flags & (1U << HCD_FLAG_RH_RUNNING))#define HCD_DEAD (hcd) ((hcd)->flags & (1U << HCD_FLAG_DEAD)) +#define HCD_DEFER_RH_REGISTER (hcd) ((hcd)->flags & (1U << HCD_FLAG_DEFER_RH_REGISTER))/* * Specifies if interfaces are authorized by default
Greg Kroah-Hartman
maintainerPATCH 19/103 USB: serial: mos7840: remove duplicated 0xac24 device ID
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
commit 211f323768a25b30c106fd38f15a0f62c7c2b5f4 upstream.
0xac24 device ID is already defined and used via BANDB_DEVICE_ID_USO9ML2_4. Remove the duplicate from the list.
--- drivers/usb/serial/mos7840.c | 2 -- 1 file changed, 2 deletions(-)
drivers/usb/serial/mos7840.c +0 -2
@@ -107,7 +107,6 @@#define BANDB_DEVICE_ID_USOPTL4_2P 0xBC02#define BANDB_DEVICE_ID_USOPTL4_4 0xAC44#define BANDB_DEVICE_ID_USOPTL4_4P 0xBC03 -#define BANDB_DEVICE_ID_USOPTL2_4 0xAC24/* Interrupt Routine Defines */
@@ -186,7 +185,6 @@ static const struct usb_device_id id_tab { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_2P) }, { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4) }, { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4P) }, - { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL2_4) }, {} /* terminating entry */ };MODULE_DEVICE_TABLE (usb, id_table);
Greg Kroah-Hartman
maintainerPATCH 2/103 ocfs2: drop acl cache for directories too
In reply to Greg Kroah-HartmanFrom: Wengang Wang <[email protected]>
commit 9c0f0a03e386f4e1df33db676401547e1b7800c6 upstream.
ocfs2_data_convert_worker() is currently dropping any cached acl info for FILE before down-converting meta lock. It should also drop for DIRECTORY. Otherwise the second acl lookup returns the cached one (from VFS layer) which could be already stale.
The problem we are seeing is that the acl changes on one node doesn't get refreshed on other nodes in the following case:
Node 1 Node 2
-------------- ----------------
getfacl dir1
getfacl dir1 <-- this is OK
setfacl -m u:user1:rwX dir1
getfacl dir1 <-- see the change for user1
getfacl dir1 <-- can't see change for user1
--- fs/ocfs2/dlmglue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/ocfs2/dlmglue.c +2 -1
@@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(str oi =OCFS2_I (inode); oi->ip_dir_lock_gen++;mlog (0 ,"generation: %u\n" , oi->ip_dir_lock_gen); - goto out; + goto out_forget; }if (!S_ISREG (inode->i_mode))
@@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(strfilemap_fdatawait (mapping); } +out_forget:forget_all_cached_acls (inode); out:
Greg Kroah-Hartman
maintainerPATCH 4/103 usb: gadget: r8a66597: fix a loop in set_feature()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
commit 17956b53ebff6a490baf580a836cbd3eae94892b upstream.
This loop is supposed to loop until if reads something other than CS_IDST or until it times out after 30,000 attempts. But because of the || vs && bug, it will never time out and instead it will loop a minimum of 30,000 times.
This bug is quite old but the code is only used in USB_DEVICE_TEST_MODE so it probably doesn't affect regular usage.
--- drivers/usb/gadget/udc/r8a66597-udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/r8a66597-udc.c +1 -1
@@ -1250,7 +1250,7 @@ static void set_feature(struct r8a66597do { tmp =r8a66597_read (r8a66597,INTSTS0 ) &CTSQ ;udelay (1 ); - }while (tmp !=CS_IDST || timeout-- >0 ); + }while (tmp !=CS_IDST && timeout-- >0 );if (tmp ==CS_IDST ) r8a66597_bset(r8a66597,
Greg Kroah-Hartman
maintainerPATCH 3/103 mm: fix uninitialized use in overcommit_policy_handler
In reply to Greg Kroah-HartmanFrom: Chen Jun <[email protected]>
commit bcbda81020c3ee77e2c098cadf3e84f99ca3de17 upstream.
We get an unexpected value of /proc/sys/vm/overcommit_memory after running the following program:
int main()
{
int fd = open("/proc/sys/vm/overcommit_memory", O_RDWR);
write(fd, "1", 1);
write(fd, "2", 1);
close(fd);
}write(fd, "2", 1) will pass *ppos = 1 to proc_dointvec_minmax. proc_dointvec_minmax will return 0 without setting new_policy.
t.data = &new_policy;
ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos)
-->do_proc_dointvec
-->__do_proc_dointvec
if (write) {
if (proc_first_pos_non_zero_ignore(ppos, table))
goto out;
sysctl_overcommit_memory = new_policy;so sysctl_overcommit_memory will be set to an uninitialized value.
Check whether new_policy has been changed by proc_dointvec_minmax.
--- mm/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/util.c +2 -2
@@ -756,7 +756,7 @@ int overcommit_policy_handler(struct ctl size_t *lenp, loff_t *ppos) { struct ctl_table t; -int new_policy; +int new_policy =-1 ;int ret;/*
@@ -774,7 +774,7 @@ int overcommit_policy_handler(struct ctl t = *table; t.data = &new_policy; ret =proc_dointvec_minmax (&t, write, buffer, lenp, ppos); -if (ret) +if (ret || new_policy ==-1 )return ret;mm_compute_batch (new_policy);
Greg Kroah-Hartman
maintainerPATCH 5/103 usb: dwc2: gadget: Fix ISOC flow for BDMA and Slave
In reply to Greg Kroah-HartmanFrom: Minas Harutyunyan <[email protected]>
commit 91bb163e1e4f88092f50dfaa5a816b658753e4b2 upstream.
According USB spec each ISOC transaction should be performed in a designated for that transaction interval. On bus errors or delays in operating system scheduling of client software can result in no packet being transferred for a (micro)frame. An error indication should be returned as status to the client software in such a case.
Current implementation in case of missed/dropped interval send same data in next possible interval instead of reporting missed isoc.
This fix complete requests with -ENODATA if interval elapsed.
HSOTG core in BDMA and Slave modes haven't HW support for (micro)frames tracking, this is why SW should care about tracking of (micro)frames. Because of that method and consider operating system scheduling delays, added few additional checking's of elapsed target (micro)frame:
1. Immediately before enabling EP to start transfer.
2. With any transfer completion interrupt.
3. With incomplete isoc in/out interrupt.
4. With EP disabled interrupt because of incomplete transfer.
5. With OUT token received while EP disabled interrupt (for OUT transfers).
6. With NAK replied to IN token interrupt (for IN transfers).
As part of ISOC flow, additionally fixed 'current' and 'target' frame calculation functions. In HS mode SOF limits provided by DSTS register is 0x3fff, but in non HS mode this limit is 0x7ff.
Tested by internal tool which also using for dwc3 testing.
--- drivers/usb/dwc2/gadget.c | 189 +++++++++++++++++++++++++--------------------- 1 file changed, 106 insertions(+), 83 deletions(-)
drivers/usb/dwc2/gadget.c +106 -83
@@ -115,10 +115,16 @@ static inline bool using_desc_dma(struct*/ static inline void dwc2_gadget_incr_frame_num (struct dwc2_hsotg_ep *hs_ep) { +struct dwc2_hsotg *hsotg = hs_ep->parent; +u16 limit =DSTS_SOFFN_LIMIT ; + +if (hsotg->gadget.speed !=USB_SPEED_HIGH ) + limit >>=3 ; + hs_ep->target_frame += hs_ep->interval; -if (hs_ep->target_frame >DSTS_SOFFN_LIMIT ) { +if (hs_ep->target_frame > limit) { hs_ep->frame_overrun = true; - hs_ep->target_frame &=DSTS_SOFFN_LIMIT ; + hs_ep->target_frame &= limit; }else { hs_ep->frame_overrun = false; }
@@ -136,10 +142,16 @@ static inline void dwc2_gadget_incr_fram*/ static inline void dwc2_gadget_dec_frame_num_by_one (struct dwc2_hsotg_ep *hs_ep) { +struct dwc2_hsotg *hsotg = hs_ep->parent; +u16 limit =DSTS_SOFFN_LIMIT ; + +if (hsotg->gadget.speed !=USB_SPEED_HIGH ) + limit >>=3 ; +if (hs_ep->target_frame) hs_ep->target_frame -=1 ;else - hs_ep->target_frame =DSTS_SOFFN_LIMIT ; + hs_ep->target_frame = limit; }/**
@@ -1018,6 +1030,12 @@ static void dwc2_gadget_start_isoc_ddma(dwc2_writel (hsotg, ctrl, depctl); } +static bool dwc2_gadget_target_frame_elapsed (struct dwc2_hsotg_ep *hs_ep); +static void dwc2_hsotg_complete_request (struct dwc2_hsotg *hsotg, +struct dwc2_hsotg_ep *hs_ep, +struct dwc2_hsotg_req *hs_req, +int result); +/** * dwc2_hsotg_start_req - start a USB request from an endpoint's queue * @hsotg: The controller state.
@@ -1170,14 +1188,19 @@ static void dwc2_hsotg_start_req(struct } } -if (hs_ep->isochronous && hs_ep->interval ==1 ) { - hs_ep->target_frame =dwc2_hsotg_read_frameno (hsotg); -dwc2_gadget_incr_frame_num (hs_ep); - -if (hs_ep->target_frame &0x1 ) - ctrl |=DXEPCTL_SETODDFR ; -else - ctrl |=DXEPCTL_SETEVENFR ; +if (hs_ep->isochronous) { +if (!dwc2_gadget_target_frame_elapsed (hs_ep)) { +if (hs_ep->interval ==1 ) { +if (hs_ep->target_frame &0x1 ) + ctrl |=DXEPCTL_SETODDFR ; +else + ctrl |=DXEPCTL_SETEVENFR ; + } + ctrl |=DXEPCTL_CNAK ; + }else { +dwc2_hsotg_complete_request (hsotg, hs_ep, hs_req, -ENODATA ); +return ; + } } ctrl |=DXEPCTL_EPENA ;/* ensure ep enabled */
@@ -1325,12 +1348,16 @@ static bool dwc2_gadget_target_frame_elau32 target_frame = hs_ep->target_frame;u32 current_frame = hsotg->frame_number;bool frame_overrun = hs_ep->frame_overrun; +u16 limit =DSTS_SOFFN_LIMIT ; + +if (hsotg->gadget.speed !=USB_SPEED_HIGH ) + limit >>=3 ;if (!frame_overrun && current_frame >= target_frame)return true;if (frame_overrun && current_frame >= target_frame && - ((current_frame - target_frame) <DSTS_SOFFN_LIMIT /2 )) + ((current_frame - target_frame) < limit /2 ))return true;return false;
@@ -1713,11 +1740,9 @@ static struct dwc2_hsotg_req *get_ep_hea*/ static void dwc2_gadget_start_next_request (struct dwc2_hsotg_ep *hs_ep) { -u32 mask;struct dwc2_hsotg *hsotg = hs_ep->parent;int dir_in = hs_ep->dir_in;struct dwc2_hsotg_req *hs_req; -u32 epmsk_reg = dir_in ?DIEPMSK :DOEPMSK ;if (!list_empty (&hs_ep->queue)) { hs_req =get_ep_head (hs_ep);
@@ -1733,9 +1758,6 @@ static void dwc2_gadget_start_next_reque }else {dev_dbg (hsotg->dev,"%s: No more ISOC-OUT requests\n" , __func__); - mask =dwc2_readl (hsotg, epmsk_reg); - mask |=DOEPMSK_OUTTKNEPDISMSK ; -dwc2_writel (hsotg, mask, epmsk_reg); } }
@@ -2305,19 +2327,6 @@ static void dwc2_hsotg_ep0_zlp(struct dwdwc2_hsotg_program_zlp (hsotg, hsotg->eps_out[0 ]); } -static void dwc2_hsotg_change_ep_iso_parity (struct dwc2_hsotg *hsotg, -u32 epctl_reg) -{ -u32 ctrl; - - ctrl =dwc2_readl (hsotg, epctl_reg); -if (ctrl &DXEPCTL_EOFRNUM ) - ctrl |=DXEPCTL_SETEVENFR ; -else - ctrl |=DXEPCTL_SETODDFR ; -dwc2_writel (hsotg, ctrl, epctl_reg); -} -/* * dwc2_gadget_get_xfersize_ddma - get transferred bytes amount from desc * @hs_ep - The endpoint on which transfer went
@@ -2438,20 +2447,11 @@ static void dwc2_hsotg_handle_outdone(stdwc2_hsotg_ep0_zlp (hsotg, true); } -/* -* Slave mode OUT transfers do not go through XferComplete so -* adjust the ISOC parity here. -*/ -if (!using_dma (hsotg)) { -if (hs_ep->isochronous && hs_ep->interval ==1 ) -dwc2_hsotg_change_ep_iso_parity (hsotg,DOEPCTL (epnum)); -else if (hs_ep->isochronous && hs_ep->interval >1 ) -dwc2_gadget_incr_frame_num (hs_ep); - } -/* Set actual frame number for completed transfers */ -if (!using_desc_dma (hsotg) && hs_ep->isochronous) - req->frame_number = hsotg->frame_number; +if (!using_desc_dma (hsotg) && hs_ep->isochronous) { + req->frame_number = hs_ep->target_frame; +dwc2_gadget_incr_frame_num (hs_ep); + }dwc2_hsotg_complete_request (hsotg, hs_ep, hs_req, result); }
@@ -2765,6 +2765,12 @@ static void dwc2_hsotg_complete_in(strucreturn ; } +/* Set actual frame number for completed transfers */ +if (!using_desc_dma (hsotg) && hs_ep->isochronous) { + hs_req->req.frame_number = hs_ep->target_frame; +dwc2_gadget_incr_frame_num (hs_ep); + } +dwc2_hsotg_complete_request (hsotg, hs_ep, hs_req,0 ); }
@@ -2825,23 +2831,18 @@ static void dwc2_gadget_handle_ep_disabldwc2_hsotg_txfifo_flush (hsotg, hs_ep->fifo_index); -if (hs_ep->isochronous) { -dwc2_hsotg_complete_in (hsotg, hs_ep); -return ; - } -if ((epctl &DXEPCTL_STALL ) && (epctl &DXEPCTL_EPTYPE_BULK )) {int dctl =dwc2_readl (hsotg,DCTL ); dctl |=DCTL_CGNPINNAK ;dwc2_writel (hsotg, dctl,DCTL ); } -return ; - } + }else { -if (dctl &DCTL_GOUTNAKSTS ) { - dctl |=DCTL_CGOUTNAK ; -dwc2_writel (hsotg, dctl,DCTL ); +if (dctl &DCTL_GOUTNAKSTS ) { + dctl |=DCTL_CGOUTNAK ; +dwc2_writel (hsotg, dctl,DCTL ); + } }if (!hs_ep->isochronous)
@@ -2862,8 +2863,6 @@ static void dwc2_gadget_handle_ep_disabl/* Update current frame number value. */ hsotg->frame_number =dwc2_hsotg_read_frameno (hsotg); }while (dwc2_gadget_target_frame_elapsed (hs_ep)); - -dwc2_gadget_start_next_request (hs_ep); }/**
@@ -2880,8 +2879,8 @@ static void dwc2_gadget_handle_ep_disablstatic void dwc2_gadget_handle_out_token_ep_disabled (struct dwc2_hsotg_ep *ep) {struct dwc2_hsotg *hsotg = ep->parent; +struct dwc2_hsotg_req *hs_req;int dir_in = ep->dir_in; -u32 doepmsk;if (dir_in || !ep->isochronous)return ;
@@ -2895,28 +2894,39 @@ static void dwc2_gadget_handle_out_tokenreturn ; } -if (ep->interval >1 && - ep->target_frame ==TARGET_FRAME_INITIAL ) { +if (ep->target_frame ==TARGET_FRAME_INITIAL ) {u32 ctrl; ep->target_frame = hsotg->frame_number; -dwc2_gadget_incr_frame_num (ep); +if (ep->interval >1 ) { + ctrl =dwc2_readl (hsotg,DOEPCTL (ep->index)); +if (ep->target_frame &0x1 ) + ctrl |=DXEPCTL_SETODDFR ; +else + ctrl |=DXEPCTL_SETEVENFR ; - ctrl =dwc2_readl (hsotg,DOEPCTL (ep->index)); -if (ep->target_frame &0x1 ) - ctrl |=DXEPCTL_SETODDFR ; -else - ctrl |=DXEPCTL_SETEVENFR ; +dwc2_writel (hsotg, ctrl,DOEPCTL (ep->index)); + } + } + +while (dwc2_gadget_target_frame_elapsed (ep)) { + hs_req =get_ep_head (ep); +if (hs_req) +dwc2_hsotg_complete_request (hsotg, ep, hs_req, -ENODATA ); -dwc2_writel (hsotg, ctrl,DOEPCTL (ep->index)); +dwc2_gadget_incr_frame_num (ep); +/* Update current frame number value. */ + hsotg->frame_number =dwc2_hsotg_read_frameno (hsotg); } -dwc2_gadget_start_next_request (ep); - doepmsk =dwc2_readl (hsotg,DOEPMSK ); - doepmsk &= ~DOEPMSK_OUTTKNEPDISMSK ; -dwc2_writel (hsotg, doepmsk,DOEPMSK ); +if (!ep->req) +dwc2_gadget_start_next_request (ep); + } +static void dwc2_hsotg_ep_stop_xfr (struct dwc2_hsotg *hsotg, +struct dwc2_hsotg_ep *hs_ep); +/** * dwc2_gadget_handle_nak - handle NAK interrupt * @hs_ep: The endpoint on which interrupt is asserted.
@@ -2934,7 +2944,9 @@ static void dwc2_gadget_handle_out_tokenstatic void dwc2_gadget_handle_nak (struct dwc2_hsotg_ep *hs_ep) {struct dwc2_hsotg *hsotg = hs_ep->parent; +struct dwc2_hsotg_req *hs_req;int dir_in = hs_ep->dir_in; +u32 ctrl;if (!dir_in || !hs_ep->isochronous)return ;
@@ -2976,13 +2988,29 @@ static void dwc2_gadget_handle_nak(strucdwc2_writel (hsotg, ctrl,DIEPCTL (hs_ep->index)); } - -dwc2_hsotg_complete_request (hsotg, hs_ep, -get_ep_head (hs_ep),0 ); } -if (!using_desc_dma (hsotg)) +if (using_desc_dma (hsotg)) +return ; + + ctrl =dwc2_readl (hsotg,DIEPCTL (hs_ep->index)); +if (ctrl &DXEPCTL_EPENA ) +dwc2_hsotg_ep_stop_xfr (hsotg, hs_ep); +else +dwc2_hsotg_txfifo_flush (hsotg, hs_ep->fifo_index); + +while (dwc2_gadget_target_frame_elapsed (hs_ep)) { + hs_req =get_ep_head (hs_ep); +if (hs_req) +dwc2_hsotg_complete_request (hsotg, hs_ep, hs_req, -ENODATA ); +dwc2_gadget_incr_frame_num (hs_ep); +/* Update current frame number value. */ + hsotg->frame_number =dwc2_hsotg_read_frameno (hsotg); + } + +if (!hs_ep->req) +dwc2_gadget_start_next_request (hs_ep); }/**
@@ -3047,12 +3075,8 @@ static void dwc2_hsotg_epint(struct dwc2* need to look at completing IN requests here * if operating slave mode */ -if (hs_ep->isochronous && hs_ep->interval >1 ) -dwc2_gadget_incr_frame_num (hs_ep); - -dwc2_hsotg_complete_in (hsotg, hs_ep); -if (ints &DXEPINT_NAKINTRPT ) - ints &= ~DXEPINT_NAKINTRPT ; +if (!hs_ep->isochronous || !(ints &DXEPINT_NAKINTRPT )) +dwc2_hsotg_complete_in (hsotg, hs_ep);if (idx ==0 && !hs_ep->req)dwc2_hsotg_enqueue_setup (hsotg);
@@ -3061,10 +3085,8 @@ static void dwc2_hsotg_epint(struct dwc2* We're using DMA, we need to fire an OutDone here * as we ignore the RXFIFO. */ -if (hs_ep->isochronous && hs_ep->interval >1 ) -dwc2_gadget_incr_frame_num (hs_ep); - -dwc2_hsotg_handle_outdone (hsotg, idx); +if (!hs_ep->isochronous || !(ints &DXEPINT_OUTTKNEPDIS )) +dwc2_hsotg_handle_outdone (hsotg, idx); } }
@@ -4083,6 +4105,7 @@ static int dwc2_hsotg_ep_enable(struct u mask |=DIEPMSK_NAKMSK ;dwc2_writel (hsotg, mask,DIEPMSK ); }else { + epctrl |=DXEPCTL_SNAK ; mask =dwc2_readl (hsotg,DOEPMSK ); mask |=DOEPMSK_OUTTKNEPDISMSK ;dwc2_writel (hsotg, mask,DOEPMSK );
Greg Kroah-Hartman
maintainerPATCH 6/103 usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA
In reply to Greg Kroah-HartmanFrom: Minas Harutyunyan <[email protected]>
commit dbe2518b2d8eabffa74dbf7d9fdd7dacddab7fc0 upstream.
When last descriptor in a descriptor list completed with XferComplete interrupt, core switching to handle next descriptor and assert BNA interrupt. Both these interrupts are set while dwc2_hsotg_epint() handler called. Each interrupt should be handled separately: first XferComplete interrupt then BNA interrupt, otherwise last completed transfer will not be giveback to function driver as completed request.
--- drivers/usb/dwc2/gadget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/dwc2/gadget.c +1 -3
@@ -3066,9 +3066,7 @@ static void dwc2_hsotg_epint(struct dwc2/* In DDMA handle isochronous requests separately */ if (using_desc_dma (hsotg) && hs_ep->isochronous) { -/* XferCompl set along with BNA */ -if (!(ints &DXEPINT_BNAINTR )) -dwc2_gadget_complete_isoc_request_ddma (hs_ep); +dwc2_gadget_complete_isoc_request_ddma (hs_ep); }else if (dir_in) {/* * We get OutDone from the FIFO, so we only
Greg Kroah-Hartman
maintainerPATCH 7/103 usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
commit 517c7bf99bad3d6b9360558414aae634b7472d80 upstream.
This is writing to the first 1 - 3 bytes of "val" and then writing all four bytes to musb_writel(). The last byte is always going to be garbage. Zero out the last bytes instead.
--- drivers/usb/musb/tusb6010.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/musb/tusb6010.c +1 -0
@@ -190,6 +190,7 @@ tusb_fifo_write_unaligned(void __iomem * }if (len >0 ) {/* Write the rest 1 - 3 bytes to FIFO */ + val =0 ;memcpy (&val, buf, len);musb_writel (fifo,0 , val); }
Greg Kroah-Hartman
maintainerPATCH 8/103 cifs: fix incorrect check for null pointer in header_assemble
In reply to Greg Kroah-HartmanFrom: Steve French <[email protected]>
commit 9ed38fd4a15417cac83967360cf20b853bfab9b6 upstream.
Although very unlikely that the tlink pointer would be null in this case, get_next_mid function can in theory return null (but not an error) so need to check for null (not for IS_ERR, which can not be returned here).
Address warning:
fs/smbfs_client/connect.c:2392 cifs_match_super()
warn: 'tlink' isn't an ERR_PTR
Pointed out by Dan Carpenter via smatch code analysis tool
--- fs/cifs/connect.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/cifs/connect.c +3 -2
@@ -3504,9 +3504,10 @@ cifs_match_super(struct super_block *sb,spin_lock (&cifs_tcp_ses_lock); cifs_sb =CIFS_SB (sb); tlink =cifs_get_tlink (cifs_sb_master_tlink (cifs_sb)); -if (IS_ERR (tlink)) { +if (tlink ==NULL ) { +/* can not match superblock if tlink were ever null */ spin_unlock (&cifs_tcp_ses_lock); -return rc; +return 0 ; } tcon =tlink_tcon (tlink); ses = tcon->ses;
Greg Kroah-Hartman
maintainerPATCH 9/103 xen/x86: fix PV trap handling on secondary processors
In reply to Greg Kroah-HartmanFrom: Jan Beulich <[email protected]>
commit 0594c58161b6e0f3da8efa9c6e3d4ba52b652717 upstream.
The initial observation was that in PV mode under Xen 32-bit user space didn't work anymore. Attempts of system calls ended in #GP(0x402). All of the sudden the vector 0x80 handler was not in place anymore. As it turns out up to 5.13 redundant initialization did occur: Once from cpu_initialize_context() (through its VCPUOP_initialise hypercall) and a 2nd time while each CPU was brought fully up. This 2nd initialization is now gone, uncovering that the 1st one was flawed: Unlike for the set_trap_table hypercall, a full virtual IDT needs to be specified here; the "vector" fields of the individual entries are of no interest. With many (kernel) IDT entries still(?) (i.e. at that point at least) empty, the syscall vector 0x80 ended up in slot 0x20 of the virtual IDT, thus becoming the domain's handler for vector 0x20.
Make xen_convert_trap_info() fit for either purpose, leveraging the fact that on the xen_copy_trap_info() path the table starts out zero-filled. This includes moving out the writing of the sentinel, which would also have lead to a buffer overrun in the xen_copy_trap_info() case if all (kernel) IDT entries were populated. Convert the writing of the sentinel to clearing of the entire table entry rather than just the address field.
(I didn't bother trying to identify the commit which uncovered the issue in 5.14; the commit named below is the one which actually introduced the bad code.)
--- arch/x86/xen/enlighten_pv.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
arch/x86/xen/enlighten_pv.c +9 -6
@@ -736,8 +736,8 @@ static void xen_write_idt_entry(gate_despreempt_enable (); } -static void xen_convert_trap_info (const struct desc_ptr *desc, -struct trap_info *traps) +static unsigned xen_convert_trap_info (const struct desc_ptr *desc, +struct trap_info *traps,bool full) {unsigned in, out, count;
@@ -747,17 +747,18 @@ static void xen_convert_trap_info(constfor (in = out =0 ; in < count; in++) {gate_desc *entry = (gate_desc *)(desc->address) + in; -if (cvt_gate_to_trap (in, entry, &traps[out])) +if (cvt_gate_to_trap (in, entry, &traps[out]) || full) out++; } - traps[out].address =0 ; + +return out; }void xen_copy_trap_info (struct trap_info *traps) {const struct desc_ptr *desc =this_cpu_ptr (&idt_desc); -xen_convert_trap_info (desc, traps); +xen_convert_trap_info (desc, traps, true); }/* Load a new IDT into Xen. In principle this can be per-CPU, so we
@@ -767,6 +768,7 @@ static void xen_load_idt(const struct de {static DEFINE_SPINLOCK (lock);static struct trap_info traps[257 ]; +unsigned out;trace_xen_cpu_load_idt (desc);
@@ -774,7 +776,8 @@ static void xen_load_idt(const struct dememcpy (this_cpu_ptr (&idt_desc), desc,sizeof (idt_desc)); -xen_convert_trap_info (desc, traps); + out =xen_convert_trap_info (desc, traps, false); +memset (&traps[out],0 ,sizeof (traps[0 ]));xen_mc_flush ();if (HYPERVISOR_set_trap_table (traps))
Greg Kroah-Hartman
maintainercover 5.10.70-rc1 review
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.10.70-rc1
Linus Torvalds <[email protected]>
qnx4: work around gcc false positive warning bug
Juergen Gross <[email protected]>
xen/balloon: fix balloon kthread freezing
Johan Hovold <[email protected]>
USB: serial: cp210x: fix dropped characters with CP2102
Antoine Tenart <[email protected]>
thermal/drivers/int340x: Do not set a wrong tcc offset on resume
Borislav Petkov <[email protected]>
EDAC/dmc520: Assign the proper type to dimm->edac_mode
Sai Krishna Potthuri <[email protected]>
EDAC/synopsys: Fix wrong value type assignment for edac_mode
Linus Torvalds <[email protected]>
spi: Fix tegra20 build with CONFIG_PM=n
Guenter Roeck <[email protected]>
net: 6pack: Fix tx timeout and slot time
Guenter Roeck <[email protected]>
alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile
Dan Li <[email protected]>
arm64: Mark __stack_chk_guard as __ro_after_init
Helge Deller <[email protected]>
parisc: Use absolute_pointer() to define PAGE0
Linus Torvalds <[email protected]>
qnx4: avoid stringop-overread errors
Linus Torvalds <[email protected]>
sparc: avoid stringop-overread errors
Guenter Roeck <[email protected]>
net: i825xx: Use absolute_pointer for memcpy from fixed memory location
Guenter Roeck <[email protected]>
compiler.h: Introduce absolute_pointer macro
Li Jinlin <[email protected]>
blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd
Lihong Kou <[email protected]>
block: flush the integrity workqueue in blk_integrity_unregister
Christoph Hellwig <[email protected]>
block: check if a profile is actually registered in blk_integrity_unregister
Simon Ser <[email protected]>
amd/display: downgrade validation failure log level
Andreas Larsson <[email protected]>
sparc32: page align size in arch_dma_alloc
Ruozhu Li <[email protected]>
nvme-rdma: destroy cm id before destroy qp to avoid use after free
Anton Eidelman <[email protected]>
nvme-multipath: fix ANA state updates when a namespace is not present
Juergen Gross <[email protected]>
xen/balloon: use a kernel thread instead a workqueue
Bixuan Cui <[email protected]>
bpf: Add oversize check before call kvcalloc()
Doug Smythies <[email protected]>
cpufreq: intel_pstate: Override parameters if HWP forced by BIOS
zhang kai <[email protected]>
ipv6: delay fib6_sernum increase in fib6_add
Guenter Roeck <[email protected]>
m68k: Double cast io functions to unsigned long
Ming Lei <[email protected]>
blk-mq: avoid to iterate over stale request
Jesper Nilsson <[email protected]>
net: stmmac: allow CSR clock of 300MHz
Tong Zhang <[email protected]>
net: macb: fix use after free on rmmod
Nathan Rossi <[email protected]>
net: phylink: Update SFP selected interface on advertising changes
Zhihao Cheng <[email protected]>
blktrace: Fix uaf in blk_trace access after removing by sysfs
Jens Axboe <[email protected]>
io_uring: put provided buffer meta data under memcg accounting
Kees Cook <[email protected]>
x86/asm: Fix SETZ size enqcmds() build failure
Dave Jiang <[email protected]>
x86/asm: Add a missing __iomem annotation in enqcmds()
Christoph Hellwig <[email protected]>
md: fix a lock order reversal in md_alloc
Kaige Fu <[email protected]>
irqchip/gic-v3-its: Fix potential VPE leak on error
Randy Dunlap <[email protected]>
irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build
Dan Carpenter <[email protected]>
scsi: lpfc: Use correct scnprintf() limit
Dmitry Bogdanov <[email protected]>
scsi: qla2xxx: Restore initiator in dual mode
Dan Carpenter <[email protected]>
cifs: fix a sign extension bug
Dan Carpenter <[email protected]>
thermal/core: Potential buffer overflow in thermal_build_list_of_policies()
Christoph Hellwig <[email protected]>
nvme: keep ctrl->namespaces ordered
Sami Tolvanen <[email protected]>
treewide: Change list_sort to use const pointers
Sagi Grimberg <[email protected]>
nvme-tcp: fix incorrect h2cdata pdu offset accounting
Jiapeng Chong <[email protected]>
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
Tom Rix <[email protected]>
fpga: machxo2-spi: Return an error on failure
Randy Dunlap <[email protected]>
tty: synclink_gt: rename a conflicting function name
Jiri Slaby <[email protected]>
tty: synclink_gt, drop unneeded forward declarations
Maurizio Lombardi <[email protected]>
scsi: target: Fix the pgr/alua_support_store functions
Baokun Li <[email protected]>
scsi: iscsi: Adjust iface sysfs attr detection
Sudarsana Reddy Kalluru <[email protected]>
atlantic: Fix issue in the pm resume flow.
Aya Levin <[email protected]>
net/mlx4_en: Don't allow aRFS for encapsulated packets
Shai Malin <[email protected]>
qed: rdma - don't wait for resources under hw error recovery flow
Kunihiko Hayashi <[email protected]>
gpio: uniphier: Fix void functions to remove return value
Alexandra Winter <[email protected]>
s390/qeth: fix deadlock during failing recovery
Julian Wiedmann <[email protected]>
s390/qeth: fix NULL deref in qeth_clear_working_pool_list()
Cristian Marussi <[email protected]>
kselftest/arm64: signal: Skip tests if required features are missing
Mark Brown <[email protected]>
kselftest/arm64: signal: Add SVE to the set of features we can check for
Vladimir Oltean <[email protected]>
net: dsa: realtek: register the MDIO bus under devres
Vladimir Oltean <[email protected]>
net: dsa: don't allocate the slave_mii_bus using devres
Karsten Graul <[email protected]>
net/smc: fix 'workqueue leaked lock' in smc_conn_abort_work
Karsten Graul <[email protected]>
net/smc: add missing error check in smc_clc_prfx_set()
Yufeng Mo <[email protected]>
net: hns3: check queue id range before using
Jian Shen <[email protected]>
net: hns3: fix change RSS 'hfunc' ineffective issue
Michael Chan <[email protected]>
bnxt_en: Fix TX timeout when TX ring size is set to the smallest
Claudiu Manoil <[email protected]>
enetc: Fix uninitialized struct dim_sample field usage
Claudiu Manoil <[email protected]>
enetc: Fix illegal access when reading affinity_hint
Andy Shevchenko <[email protected]>
platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR()
David Howells <[email protected]>
afs: Fix updating of i_blocks on file/dir extension
David Howells <[email protected]>
afs: Fix incorrect triggering of sillyrename on 3rd-party invalidation
Ian Abbott <[email protected]>
comedi: Fix memory leak in compat_insnlist()
Johan Hovold <[email protected]>
net: hso: fix muxed tty registration
Lijo Lazar <[email protected]>
drm/amd/pm: Update intermediate power state for SI
Naohiro Aota <[email protected]>
scsi: sd_zbc: Ensure buffer size is aligned to SECTOR_SIZE
Pali Rohár <[email protected]>
serial: mvebu-uart: fix driver's tx_empty callback
Nishanth Menon <[email protected]>
serial: 8250: 8250_omap: Fix RX_LVL register offset
Kishon Vijay Abraham I <[email protected]>
xhci: Set HCD flag to defer primary roothub registration
Qu Wenruo <[email protected]>
btrfs: prevent __btrfs_dump_space_info() to underflow its free space
Gao Xiang <[email protected]>
erofs: fix up erofs_lookup tracepoint
Dan Carpenter <[email protected]>
mcb: fix error handling in mcb_alloc_bus()
Slark Xiao <[email protected]>
USB: serial: option: add device id for Foxconn T99W265
Krzysztof Kozlowski <[email protected]>
USB: serial: option: remove duplicate USB device ID
Carlo Lobrano <[email protected]>
USB: serial: option: add Telit LN920 compositions
Krzysztof Kozlowski <[email protected]>
USB: serial: mos7840: remove duplicated 0xac24 device ID
Kishon Vijay Abraham I <[email protected]>
usb: core: hcd: Add support for deferring roothub registration
Li Jun <[email protected]>
usb: dwc3: core: balance phy init and exit
Julian Sikorski <[email protected]>
Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
Johan Hovold <[email protected]>
staging: greybus: uart: fix tty use after free
Todd Kjos <[email protected]>
binder: make sure fd closes complete
Rafał Miłecki <[email protected]>
Revert "USB: bcma: Add a check for devm_gpiod_get"
Johan Hovold <[email protected]>
USB: cdc-acm: fix minor-number release
Uwe Brandt <[email protected]>
USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter
Ondrej Zary <[email protected]>
usb-storage: Add quirk for ScanLogic SL11R-IDE older than 2.6c
Jan Beulich <[email protected]>
xen/x86: fix PV trap handling on secondary processors
Steve French <[email protected]>
cifs: fix incorrect check for null pointer in header_assemble
Dan Carpenter <[email protected]>
usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
Minas Harutyunyan <[email protected]>
usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA
Minas Harutyunyan <[email protected]>
usb: dwc2: gadget: Fix ISOC flow for BDMA and Slave
Dan Carpenter <[email protected]>
usb: gadget: r8a66597: fix a loop in set_feature()
Chen Jun <[email protected]>
mm: fix uninitialized use in overcommit_policy_handler
Wengang Wang <[email protected]>
ocfs2: drop acl cache for directories too
Pali Rohár <[email protected]>
PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response
-------------
Diffstat:
Makefile | 4 +- arch/alpha/include/asm/io.h | 6 +- arch/arm64/kernel/process.c | 2 +- arch/arm64/kvm/vgic/vgic-its.c | 8 +- arch/arm64/kvm/vgic/vgic.c | 3 +- arch/m68k/include/asm/raw_io.h | 20 +-- arch/parisc/include/asm/page.h | 2 +- arch/s390/include/asm/ccwgroup.h | 2 +- arch/sparc/kernel/ioport.c | 4 +- arch/sparc/kernel/mdesc.c | 3 +- arch/x86/include/asm/special_insns.h | 4 +- arch/x86/xen/enlighten_pv.c | 15 +- block/blk-cgroup.c | 8 + block/blk-integrity.c | 9 +- block/blk-mq-sched.c | 3 +- block/blk-mq-tag.c | 2 +- block/blk-mq.c | 3 +- drivers/acpi/nfit/core.c | 3 +- drivers/acpi/numa/hmat.c | 3 +- drivers/android/binder.c | 23 ++- drivers/clk/keystone/sci-clk.c | 4 +- drivers/cpufreq/intel_pstate.c | 22 ++- drivers/edac/dmc520_edac.c | 2 +- drivers/edac/synopsys_edac.c | 2 +- drivers/fpga/machxo2-spi.c | 6 +- drivers/gpio/gpio-uniphier.c | 4 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/amd/pm/powerplay/si_dpm.c | 2 + drivers/gpu/drm/drm_modes.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_user.c | 3 +- drivers/gpu/drm/i915/gvt/debugfs.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 3 +- drivers/gpu/drm/radeon/radeon_cs.c | 4 +- .../infiniband/hw/usnic/usnic_uiom_interval_tree.c | 3 +- drivers/interconnect/qcom/bcm-voter.c | 2 +- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-gic-v3-its.c | 2 +- drivers/mcb/mcb-core.c | 12 +- drivers/md/md.c | 5 - drivers/md/raid5.c | 3 +- drivers/misc/sram.c | 4 +- drivers/net/dsa/realtek-smi-core.c | 2 +- .../net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 + drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- drivers/net/ethernet/freescale/enetc/enetc.c | 7 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 45 +++-- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 8 + .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 52 ++++-- drivers/net/ethernet/i825xx/82596.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 + drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 8 + drivers/net/ethernet/qlogic/qed/qed_roce.c | 8 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- drivers/net/hamradio/6pack.c | 4 +- drivers/net/phy/phylink.c | 30 +++- drivers/net/usb/hso.c | 12 +- drivers/nvme/host/core.c | 32 ++-- drivers/nvme/host/multipath.c | 7 +- drivers/nvme/host/rdma.c | 16 +- drivers/nvme/host/tcp.c | 13 +- drivers/pci/controller/cadence/pcie-cadence-host.c | 3 +- drivers/pci/controller/pci-aardvark.c | 2 +- drivers/platform/x86/intel_punit_ipc.c | 3 +- drivers/s390/cio/ccwgroup.c | 10 +- drivers/s390/net/qeth_core_main.c | 6 +- drivers/scsi/lpfc/lpfc_attr.c | 3 +- drivers/scsi/qla2xxx/qla_init.c | 3 +- drivers/scsi/scsi_transport_iscsi.c | 8 +- drivers/scsi/sd_zbc.c | 6 +- drivers/spi/spi-loopback-test.c | 3 +- drivers/spi/spi-tegra20-slink.c | 4 +- drivers/staging/comedi/comedi_fops.c | 1 + drivers/staging/greybus/uart.c | 62 +++---- drivers/target/target_core_configfs.c | 32 ++-- .../int340x_thermal/processor_thermal_device.c | 5 +- drivers/thermal/thermal_core.c | 7 +- drivers/tty/serial/8250/8250_omap.c | 2 +- drivers/tty/serial/mvebu-uart.c | 2 +- drivers/tty/synclink_gt.c | 101 +++-------- drivers/usb/class/cdc-acm.c | 7 +- drivers/usb/class/cdc-acm.h | 2 + drivers/usb/core/hcd.c | 29 +++- drivers/usb/dwc2/gadget.c | 193 ++++++++++++--------- drivers/usb/dwc3/core.c | 30 ++-- drivers/usb/gadget/udc/r8a66597-udc.c | 2 +- drivers/usb/host/bcma-hcd.c | 5 +- drivers/usb/host/xhci.c | 1 + drivers/usb/musb/tusb6010.c | 1 + drivers/usb/serial/cp210x.c | 47 +++++ drivers/usb/serial/mos7840.c | 2 - drivers/usb/serial/option.c | 11 +- drivers/usb/storage/unusual_devs.h | 9 +- drivers/usb/storage/unusual_uas.h | 2 +- drivers/xen/balloon.c | 62 +++++-- fs/afs/dir.c | 46 +---- fs/afs/dir_edit.c | 4 +- fs/afs/inode.c | 10 -- fs/afs/internal.h | 10 ++ fs/afs/write.c | 2 +- fs/btrfs/raid56.c | 3 +- fs/btrfs/space-info.c | 5 +- fs/btrfs/tree-log.c | 3 +- fs/btrfs/volumes.c | 3 +- fs/cifs/connect.c | 5 +- fs/cifs/file.c | 2 +- fs/ext4/fsmap.c | 4 +- fs/gfs2/glock.c | 3 +- fs/gfs2/log.c | 2 +- fs/gfs2/lops.c | 3 +- fs/io_uring.c | 2 +- fs/iomap/buffered-io.c | 3 +- fs/ocfs2/dlmglue.c | 3 +- fs/qnx4/dir.c | 69 ++++++-- fs/ubifs/gc.c | 7 +- fs/ubifs/replay.c | 4 +- fs/xfs/scrub/bitmap.c | 4 +- fs/xfs/xfs_bmap_item.c | 4 +- fs/xfs/xfs_buf.c | 6 +- fs/xfs/xfs_extent_busy.c | 4 +- fs/xfs/xfs_extent_busy.h | 3 +- fs/xfs/xfs_extfree_item.c | 4 +- fs/xfs/xfs_refcount_item.c | 4 +- fs/xfs/xfs_rmap_item.c | 4 +- include/linux/compiler.h | 2 + include/linux/list_sort.h | 7 +- include/linux/usb/hcd.h | 2 + include/trace/events/erofs.h | 6 +- kernel/bpf/verifier.c | 2 + kernel/trace/blktrace.c | 8 + lib/list_sort.c | 17 +- lib/test_list_sort.c | 3 +- mm/util.c | 4 +- net/dsa/dsa2.c | 12 +- net/ipv6/ip6_fib.c | 3 +- net/smc/smc_clc.c | 3 +- net/smc/smc_core.c | 2 + net/tipc/name_table.c | 4 +- .../testing/selftests/arm64/signal/test_signals.h | 2 + .../selftests/arm64/signal/test_signals_utils.c | 10 +- 142 files changed, 873 insertions(+), 597 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 21/103 USB: serial: option: remove duplicate USB device ID
From: Krzysztof Kozlowski <[email protected]>
commit 1ca200a8c6f079950a04ea3c3380fe8cf78e95a2 upstream.
The device ZTE 0x0094 is already on the list.
--- drivers/usb/serial/option.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/serial/option.c +0 -1
@@ -1658,7 +1658,6 @@ static const struct usb_device_id option { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0060, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0070, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0073, 0xff, 0xff, 0xff) }, - { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0094, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0130, 0xff, 0xff, 0xff), .driver_info = RSVD(1) }, { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0133, 0xff, 0xff, 0xff),
Greg Kroah-Hartman
maintainerPATCH 30/103 drm/amd/pm: Update intermediate power state for SI
In reply to Greg Kroah-HartmanFrom: Lijo Lazar <[email protected]>
commit ab39d3cef526ba09c4c6923b4cd7e6ec1c5d4faa upstream.
Update the current state as boot state during dpm initialization. During the subsequent initialization, set_power_state gets called to transition to the final power state. set_power_state refers to values from the current state and without current state populated, it could result in NULL pointer dereference.
For ex: on platforms where PCI speed change is supported through ACPI ATCS method, the link speed of current state needs to be queried before deciding on changing to final power state's link speed. The logic to query ATCS-support was broken on certain platforms. The issue became visible when broken ATCS-support logic got fixed with commit f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)").
--- drivers/gpu/drm/amd/pm/powerplay/si_dpm.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/pm/powerplay/si_dpm.c +2 -0
@@ -6870,6 +6870,8 @@ static int si_dpm_enable(struct amdgpu_dsi_enable_auto_throttle_source (adev,AMDGPU_DPM_AUTO_THROTTLE_SRC_THERMAL , true);si_thermal_start_thermal_controller (adev); +ni_update_current_ps (adev, boot_ps); +return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 31/103 net: hso: fix muxed tty registration
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit e8f69b16ee776da88589b5271e3f46020efc8f6c upstream.
If resource allocation and registration fail for a muxed tty device (e.g. if there are no more minor numbers) the driver should not try to deregister the never-registered (or already-deregistered) tty.
Fix up the error handling to avoid dereferencing a NULL pointer when attempting to remove the character device.
--- drivers/net/usb/hso.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/net/usb/hso.c +5 -7
@@ -2721,14 +2721,14 @@ struct hso_device *hso_create_mux_serial serial =kzalloc (sizeof (*serial),GFP_KERNEL );if (!serial) - goto exit; + goto err_free_dev; hso_dev->port_data.dev_serial = serial; serial->parent = hso_dev;if (hso_serial_common_create (serial,1 ,CTRL_URB_RX_SIZE ,CTRL_URB_TX_SIZE )) - goto exit; + goto err_free_serial; serial->tx_data_length--; serial->write_data = hso_mux_serial_write_data;
@@ -2744,11 +2744,9 @@ struct hso_device *hso_create_mux_serial/* done, return it */ return hso_dev; -exit: -if (serial) { -tty_unregister_device (tty_drv, serial->minor); -kfree (serial); - } +err_free_serial: +kfree (serial); +err_free_dev:kfree (hso_dev);return NULL ;
Greg Kroah-Hartman
maintainerPATCH 33/103 afs: Fix incorrect triggering of sillyrename on 3rd-party invalidation
In reply to Greg Kroah-HartmanFrom: David Howells <[email protected]>
[ Upstream commit 63d49d843ef5fffeea069e0ffdfbd2bf40ba01c6 ]
The AFS filesystem is currently triggering the silly-rename cleanup from afs_d_revalidate() when it sees that a dentry has been changed by a third party[1]. It should not be doing this as the cleanup includes deleting the silly-rename target file on iput.
Fix this by removing the places in the d_revalidate handling that validate anything other than the directory and the dirent. It probably should not be looking to validate the target inode of the dentry also.
This includes removing the point in afs_d_revalidate() where the inode that a dentry used to point to was marked as being deleted (AFS_VNODE_DELETED). We don't know it got deleted. It could have been renamed or it could have hard links remaining.
This was reproduced by cloning a git repo onto an afs volume on one machine, switching to another machine and doing "git status", then switching back to the first and doing "git status". The second status would show weird output due to ".git/index" getting deleted by the above mentioned mechanism.
A simpler way to do it is to do:
machine 1: touch a
machine 2: touch b; mv -f b a
machine 1: stat a
on an afs volume. The bug shows up as the stat failing with ENOENT and the file server log showing that machine 1 deleted "a".
--- fs/afs/dir.c | 46 +++++++--------------------------------------- 1 file changed, 7 insertions(+), 39 deletions(-)
fs/afs/dir.c +7 -39
@@ -997,9 +997,9 @@ static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry,*/ static int afs_d_revalidate_rcu (struct dentry *dentry) { -struct afs_vnode *dvnode, *vnode; +struct afs_vnode *dvnode;struct dentry *parent; -struct inode *dir, *inode; +struct inode *dir;long dir_version, de_version;_enter ("%p" , dentry);
@@ -1029,18 +1029,6 @@ static int afs_d_revalidate_rcu(struct dentry *dentry)return -ECHILD ; } -/* Check to see if the vnode referred to by the dentry still -* has a callback. -*/ -if (d_really_is_positive (dentry)) { - inode =d_inode_rcu (dentry); -if (inode) { - vnode =AFS_FS_I (inode); -if (!afs_check_validity (vnode)) -return -ECHILD ; - } - } -return 1 ;/* Still valid */ }
@@ -1076,17 +1064,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)if (IS_ERR (key)) key =NULL ; -if (d_really_is_positive (dentry)) { - inode =d_inode (dentry); -if (inode) { - vnode =AFS_FS_I (inode); -afs_validate (vnode, key); -if (test_bit (AFS_VNODE_DELETED , &vnode->flags)) - goto out_bad; - } - } - -/* lock down the parent dentry so we can peer at it */ +/* Hold the parent dentry so we can peer at it */ parent =dget_parent (dentry); dir =AFS_FS_I (d_inode (parent));
@@ -1095,7 +1073,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)if (test_bit (AFS_VNODE_DELETED , &dir->flags)) {_debug ("%pd: parent dir deleted" , dentry); - goto out_bad_parent; + goto not_found; }/* We only need to invalidate a dentry if the server's copy changed
@@ -1121,12 +1099,12 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)case 0 :/* the filename maps to something */ if (d_really_is_negative (dentry)) - goto out_bad_parent; + goto not_found; inode =d_inode (dentry);if (is_bad_inode (inode)) {printk ("kAFS: afs_d_revalidate: %pd2 has bad inode\n" , dentry); - goto out_bad_parent; + goto not_found; } vnode =AFS_FS_I (inode);
@@ -1148,9 +1126,6 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags) dentry, fid.unique, vnode->fid.unique, vnode->vfs_inode.i_generation); -write_seqlock (&vnode->cb_lock); -set_bit (AFS_VNODE_DELETED , &vnode->flags); -write_sequnlock (&vnode->cb_lock); goto not_found; } goto out_valid;
@@ -1165,7 +1140,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)default :_debug ("failed to iterate dir %pd: %d" , parent, ret); - goto out_bad_parent; + goto not_found; } out_valid:
@@ -1176,16 +1151,9 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)_leave (" = 1 [valid]" );return 1 ; -/* the dirent, if it exists, now points to a different vnode */ not_found: -spin_lock (&dentry->d_lock); - dentry->d_flags |=DCACHE_NFSFS_RENAMED ; -spin_unlock (&dentry->d_lock); - -out_bad_parent:_debug ("dropping dentry %pd2" , dentry);dput (parent); -out_bad:key_put (key);_leave (" = 0 [bad]" );
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 34/103 afs: Fix updating of i_blocks on file/dir extension
In reply to Greg Kroah-HartmanFrom: David Howells <[email protected]>
[ Upstream commit 9d37e1cab2a9d2cee2737973fa455e6f89eee46a ]
When an afs file or directory is modified locally such that the total file size is extended, i_blocks needs to be recalculated too.
Fix this by making afs_write_end() and afs_edit_dir_add() call afs_set_i_size() rather than setting inode->i_size directly as that also recalculates inode->i_blocks.
This can be tested by creating and writing into directories and files and then examining them with du. Without this change, directories show a 4 blocks (they start out at 2048 bytes) and files show 0 blocks; with this change, they should show a number of blocks proportional to the file size rounded up to 1024.
--- fs/afs/dir_edit.c | 4 ++-- fs/afs/inode.c | 10 ---------- fs/afs/internal.h | 10 ++++++++++ fs/afs/write.c | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-)
fs/afs/dir_edit.c +2 -2
@@ -264,7 +264,7 @@ void afs_edit_dir_add(struct afs_vnode *vnode,if (b == nr_blocks) {_debug ("init %u" , b);afs_edit_init_block (meta, block, b); -i_size_write (&vnode->vfs_inode, (b +1 ) *AFS_DIR_BLOCK_SIZE ); +afs_set_i_size (vnode, (b +1 ) *AFS_DIR_BLOCK_SIZE ); }/* Only lower dir pages have a counter in the header. */
@@ -297,7 +297,7 @@ void afs_edit_dir_add(struct afs_vnode *vnode, new_directory:afs_edit_init_block (meta, meta,0 ); i_size =AFS_DIR_BLOCK_SIZE ; -i_size_write (&vnode->vfs_inode, i_size); +afs_set_i_size (vnode, i_size); slot =AFS_DIR_RESV_BLOCKS0 ; page = page0; block = meta;
fs/afs/inode.c +0 -10
@@ -53,16 +53,6 @@ static noinline void dump_vnode(struct afs_vnode *vnode, struct afs_vnode *parendump_stack (); } -/* -* Set the file size and block count. Estimate the number of 512 bytes blocks -* used, rounded up to nearest 1K for consistency with other AFS clients. -*/ -static void afs_set_i_size (struct afs_vnode *vnode,u64 size) -{ -i_size_write (&vnode->vfs_inode, size); - vnode->vfs_inode.i_blocks = ((size +1023 ) >>10 ) <<1 ; -} -/* * Initialise an inode from the vnode status. */
fs/afs/internal.h +10 -0
@@ -1573,6 +1573,16 @@ static inline void afs_update_dentry_version(struct afs_operation *op, (void *)(unsigned long )dir_vp->scb.status.data_version; } +/* +* Set the file size and block count. Estimate the number of 512 bytes blocks +* used, rounded up to nearest 1K for consistency with other AFS clients. +*/ +static inline void afs_set_i_size (struct afs_vnode *vnode,u64 size) +{ +i_size_write (&vnode->vfs_inode, size); + vnode->vfs_inode.i_blocks = ((size +1023 ) >>10 ) <<1 ; +} +/* * Check for a conflicting operation on a directory that we just unlinked from. * If someone managed to sneak a link or an unlink in on the file we just
fs/afs/write.c +1 -1
@@ -184,7 +184,7 @@ int afs_write_end(struct file *file, struct address_space *mapping,write_seqlock (&vnode->cb_lock); i_size =i_size_read (&vnode->vfs_inode);if (maybe_i_size > i_size) -i_size_write (&vnode->vfs_inode, maybe_i_size); +afs_set_i_size (vnode, maybe_i_size);write_sequnlock (&vnode->cb_lock); }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 35/103 platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR()
In reply to Greg Kroah-HartmanFrom: Andy Shevchenko <[email protected]>
[ Upstream commit 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6 ]
ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused which is not what we want.
Instead of adding ifdeffery here and there, drop ACPI_PTR() and unused acpi.h.
--- drivers/platform/x86/intel_punit_ipc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/platform/x86/intel_punit_ipc.c +1 -2
@@ -8,7 +8,6 @@* which provide mailbox interface for power management usage. */ -#include <linux/acpi.h> #include <linux/bitops.h> #include <linux/delay.h> #include <linux/device.h>
@@ -319,7 +318,7 @@ static struct platform_driver intel_punit_ipc_driver = { .remove = intel_punit_ipc_remove, .driver = { .name = "intel_punit_ipc", - .acpi_match_table = ACPI_PTR(punit_ipc_acpi_ids), + .acpi_match_table = punit_ipc_acpi_ids, }, };
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 36/103 enetc: Fix illegal access when reading affinity_hint
In reply to Greg Kroah-HartmanFrom: Claudiu Manoil <[email protected]>
[ Upstream commit 7237a494decfa17d0b9d0076e6cee3235719de90 ]
irq_set_affinity_hit() stores a reference to the cpumask_t parameter in the irq descriptor, and that reference can be accessed later from irq_affinity_hint_proc_show(). Since the cpu_mask parameter passed to irq_set_affinity_hit() has only temporary storage (it's on the stack memory), later accesses to it are illegal. Thus reads from the corresponding procfs affinity_hint file can result in paging request oops.
The issue is fixed by the get_cpu_mask() helper, which provides a permanent storage for the cpumask_t parameter.
--- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/freescale/enetc/enetc.c +1 -4
@@ -1320,7 +1320,6 @@ static void enetc_clear_bdrs(struct enetc_ndev_priv *priv)static int enetc_setup_irqs (struct enetc_ndev_priv *priv) {struct pci_dev *pdev = priv->si->pdev; -cpumask_t cpu_mask;int i, j, err;for (i =0 ; i < priv->bdr_int_num; i++) {
@@ -1349,9 +1348,7 @@ static int enetc_setup_irqs(struct enetc_ndev_priv *priv)enetc_wr (hw,ENETC_SIMSITRV (idx), entry); } -cpumask_clear (&cpu_mask); -cpumask_set_cpu (i %num_online_cpus (), &cpu_mask); -irq_set_affinity_hint (irq, &cpu_mask); +irq_set_affinity_hint (irq,get_cpu_mask (i %num_online_cpus ())); }return 0 ;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 37/103 enetc: Fix uninitialized struct dim_sample field usage
In reply to Greg Kroah-HartmanFrom: Claudiu Manoil <[email protected]>
[ Upstream commit 9f7afa05c9522b086327929ae622facab0f0f72b ]
The only struct dim_sample member that does not get initialized by dim_update_sample() is comp_ctr. (There is special API to initialize comp_ctr:dim_update_sample_with_comps(), and it is currently used only for RDMA.) comp_ctr is used to compute curr_stats->cmps and curr_stats->cpe_ratio (see dim_calc_stats()) which in turn are consumed by the rdma_dim_*() API. Therefore, functionally, the net_dim*() API consumers are not affected. Nevertheless, fix the computation of statistics based on an uninitialized variable, even if the mentioned statistics are not used at the moment.
--- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc.c +1 -1
@@ -299,7 +299,7 @@ static void enetc_rx_dim_work(struct work_struct *w)static void enetc_rx_net_dim (struct enetc_int_vector *v) { -struct dim_sample dim_sample; +struct dim_sample dim_sample = {}; v->comp_cnt++;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 38/103 bnxt_en: Fix TX timeout when TX ring size is set to the smallest
In reply to Greg Kroah-HartmanFrom: Michael Chan <[email protected]>
[ Upstream commit 5bed8b0704c9ecccc8f4a2c377d7c8e21090a82e ]
The smallest TX ring size we support must fit a TX SKB with MAX_SKB_FRAGS
+ 1. Because the first TX BD for a packet is always a long TX BD, we need an extra TX BD to fit this packet. Define BNXT_MIN_TX_DESC_CNT with this value to make this more clear. The current code uses a minimum that is off by 1. Fix it using this constant.
The tx_wake_thresh to determine when to wake up the TX queue is half the ring size but we must have at least BNXT_MIN_TX_DESC_CNT for the next packet which may have maximum fragments. So the comparison of the available TX BDs with tx_wake_thresh should be >= instead of > in the current code. Otherwise, at the smallest ring size, we will never wake up the TX queue and will cause TX timeout.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++++---- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 +++++ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +4 -4
@@ -381,7 +381,7 @@ static bool bnxt_txr_netif_try_stop_queue(struct bnxt *bp,* netif_tx_queue_stopped(). */ smp_mb (); -if (bnxt_tx_avail (bp, txr) > bp->tx_wake_thresh) { +if (bnxt_tx_avail (bp, txr) >= bp->tx_wake_thresh) {netif_tx_wake_queue (txq);return false; }
@@ -717,7 +717,7 @@ static void bnxt_tx_int(struct bnxt *bp, struct bnxt_napi *bnapi, int nr_pkts)smp_mb ();if (unlikely (netif_tx_queue_stopped (txq)) && -bnxt_tx_avail (bp, txr) > bp->tx_wake_thresh && +bnxt_tx_avail (bp, txr) >= bp->tx_wake_thresh &&READ_ONCE (txr->dev_state) !=BNXT_DEV_STATE_CLOSING )netif_tx_wake_queue (txq); }
@@ -2300,7 +2300,7 @@ static int __bnxt_poll_work(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,if (TX_CMP_TYPE (txcmp) ==CMP_TYPE_TX_L2_CMP ) { tx_pkts++;/* return full budget so NAPI will complete. */ -if (unlikely (tx_pkts > bp->tx_wake_thresh)) { +if (unlikely (tx_pkts >= bp->tx_wake_thresh)) { rx_pkts = budget; raw_cons =NEXT_RAW_CMP (raw_cons);if (budget)
@@ -3431,7 +3431,7 @@ static int bnxt_init_tx_rings(struct bnxt *bp)u16 i; bp->tx_wake_thresh =max_t (int, bp->tx_ring_size /2 , -MAX_SKB_FRAGS +1 ); +BNXT_MIN_TX_DESC_CNT );for (i =0 ; i < bp->tx_nr_rings; i++) {struct bnxt_tx_ring_info *txr = &bp->tx_ring[i];
drivers/net/ethernet/broadcom/bnxt/bnxt.h +5 -0
@@ -611,6 +611,11 @@ struct nqe_cn {#define BNXT_MAX_RX_JUM_DESC_CNT (RX_DESC_CNT * MAX_RX_AGG_PAGES - 1)#define BNXT_MAX_TX_DESC_CNT (TX_DESC_CNT * MAX_TX_PAGES - 1) +/* Minimum TX BDs for a TX packet with MAX_SKB_FRAGS + 1. We need one extra +* BD because the first TX BD is always a long BD. +*/ +#define BNXT_MIN_TX_DESC_CNT (MAX_SKB_FRAGS + 2) +#define RX_RING (x) (((x) & ~(RX_DESC_CNT - 1)) >> (BNXT_PAGE_SHIFT - 4))#define RX_IDX (x) ((x) & (RX_DESC_CNT - 1))
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +1 -1
@@ -780,7 +780,7 @@ static int bnxt_set_ringparam(struct net_device *dev,if ((ering->rx_pending >BNXT_MAX_RX_DESC_CNT ) || (ering->tx_pending >BNXT_MAX_TX_DESC_CNT ) || - (ering->tx_pending <=MAX_SKB_FRAGS )) + (ering->tx_pending <BNXT_MIN_TX_DESC_CNT ))return -EINVAL ;if (netif_running (dev))
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 39/103 net: hns3: fix change RSS hfunc ineffective issue
In reply to Greg Kroah-HartmanFrom: Jian Shen <[email protected]>
[ Upstream commit e184cec5e29d8eb3c3435b12a9074b75e2d69e4a ]
When user change rss 'hfunc' without set rss 'hkey' by ethtool -X command, the driver will ignore the 'hfunc' for the hkey is NULL. It's unreasonable. So fix it.
--- .../hisilicon/hns3/hns3pf/hclge_main.c | 45 ++++++++++------ .../hisilicon/hns3/hns3vf/hclgevf_main.c | 52 ++++++++++++------- 2 files changed, 64 insertions(+), 33 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +30 -15
@@ -4377,6 +4377,24 @@ static int hclge_get_rss(struct hnae3_handle *handle, u32 *indir,return 0 ; } +static int hclge_parse_rss_hfunc (struct hclge_vport *vport,const u8 hfunc, +u8 *hash_algo) +{ +switch (hfunc) { +case ETH_RSS_HASH_TOP : + *hash_algo =HCLGE_RSS_HASH_ALGO_TOEPLITZ ; +return 0 ; +case ETH_RSS_HASH_XOR : + *hash_algo =HCLGE_RSS_HASH_ALGO_SIMPLE ; +return 0 ; +case ETH_RSS_HASH_NO_CHANGE : + *hash_algo = vport->rss_algo; +return 0 ; +default : +return -EINVAL ; + } +} +static int hclge_set_rss (struct hnae3_handle *handle,const u32 *indir,const u8 *key,const u8 hfunc) {
@@ -4385,30 +4403,27 @@ static int hclge_set_rss(struct hnae3_handle *handle, const u32 *indir,u8 hash_algo;int ret, i; + ret =hclge_parse_rss_hfunc (vport, hfunc, &hash_algo); +if (ret) { +dev_err (&hdev->pdev->dev,"invalid hfunc type %u\n" , hfunc); +return ret; + } +/* Set the RSS Hash Key if specififed by the user */ if (key) { -switch (hfunc) { -case ETH_RSS_HASH_TOP : - hash_algo =HCLGE_RSS_HASH_ALGO_TOEPLITZ ; -break ; -case ETH_RSS_HASH_XOR : - hash_algo =HCLGE_RSS_HASH_ALGO_SIMPLE ; -break ; -case ETH_RSS_HASH_NO_CHANGE : - hash_algo = vport->rss_algo; -break ; -default : -return -EINVAL ; - } - ret =hclge_set_rss_algo_key (hdev, hash_algo, key);if (ret)return ret;/* Update the shadow RSS key with user specified qids */ memcpy (vport->rss_hash_key, key,HCLGE_RSS_KEY_SIZE ); - vport->rss_algo = hash_algo; + }else { + ret =hclge_set_rss_algo_key (hdev, hash_algo, + vport->rss_hash_key); +if (ret) +return ret; } + vport->rss_algo = hash_algo;/* Update the shadow RSS table with user specified qids */ for (i =0 ; i <HCLGE_RSS_IND_TBL_SIZE ; i++)
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c +34 -18
74 lines not on this page · raw message
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 22/103 USB: serial: option: add device id for Foxconn T99W265
In reply to Greg Kroah-HartmanFrom: Slark Xiao <[email protected]>
commit 9e3eed534f8235a4a596a9dae5b8a6425d81ea1a upstream.
Adding support for Foxconn device T99W265 for enumeration with PID 0xe0db.
usb-devices output for 0xe0db
T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 19 Spd=5000 MxCh= 0 D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1 P: Vendor=0489 ProdID=e0db Rev=05.04 S: Manufacturer=Microsoft S: Product=Generic Mobile Broadband Adapter S: SerialNumber=6c50f452 C: #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=896mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option I: If#=0x3 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
if0/1: MBIM, if2:Diag, if3:GNSS, if4: Modem
--- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/serial/option.c +2 -0
@@ -2075,6 +2075,8 @@ static const struct usb_device_id option .driver_info = RSVD(0) | RSVD(1) | RSVD(6) }, { USB_DEVICE(0x0489, 0xe0b5), /* Foxconn T77W968 ESIM */ .driver_info = RSVD(0) | RSVD(1) | RSVD(6) }, + { USB_DEVICE_INTERFACE_CLASS(0x0489, 0xe0db, 0xff), /* Foxconn T99W265 MBIM */ + .driver_info = RSVD(3) }, { USB_DEVICE(0x1508, 0x1001), /* Fibocom NL668 (IOT version) */ .driver_info = RSVD(4) | RSVD(5) | RSVD(6) }, { USB_DEVICE(0x2cb7, 0x0104), /* Fibocom NL678 series */
Greg Kroah-Hartman
maintainerPATCH 41/103 net/smc: add missing error check in smc_clc_prfx_set()
In reply to Greg Kroah-HartmanFrom: Karsten Graul <[email protected]>
[ Upstream commit 6c90731980655280ea07ce4b21eb97457bf86286 ]
Coverity stumbled over a missing error check in smc_clc_prfx_set():
*** CID 1475954: Error handling issues (CHECKED_RETURN) /net/smc/smc_clc.c: 233 in smc_clc_prfx_set()
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
CID 1475954: Error handling issues (
CHECKED_RETURN)
Calling "kernel_getsockname" without checking return value (as is done elsewhere 8 out of 10 times).
233 kernel_getsockname(clcsock, (struct sockaddr *)&addrs);
Add the return code check in smc_clc_prfx_set().
--- net/smc/smc_clc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/smc/smc_clc.c +2 -1
@@ -230,7 +230,8 @@ static int smc_clc_prfx_set(struct socket *clcsock, goto out_rel; }/* get address to which the internal TCP socket is bound */ -kernel_getsockname (clcsock, (struct sockaddr *)&addrs); +if (kernel_getsockname (clcsock, (struct sockaddr *)&addrs) <0 ) + goto out_rel;/* analyze IP specific data of net_device belonging to TCP socket */ addr6 = (struct sockaddr_in6 *)&addrs;rcu_read_lock ();
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 40/103 net: hns3: check queue id range before using
In reply to Greg Kroah-HartmanFrom: Yufeng Mo <[email protected]>
[ Upstream commit 63b1279d9905100a14da9e043de7b28e99dba3f8 ]
The input parameters may not be reliable. Before using the queue id, we should check this parameter. Otherwise, memory overwriting may occur.
--- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c +8 -0
@@ -581,9 +581,17 @@ static void hclge_get_queue_id_in_pf(struct hclge_vport *vport,struct hclge_mbx_vf_to_pf_cmd *mbx_req, struct hclge_respond_to_vf_msg *resp_msg) { + struct hnae3_handle *handle = &vport->nic; +struct hclge_dev *hdev = vport->back;u16 queue_id, qid_in_pf;memcpy (&queue_id, mbx_req->msg.data,sizeof (queue_id)); +if (queue_id >= handle->kinfo.num_tqps) { +dev_err (&hdev->pdev->dev,"Invalid queue id(%u) from VF %u\n" , + queue_id, mbx_req->mbx_src_vfid); +return ; + } + qid_in_pf =hclge_covert_handle_qid_global (&vport->nic, queue_id);memcpy (resp_msg->data, &qid_in_pf,sizeof (qid_in_pf)); resp_msg->len =sizeof (qid_in_pf);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 42/103 net/smc: fix workqueue leaked lock in smc_conn_abort_work
In reply to Greg Kroah-HartmanFrom: Karsten Graul <[email protected]>
[ Upstream commit a18cee4791b1123d0a6579a7c89f4b87e48abe03 ]
The abort_work is scheduled when a connection was detected to be out-of-sync after a link failure. The work calls smc_conn_kill(), which calls smc_close_active_abort() and that might end up calling smc_close_cancel_work().smc_close_cancel_work() cancels any pending close_work and tx_work but needs to release the sock_lock before and acquires the sock_lock again afterwards. So when the sock_lock was NOT acquired before then it may be held after the abort_work completes. Thats why the sock_lock is acquired before the call to smc_conn_kill() in __smc_lgr_terminate(), but this is missing in smc_conn_abort_work().
Fix that by acquiring the sock_lock first and release it after the call to smc_conn_kill().
--- net/smc/smc_core.c | 2 ++ 1 file changed, 2 insertions(+)
net/smc/smc_core.c +2 -0
@@ -1089,7 +1089,9 @@ static void smc_conn_abort_work(struct work_struct *work) abort_work); struct smc_sock *smc = container_of(conn, struct smc_sock, conn); +lock_sock (&smc->sk);smc_conn_kill (conn, true); +release_sock (&smc->sk);sock_put (&smc->sk);/* sock_hold done by schedulers of abort_work */ }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 43/103 net: dsa: dont allocate the slave_mii_bus using devres
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
[ Upstream commit 5135e96a3dd2f4555ae6981c3155a62bcf3227f6 ]
The Linux device model permits both the ->shutdown and ->remove driver methods to get called during a shutdown procedure. Example: a DSA switch which sits on an SPI bus, and the SPI bus driver calls this on its ->shutdown method:
spi_unregister_controller
-> device_for_each_child(&ctlr->dev, NULL, __unregister);
-> spi_unregister_device(to_spi_device(dev));
-> device_del(&spi->dev);So this is a simple pattern which can theoretically appear on any bus, although the only other buses on which I've been able to find it are I2C:
i2c_del_adapter
-> device_for_each_child(&adap->dev, NULL, __unregister_client);
-> i2c_unregister_device(client);
-> device_unregister(&client->dev);The implication of this pattern is that devices on these buses can be unregistered after having been shut down. The drivers for these devices might choose to return early either from ->remove or ->shutdown if the other callback has already run once, and they might choose that the ->shutdown method should only perform a subset of the teardown done by ->remove (to avoid unnecessary delays when rebooting).
So in other words, the device driver may choose on ->remove to not do anything (therefore to not unregister an MDIO bus it has registered on ->probe), because this ->remove is actually triggered by the device_shutdown path, and its ->shutdown method has already run and done the minimally required cleanup.
This used to be fine until the blamed commit, but now, the following BUG_ON triggers:
void mdiobus_free(struct mii_bus *bus)
{
/* For compatibility with error handling in drivers. */
if (bus->state == MDIOBUS_ALLOCATED) {
kfree(bus);
return;
}
BUG_ON(bus->state != MDIOBUS_UNREGISTERED);
bus->state = MDIOBUS_RELEASED;
put_device(&bus->dev);
}In other words, there is an attempt to free an MDIO bus which was not unregistered. The attempt to free it comes from the devres release callbacks of the SPI device, which are executed after the device is unregistered.
I'm not saying that the fact that MDIO buses allocated using devres would automatically get unregistered wasn't strange. I'm just saying that the commit didn't care about auditing existing call paths in the kernel, and now, the following code sequences are potentially buggy:
(a) devm_mdiobus_alloc followed by plain mdiobus_register, for a device located on a bus that unregisters its children on shutdown. After the blamed patch, either both the alloc and the register should use devres, or none should.
(b) devm_mdiobus_alloc followed by plain mdiobus_register, and then no mdiobus_unregister at all in the remove path. After the blamed patch, nobody unregisters the MDIO bus anymore, so this is even more buggy than the previous case which needs a specific bus configuration to be seen, this one is an unconditional bug.
In this case, DSA falls into category (a), it tries to be helpful and registers an MDIO bus on behalf of the switch, which might be on such a bus. I've no idea why it does it under devres.
It does this on probe:
if (!ds->slave_mii_bus && ds->ops->phy_read) alloc and register mdio bus
and this on remove:
if (ds->slave_mii_bus && ds->ops->phy_read) unregister mdio bus
I _could_ imagine using devres because the condition used on remove is different than the condition used on probe. So strictly speaking, DSA cannot determine whether the ds->slave_mii_bus it sees on remove is the ds->slave_mii_bus that _it_ has allocated on probe. Using devres would have solved that problem. But nonetheless, the existing code already proceeds to unregister the MDIO bus, even though it might be unregistering an MDIO bus it has never registered. So I can only guess that no driver that implements ds->ops->phy_read also allocates and registers ds->slave_mii_bus itself.
So in that case, if unregistering is fine, freeing must be fine too.
Stop using devres and free the MDIO bus manually. This will make devres stop attempting to free a still registered MDIO bus on ->shutdown.
--- net/dsa/dsa2.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
net/dsa/dsa2.c +9 -3
@@ -459,7 +459,7 @@ static int dsa_switch_setup(struct dsa_switch *ds)devlink_params_publish (ds->devlink);if (!ds->slave_mii_bus && ds->ops->phy_read) { - ds->slave_mii_bus =devm_mdiobus_alloc (ds->dev); + ds->slave_mii_bus =mdiobus_alloc ();if (!ds->slave_mii_bus) { err = -ENOMEM ; goto teardown;
@@ -469,13 +469,16 @@ static int dsa_switch_setup(struct dsa_switch *ds) err =mdiobus_register (ds->slave_mii_bus);if (err <0 ) - goto teardown; + goto free_slave_mii_bus; } ds->setup = true;return 0 ; +free_slave_mii_bus: +if (ds->slave_mii_bus && ds->ops->phy_read) +mdiobus_free (ds->slave_mii_bus); teardown:if (ds->ops->teardown) ds->ops->teardown (ds);
@@ -500,8 +503,11 @@ static void dsa_switch_teardown(struct dsa_switch *ds)if (!ds->setup)return ; -if (ds->slave_mii_bus && ds->ops->phy_read) +if (ds->slave_mii_bus && ds->ops->phy_read) {mdiobus_unregister (ds->slave_mii_bus); +mdiobus_free (ds->slave_mii_bus); + ds->slave_mii_bus =NULL ; + }dsa_switch_unregister_notifier (ds);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 46/103 kselftest/arm64: signal: Skip tests if required features are missing
In reply to Greg Kroah-HartmanFrom: Cristian Marussi <[email protected]>
[ Upstream commit 0e3dbf765fe22060acbcb8eb8c4d256e655a1247 ]
During initialization of a signal testcase, features declared as required are properly checked against the running system but no action is then taken to effectively skip such a testcase.
Fix core signals test logic to abort initialization and report such a testcase as skipped to the KSelfTest framework.
--- tools/testing/selftests/arm64/signal/test_signals_utils.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/testing/selftests/arm64/signal/test_signals_utils.c +5 -2
@@ -266,16 +266,19 @@ int test_init(struct tdescr *td) td->feats_supported |=FEAT_SSBS ;if (getauxval (AT_HWCAP ) &HWCAP_SVE ) td->feats_supported |=FEAT_SVE ; -if (feats_ok (td)) +if (feats_ok (td)) {fprintf (stderr,"Required Features: [%s] supported\n" ,feats_to_string (td->feats_required & td->feats_supported)); -else + }else {fprintf (stderr,"Required Features: [%s] NOT supported\n" ,feats_to_string (td->feats_required & ~td->feats_supported)); + td->result =KSFT_SKIP ; +return 0 ; + } }/* Perform test specific additional initialization */
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 48/103 s390/qeth: fix deadlock during failing recovery
In reply to Greg Kroah-HartmanFrom: Alexandra Winter <[email protected]>
[ Upstream commit d2b59bd4b06d84a4eadb520b0f71c62fe8ec0a62 ]
Commit 0b9902c1fcc5 ("s390/qeth: fix deadlock during recovery") removed taking discipline_mutex inside qeth_do_reset(), fixing potential deadlocks. An error path was missed though, that still takes discipline_mutex and thus has the original deadlock potential.
Intermittent deadlocks were seen when a qeth channel path is configured offline, causing a race between qeth_do_reset and ccwgroup_remove. Call qeth_set_offline() directly in the qeth_do_reset() error case and then a new variant of ccwgroup_set_offline(), without taking discipline_mutex.
--- arch/s390/include/asm/ccwgroup.h | 2 +- drivers/s390/cio/ccwgroup.c | 10 ++++++++-- drivers/s390/net/qeth_core_main.c | 3 ++- 3 files changed, 11 insertions(+), 4 deletions(-)
arch/s390/include/asm/ccwgroup.h +1 -1
@@ -58,7 +58,7 @@ struct ccwgroup_device *get_ccwgroupdev_by_busid(struct ccwgroup_driver *gdrv, char *bus_id);extern int ccwgroup_set_online (struct ccwgroup_device *gdev); -extern int ccwgroup_set_offline (struct ccwgroup_device *gdev); +int ccwgroup_set_offline (struct ccwgroup_device *gdev,bool call_gdrv);extern int ccwgroup_probe_ccwdev (struct ccw_device *cdev);extern void ccwgroup_remove_ccwdev (struct ccw_device *cdev);
drivers/s390/cio/ccwgroup.c +8 -2
@@ -98,12 +98,13 @@ EXPORT_SYMBOL(ccwgroup_set_online);/** * ccwgroup_set_offline() - disable a ccwgroup device * @gdev: target ccwgroup device +* @call_gdrv: Call the registered gdrv set_offline function * * This function attempts to put the ccwgroup device into the offline state. * Returns: * %0 on success and a negative error value on failure. */ -int ccwgroup_set_offline (struct ccwgroup_device *gdev) +int ccwgroup_set_offline (struct ccwgroup_device *gdev,bool call_gdrv) {struct ccwgroup_driver *gdrv =to_ccwgroupdrv (gdev->dev.driver);int ret = -EINVAL ;
@@ -112,11 +113,16 @@ int ccwgroup_set_offline(struct ccwgroup_device *gdev)return -EAGAIN ;if (gdev->state ==CCWGROUP_OFFLINE ) goto out; +if (!call_gdrv) { + ret =0 ; + goto offline; + }if (gdrv->set_offline) ret = gdrv->set_offline (gdev);if (ret) goto out; +offline: gdev->state =CCWGROUP_OFFLINE ; out:atomic_set (&gdev->onoff,0 );
@@ -145,7 +151,7 @@ static ssize_t ccwgroup_online_store(struct device *dev,if (value ==1 ) ret =ccwgroup_set_online (gdev);else if (value ==0 ) - ret =ccwgroup_set_offline (gdev); + ret =ccwgroup_set_offline (gdev, true);else ret = -EINVAL ; out:
drivers/s390/net/qeth_core_main.c +2 -1
@@ -5406,7 +5406,8 @@ static int qeth_do_reset(void *data)dev_info (&card->gdev->dev,"Device successfully recovered!\n" ); }else { -ccwgroup_set_offline (card->gdev); +qeth_set_offline (card, disc, true); +ccwgroup_set_offline (card->gdev, false);dev_warn (&card->gdev->dev,"The qeth device driver failed to recover an error on the device\n" ); }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 50/103 qed: rdma - dont wait for resources under hw error recovery flow
In reply to Greg Kroah-HartmanFrom: Shai Malin <[email protected]>
[ Upstream commit 1ea7812326004afd2803cc968a4776ae5120a597 ]
If the HW device is during recovery, the HW resources will never return, hence we shouldn't wait for the CID (HW context ID) bitmaps to clear. This fix speeds up the error recovery flow.
--- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 8 ++++++++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 8 ++++++++ 2 files changed, 16 insertions(+)
drivers/net/ethernet/qlogic/qed/qed_iwarp.c +8 -0
@@ -1297,6 +1297,14 @@ qed_iwarp_wait_cid_map_cleared(struct qed_hwfn *p_hwfn, struct qed_bmap *bmap) prev_weight = weight;while (weight) { +/* If the HW device is during recovery, all resources are +* immediately reset without receiving a per-cid indication +* from HW. In this case we don't expect the cid_map to be +* cleared. +*/ +if (p_hwfn->cdev->recov_in_prog) +return 0 ; +msleep (QED_IWARP_MAX_CID_CLEAN_TIME ); weight =bitmap_weight (bmap->bitmap, bmap->max_count);
drivers/net/ethernet/qlogic/qed/qed_roce.c +8 -0
@@ -77,6 +77,14 @@ void qed_roce_stop(struct qed_hwfn *p_hwfn)* Beyond the added delay we clear the bitmap anyway. */ while (bitmap_weight (rcid_map->bitmap, rcid_map->max_count)) { +/* If the HW device is during recovery, all resources are +* immediately reset without receiving a per-cid indication +* from HW. In this case we don't expect the cid bitmap to be +* cleared. +*/ +if (p_hwfn->cdev->recov_in_prog) +return ; +msleep (100 );if (wait_count++ >20 ) {DP_NOTICE (p_hwfn,"cid bitmap wait timed out\n" );
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 51/103 net/mlx4_en: Dont allow aRFS for encapsulated packets
In reply to Greg Kroah-HartmanFrom: Aya Levin <[email protected]>
[ Upstream commit fdbccea419dc782079ce5881d2705cc9e3881480 ]
Driver doesn't support aRFS for encapsulated packets, return early error in such a case.
--- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/mellanox/mlx4/en_netdev.c +3 -0
@@ -372,6 +372,9 @@ mlx4_en_filter_rfs(struct net_device *net_dev, const struct sk_buff *skb,int nhoff =skb_network_offset (skb);int ret =0 ; +if (skb->encapsulation) +return -EPROTONOSUPPORT ; +if (skb->protocol !=htons (ETH_P_IP ))return -EPROTONOSUPPORT ;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 53/103 scsi: iscsi: Adjust iface sysfs attr detection
In reply to Greg Kroah-HartmanFrom: Baokun Li <[email protected]>
[ Upstream commit 4e28550829258f7dab97383acaa477bd724c0ff4 ]
ISCSI_NET_PARAM_IFACE_ENABLE belongs to enum iscsi_net_param instead of iscsi_iface_param so move it to ISCSI_NET_PARAM. Otherwise, when we call into the driver, we might not match and return that we don't want attr visible in sysfs. Found in code review.
--- drivers/scsi/scsi_transport_iscsi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/scsi_transport_iscsi.c +4 -4
@@ -442,9 +442,7 @@ static umode_t iscsi_iface_attr_is_visible(struct kobject *kobj,struct iscsi_transport *t = iface->transport;int param =-1 ; -if (attr == &dev_attr_iface_enabled.attr) - param =ISCSI_NET_PARAM_IFACE_ENABLE ; -else if (attr == &dev_attr_iface_def_taskmgmt_tmo.attr) +if (attr == &dev_attr_iface_def_taskmgmt_tmo.attr) param =ISCSI_IFACE_PARAM_DEF_TASKMGMT_TMO ;else if (attr == &dev_attr_iface_header_digest.attr) param =ISCSI_IFACE_PARAM_HDRDGST_EN ;
@@ -484,7 +482,9 @@ static umode_t iscsi_iface_attr_is_visible(struct kobject *kobj,if (param !=-1 )return t->attr_is_visible (ISCSI_IFACE_PARAM , param); -if (attr == &dev_attr_iface_vlan_id.attr) +if (attr == &dev_attr_iface_enabled.attr) + param =ISCSI_NET_PARAM_IFACE_ENABLE ; +else if (attr == &dev_attr_iface_vlan_id.attr) param =ISCSI_NET_PARAM_VLAN_ID ;else if (attr == &dev_attr_iface_vlan_priority.attr) param =ISCSI_NET_PARAM_VLAN_PRIORITY ;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 24/103 erofs: fix up erofs_lookup tracepoint
In reply to Greg Kroah-HartmanFrom: Gao Xiang <[email protected]>
commit 93368aab0efc87288cac65e99c9ed2e0ffc9e7d0 upstream.
Fix up a misuse that the filename pointer isn't always valid in the ring buffer, and we should copy the content instead.
--- include/trace/events/erofs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/trace/events/erofs.h +3 -3
@@ -35,20 +35,20 @@ TRACE_EVENT(erofs_lookup,TP_STRUCT__entry (__field (dev_t ,dev )__field (erofs_nid_t, nid ) - __field(const char *, name ) + __string(name, dentry->d_name.name ) __field(unsigned int, flags ) ),TP_fast_assign ( __entry->dev = dir->i_sb->s_dev; __entry->nid =EROFS_I (dir)->nid; - __entry->name = dentry->d_name.name; +__assign_str (name, dentry->d_name.name); __entry->flags = flags; ),TP_printk ("dev = (%d,%d), pnid = %llu, name:%s, flags:%x" ,show_dev_nid (__entry), - __entry->name, +__get_str (name), __entry->flags) );
Greg Kroah-Hartman
maintainerPATCH 54/103 scsi: target: Fix the pgr/alua_support_store functions
In reply to Greg Kroah-HartmanFrom: Maurizio Lombardi <[email protected]>
[ Upstream commit ef7ae7f746e95c6fa4ec2bcfacb949c36263da78 ]
Commit 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and alua_support attributes writable") introduced support for changeable alua_support and pgr_support target attributes. These can only be changed if the backstore is user-backed, otherwise the kernel returns -EINVAL.
This triggers a warning in the targetcli/rtslib code when performing a target restore that includes non-userbacked backstores:
# targetctl restore Storage Object block/storage1: Cannot set attribute alua_support: [Errno 22] Invalid argument, skipped Storage Object block/storage1: Cannot set attribute pgr_support: [Errno 22] Invalid argument, skipped
Fix this warning by returning an error code only if we are really going to flip the PGR/ALUA bit in the transport_flags field, otherwise we will do nothing and return success.
Return ENOSYS instead of EINVAL if the pgr/alua attributes can not be changed, this way it will be possible for userspace to understand if the operation failed because an invalid value has been passed to strtobool() or because the attributes are fixed.
--- drivers/target/target_core_configfs.c | 32 +++++++++++++++++---------- 1 file changed, 20 insertions(+), 12 deletions(-)
drivers/target/target_core_configfs.c +20 -12
@@ -1110,20 +1110,24 @@ static ssize_t alua_support_store(struct config_item *item, {struct se_dev_attrib *da =to_attrib (item);struct se_device *dev = da->da_dev; -bool flag; +bool flag, oldflag;int ret; + ret =strtobool (page, &flag); +if (ret <0 ) +return ret; + + oldflag = !(dev->transport_flags &TRANSPORT_FLAG_PASSTHROUGH_ALUA ); +if (flag == oldflag) +return count; +if (!(dev->transport->transport_flags_changeable &TRANSPORT_FLAG_PASSTHROUGH_ALUA )) {pr_err ("dev[%p]: Unable to change SE Device alua_support:" " alua_support has fixed value\n" , dev); -return -EINVAL ; +return -ENOSYS ; } - ret =strtobool (page, &flag); -if (ret <0 ) -return ret; -if (flag) dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_ALUA ;else
@@ -1145,20 +1149,24 @@ static ssize_t pgr_support_store(struct config_item *item, {struct se_dev_attrib *da =to_attrib (item);struct se_device *dev = da->da_dev; -bool flag; +bool flag, oldflag;int ret; + ret =strtobool (page, &flag); +if (ret <0 ) +return ret; + + oldflag = !(dev->transport_flags &TRANSPORT_FLAG_PASSTHROUGH_PGR ); +if (flag == oldflag) +return count; +if (!(dev->transport->transport_flags_changeable &TRANSPORT_FLAG_PASSTHROUGH_PGR )) {pr_err ("dev[%p]: Unable to change SE Device pgr_support:" " pgr_support has fixed value\n" , dev); -return -EINVAL ; +return -ENOSYS ; } - ret =strtobool (page, &flag); -if (ret <0 ) -return ret; -if (flag) dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_PGR ;else
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 25/103 btrfs: prevent __btrfs_dump_space_info() to underflow its free space
In reply to Greg Kroah-HartmanFrom: Qu Wenruo <[email protected]>
commit 0619b7901473c380abc05d45cf9c70bee0707db3 upstream.
It's not uncommon where __btrfs_dump_space_info() gets called under over-commit situations.
In that case free space would underflow as total allocated space is not enough to handle all the over-committed space.
Such underflow values can sometimes cause confusion for users enabled enospc_debug mount option, and takes some seconds for developers to convert the underflow value to signed result.
Just output the free space as s64 to avoid such problem.
--- fs/btrfs/space-info.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/btrfs/space-info.c +3 -2
@@ -417,9 +417,10 @@ static void __btrfs_dump_space_info(stru {lockdep_assert_held (&info->lock); -btrfs_info (fs_info,"space_info %llu has %llu free, is %sfull" , +/* The free space could be negative in case of overcommit */ +btrfs_info (fs_info,"space_info %llu has %lld free, is %sfull" , info->flags, - info->total_bytes -btrfs_space_info_used (info, true), + (s64)(info->total_bytes -btrfs_space_info_used (info, true)), info->full ?"" :"not " ); btrfs_info(fs_info, "space_info total=%llu, used=%llu, pinned=%llu, reserved=%llu, may_use=%llu, readonly=%llu",
Greg Kroah-Hartman
maintainerPATCH 29/103 scsi: sd_zbc: Ensure buffer size is aligned to SECTOR_SIZE
In reply to Greg Kroah-HartmanFrom: Naohiro Aota <[email protected]>
commit 7215e909814fed7cda33c954943a4050d8348204 upstream.
Reporting zones on a SCSI device sometimes fail with the following error:
[76248.516390] ata16.00: invalid transfer count 131328 [76248.523618] sd 15:0:0:0: [sda] REPORT ZONES start lba 536870912 failed
The error (from drivers/ata/libata-scsi.c:ata_scsi_zbc_in_xlat()) indicates that buffer size is not aligned to SECTOR_SIZE.
This happens when the __vmalloc() failed. Consider we are reporting 4096 zones, then we will have "bufsize = roundup((4096 + 1) * 64, SECTOR_SIZE)" = (513 * 512) = 262656. Then, __vmalloc() failure halves the bufsize to 131328, which is no longer aligned to SECTOR_SIZE.
Use rounddown() to ensure the size is always aligned to SECTOR_SIZE and fix the comment as well.
--- drivers/scsi/sd_zbc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/sd_zbc.c +3 -3
@@ -155,8 +155,8 @@ static void *sd_zbc_alloc_report_buffer(/* * Report zone buffer size should be at most 64B times the number of -* zones requested plus the 64B reply header, but should be at least -* SECTOR_SIZE for ATA devices. +* zones requested plus the 64B reply header, but should be aligned +* to SECTOR_SIZE for ATA devices. * Make sure that this size does not exceed the hardware capabilities. * Furthermore, since the report zone command cannot be split, make * sure that the allocated buffer can always be mapped by limiting the
@@ -175,7 +175,7 @@ static void *sd_zbc_alloc_report_buffer( *buflen = bufsize;return buf; } - bufsize >>=1 ; + bufsize =rounddown (bufsize >>1 ,SECTOR_SIZE ); }return NULL ;
Greg Kroah-Hartman
maintainerPATCH 27/103 serial: 8250: 8250_omap: Fix RX_LVL register offset
In reply to Greg Kroah-HartmanFrom: Nishanth Menon <[email protected]>
commit 79e9e30a9292a62d25ab75488d3886108db1eaad upstream.
Commit b67e830d38fa ("serial: 8250: 8250_omap: Fix possible interrupt storm on K3 SoCs") introduced fixup including a register read to RX_LVL, however, we should be using word offset than byte offset since our registers are on 4 byte boundary (port.regshift = 2) for 8250_omap.
--- drivers/tty/serial/8250/8250_omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/8250/8250_omap.c +1 -1
@@ -106,7 +106,7 @@#define UART_OMAP_EFR2_TIMEOUT_BEHAVE BIT(6)/* RX FIFO occupancy indicator */ -#define UART_OMAP_RX_LVL 0x64 +#define UART_OMAP_RX_LVL 0x19struct omap8250_priv {int line;
Greg Kroah-Hartman
maintainerPATCH 28/103 serial: mvebu-uart: fix drivers tx_empty callback
In reply to Greg Kroah-HartmanFrom: Pali Rohár <[email protected]>
commit 74e1eb3b4a1ef2e564b4bdeb6e92afe844e900de upstream.
Driver's tx_empty callback should signal when the transmit shift register is empty. So when the last character has been sent.
STAT_TX_FIFO_EMP bit signals only that HW transmit FIFO is empty, which happens when the last byte is loaded into transmit shift register.
STAT_TX_EMP bit signals when the both HW transmit FIFO and transmit shift register are empty.
So replace STAT_TX_FIFO_EMP check by STAT_TX_EMP in mvebu_uart_tx_empty() callback function.
--- drivers/tty/serial/mvebu-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/mvebu-uart.c +1 -1
@@ -164,7 +164,7 @@ static unsigned int mvebu_uart_tx_empty( st =readl (port->membase +UART_STAT );spin_unlock_irqrestore (&port->lock, flags); -return (st &STAT_TX_FIFO_EMP ) ?TIOCSER_TEMT :0 ; +return (st &STAT_TX_EMP ) ?TIOCSER_TEMT :0 ; }static unsigned int mvebu_uart_get_mctrl (struct uart_port *port)
Greg Kroah-Hartman
maintainerPATCH 76/103 blk-mq: avoid to iterate over stale request
In reply to Greg Kroah-HartmanFrom: Ming Lei <[email protected]>
[ Upstream commit 67f3b2f822b7e71cfc9b42dbd9f3144fa2933e0b ]
blk-mq can't run allocating driver tag and updating ->rqs[tag] atomically, meantime blk-mq doesn't clear ->rqs[tag] after the driver tag is released.
So there is chance to iterating over one stale request just after the tag is allocated and before updating ->rqs[tag].
scsi_host_busy_iter() calls scsi_host_check_in_flight() to count scsi in-flight requests after scsi host is blocked, so no new scsi command can be marked as SCMD_STATE_INFLIGHT. However, driver tag allocation still can be run by blk-mq core. One request is marked as SCMD_STATE_INFLIGHT, but this request may have been kept in another slot of ->rqs[], meantime the slot can be allocated out but ->rqs[] isn't updated yet. Then this in-flight request is counted twice as SCMD_STATE_INFLIGHT. This way causes trouble in handling scsi error.
Fixes the issue by not iterating over stale request.
--- block/blk-mq-tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-mq-tag.c +1 -1
@@ -207,7 +207,7 @@ static struct request *blk_mq_find_and_get_req(struct blk_mq_tags *tags,spin_lock_irqsave (&tags->lock, flags); rq = tags->rqs[bitnr]; -if (!rq || !refcount_inc_not_zero (&rq->ref)) +if (!rq || rq->tag != bitnr || !refcount_inc_not_zero (&rq->ref)) rq =NULL ;spin_unlock_irqrestore (&tags->lock, flags);return rq;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 20/103 USB: serial: option: add Telit LN920 compositions
In reply to Greg Kroah-HartmanFrom: Carlo Lobrano <[email protected]>
commit 7bb057134d609b9c038a00b6876cf0d37d0118ce upstream.
This patch adds the following Telit LN920 compositions:
0x1060: tty, adb, rmnet, tty, tty, tty, tty 0x1061: tty, adb, mbim, tty, tty, tty, tty 0x1062: rndis, tty, adb, tty, tty, tty, tty 0x1063: tty, adb, ecm, tty, tty, tty, tty
--- drivers/usb/serial/option.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/usb/serial/option.c +8 -0
@@ -1205,6 +1205,14 @@ static const struct usb_device_id option .driver_info = NCTRL(0) | RSVD(1) }, { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1056, 0xff), /* Telit FD980 */ .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1060, 0xff), /* Telit LN920 (rmnet) */ + .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1061, 0xff), /* Telit LN920 (MBIM) */ + .driver_info = NCTRL(0) | RSVD(1) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1062, 0xff), /* Telit LN920 (RNDIS) */ + .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1063, 0xff), /* Telit LN920 (ECM) */ + .driver_info = NCTRL(0) | RSVD(1) }, { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910), .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) }, { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
Greg Kroah-Hartman
maintainerPATCH 56/103 tty: synclink_gt: rename a conflicting function name
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
[ Upstream commit 06e49073dfba24df4b1073a068631b13a0039c34 ]
'set_signals()' in synclink_gt.c conflicts with an exported symbol in arch/um/, so change set_signals() to set_gtsignals(). Keep the function names similar by also changing get_signals() to get_gtsignals().
../drivers/tty/synclink_gt.c:442:13: error: conflicting types for ‘set_signals’
static void set_signals(struct slgt_info *info);
^~~~~~~~~~~
In file included from ../include/linux/irqflags.h:16:0,
from ../include/linux/spinlock.h:58,
from ../include/linux/mm_types.h:9,
from ../include/linux/buildid.h:5,
from ../include/linux/module.h:14,
from ../drivers/tty/synclink_gt.c:46:
../arch/um/include/asm/irqflags.h:6:5: note: previous declaration of ‘set_signals’ was here
int set_signals(int enable);
^~~~~~~~~~~--- drivers/tty/synclink_gt.c | 44 +++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 22 deletions(-)
drivers/tty/synclink_gt.c +22 -22
@@ -438,8 +438,8 @@ static void reset_tbufs(struct slgt_info *info);static void tdma_reset (struct slgt_info *info);static bool tx_load (struct slgt_info *info,const char *buf,unsigned int count); -static void get_signals (struct slgt_info *info); -static void set_signals (struct slgt_info *info); +static void get_gtsignals (struct slgt_info *info); +static void set_gtsignals (struct slgt_info *info);static void set_rate (struct slgt_info *info,u32 data_rate);static void bh_transmit (struct slgt_info *info);
@@ -721,7 +721,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)if ((old_termios->c_cflag &CBAUD ) && !C_BAUD (tty)) { info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);spin_lock_irqsave (&info->lock,flags); -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); }
@@ -731,7 +731,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)if (!C_CRTSCTS (tty) || !tty_throttled (tty)) info->signals |= SerialSignal_RTS;spin_lock_irqsave (&info->lock,flags); -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); }
@@ -1182,7 +1182,7 @@ static inline void line_info(struct seq_file *m, struct slgt_info *info)/* output current serial signal states */ spin_lock_irqsave (&info->lock,flags); -get_signals (info); +get_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); stat_buf[0 ] =0 ;
@@ -1282,7 +1282,7 @@ static void throttle(struct tty_struct * tty)if (C_CRTSCTS (tty)) {spin_lock_irqsave (&info->lock,flags); info->signals &= ~SerialSignal_RTS; -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); } }
@@ -1307,7 +1307,7 @@ static void unthrottle(struct tty_struct * tty)if (C_CRTSCTS (tty)) {spin_lock_irqsave (&info->lock,flags); info->signals |= SerialSignal_RTS; -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); } }
@@ -1478,7 +1478,7 @@ static int hdlcdev_open(struct net_device *dev)/* inform generic HDLC layer of current DCD status */ spin_lock_irqsave (&info->lock, flags); -get_signals (info); +get_gtsignals (info);spin_unlock_irqrestore (&info->lock, flags);if (info->signals & SerialSignal_DCD)netif_carrier_on (dev);
@@ -2232,7 +2232,7 @@ static void isr_txeom(struct slgt_info *info, unsigned short status)if (info->params.mode !=MGSL_MODE_ASYNC && info->drop_rts_on_tx_done) { info->signals &= ~SerialSignal_RTS; info->drop_rts_on_tx_done = false; -set_signals (info); +set_gtsignals (info); }#if SYNCLINK_GENERIC_HDLC
@@ -2397,7 +2397,7 @@ static void shutdown(struct slgt_info *info)if (!info->port.tty || info->port.tty->termios.c_cflag &HUPCL ) { info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR); -set_signals (info); +set_gtsignals (info); }flush_cond_wait (&info->gpio_wait_q);
@@ -2425,7 +2425,7 @@ static void program_hw(struct slgt_info *info)else async_mode (info); -set_signals (info); +set_gtsignals (info); info->dcd_chkcount =0 ; info->cts_chkcount =0 ;
@@ -2433,7 +2433,7 @@ static void program_hw(struct slgt_info *info) info->dsr_chkcount =0 ;slgt_irq_on (info,IRQ_DCD |IRQ_CTS |IRQ_DSR |IRQ_RI ); -get_signals (info); +get_gtsignals (info);if (info->netcount || (info->port.tty && info->port.tty->termios.c_cflag &CREAD ))
@@ -2677,7 +2677,7 @@ static int wait_mgsl_event(struct slgt_info *info, int __user *mask_ptr)spin_lock_irqsave (&info->lock,flags);/* return immediately if state matches requested events */ -get_signals (info); +get_gtsignals (info); s = info->signals; events = mask &
@@ -3095,7 +3095,7 @@ static int tiocmget(struct tty_struct *tty)unsigned long flags;spin_lock_irqsave (&info->lock,flags); -get_signals (info); +get_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); result = ((info->signals & SerialSignal_RTS) ? TIOCM_RTS:0) +
@@ -3134,7 +3134,7 @@ static int tiocmset(struct tty_struct *tty, info->signals &= ~SerialSignal_DTR;spin_lock_irqsave (&info->lock,flags); -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags);return 0 ; }
@@ -3145,7 +3145,7 @@ static int carrier_raised(struct tty_port *port) struct slgt_info *info = container_of(port, struct slgt_info, port);spin_lock_irqsave (&info->lock,flags); -get_signals (info); +get_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags);return (info->signals & SerialSignal_DCD) ?1 :0 ; }
@@ -3160,7 +3160,7 @@ static void dtr_rts(struct tty_port *port, int on) info->signals |= SerialSignal_RTS | SerialSignal_DTR; else info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR); -set_signals (info); +set_gtsignals (info);spin_unlock_irqrestore (&info->lock,flags); }
@@ -3963,10 +3963,10 @@ static void tx_start(struct slgt_info *info)if (info->params.mode !=MGSL_MODE_ASYNC ) {if (info->params.flags &HDLC_FLAG_AUTO_RTS ) { -get_signals (info); +get_gtsignals (info);if (!(info->signals & SerialSignal_RTS)) { info->signals |= SerialSignal_RTS; -set_signals (info); +set_gtsignals (info); info->drop_rts_on_tx_done = true; } }
@@ -4020,7 +4020,7 @@ static void reset_port(struct slgt_info *info)rx_stop (info); info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR); -set_signals (info); +set_gtsignals (info);slgt_irq_off (info,IRQ_ALL |IRQ_MASTER ); }
@@ -4442,7 +4442,7 @@ static void tx_set_idle(struct slgt_info *info)/* * get state of V24 status (input) signals */ -static void get_signals (struct slgt_info *info) +static void get_gtsignals (struct slgt_info *info) {unsigned short status =rd_reg16 (info,SSR );
@@ -4504,7 +4504,7 @@ static void msc_set_vcr(struct slgt_info *info)/* * set state of V24 control (output) signals */ -static void set_signals (struct slgt_info *info) +static void set_gtsignals (struct slgt_info *info) {unsigned char val =rd_reg8 (info,VCR );if (info->signals & SerialSignal_DTR)
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 65/103 scsi: lpfc: Use correct scnprintf() limit
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 6dacc371b77f473770ec646e220303a84fe96c11 ]
The limit should be "PAGE_SIZE - len" instead of "PAGE_SIZE". We're not going to hit the limit so this fix will not affect runtime.
--- drivers/scsi/lpfc/lpfc_attr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_attr.c +2 -1
@@ -6005,7 +6005,8 @@ lpfc_sg_seg_cnt_show(struct device *dev, struct device_attribute *attr, len =scnprintf (buf,PAGE_SIZE ,"SGL sz: %d total SGEs: %d\n" , phba->cfg_sg_dma_buf_size, phba->cfg_total_seg_cnt); - len +=scnprintf (buf + len,PAGE_SIZE ,"Cfg: %d SCSI: %d NVME: %d\n" , + len +=scnprintf (buf + len,PAGE_SIZE - len, +"Cfg: %d SCSI: %d NVME: %d\n" , phba->cfg_sg_seg_cnt, phba->cfg_scsi_seg_cnt, phba->cfg_nvme_seg_cnt);return len;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 66/103 irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
[ Upstream commit 969ac78db78c723a24e9410666b457cc1b0cb3c3 ]
irq-goldfish-pic uses GENERIC_IRQ_CHIP interfaces so select that symbol to fix build errors.
Fixes these build errors:
mips-linux-ld: drivers/irqchip/irq-goldfish-pic.o: in function `goldfish_pic_of_init':
irq-goldfish-pic.c:(.init.text+0xc0): undefined reference to `irq_alloc_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf4): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0xf8): undefined reference to `irq_gc_unmask_enable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x100): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x104): undefined reference to `irq_gc_mask_disable_reg'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x11c): undefined reference to `irq_setup_generic_chip'
mips-linux-ld: irq-goldfish-pic.c:(.init.text+0x168): undefined reference to `irq_remove_generic_chip'
--- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/Kconfig +1 -0
@@ -425,6 +425,7 @@ config MESON_IRQ_GPIO config GOLDFISH_PIC bool "Goldfish programmable interrupt controller" depends on MIPS && (GOLDFISH || COMPILE_TEST) + select GENERIC_IRQ_CHIP select IRQ_DOMAIN help Say yes here to enable Goldfish interrupt controller driver used
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 67/103 irqchip/gic-v3-its: Fix potential VPE leak on error
In reply to Greg Kroah-HartmanFrom: Kaige Fu <[email protected]>
[ Upstream commit 280bef512933b2dda01d681d8cbe499b98fc5bdd ]
In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error, there is an off-by-one in the number of VPEs to be freed.
Fix it by simply passing the number of VPEs allocated, which is the index of the loop iterating over the VPEs.
--- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-gic-v3-its.c +1 -1
@@ -4489,7 +4489,7 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virqif (err) {if (i >0 ) -its_vpe_irq_domain_free (domain, virq, i -1 ); +its_vpe_irq_domain_free (domain, virq, i);its_lpi_free (bitmap, base, nr_ids);its_free_prop_table (vprop_page);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 69/103 x86/asm: Add a missing __iomem annotation in enqcmds()
In reply to Greg Kroah-HartmanFrom: Dave Jiang <[email protected]>
[ Upstream commit 5c99720b28381bb400d4f546734c34ddaf608761 ]
Add a missing __iomem annotation to address a sparse warning. The caller is expected to pass an __iomem annotated pointer to this function. The current usages send a 64-bytes command descriptor to an MMIO location (portal) on a device for consumption.
Also, from the comment in movdir64b(), which also applies to enqcmds(), @__dst must be supplied as an lvalue because this tells the compiler what the object is (its size) the instruction accesses. I.e., not the pointers but what they point to, thus the deref'ing '*'."
The actual sparse warning is:
drivers/dma/idxd/submit.c: note: in included file (through arch/x86/include/asm/processor.h, \
arch/x86/include/asm/timex.h, include/linux/timex.h, include/linux/time32.h, \ include/linux/time.h, include/linux/stat.h, ...):
./arch/x86/include/asm/special_insns.h:289:41: warning: incorrect type in initializer (different address spaces)
./arch/x86/include/asm/special_insns.h:289:41: expected struct <noident> *__dst
./arch/x86/include/asm/special_insns.h:289:41: got void [noderef] __iomem *dst
[ bp: Massage commit message. ]
--- arch/x86/include/asm/special_insns.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/special_insns.h +1 -1
@@ -286,7 +286,7 @@ static inline void movdir64b(void *dst, const void *src)static inline int enqcmds (void __iomem *dst,const void *src) {const struct {char _[64 ]; } *__src = src; -struct {char _[64 ]; } *__dst = dst; +struct {char _[64 ]; }__iomem *__dst = dst;int zf;/*
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 72/103 blktrace: Fix uaf in blk_trace access after removing by sysfs
In reply to Greg Kroah-HartmanFrom: Zhihao Cheng <[email protected]>
[ Upstream commit 5afedf670caf30a2b5a52da96eb7eac7dee6a9c9 ]
There is an use-after-free problem triggered by following process:
P1(sda) P2(sdb)
echo 0 > /sys/block/sdb/trace/enable
blk_trace_remove_queue
synchronize_rcu blk_trace_free
relay_closercu_read_lock__blk_add_trace
trace_note_tsk
(Iterate running_trace_list)
relay_close_buf
relay_destroy_buf
kfree(buf)
trace_note(sdb's bt)
relay_reserve
buf->offset <- nullptr deference (use-after-free) !!!rcu_read_unlock
[ 502.714379] BUG: kernel NULL pointer dereference, address: 0000000000000010 [ 502.715260] #PF: supervisor read access in kernel mode [ 502.715903] #PF: error_code(0x0000) - not-present page [ 502.716546] PGD 103984067 P4D 103984067 PUD 17592b067 PMD 0 [ 502.717252] Oops: 0000 [#1] SMP [ 502.720308] RIP: 0010:trace_note.isra.0+0x86/0x360 [ 502.732872] Call Trace: [ 502.733193] __blk_add_trace.cold+0x137/0x1a3 [ 502.733734] blk_add_trace_rq+0x7b/0xd0 [ 502.734207] blk_add_trace_rq_issue+0x54/0xa0 [ 502.734755] blk_mq_start_request+0xde/0x1b0 [ 502.735287] scsi_queue_rq+0x528/0x1140 ... [ 502.742704] sg_new_write.isra.0+0x16e/0x3e0 [ 502.747501] sg_ioctl+0x466/0x1100
Reproduce method:
ioctl(/dev/sda, BLKTRACESETUP, blk_user_trace_setup[buf_size=127]) ioctl(/dev/sda, BLKTRACESTART)
ioctl(/dev/sdb, BLKTRACESETUP, blk_user_trace_setup[buf_size=127]) ioctl(/dev/sdb, BLKTRACESTART)
echo 0 > /sys/block/sdb/trace/enable &
// Add delay(mdelay/msleep) before kernel enters blk_trace_free()
ioctl$SG_IO(/dev/sda, SG_IO, ...)
// Enters trace_note_tsk() after blk_trace_free() returned // Use mdelay in rcu region rather than msleep(which may schedule out)
Remove blk_trace from running_list before calling blk_trace_free() by sysfs if blk_trace is at Blktrace_running state.
--- kernel/trace/blktrace.c | 8 ++++++++ 1 file changed, 8 insertions(+)
kernel/trace/blktrace.c +8 -0
@@ -1670,6 +1670,14 @@ static int blk_trace_remove_queue(struct request_queue *q)if (bt ==NULL )return -EINVAL ; +if (bt->trace_state == Blktrace_running) { + bt->trace_state = Blktrace_stopped; +spin_lock_irq (&running_trace_lock); +list_del_init (&bt->running_list); +spin_unlock_irq (&running_trace_lock); +relay_flush (bt->rchan); + } +put_probe_ref ();synchronize_rcu ();blk_trace_free (bt);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 73/103 net: phylink: Update SFP selected interface on advertising changes
In reply to Greg Kroah-HartmanFrom: Nathan Rossi <[email protected]>
[ Upstream commit ea269a6f720782ed94171fb962b14ce07c372138 ]
Currently changes to the advertising state via ethtool do not cause any reselection of the configured interface mode after the SFP is already inserted and initially configured.
While it is not typical to change the advertised link modes for an interface using an SFP in certain use cases it is desirable. In the case of a SFP port that is capable of handling both SFP and SFP+ modules it will automatically select between 1G and 10G modes depending on the supported mode of the SFP. However if the SFP module is capable of working in multiple modes (e.g. a SFP+ DAC that can operate at 1G or 10G), one end of the cable may be attached to a SFP 1000base-x port thus the SFP+ end must be manually configured to the 1000base-x mode in order for the link to be established.
This change causes the ethtool setting of advertised mode changes to reselect the interface mode so that the link can be established. Additionally when a module is inserted the advertising mode is reset to match the supported modes of the module.
--- drivers/net/phy/phylink.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)
drivers/net/phy/phylink.c +29 -1
@@ -1493,6 +1493,32 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,if (config.an_enabled &&phylink_is_empty_linkmode (config.advertising))return -EINVAL ; +/* If this link is with an SFP, ensure that changes to advertised modes +* also cause the associated interface to be selected such that the +* link can be configured correctly. +*/ +if (pl->sfp_port && pl->sfp_bus) { + config.interface =sfp_select_interface (pl->sfp_bus, + config.advertising); +if (config.interface ==PHY_INTERFACE_MODE_NA ) { +phylink_err (pl, +"selection of interface failed, advertisement %*pb\n" , + __ETHTOOL_LINK_MODE_MASK_NBITS, + config.advertising); +return -EINVAL ; + } + +/* Revalidate with the selected interface */ +linkmode_copy (support, pl->supported); +if (phylink_validate (pl, support, &config)) { +phylink_err (pl,"validation of %s/%s with support %*pb failed\n" , +phylink_an_mode_str (pl->cur_link_an_mode), +phy_modes (config.interface), + __ETHTOOL_LINK_MODE_MASK_NBITS, support); +return -EINVAL ; + } + } +mutex_lock (&pl->state_mutex); pl->link_config.speed = config.speed; pl->link_config.duplex = config.duplex;
@@ -2072,7 +2098,9 @@ static int phylink_sfp_config(struct phylink *pl, u8 mode,if (phy_interface_mode_is_8023z (iface) && pl->phydev)return -EINVAL ; - changed = !linkmode_equal (pl->supported, support); + changed = !linkmode_equal (pl->supported, support) || + !linkmode_equal (pl->link_config.advertising, + config.advertising);if (changed) {linkmode_copy (pl->supported, support);linkmode_copy (pl->link_config.advertising, config.advertising);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 74/103 net: macb: fix use after free on rmmod
In reply to Greg Kroah-HartmanFrom: Tong Zhang <[email protected]>
[ Upstream commit d82d5303c4c539db86588ffb5dc5b26c3f1513e8 ]
plat_dev->dev->platform_data is released by platform_device_unregister(), use of pclk and hclk is a use-after-free. Since device unregister won't need a clk device we adjust the function call sequence to fix this issue.
[ 31.261225] BUG: KASAN: use-after-free in macb_remove+0x77/0xc6 [macb_pci] [ 31.275563] Freed by task 306: [ 30.276782] platform_device_release+0x25/0x80
--- drivers/net/ethernet/cadence/macb_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/cadence/macb_pci.c +1 -1
@@ -111,9 +111,9 @@ static void macb_remove(struct pci_dev *pdev)struct platform_device *plat_dev =pci_get_drvdata (pdev);struct macb_platform_data *plat_data =dev_get_platdata (&plat_dev->dev); -platform_device_unregister (plat_dev);clk_unregister (plat_data->pclk);clk_unregister (plat_data->hclk); +platform_device_unregister (plat_dev); }static const struct pci_device_id dev_id_table[] = {
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 57/103 fpga: machxo2-spi: Return an error on failure
In reply to Greg Kroah-HartmanFrom: Tom Rix <[email protected]>
[ Upstream commit 34331739e19fd6a293d488add28832ad49c9fc54 ]
Earlier successes leave 'ret' in a non error state, so these errors are not reported. Set ret to -EINVAL before going to the error handler.
This addresses two issues reported by smatch:drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
warn: missing error code 'ret'
drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
warn: missing error code 'ret'
--- drivers/fpga/machxo2-spi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/fpga/machxo2-spi.c +4 -1
@@ -225,8 +225,10 @@ static int machxo2_write_init(struct fpga_manager *mgr, goto fail;get_status (spi, &status); -if (test_bit (FAIL , &status)) +if (test_bit (FAIL , &status)) { + ret = -EINVAL ; goto fail; + }dump_status_reg (&status);spi_message_init (&msg);
@@ -313,6 +315,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,dump_status_reg (&status);if (!test_bit (DONE , &status)) {machxo2_cleanup (mgr); + ret = -EINVAL ; goto fail; }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 75/103 net: stmmac: allow CSR clock of 300MHz
In reply to Greg Kroah-HartmanFrom: Jesper Nilsson <[email protected]>
[ Upstream commit 08dad2f4d541fcfe5e7bfda72cc6314bbfd2802f ]
The Synopsys Ethernet IP uses the CSR clock as a base clock for MDC. The divisor used is set in the MAC_MDIO_Address register field CR (Clock Rate)
The divisor is there to change the CSR clock into a clock that falls below the IEEE 802.3 specified max frequency of 2.5MHz.
If the CSR clock is 300MHz, the code falls back to using the reset value in the MAC_MDIO_Address register, as described in the comment above this code.
However, 300MHz is actually an allowed value and the proper divider can be estimated quite easily (it's just 1Hz difference!)
A CSR frequency of 300MHz with the maximum clock rate value of 0x5 (STMMAC_CSR_250_300M, a divisor of 124) gives somewhere around ~2.42MHz which is below the IEEE 802.3 specified maximum.
For the ARTPEC-8 SoC, the CSR clock is this problematic 300MHz, and unfortunately, the reset-value of the MAC_MDIO_Address CR field is 0x0.
This leads to a clock rate of zero and a divisor of 42, and gives an MDC frequency of ~7.14MHz.
Allow CSR clock of 300MHz by making the comparison inclusive.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -1
@@ -226,7 +226,7 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv) priv->clk_csr =STMMAC_CSR_100_150M ; else if ((clk_rate >= CSR_F_150M) && (clk_rate < CSR_F_250M)) priv->clk_csr = STMMAC_CSR_150_250M; - else if ((clk_rate >= CSR_F_250M) && (clk_rate < CSR_F_300M)) + else if ((clk_rate >= CSR_F_250M) && (clk_rate <= CSR_F_300M)) priv->clk_csr = STMMAC_CSR_250_300M; }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 77/103 m68k: Double cast io functions to unsigned long
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
[ Upstream commit b1a89856fbf63fffde6a4771d8f1ac21df549e50 ]
m68k builds fail widely with errors such as
arch/m68k/include/asm/raw_io.h:20:19: error:
cast to pointer from integer of different sizearch/m68k/include/asm/raw_io.h:30:32: error:
cast to pointer from integer of different size [-Werror=int-to-p
On m68k, io functions are defined as macros. The problem is seen if the macro parameter variable size differs from the size of a pointer. Cast the parameter of all io macros to unsigned long before casting it to a pointer to fix the problem.
--- arch/m68k/include/asm/raw_io.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
arch/m68k/include/asm/raw_io.h +10 -10
@@ -17,21 +17,21 @@* two accesses to memory, which may be undesirable for some devices. */ #define in_8 (addr) \ - ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; }) + ({ u8 __v = (*(__force volatile u8 *) (unsigned long)(addr)); __v; })#define in_be16 (addr) \ - ({ u16 __v = (*(__force volatile u16 *) (addr)); __v; }) + ({ u16 __v = (*(__force volatile u16 *) (unsigned long)(addr)); __v; })#define in_be32 (addr) \ - ({ u32 __v = (*(__force volatile u32 *) (addr)); __v; }) + ({ u32 __v = (*(__force volatile u32 *) (unsigned long)(addr)); __v; })#define in_le16 (addr) \ - ({ u16 __v = le16_to_cpu(*(__force volatile __le16 *) (addr)); __v; }) + ({ u16 __v = le16_to_cpu(*(__force volatile __le16 *) (unsigned long)(addr)); __v; })#define in_le32 (addr) \ - ({ u32 __v = le32_to_cpu(*(__force volatile __le32 *) (addr)); __v; }) + ({ u32 __v = le32_to_cpu(*(__force volatile __le32 *) (unsigned long)(addr)); __v; }) -#define out_8 (addr,b) (void)((*(__force volatile u8 *) (addr)) = (b)) -#define out_be16 (addr,w) (void)((*(__force volatile u16 *) (addr)) = (w)) -#define out_be32 (addr,l) (void)((*(__force volatile u32 *) (addr)) = (l)) -#define out_le16 (addr,w) (void)((*(__force volatile __le16 *) (addr)) = cpu_to_le16(w)) -#define out_le32 (addr,l) (void)((*(__force volatile __le32 *) (addr)) = cpu_to_le32(l)) +#define out_8 (addr,b) (void)((*(__force volatile u8 *) (unsigned long)(addr)) = (b)) +#define out_be16 (addr,w) (void)((*(__force volatile u16 *) (unsigned long)(addr)) = (w)) +#define out_be32 (addr,l) (void)((*(__force volatile u32 *) (unsigned long)(addr)) = (l)) +#define out_le16 (addr,w) (void)((*(__force volatile __le16 *) (unsigned long)(addr)) = cpu_to_le16(w)) +#define out_le32 (addr,l) (void)((*(__force volatile __le32 *) (unsigned long)(addr)) = cpu_to_le32(l))#define raw_inb in_8#define raw_inw in_be16
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 78/103 ipv6: delay fib6_sernum increase in fib6_add
In reply to Greg Kroah-HartmanFrom: zhang kai <[email protected]>
[ Upstream commit e87b5052271e39d62337ade531992b7e5d8c2cfa ]
only increase fib6_sernum in net namespace after add fib6_info successfully.
--- net/ipv6/ip6_fib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/ipv6/ip6_fib.c +1 -2
@@ -1376,7 +1376,6 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,int err = -ENOMEM ;int allow_create =1 ;int replace_required =0 ; -int sernum =fib6_new_sernum (info->nl_net);if (info->nlh) {if (!(info->nlh->nlmsg_flags &NLM_F_CREATE ))
@@ -1476,7 +1475,7 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,if (!err) {if (rt->nh)list_add (&rt->nh_list, &rt->nh->f6i_list); -__fib6_update_sernum_upto_root (rt, sernum); +__fib6_update_sernum_upto_root (rt,fib6_new_sernum (info->nl_net));fib6_start_gc (info->nl_net, rt); }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 79/103 cpufreq: intel_pstate: Override parameters if HWP forced by BIOS
In reply to Greg Kroah-HartmanFrom: Doug Smythies <[email protected]>
[ Upstream commit d9a7e9df731670acdc69e81748941ad338f47fab ]
If HWP has been already been enabled by BIOS, it may be necessary to override some kernel command line parameters. Once it has been enabled it requires a reset to be disabled.
--- drivers/cpufreq/intel_pstate.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +14 -8
@@ -3035,11 +3035,15 @@ static int __init intel_pstate_init(void)if (boot_cpu_data.x86_vendor !=X86_VENDOR_INTEL )return -ENODEV ; -if (no_load) -return -ENODEV ; - id =x86_match_cpu (hwp_support_ids);if (id) { +bool hwp_forced =intel_pstate_hwp_is_enabled (); + +if (hwp_forced) +pr_info ("HWP enabled by BIOS\n" ); +else if (no_load) +return -ENODEV ; +copy_cpu_funcs (&core_funcs);/* * Avoid enabling HWP for processors without EPP support,
@@ -3049,8 +3053,7 @@ static int __init intel_pstate_init(void)* If HWP is enabled already, though, there is no choice but to * deal with it. */ -if ((!no_hwp &&boot_cpu_has (X86_FEATURE_HWP_EPP )) || -intel_pstate_hwp_is_enabled ()) { +if ((!no_hwp &&boot_cpu_has (X86_FEATURE_HWP_EPP )) || hwp_forced) { hwp_active++; hwp_mode_bdw = id->driver_data; intel_pstate.attr = hwp_cpufreq_attrs;
@@ -3061,7 +3064,11 @@ static int __init intel_pstate_init(void) goto hwp_cpu_matched; } +pr_info ("HWP not enabled\n" ); }else { +if (no_load) +return -ENODEV ; + id =x86_match_cpu (intel_pstate_cpu_ids);if (!id) {pr_info ("CPU model not supported\n" );
@@ -3138,10 +3145,9 @@ static int __init intel_pstate_setup(char *str)else if (!strcmp (str,"passive" )) default_driver = &intel_cpufreq; -if (!strcmp (str,"no_hwp" )) { -pr_info ("HWP disabled\n" ); +if (!strcmp (str,"no_hwp" )) no_hwp =1 ; - } +if (!strcmp (str,"force" )) force_load =1 ;if (!strcmp (str,"hwp_only" ))
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 80/103 bpf: Add oversize check before call kvcalloc()
In reply to Greg Kroah-HartmanFrom: Bixuan Cui <[email protected]>
[ Upstream commit 0e6491b559704da720f6da09dd0a52c4df44c514 ]
Commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") add the oversize check. When the allocation is larger than what kmalloc() supports, the following warning triggered:
WARNING: CPU: 0 PID: 8408 at mm/util.c:597 kvmalloc_node+0x108/0x110 mm/util.c:597 Modules linked in: CPU: 0 PID: 8408 Comm: syz-executor221 Not tainted 5.14.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:kvmalloc_node+0x108/0x110 mm/util.c:597 Call Trace: kvmalloc include/linux/mm.h:806 [inline] kvmalloc_array include/linux/mm.h:824 [inline] kvcalloc include/linux/mm.h:829 [inline] check_btf_line kernel/bpf/verifier.c:9925 [inline] check_btf_info kernel/bpf/verifier.c:10049 [inline] bpf_check+0xd634/0x150d0 kernel/bpf/verifier.c:13759 bpf_prog_load kernel/bpf/syscall.c:2301 [inline] __sys_bpf+0x11181/0x126e0 kernel/bpf/syscall.c:4587 __do_sys_bpf kernel/bpf/syscall.c:4691 [inline] __se_sys_bpf kernel/bpf/syscall.c:4689 [inline] __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4689 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae
--- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/bpf/verifier.c +2 -0
@@ -8822,6 +8822,8 @@ static int check_btf_line(struct bpf_verifier_env *env, nr_linfo = attr->line_info_cnt;if (!nr_linfo)return 0 ; +if (nr_linfo >INT_MAX /sizeof (struct bpf_line_info )) +return -EINVAL ; rec_size = attr->line_info_rec_size; if (rec_size < MIN_BPF_LINEINFO_SIZE ||
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 44/103 net: dsa: realtek: register the MDIO bus under devres
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
[ Upstream commit 74b6d7d13307b016f4b5bba8198297824c0ee6df ]
The Linux device model permits both the ->shutdown and ->remove driver methods to get called during a shutdown procedure. Example: a DSA switch which sits on an SPI bus, and the SPI bus driver calls this on its ->shutdown method:
spi_unregister_controller
-> device_for_each_child(&ctlr->dev, NULL, __unregister);
-> spi_unregister_device(to_spi_device(dev));
-> device_del(&spi->dev);So this is a simple pattern which can theoretically appear on any bus, although the only other buses on which I've been able to find it are I2C:
i2c_del_adapter
-> device_for_each_child(&adap->dev, NULL, __unregister_client);
-> i2c_unregister_device(client);
-> device_unregister(&client->dev);The implication of this pattern is that devices on these buses can be unregistered after having been shut down. The drivers for these devices might choose to return early either from ->remove or ->shutdown if the other callback has already run once, and they might choose that the ->shutdown method should only perform a subset of the teardown done by ->remove (to avoid unnecessary delays when rebooting).
So in other words, the device driver may choose on ->remove to not do anything (therefore to not unregister an MDIO bus it has registered on ->probe), because this ->remove is actually triggered by the device_shutdown path, and its ->shutdown method has already run and done the minimally required cleanup.
This used to be fine until the blamed commit, but now, the following BUG_ON triggers:
void mdiobus_free(struct mii_bus *bus)
{
/* For compatibility with error handling in drivers. */
if (bus->state == MDIOBUS_ALLOCATED) {
kfree(bus);
return;
}
BUG_ON(bus->state != MDIOBUS_UNREGISTERED);
bus->state = MDIOBUS_RELEASED;
put_device(&bus->dev);
}In other words, there is an attempt to free an MDIO bus which was not unregistered. The attempt to free it comes from the devres release callbacks of the SPI device, which are executed after the device is unregistered.
I'm not saying that the fact that MDIO buses allocated using devres would automatically get unregistered wasn't strange. I'm just saying that the commit didn't care about auditing existing call paths in the kernel, and now, the following code sequences are potentially buggy:
(a) devm_mdiobus_alloc followed by plain mdiobus_register, for a device located on a bus that unregisters its children on shutdown. After the blamed patch, either both the alloc and the register should use devres, or none should.
(b) devm_mdiobus_alloc followed by plain mdiobus_register, and then no mdiobus_unregister at all in the remove path. After the blamed patch, nobody unregisters the MDIO bus anymore, so this is even more buggy than the previous case which needs a specific bus configuration to be seen, this one is an unconditional bug.
In this case, the Realtek drivers fall under category (b). To solve it, we can register the MDIO bus under devres too, which restores the previous behavior.
--- drivers/net/dsa/realtek-smi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/realtek-smi-core.c +1 -1
@@ -368,7 +368,7 @@ int realtek_smi_setup_mdio(struct realtek_smi *smi) smi->slave_mii_bus->parent = smi->dev; smi->ds->slave_mii_bus = smi->slave_mii_bus; - ret =of_mdiobus_register (smi->slave_mii_bus, mdio_np); + ret =devm_of_mdiobus_register (smi->dev, smi->slave_mii_bus, mdio_np);if (ret) {dev_err (smi->dev,"unable to register MDIO bus %s\n" , smi->slave_mii_bus->id);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 45/103 kselftest/arm64: signal: Add SVE to the set of features we can check for
In reply to Greg Kroah-HartmanFrom: Mark Brown <[email protected]>
[ Upstream commit d4e4dc4fab686c5f3f185272a19b83930664bef5 ]
Allow testcases for SVE signal handling to flag the dependency and be skipped on systems without SVE support.
--- tools/testing/selftests/arm64/signal/test_signals.h | 2 ++ tools/testing/selftests/arm64/signal/test_signals_utils.c | 3 +++ 2 files changed, 5 insertions(+)
tools/testing/selftests/arm64/signal/test_signals.h +2 -0
@@ -33,10 +33,12 @@*/ enum {FSSBS_BIT , +FSVE_BIT ,FMAX_END };#define FEAT_SSBS (1UL << FSSBS_BIT) +#define FEAT_SVE (1UL << FSVE_BIT)/* * A descriptor used to describe and configure a test case.
tools/testing/selftests/arm64/signal/test_signals_utils.c +3 -0
@@ -26,6 +26,7 @@ static int sig_copyctx = SIGTRAP;static char const *const feats_names[FMAX_END ] = {" SSBS " , +" SVE " , };#define MAX_FEATS_SZ 128
@@ -263,6 +264,8 @@ int test_init(struct tdescr *td)*/ if (getauxval (AT_HWCAP ) &HWCAP_SSBS ) td->feats_supported |=FEAT_SSBS ; +if (getauxval (AT_HWCAP ) &HWCAP_SVE ) + td->feats_supported |=FEAT_SVE ;if (feats_ok (td)) fprintf(stderr, "Required Features: [%s] supported\n",
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 23/103 mcb: fix error handling in mcb_alloc_bus()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
commit 25a1433216489de4abc889910f744e952cb6dbae upstream.
There are two bugs:
1) If ida_simple_get() fails then this code calls put_device(carrier) but we haven't yet called get_device(carrier) and probably that leads to a use after free.
2) After device_initialize() then we need to use put_device() to release the bus. This will free the internal resources tied to the device and call mcb_free_bus() which will free the rest.
--- drivers/mcb/mcb-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/mcb/mcb-core.c +6 -6
@@ -277,8 +277,8 @@ struct mcb_bus *mcb_alloc_bus(struct dev bus_nr =ida_simple_get (&mcb_ida,0 ,0 ,GFP_KERNEL );if (bus_nr <0 ) { - rc = bus_nr; - goto err_free; +kfree (bus); +return ERR_PTR (bus_nr); } bus->bus_nr = bus_nr;
@@ -293,12 +293,12 @@ struct mcb_bus *mcb_alloc_bus(struct devdev_set_name (&bus->dev,"mcb:%d" , bus_nr); rc =device_add (&bus->dev);if (rc) - goto err_free; + goto err_put;return bus; -err_free: -put_device (carrier); -kfree (bus); + +err_put: +put_device (&bus->dev);return ERR_PTR (rc); }EXPORT_SYMBOL_NS_GPL (mcb_alloc_bus,MCB );
Greg Kroah-Hartman
maintainerPATCH 47/103 s390/qeth: fix NULL deref in qeth_clear_working_pool_list()
In reply to Greg Kroah-HartmanFrom: Julian Wiedmann <[email protected]>
[ Upstream commit 248f064af222a1f97ee02c84a98013dfbccad386 ]
When qeth_set_online() calls qeth_clear_working_pool_list() to roll back after an error exit from qeth_hardsetup_card(), we are at risk of accessing card->qdio.in_q before it was allocated by qeth_alloc_qdio_queues() via qeth_mpc_initialize().
qeth_clear_working_pool_list() then dereferences NULL, and by writing to queue->bufs[i].pool_entry scribbles all over the CPU's lowcore. Resulting in a crash when those lowcore areas are used next (eg. on the next machine-check interrupt).
Such a scenario would typically happen when the device is first set online and its queues aren't allocated yet. An early IO error or certain misconfigs (eg. mismatched transport mode, bad portno) then cause us to error out from qeth_hardsetup_card() with card->qdio.in_q still being NULL.
Fix it by checking the pointer for NULL before accessing it.
Note that we also have (rare) paths inside qeth_mpc_initialize() where a configuration change can cause us to free the existing queues, expecting that subsequent code will allocate them again. If we then error out before that re-allocation happens, the same bug occurs.
--- drivers/s390/net/qeth_core_main.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/s390/net/qeth_core_main.c +3 -0
@@ -210,6 +210,9 @@ static void qeth_clear_working_pool_list(struct qeth_card *card) &card->qdio.in_buf_pool.entry_list, list)list_del (&pool_entry->list); +if (!queue) +return ; +for (i =0 ; i <ARRAY_SIZE (queue->bufs); i++) queue->bufs[i].pool_entry =NULL ; }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 49/103 gpio: uniphier: Fix void functions to remove return value
In reply to Greg Kroah-HartmanFrom: Kunihiko Hayashi <[email protected]>
[ Upstream commit 2dd824cca3407bc9a2bd11b00f6e117b66fcfcf1 ]
The return type of irq_chip.irq_mask() and irq_chip.irq_unmask() should be void.
--- drivers/gpio/gpio-uniphier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-uniphier.c +2 -2
@@ -184,7 +184,7 @@ static void uniphier_gpio_irq_mask(struct irq_data *data)uniphier_gpio_reg_update (priv,UNIPHIER_GPIO_IRQ_EN , mask,0 ); -return irq_chip_mask_parent (data); +irq_chip_mask_parent (data); }static void uniphier_gpio_irq_unmask (struct irq_data *data)
@@ -194,7 +194,7 @@ static void uniphier_gpio_irq_unmask(struct irq_data *data)uniphier_gpio_reg_update (priv,UNIPHIER_GPIO_IRQ_EN , mask, mask); -return irq_chip_unmask_parent (data); +irq_chip_unmask_parent (data); }static int uniphier_gpio_irq_set_type (struct irq_data *data,unsigned int type)
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 26/103 xhci: Set HCD flag to defer primary roothub registration
In reply to Greg Kroah-HartmanFrom: Kishon Vijay Abraham I <[email protected]>
commit b7a0a792f864583207c593b50fd1b752ed89f4c1 upstream.
Set "HCD_FLAG_DEFER_RH_REGISTER" to hcd->flags in xhci_run() to defer registering primary roothub in usb_add_hcd(). This will make sure both primary roothub and secondary roothub will be registered along with the second HCD. This is required for cold plugged USB devices to be detected in certain PCIe USB cards (like Inateck USB card connected to AM64 EVM or J7200 EVM).
--- drivers/usb/host/xhci.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/host/xhci.c +1 -0
@@ -693,6 +693,7 @@ int xhci_run(struct usb_hcd *hcd)if (ret)xhci_free_command (xhci, command); } +set_bit (HCD_FLAG_DEFER_RH_REGISTER , &hcd->flags);xhci_dbg_trace (xhci, trace_xhci_dbg_init,"Finished xhci_run for USB2 roothub" );
Greg Kroah-Hartman
maintainerPATCH 52/103 atlantic: Fix issue in the pm resume flow.
In reply to Greg Kroah-HartmanFrom: Sudarsana Reddy Kalluru <[email protected]>
[ Upstream commit 4d88c339c423eefe2fd48215016cb0c75fcb4c4d ]
After fixing hibernation resume flow, another usecase was found which should be explicitly handled - resume when device is in "down" state. Invoke aq_nic_init jointly with aq_nic_start only if ndev was already up during suspend/hibernate. We still need to perform nic_deinit() if caller requests for it, to handle the freeze/resume scenarios.
--- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +2 -2
@@ -419,13 +419,13 @@ static int atl_resume_common(struct device *dev, bool deep)if (deep) {/* Reinitialize Nic/Vecs objects */ aq_nic_deinit (nic, !nic->aq_hw->aq_nic_cfg->wol); + } +if (netif_running (nic->ndev)) { ret =aq_nic_init (nic);if (ret) goto err_exit; - } -if (netif_running (nic->ndev)) { ret =aq_nic_start (nic);if (ret) goto err_exit;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 68/103 md: fix a lock order reversal in md_alloc
In reply to Greg Kroah-HartmanFrom: Christoph Hellwig <[email protected]>
[ Upstream commit 7df835a32a8bedf7ce88efcfa7c9b245b52ff139 ]
Commit b0140891a8cea3 ("md: Fix race when creating a new md device.") not only moved assigning mddev->gendisk before calling add_disk, which fixes the races described in the commit log, but also added a mddev->open_mutex critical section over add_disk and creation of the md kobj. Adding a kobject after add_disk is racy vs deleting the gendisk right after adding it, but md already prevents against that by holding a mddev->active reference.
On the other hand taking this lock added a lock order reversal with what is not disk->open_mutex (used to be bdev->bd_mutex when the commit was added) for partition devices, which need that lock for the internal open for the partition scan, and a recent commit also takes it for non-partitioned devices, leading to further lockdep splatter.
--- drivers/md/md.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/md/md.c +0 -5
@@ -5759,10 +5759,6 @@ static int md_alloc(dev_t dev, char *name) disk->flags |=GENHD_FL_EXT_DEVT ; disk->events |=DISK_EVENT_MEDIA_CHANGE ; mddev->gendisk = disk; -/* As soon as we call add_disk(), another thread could get -* through to md_open, so make sure it doesn't get too far -*/ -mutex_lock (&mddev->open_mutex);add_disk (disk); error =kobject_add (&mddev->kobj, &disk_to_dev (disk)->kobj,"%s" ,"md" );
@@ -5777,7 +5773,6 @@ static int md_alloc(dev_t dev, char *name)if (mddev->kobj.sd &&sysfs_create_group (&mddev->kobj, &md_bitmap_group))pr_debug ("pointless warning\n" ); -mutex_unlock (&mddev->open_mutex); abort:mutex_unlock (&disks_mutex);if (!error && mddev->kobj.sd) {
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 70/103 x86/asm: Fix SETZ size enqcmds() build failure
In reply to Greg Kroah-HartmanFrom: Kees Cook <[email protected]>
[ Upstream commit d81ff5fe14a950f53e2833cfa196e7bb3fd5d4e3 ]
When building under GCC 4.9 and 5.5:
arch/x86/include/asm/special_insns.h: Assembler messages:
arch/x86/include/asm/special_insns.h:286: Error: operand size mismatch for `setz'
Change the type to "bool" for condition code arguments, as documented.
--- arch/x86/include/asm/special_insns.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/special_insns.h +1 -1
@@ -287,7 +287,7 @@ static inline int enqcmds(void __iomem *dst, const void *src) {const struct {char _[64 ]; } *__src = src;struct {char _[64 ]; }__iomem *__dst = dst; -int zf; +bool zf;/* * ENQCMDS %(rdx), rax
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 71/103 io_uring: put provided buffer meta data under memcg accounting
In reply to Greg Kroah-HartmanFrom: Jens Axboe <[email protected]>
[ Upstream commit 9990da93d2bf9892c2c14c958bef050d4e461a1a ]
For each provided buffer, we allocate a struct io_buffer to hold the data associated with it. As a large number of buffers can be provided, account that data with memcg.
--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/io_uring.c +1 -1
@@ -4041,7 +4041,7 @@ static int io_add_buffers(struct io_provide_buf *pbuf, struct io_buffer **head)int i, bid = pbuf->bid;for (i =0 ; i < pbuf->nbufs; i++) { - buf =kmalloc (sizeof (*buf),GFP_KERNEL ); + buf =kmalloc (sizeof (*buf),GFP_KERNEL_ACCOUNT );if (!buf)break ;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 81/103 xen/balloon: use a kernel thread instead a workqueue
In reply to Greg Kroah-HartmanFrom: Juergen Gross <[email protected]>
[ Upstream commit 8480ed9c2bbd56fc86524998e5f2e3e22f5038f6 ]
Today the Xen ballooning is done via delayed work in a workqueue. This might result in workqueue hangups being reported in case of large amounts of memory are being ballooned in one go (here 16GB):
BUG: workqueue lockup - pool cpus=6 node=0 flags=0x0 nice=0 stuck for 64s!
Showing busy workqueues and worker pools:
workqueue events: flags=0x0
pwq 12: cpus=6 node=0 flags=0x0 nice=0 active=2/256 refcnt=3
in-flight: 229:balloon_process
pending: cache_reap
workqueue events_freezable_power_: flags=0x84
pwq 12: cpus=6 node=0 flags=0x0 nice=0 active=1/256 refcnt=2
pending: disk_events_workfn
workqueue mm_percpu_wq: flags=0x8
pwq 12: cpus=6 node=0 flags=0x0 nice=0 active=1/256 refcnt=2
pending: vmstat_update
pool 12: cpus=6 node=0 flags=0x0 nice=0 hung=64s workers=3 idle: 2222 43
This can easily be avoided by using a dedicated kernel thread for doing the ballooning work.
--- drivers/xen/balloon.c | 62 +++++++++++++++++++++++++++++++------------ 1 file changed, 45 insertions(+), 17 deletions(-)
drivers/xen/balloon.c +45 -17
@@ -43,6 +43,8 @@#include <linux/sched.h> #include <linux/cred.h> #include <linux/errno.h> +#include <linux/freezer.h> +#include <linux/kthread.h> #include <linux/mm.h> #include <linux/memblock.h> #include <linux/pagemap.h>
@@ -115,7 +117,7 @@ static struct ctl_table xen_root[] = {#define EXTENT_ORDER (fls(XEN_PFN_PER_PAGE) - 1)/* -* balloon_process() state: +* balloon_thread() state: * * BP_DONE: done or nothing to do, * BP_WAIT: wait to be rescheduled,
@@ -130,6 +132,8 @@ enum bp_state { BP_ECANCELED }; +/* Main waiting point for xen-balloon thread. */ +static DECLARE_WAIT_QUEUE_HEAD (balloon_thread_wq);static DEFINE_MUTEX (balloon_mutex);
@@ -144,10 +148,6 @@ static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)];static LIST_HEAD (ballooned_pages);static DECLARE_WAIT_QUEUE_HEAD (balloon_wq); -/* Main work function, always executed in process context. */ -static void balloon_process (struct work_struct *work); -static DECLARE_DELAYED_WORK(balloon_worker, balloon_process); -/* When ballooning out (allocating memory to return to Xen) we don't really want the kernel to try too hard since that can trigger the oom killer. */ #define GFP_BALLOON \
@@ -366,7 +366,7 @@ static void xen_online_page(struct page *page, unsigned int order)static int xen_memory_notifier (struct notifier_block *nb,unsigned long val,void *v) {if (val ==MEM_ONLINE ) -schedule_delayed_work (&balloon_worker,0 ); +wake_up (&balloon_thread_wq);return NOTIFY_OK ; }
@@ -491,18 +491,43 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp) }/* -* As this is a work item it is guaranteed to run as a single instance only. +* Stop waiting if either state is not BP_EAGAIN and ballooning action is +* needed, or if the credit has changed while state is BP_EAGAIN. +*/ +static bool balloon_thread_cond (enum bp_state state,long credit) +{ +if (state !=BP_EAGAIN ) + credit =0 ; + +return current_credit () != credit ||kthread_should_stop (); +} + +/* +* As this is a kthread it is guaranteed to run as a single instance only. * We may of course race updates of the target counts (which are protected * by the balloon lock), or with changes to the Xen hard limit, but we will * recover from these in time. */ -static void balloon_process (struct work_struct *work) +static int balloon_thread (void *unused) {enum bp_state state =BP_DONE ;long credit; +unsigned long timeout; + +set_freezable (); +for (;;) { +if (state ==BP_EAGAIN ) + timeout = balloon_stats.schedule_delay *HZ ; +else + timeout =3600 *HZ ; + credit =current_credit (); +wait_event_interruptible_timeout (balloon_thread_wq, +balloon_thread_cond (state, credit), timeout); + +if (kthread_should_stop ()) +return 0 ; - do {mutex_lock (&balloon_mutex); credit =current_credit ();
@@ -529,12 +554,7 @@ static void balloon_process(struct work_struct *work)mutex_unlock (&balloon_mutex);cond_resched (); - - }while (credit && state ==BP_DONE ); - -/* Schedule more work if there is some still to be done. */ -if (state ==BP_EAGAIN ) -schedule_delayed_work (&balloon_worker, balloon_stats.schedule_delay *HZ ); + } }/* Resets the Xen limit, sets new target, and kicks off processing. */
@@ -542,7 +562,7 @@ void balloon_set_new_target(unsigned long target) {/* No need for lock. Not read-modify-write updates. */ balloon_stats.target_pages = target; -schedule_delayed_work (&balloon_worker,0 ); +wake_up (&balloon_thread_wq); }EXPORT_SYMBOL_GPL (balloon_set_new_target);
@@ -647,7 +667,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)/* The balloon may be too large now. Shrink it if needed. */ if (current_credit ()) -schedule_delayed_work (&balloon_worker,0 ); +wake_up (&balloon_thread_wq);mutex_unlock (&balloon_mutex); }
@@ -679,6 +699,8 @@ static void __init balloon_add_region(unsigned long start_pfn,static int __init balloon_init (void ) { +struct task_struct *task; +if (!xen_domain ())return -ENODEV ;
@@ -722,6 +744,12 @@ static int __init balloon_init(void) }#endif + task =kthread_run (balloon_thread,NULL ,"xen-balloon" ); +if (IS_ERR (task)) { +pr_err ("xen-balloon thread could not be started, ballooning will not work!\n" ); +return PTR_ERR (task); + } +/* Init the xen-balloon driver. */ xen_balloon_init ();
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 82/103 nvme-multipath: fix ANA state updates when a namespace is not present
In reply to Greg Kroah-HartmanFrom: Anton Eidelman <[email protected]>
[ Upstream commit 79f528afa93918519574773ea49a444c104bc1bd ]
nvme_update_ana_state() has a deficiency that results in a failure to properly update the ana state for a namespace in the following case:
NSIDs in ctrl->namespaces: 1, 3, 4
NSIDs in desc->nsids: 1, 2, 3, 4
Loop iteration 0:
ns index = 0, n = 0, ns->head->ns_id = 1, nsid = 1, MATCH.
Loop iteration 1:
ns index = 1, n = 1, ns->head->ns_id = 3, nsid = 2, NO MATCH.
Loop iteration 2:
ns index = 2, n = 2, ns->head->ns_id = 4, nsid = 4, MATCH.Where the update to the ANA state of NSID 3 is missed. To fix this increment n and retry the update with the same ns when ns->head->ns_id is higher than nsid,
--- drivers/nvme/host/multipath.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/nvme/host/multipath.c +5 -2
@@ -509,14 +509,17 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,down_read (&ctrl->namespaces_rwsem);list_for_each_entry (ns, &ctrl->namespaces, list) { -unsigned nsid =le32_to_cpu (desc->nsids[n]); - +unsigned nsid; +again: + nsid =le32_to_cpu (desc->nsids[n]);if (ns->head->ns_id < nsid)continue ;if (ns->head->ns_id == nsid)nvme_update_ns_ana_state (desc, ns);if (++n == nr_nsids)break ; +if (ns->head->ns_id > nsid) + goto again; }up_read (&ctrl->namespaces_rwsem);return 0 ;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 83/103 nvme-rdma: destroy cm id before destroy qp to avoid use after free
In reply to Greg Kroah-HartmanFrom: Ruozhu Li <[email protected]>
[ Upstream commit 9817d763dbe15327b9b3ff4404fa6f27f927e744 ]
We should always destroy cm_id before destroy qp to avoid to get cma event after qp was destroyed, which may lead to use after free. In RDMA connection establishment error flow, don't destroy qp in cm event handler.Just report cm_error to upper level, qp will be destroy in nvme_rdma_alloc_queue() after destroy cm id.
--- drivers/nvme/host/rdma.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
drivers/nvme/host/rdma.c +3 -13
@@ -655,8 +655,8 @@ static void nvme_rdma_free_queue(struct nvme_rdma_queue *queue)if (!test_and_clear_bit (NVME_RDMA_Q_ALLOCATED , &queue->flags))return ; -nvme_rdma_destroy_queue_ib (queue);rdma_destroy_id (queue->cm_id); +nvme_rdma_destroy_queue_ib (queue);mutex_destroy (&queue->queue_lock); }
@@ -1823,14 +1823,10 @@ static int nvme_rdma_conn_established(struct nvme_rdma_queue *queue)for (i =0 ; i < queue->queue_size; i++) { ret =nvme_rdma_post_recv (queue, &queue->rsp_ring[i]);if (ret) - goto out_destroy_queue_ib; +return ret; }return 0 ; - -out_destroy_queue_ib: -nvme_rdma_destroy_queue_ib (queue); -return ret; } static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
@@ -1924,14 +1920,10 @@ static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)if (ret) {dev_err (ctrl->ctrl.device,"rdma_connect_locked failed (%d).\n" , ret); - goto out_destroy_queue_ib; +return ret; }return 0 ; - -out_destroy_queue_ib: -nvme_rdma_destroy_queue_ib (queue); -return ret; } static int nvme_rdma_cm_handler(struct rdma_cm_id *cm_id,
@@ -1962,8 +1954,6 @@ static int nvme_rdma_cm_handler(struct rdma_cm_id *cm_id,case RDMA_CM_EVENT_ROUTE_ERROR :case RDMA_CM_EVENT_CONNECT_ERROR :case RDMA_CM_EVENT_UNREACHABLE : -nvme_rdma_destroy_queue_ib (queue); - fallthrough;case RDMA_CM_EVENT_ADDR_ERROR :dev_dbg (queue->ctrl->ctrl.device,"CM error event %d\n" , ev->event);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 84/103 sparc32: page align size in arch_dma_alloc
In reply to Greg Kroah-HartmanFrom: Andreas Larsson <[email protected]>
[ Upstream commit 59583f747664046aaae5588d56d5954fab66cce8 ]
Commit 53b7670e5735 ("sparc: factor the dma coherent mapping into helper") lost the page align for the calls to dma_make_coherent and srmmu_unmapiorange. The latter cannot handle a non page aligned len argument.
--- arch/sparc/kernel/ioport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/sparc/kernel/ioport.c +3 -1
@@ -356,7 +356,9 @@ err_nomem:void arch_dma_free (struct device *dev,size_t size,void *cpu_addr,dma_addr_t dma_addr,unsigned long attrs) { -if (!sparc_dma_free_resource (cpu_addr,PAGE_ALIGN (size))) + size =PAGE_ALIGN (size); + +if (!sparc_dma_free_resource (cpu_addr, size))return ;dma_make_coherent (dma_addr, size);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 58/103 fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
In reply to Greg Kroah-HartmanFrom: Jiapeng Chong <[email protected]>
[ Upstream commit a1e4470823d99e75b596748086e120dea169ed3c ]
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'.
Eliminate the follow smatch warning:
drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
warn: missing error code 'ret'.
--- drivers/fpga/machxo2-spi.c | 1 + 1 file changed, 1 insertion(+)
drivers/fpga/machxo2-spi.c +1 -0
@@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,break ;if (++refreshloop ==MACHXO2_MAX_REFRESH_LOOP ) {machxo2_cleanup (mgr); + ret = -EINVAL ; goto fail; } }while (1 );
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 85/103 amd/display: downgrade validation failure log level
In reply to Greg Kroah-HartmanFrom: Simon Ser <[email protected]>
[ Upstream commit 7bbee36d71502ab9a341505da89a017c7ae2e6b2 ]
In amdgpu_dm_atomic_check, dc_validate_global_state is called. On failure this logs a warning to the kernel journal. However warnings shouldn't be used for atomic test-only commit failures: user-space might be perfoming a lot of atomic test-only commits to find the best hardware configuration.
Downgrade the log to a regular DRM atomic message. While at it, use the new device-aware logging infrastructure.
This fixes error messages in the kernel when running gamescope [1].
[1]: https://github.com/Plagman/gamescope/issues/245
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -8962,7 +8962,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev, goto fail; status =dc_validate_global_state (dc, dm_state->context, false);if (status !=DC_OK ) { -DC_LOG_WARNING ("DC global validation failure: %s (%d)" , +drm_dbg_atomic (dev, +"DC global validation failure: %s (%d)" ,dc_status_to_str (status), status); ret = -EINVAL ; goto fail;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 86/103 block: check if a profile is actually registered in blk_integrity_unregister
In reply to Greg Kroah-HartmanFrom: Christoph Hellwig <[email protected]>
[ Upstream commit 783a40a1b3ac7f3714d2776fa8ac8cce3535e4f6 ]
While clearing the profile itself is harmless, we really should not clear the stable writes flag if it wasn't set due to a registered integrity profile.
--- block/blk-integrity.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
block/blk-integrity.c +5 -1
@@ -426,8 +426,12 @@ EXPORT_SYMBOL(blk_integrity_register);*/ void blk_integrity_unregister (struct gendisk *disk) { +struct blk_integrity *bi = &disk->queue->integrity; + +if (!bi->profile) +return ;blk_queue_flag_clear (QUEUE_FLAG_STABLE_WRITES , disk->queue); -memset (&disk->queue->integrity,0 ,sizeof (struct blk_integrity )); +memset (bi,0 ,sizeof (*bi)); }EXPORT_SYMBOL (blk_integrity_unregister);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 87/103 block: flush the integrity workqueue in blk_integrity_unregister
In reply to Greg Kroah-HartmanFrom: Lihong Kou <[email protected]>
[ Upstream commit 3df49967f6f1d2121b0c27c381ca1c8386b1dab9 ]
When the integrity profile is unregistered there can still be integrity reads queued up which could see a NULL verify_fn as shown by the race window below:
CPU0 CPU1
process_one_work nvme_validate_ns
bio_integrity_verify_fn nvme_update_ns_info
nvme_update_disk_info
blk_integrity_unregister
---set queue->integrity as 0
bio_integrity_process
--access bi->profile->verify_fn(bi is a pointer of queue->integity)Before calling blk_integrity_unregister in nvme_update_disk_info, we must make sure that there is no work item in the kintegrityd_wq. Just call blk_flush_integrity to flush the work queue so the bug can be resolved.
--- block/blk-integrity.c | 3 +++ 1 file changed, 3 insertions(+)
block/blk-integrity.c +3 -0
@@ -430,6 +430,9 @@ void blk_integrity_unregister(struct gendisk *disk)if (!bi->profile)return ; + +/* ensure all bios are off the integrity workqueue */ +blk_flush_integrity ();blk_queue_flag_clear (QUEUE_FLAG_STABLE_WRITES , disk->queue);memset (bi,0 ,sizeof (*bi)); }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 88/103 blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd
In reply to Greg Kroah-HartmanFrom: Li Jinlin <[email protected]>
[ Upstream commit 858560b27645e7e97aca37ee8f232cccd658fbd2 ]
KASAN reports a use-after-free report when doing fuzz test:
[693354.104835] ================================================================== [693354.105094] BUG: KASAN: use-after-free in bfq_io_set_weight_legacy+0xd3/0x160 [693354.105336] Read of size 4 at addr ffff888be0a35664 by task sh/1453338
[693354.105607] CPU: 41 PID: 1453338 Comm: sh Kdump: loaded Not tainted 4.18.0-147 [693354.105610] Hardware name: Huawei 2288H V5/BC11SPSCB0, BIOS 0.81 07/02/2018 [693354.105612] Call Trace: [693354.105621] dump_stack+0xf1/0x19b [693354.105626] ? show_regs_print_info+0x5/0x5 [693354.105634] ? printk+0x9c/0xc3 [693354.105638] ? cpumask_weight+0x1f/0x1f [693354.105648] print_address_description+0x70/0x360 [693354.105654] kasan_report+0x1b2/0x330 [693354.105659] ? bfq_io_set_weight_legacy+0xd3/0x160 [693354.105665] ? bfq_io_set_weight_legacy+0xd3/0x160 [693354.105670] bfq_io_set_weight_legacy+0xd3/0x160 [693354.105675] ? bfq_cpd_init+0x20/0x20 [693354.105683] cgroup_file_write+0x3aa/0x510 [693354.105693] ? ___slab_alloc+0x507/0x540 [693354.105698] ? cgroup_file_poll+0x60/0x60 [693354.105702] ? 0xffffffff89600000 [693354.105708] ? usercopy_abort+0x90/0x90 [693354.105716] ? mutex_lock+0xef/0x180 [693354.105726] kernfs_fop_write+0x1ab/0x280 [693354.105732] ? cgroup_file_poll+0x60/0x60 [693354.105738] vfs_write+0xe7/0x230 [693354.105744] ksys_write+0xb0/0x140 [693354.105749] ? __ia32_sys_read+0x50/0x50 [693354.105760] do_syscall_64+0x112/0x370 [693354.105766] ? syscall_return_slowpath+0x260/0x260 [693354.105772] ? do_page_fault+0x9b/0x270 [693354.105779] ? prepare_exit_to_usermode+0xf9/0x1a0 [693354.105784] ? enter_from_user_mode+0x30/0x30 [693354.105793] entry_SYSCALL_64_after_hwframe+0x65/0xca
[693354.105875] Allocated by task 1453337: [693354.106001] kasan_kmalloc+0xa0/0xd0 [693354.106006] kmem_cache_alloc_node_trace+0x108/0x220 [693354.106010] bfq_pd_alloc+0x96/0x120 [693354.106015] blkcg_activate_policy+0x1b7/0x2b0 [693354.106020] bfq_create_group_hierarchy+0x1e/0x80 [693354.106026] bfq_init_queue+0x678/0x8c0 [693354.106031] blk_mq_init_sched+0x1f8/0x460 [693354.106037] elevator_switch_mq+0xe1/0x240 [693354.106041] elevator_switch+0x25/0x40 [693354.106045] elv_iosched_store+0x1a1/0x230 [693354.106049] queue_attr_store+0x78/0xb0 [693354.106053] kernfs_fop_write+0x1ab/0x280 [693354.106056] vfs_write+0xe7/0x230 [693354.106060] ksys_write+0xb0/0x140 [693354.106064] do_syscall_64+0x112/0x370 [693354.106069] entry_SYSCALL_64_after_hwframe+0x65/0xca
[693354.106114] Freed by task 1453336: [693354.106225] __kasan_slab_free+0x130/0x180 [693354.106229] kfree+0x90/0x1b0 [693354.106233] blkcg_deactivate_policy+0x12c/0x220 [693354.106238] bfq_exit_queue+0xf5/0x110 [693354.106241] blk_mq_exit_sched+0x104/0x130 [693354.106245] __elevator_exit+0x45/0x60 [693354.106249] elevator_switch_mq+0xd6/0x240 [693354.106253] elevator_switch+0x25/0x40 [693354.106257] elv_iosched_store+0x1a1/0x230 [693354.106261] queue_attr_store+0x78/0xb0 [693354.106264] kernfs_fop_write+0x1ab/0x280 [693354.106268] vfs_write+0xe7/0x230 [693354.106271] ksys_write+0xb0/0x140 [693354.106275] do_syscall_64+0x112/0x370 [693354.106280] entry_SYSCALL_64_after_hwframe+0x65/0xca
[693354.106329] The buggy address belongs to the object at ffff888be0a35580
which belongs to the cache kmalloc-1k of size 1024
[693354.106736] The buggy address is located 228 bytes inside of
1024-byte region [ffff888be0a35580, ffff888be0a35980)
[693354.107114] The buggy address belongs to the page:
[693354.107273] page:ffffea002f828c00 count:1 mapcount:0 mapping:ffff888107c17080 index:0x0 compound_mapcount: 0
[693354.107606] flags: 0x17ffffc0008100(slab|head)
[693354.107760] raw: 0017ffffc0008100 ffffea002fcbc808 ffffea0030bd3a08 ffff888107c17080
[693354.108020] raw: 0000000000000000 00000000001c001c 00000001ffffffff 0000000000000000
[693354.108278] page dumped because: kasan: bad access detected[693354.108511] Memory state around the buggy address: [693354.108671] ffff888be0a35500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [693354.116396] ffff888be0a35580: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [693354.124473] >ffff888be0a35600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [693354.132421] ^ [693354.140284] ffff888be0a35680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [693354.147912] ffff888be0a35700: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [693354.155281] ==================================================================
blkgs are protected by both queue and blkcg locks and holding either should stabilize them. However, the path of destroying blkg policy data is only protected by queue lock in blkcg_activate_policy()/blkcg_deactivate_policy(). Other tasks can get the blkg policy data before the blkg policy data is destroyed, and use it after destroyed, which will result in a use-after-free.
CPU0 CPU1blkcg_deactivate_policy
spin_lock_irq(&q->queue_lock)
bfq_io_set_weight_legacy
spin_lock_irq(&blkcg->lock)
blkg_to_bfqg(blkg)
pd_to_bfqg(blkg->pd[pol->plid])
^^^^^^blkg->pd[pol->plid] != NULL
bfqg != NULL
pol->pd_free_fn(blkg->pd[pol->plid])
pd_to_bfqg(blkg->pd[pol->plid])
bfqg_put(bfqg)
kfree(bfqg)
blkg->pd[pol->plid] = NULL
spin_unlock_irq(q->queue_lock);
bfq_group_set_weight(bfqg, val, 0)
bfqg->entity.new_weight
^^^^^^trigger uaf here
spin_unlock_irq(&blkcg->lock);Fix by grabbing the matching blkcg lock before trying to destroy blkg policy data.
--- block/blk-cgroup.c | 8 ++++++++ 1 file changed, 8 insertions(+)
block/blk-cgroup.c +8 -0
@@ -1387,10 +1387,14 @@ enomem:/* alloc failed, nothing's initialized yet, free everything */ spin_lock_irq (&q->queue_lock);list_for_each_entry (blkg, &q->blkg_list, q_node) { +struct blkcg *blkcg = blkg->blkcg; + +spin_lock (&blkcg->lock);if (blkg->pd[pol->plid]) { pol->pd_free_fn (blkg->pd[pol->plid]); blkg->pd[pol->plid] =NULL ; } +spin_unlock (&blkcg->lock); }spin_unlock_irq (&q->queue_lock); ret = -ENOMEM ;
@@ -1422,12 +1426,16 @@ void blkcg_deactivate_policy(struct request_queue *q,__clear_bit (pol->plid, q->blkcg_pols);list_for_each_entry (blkg, &q->blkg_list, q_node) { +struct blkcg *blkcg = blkg->blkcg; + +spin_lock (&blkcg->lock);if (blkg->pd[pol->plid]) {if (pol->pd_offline_fn) pol->pd_offline_fn (blkg->pd[pol->plid]); pol->pd_free_fn (blkg->pd[pol->plid]); blkg->pd[pol->plid] =NULL ; } +spin_unlock (&blkcg->lock); }spin_unlock_irq (&q->queue_lock);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 60/103 treewide: Change list_sort to use const pointers
In reply to Greg Kroah-HartmanFrom: Sami Tolvanen <[email protected]>
[ Upstream commit 4f0f586bf0c898233d8f316f471a21db2abd522d ]
list_sort() internally casts the comparison function passed to it to a different type with constant struct list_head pointers, and uses this pointer to call the functions, which trips indirect call Control-Flow Integrity (CFI) checking.
Instead of removing the consts, this change defines the list_cmp_func_t type and changes the comparison function types of all list_sort() callers to use const pointers, thus avoiding type mismatches.
--- arch/arm64/kvm/vgic/vgic-its.c | 8 ++++---- arch/arm64/kvm/vgic/vgic.c | 3 ++- block/blk-mq-sched.c | 3 ++- block/blk-mq.c | 3 ++- drivers/acpi/nfit/core.c | 3 ++- drivers/acpi/numa/hmat.c | 3 ++- drivers/clk/keystone/sci-clk.c | 4 ++-- drivers/gpu/drm/drm_modes.c | 3 ++- drivers/gpu/drm/i915/gt/intel_engine_user.c | 3 ++- drivers/gpu/drm/i915/gvt/debugfs.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 3 ++- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- .../hw/usnic/usnic_uiom_interval_tree.c | 3 ++- drivers/interconnect/qcom/bcm-voter.c | 2 +- drivers/md/raid5.c | 3 ++- drivers/misc/sram.c | 4 ++-- drivers/nvme/host/core.c | 3 ++- .../pci/controller/cadence/pcie-cadence-host.c | 3 ++- drivers/spi/spi-loopback-test.c | 3 ++- fs/btrfs/raid56.c | 3 ++- fs/btrfs/tree-log.c | 3 ++- fs/btrfs/volumes.c | 3 ++- fs/ext4/fsmap.c | 4 ++-- fs/gfs2/glock.c | 3 ++- fs/gfs2/log.c | 2 +- fs/gfs2/lops.c | 3 ++- fs/iomap/buffered-io.c | 3 ++- fs/ubifs/gc.c | 7 ++++--- fs/ubifs/replay.c | 4 ++-- fs/xfs/scrub/bitmap.c | 4 ++-- fs/xfs/xfs_bmap_item.c | 4 ++-- fs/xfs/xfs_buf.c | 6 +++--- fs/xfs/xfs_extent_busy.c | 4 ++-- fs/xfs/xfs_extent_busy.h | 3 ++- fs/xfs/xfs_extfree_item.c | 4 ++-- fs/xfs/xfs_refcount_item.c | 4 ++-- fs/xfs/xfs_rmap_item.c | 4 ++-- include/linux/list_sort.h | 7 ++++--- lib/list_sort.c | 17 ++++++----------- lib/test_list_sort.c | 3 ++- net/tipc/name_table.c | 4 ++-- 41 files changed, 90 insertions(+), 72 deletions(-)
arch/arm64/kvm/vgic/vgic-its.c +4 -4
@@ -2190,8 +2190,8 @@ static int vgic_its_restore_ite(struct vgic_its *its, u32 event_id,return offset; } -static int vgic_its_ite_cmp (void *priv,struct list_head *a, -struct list_head *b) +static int vgic_its_ite_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct its_ite *itea = container_of(a, struct its_ite, ite_list); struct its_ite *iteb = container_of(b, struct its_ite, ite_list);
@@ -2329,8 +2329,8 @@ static int vgic_its_restore_dte(struct vgic_its *its, u32 id,return offset; } -static int vgic_its_device_cmp (void *priv,struct list_head *a, -struct list_head *b) +static int vgic_its_device_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct its_device *deva = container_of(a, struct its_device, dev_list); struct its_device *devb = container_of(b, struct its_device, dev_list);
arch/arm64/kvm/vgic/vgic.c +2 -1
@@ -255,7 +255,8 @@ static struct kvm_vcpu *vgic_target_oracle(struct vgic_irq *irq)* Return negative if "a" sorts before "b", 0 to preserve order, and positive * to sort "b" before "a". */ -static int vgic_irq_cmp (void *priv,struct list_head *a,struct list_head *b) +static int vgic_irq_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct vgic_irq *irqa = container_of(a, struct vgic_irq, ap_list); struct vgic_irq *irqb = container_of(b, struct vgic_irq, ap_list);
block/blk-mq-sched.c +2 -1
@@ -75,7 +75,8 @@ void blk_mq_sched_restart(struct blk_mq_hw_ctx *hctx)blk_mq_run_hw_queue (hctx, true); } -static int sched_rq_cmp (void *priv,struct list_head *a,struct list_head *b) +static int sched_rq_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct request *rqa = container_of(a, struct request, queuelist); struct request *rqb = container_of(b, struct request, queuelist);
block/blk-mq.c +2 -1
@@ -1866,7 +1866,8 @@ void blk_mq_insert_requests(struct blk_mq_hw_ctx *hctx, struct blk_mq_ctx *ctx,spin_unlock (&ctx->lock); } -static int plug_rq_cmp (void *priv,struct list_head *a,struct list_head *b) +static int plug_rq_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct request *rqa = container_of(a, struct request, queuelist); struct request *rqb = container_of(b, struct request, queuelist);
drivers/acpi/nfit/core.c +2 -1
@@ -1194,7 +1194,8 @@ static int __nfit_mem_init(struct acpi_nfit_desc *acpi_desc,return 0 ; } -static int nfit_mem_cmp (void *priv,struct list_head *_a,struct list_head *_b) +static int nfit_mem_cmp (void *priv,const struct list_head *_a, +const struct list_head *_b) {struct nfit_mem *a =container_of (_a,typeof (*a), list);struct nfit_mem *b =container_of (_b,typeof (*b), list);
drivers/acpi/numa/hmat.c +2 -1
@@ -558,7 +558,8 @@ static bool hmat_update_best(u8 type, u32 value, u32 *best)return updated; } -static int initiator_cmp (void *priv,struct list_head *a,struct list_head *b) +static int initiator_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct memory_initiator *ia;struct memory_initiator *ib;
drivers/clk/keystone/sci-clk.c +2 -2
@@ -503,8 +503,8 @@ static int ti_sci_scan_clocks_from_fw(struct sci_clk_provider *provider)#else -static int _cmp_sci_clk_list (void *priv,struct list_head *a, -struct list_head *b) +static int _cmp_sci_clk_list (void *priv,const struct list_head *a, +const struct list_head *b) { struct sci_clk *ca = container_of(a, struct sci_clk, node); struct sci_clk *cb = container_of(b, struct sci_clk, node);
drivers/gpu/drm/drm_modes.c +2 -1
@@ -1290,7 +1290,8 @@ EXPORT_SYMBOL(drm_mode_prune_invalid);* Negative if @lh_a is better than @lh_b, zero if they're equivalent, or * positive if @lh_b is better than @lh_a. */ -static int drm_mode_compare (void *priv,struct list_head *lh_a,struct list_head *lh_b) +static int drm_mode_compare (void *priv,const struct list_head *lh_a, +const struct list_head *lh_b) { struct drm_display_mode *a = list_entry(lh_a, struct drm_display_mode, head); struct drm_display_mode *b = list_entry(lh_b, struct drm_display_mode, head);
drivers/gpu/drm/i915/gt/intel_engine_user.c +2 -1
@@ -49,7 +49,8 @@ static const u8 uabi_classes[] = { [VIDEO_ENHANCEMENT_CLASS] = I915_ENGINE_CLASS_VIDEO_ENHANCE, }; -static int engine_cmp (void *priv,struct list_head *A ,struct list_head *B ) +static int engine_cmp (void *priv,const struct list_head *A , +const struct list_head *B ) {const struct intel_engine_cs *a =container_of ((struct rb_node *)A ,typeof (*a), uabi_node);
drivers/gpu/drm/i915/gvt/debugfs.c +1 -1
@@ -41,7 +41,7 @@ struct diff_mmio {/* Compare two diff_mmio items. */ static int mmio_offset_compare (void *priv, -struct list_head *a,struct list_head *b) +const struct list_head *a,const struct list_head *b) {struct diff_mmio *ma;struct diff_mmio *mb;
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +2 -1
@@ -1075,7 +1075,8 @@ static int igt_ppgtt_shrink_boom(void *arg)return exercise_ppgtt (arg, shrink_boom); } -static int sort_holes (void *priv,struct list_head *A ,struct list_head *B ) +static int sort_holes (void *priv,const struct list_head *A , +const struct list_head *B ) {struct drm_mm_node *a =list_entry (A ,typeof (*a), hole_stack);struct drm_mm_node *b =list_entry (B ,typeof (*b), hole_stack);
drivers/gpu/drm/radeon/radeon_cs.c +2 -2
@@ -394,8 +394,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)return 0 ; } -static int cmp_size_smaller_first (void *priv,struct list_head *a, -struct list_head *b) +static int cmp_size_smaller_first (void *priv,const struct list_head *a, +const struct list_head *b) { struct radeon_bo_list *la = list_entry(a, struct radeon_bo_list, tv.head); struct radeon_bo_list *lb = list_entry(b, struct radeon_bo_list, tv.head);
drivers/infiniband/hw/usnic/usnic_uiom_interval_tree.c +2 -1
@@ -83,7 +83,8 @@ usnic_uiom_interval_node_alloc(long int start, long int last, int ref_cnt,return interval; } -static int interval_cmp (void *priv,struct list_head *a,struct list_head *b) +static int interval_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct usnic_uiom_interval_node *node_a, *node_b;
drivers/interconnect/qcom/bcm-voter.c +1 -1
@@ -39,7 +39,7 @@ struct bcm_voter {u32 tcs_wait; }; -static int cmp_vcd (void *priv,struct list_head *a,struct list_head *b) +static int cmp_vcd (void *priv,const struct list_head *a,const struct list_head *b) {const struct qcom_icc_bcm *bcm_a = list_entry(a, struct qcom_icc_bcm, list);
drivers/md/raid5.c +2 -1
@@ -953,7 +953,8 @@ static void dispatch_bio_list(struct bio_list *tmp)submit_bio_noacct (bio); } -static int cmp_stripe (void *priv,struct list_head *a,struct list_head *b) +static int cmp_stripe (void *priv,const struct list_head *a, +const struct list_head *b) {const struct r5pending_data *da =list_entry (a, struct r5pending_data, sibling);
drivers/misc/sram.c +2 -2
@@ -144,8 +144,8 @@ static void sram_free_partitions(struct sram_dev *sram) } } -static int sram_reserve_cmp (void *priv,struct list_head *a, -struct list_head *b) +static int sram_reserve_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct sram_reserve *ra = list_entry(a, struct sram_reserve, list); struct sram_reserve *rb = list_entry(b, struct sram_reserve, list);
drivers/nvme/host/core.c +2 -1
@@ -3801,7 +3801,8 @@ out_unlock:return ret; } -static int ns_cmp (void *priv,struct list_head *a,struct list_head *b) +static int ns_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct nvme_ns *nsa = container_of(a, struct nvme_ns, list); struct nvme_ns *nsb = container_of(b, struct nvme_ns, list);
drivers/pci/controller/cadence/pcie-cadence-host.c +2 -1
@@ -345,7 +345,8 @@ static int cdns_pcie_host_bar_config(struct cdns_pcie_rc *rc,return 0 ; } -static int cdns_pcie_host_dma_ranges_cmp (void *priv,struct list_head *a,struct list_head *b) +static int cdns_pcie_host_dma_ranges_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct resource_entry *entry1, *entry2;
drivers/spi/spi-loopback-test.c +2 -1
@@ -454,7 +454,8 @@ struct rx_ranges {u8 *end; }; -static int rx_ranges_cmp (void *priv,struct list_head *a,struct list_head *b) +static int rx_ranges_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct rx_ranges *rx_a = list_entry(a, struct rx_ranges, list); struct rx_ranges *rx_b = list_entry(b, struct rx_ranges, list);
fs/btrfs/raid56.c +2 -1
@@ -1646,7 +1646,8 @@ struct btrfs_plug_cb {/* * rbios on the plug list are sorted for easier merging. */ -static int plug_cmp (void *priv,struct list_head *a,struct list_head *b) +static int plug_cmp (void *priv,const struct list_head *a, +const struct list_head *b) { struct btrfs_raid_bio *ra = container_of(a, struct btrfs_raid_bio, plug_list);
fs/btrfs/tree-log.c +2 -1
@@ -4070,7 +4070,8 @@ static noinline int copy_items(struct btrfs_trans_handle *trans,return ret; } -static int extent_cmp (void *priv,struct list_head *a,struct list_head *b) +static int extent_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct extent_map *em1, *em2;
fs/btrfs/volumes.c +2 -1
@@ -1226,7 +1226,8 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,return 0 ; } -static int devid_cmp (void *priv,struct list_head *a,struct list_head *b) +static int devid_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct btrfs_device *dev1, *dev2;
fs/ext4/fsmap.c +2 -2
@@ -354,8 +354,8 @@ static unsigned int ext4_getfsmap_find_sb(struct super_block *sb,/* Compare two fsmap items. */ static int ext4_getfsmap_compare (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct ext4_fsmap *fa;struct ext4_fsmap *fb;
fs/gfs2/glock.c +2 -1
@@ -1744,7 +1744,8 @@ void gfs2_glock_complete(struct gfs2_glock *gl, int ret)spin_unlock (&gl->gl_lockref.lock); } -static int glock_cmp (void *priv,struct list_head *a,struct list_head *b) +static int glock_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct gfs2_glock *gla, *glb;
fs/gfs2/log.c +1 -1
@@ -605,7 +605,7 @@ void log_flush_wait(struct gfs2_sbd *sdp) } } -static int ip_cmp (void *priv,struct list_head *a,struct list_head *b) +static int ip_cmp (void *priv,const struct list_head *a,const struct list_head *b) {struct gfs2_inode *ipa, *ipb;
fs/gfs2/lops.c +2 -1
@@ -627,7 +627,8 @@ static void gfs2_check_magic(struct buffer_head *bh)kunmap_atomic (kaddr); } -static int blocknr_cmp (void *priv,struct list_head *a,struct list_head *b) +static int blocknr_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct gfs2_bufdata *bda, *bdb;
fs/iomap/buffered-io.c +2 -1
@@ -1155,7 +1155,8 @@ iomap_ioend_try_merge(struct iomap_ioend *ioend, struct list_head *more_ioends,EXPORT_SYMBOL_GPL (iomap_ioend_try_merge);static int -iomap_ioend_compare (void *priv,struct list_head *a,struct list_head *b) +iomap_ioend_compare (void *priv,const struct list_head *a, +const struct list_head *b) { struct iomap_ioend *ia = container_of(a, struct iomap_ioend, io_list); struct iomap_ioend *ib = container_of(b, struct iomap_ioend, io_list);
fs/ubifs/gc.c +4 -3
@@ -102,7 +102,8 @@ static int switch_gc_head(struct ubifs_info *c)* This function compares data nodes @a and @b. Returns %1 if @a has greater * inode or block number, and %-1 otherwise. */ -static int data_nodes_cmp (void *priv,struct list_head *a,struct list_head *b) +static int data_nodes_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {ino_t inuma, inumb;struct ubifs_info *c = priv;
@@ -145,8 +146,8 @@ static int data_nodes_cmp(void *priv, struct list_head *a, struct list_head *b)* first and sorted by length in descending order. Directory entry nodes go * after inode nodes and are sorted in ascending hash valuer order. */ -static int nondata_nodes_cmp (void *priv,struct list_head *a, -struct list_head *b) +static int nondata_nodes_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {ino_t inuma, inumb;struct ubifs_info *c = priv;
fs/ubifs/replay.c +2 -2
@@ -299,8 +299,8 @@ static int apply_replay_entry(struct ubifs_info *c, struct replay_entry *r)* entries @a and @b by comparing their sequence numer. Returns %1 if @a has * greater sequence number and %-1 otherwise. */ -static int replay_entries_cmp (void *priv,struct list_head *a, -struct list_head *b) +static int replay_entries_cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct ubifs_info *c = priv;struct replay_entry *ra, *rb;
fs/xfs/scrub/bitmap.c +2 -2
@@ -63,8 +63,8 @@ xbitmap_init(static int xbitmap_range_cmp (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct xbitmap_range *ap;struct xbitmap_range *bp;
fs/xfs/xfs_bmap_item.c +2 -2
@@ -265,8 +265,8 @@ xfs_trans_log_finish_bmap_update(static int xfs_bmap_update_diff_items (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct xfs_bmap_intent *ba;struct xfs_bmap_intent *bb;
fs/xfs/xfs_buf.c +3 -3
@@ -2114,9 +2114,9 @@ xfs_buf_delwri_queue(*/ static int xfs_buf_cmp ( -void *priv, -struct list_head *a, -struct list_head *b) +void *priv, +const struct list_head *a, +const struct list_head *b) { struct xfs_buf *ap = container_of(a, struct xfs_buf, b_list); struct xfs_buf *bp = container_of(b, struct xfs_buf, b_list);
fs/xfs/xfs_extent_busy.c +2 -2
@@ -643,8 +643,8 @@ xfs_extent_busy_wait_all(int xfs_extent_busy_ag_cmp (void *priv, -struct list_head *l1, -struct list_head *l2) +const struct list_head *l1, +const struct list_head *l2) {struct xfs_extent_busy *b1 = container_of(l1, struct xfs_extent_busy, list);
fs/xfs/xfs_extent_busy.h +2 -1
@@ -58,7 +58,8 @@ void xfs_extent_busy_wait_all(struct xfs_mount *mp);int -xfs_extent_busy_ag_cmp (void *priv,struct list_head *a,struct list_head *b); +xfs_extent_busy_ag_cmp (void *priv,const struct list_head *a, +const struct list_head *b);static inline void xfs_extent_busy_sort (struct list_head *list) {
fs/xfs/xfs_extfree_item.c +2 -2
@@ -397,8 +397,8 @@ xfs_trans_free_extent(static int xfs_extent_free_diff_items (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct xfs_mount *mp = priv;struct xfs_extent_free_item *ra;
fs/xfs/xfs_refcount_item.c +2 -2
@@ -269,8 +269,8 @@ xfs_trans_log_finish_refcount_update(static int xfs_refcount_update_diff_items (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct xfs_mount *mp = priv;struct xfs_refcount_intent *ra;
fs/xfs/xfs_rmap_item.c +2 -2
@@ -337,8 +337,8 @@ xfs_trans_log_finish_rmap_update(static int xfs_rmap_update_diff_items (void *priv, -struct list_head *a, -struct list_head *b) +const struct list_head *a, +const struct list_head *b) {struct xfs_mount *mp = priv;struct xfs_rmap_intent *ra;
include/linux/list_sort.h +4 -3
@@ -6,8 +6,9 @@struct list_head ; +typedef int __attribute__((nonnull(2,3))) (*list_cmp_func_t)(void *, + const struct list_head *, const struct list_head *); + __attribute__((nonnull (2 ,3 ))) -void list_sort (void *priv,struct list_head *head, -int (*cmp)(void *priv,struct list_head *a, -struct list_head *b)); +void list_sort (void *priv,struct list_head *head,list_cmp_func_t cmp);#endif
lib/list_sort.c +6 -11
@@ -7,16 +7,13 @@#include <linux/list_sort.h> #include <linux/list.h> -typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *, - struct list_head const *, struct list_head const *); -/* * Returns a list organized in an intermediate format suited * to chaining of merge() calls: null-terminated, no reserved or * sentinel head node, "prev" links not maintained. */ __attribute__((nonnull (2 ,3 ,4 ))) -static struct list_head *merge (void *priv,cmp_func cmp, +static struct list_head *merge (void *priv,list_cmp_func_t cmp,struct list_head *a,struct list_head *b) {struct list_head *head, **tail = &head;
@@ -52,7 +49,7 @@ static struct list_head *merge(void *priv, cmp_func cmp,* throughout. */ __attribute__((nonnull (2 ,3 ,4 ,5 ))) -static void merge_final (void *priv,cmp_func cmp,struct list_head *head, +static void merge_final (void *priv,list_cmp_func_t cmp,struct list_head *head,struct list_head *a,struct list_head *b) {struct list_head *tail = head;
@@ -185,9 +182,7 @@ static void merge_final(void *priv, cmp_func cmp, struct list_head *head,* 2^(k+1) - 1 (second merge of case 5 when x == 2^(k-1) - 1). */ __attribute__((nonnull (2 ,3 ))) -void list_sort (void *priv,struct list_head *head, -int (*cmp)(void *priv,struct list_head *a, -struct list_head *b)) +void list_sort (void *priv,struct list_head *head,list_cmp_func_t cmp) {struct list_head *list = head->next, *pending =NULL ;size_t count =0 ;/* Count of pending */
@@ -227,7 +222,7 @@ void list_sort(void *priv, struct list_head *head,if (likely (bits)) {struct list_head *a = *tail, *b = a->prev; - a =merge (priv, (cmp_func )cmp, b, a); + a =merge (priv, cmp, b, a);/* Install the merged result in place of the inputs */ a->prev = b->prev; *tail = a;
@@ -249,10 +244,10 @@ void list_sort(void *priv, struct list_head *head,if (!next)break ; - list =merge (priv, (cmp_func )cmp, pending, list); + list =merge (priv, cmp, pending, list); pending = next; }/* The final merge, rebuilding prev links */ -merge_final (priv, (cmp_func )cmp, head, pending, list); +merge_final (priv, cmp, head, pending, list); }EXPORT_SYMBOL (list_sort);
lib/test_list_sort.c +2 -1
@@ -56,7 +56,8 @@ static int __init check(struct debug_el *ela, struct debug_el *elb)return 0 ; } -static int __init cmp (void *priv,struct list_head *a,struct list_head *b) +static int __init cmp (void *priv,const struct list_head *a, +const struct list_head *b) {struct debug_el *ela, *elb;
net/tipc/name_table.c +2 -2
@@ -381,8 +381,8 @@ static struct publication *tipc_service_remove_publ(struct service_range *sr,* Code reused: time_after32() for the same purpose */ #define publication_after (pa, pb) time_after32((pa)->id, (pb)->id) -static int tipc_publ_sort (void *priv,struct list_head *a, -struct list_head *b) +static int tipc_publ_sort (void *priv,const struct list_head *a, +const struct list_head *b) {struct publication *pa, *pb;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 89/103 compiler.h: Introduce absolute_pointer macro
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
[ Upstream commit f6b5f1a56987de837f8e25cd560847106b8632a8 ]
absolute_pointer() disassociates a pointer from its originating symbol type and context. Use it to prevent compiler warnings/errors such as
drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe':
arch/m68k/include/asm/string.h:72:25: error:
'__builtin_memcpy' reading 6 bytes from a region of size 0 [-Werror=stringop-overread]
Such warnings may be reported by gcc 11.x for string and memory operations on fixed addresses.
--- include/linux/compiler.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/compiler.h +2 -0
@@ -180,6 +180,8 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, (typeof(ptr)) (__ptr + (off)); })#endif +#define absolute_pointer (val) RELOC_HIDE((void *)(val), 0) +#ifndef OPTIMIZER_HIDE_VAR /* Make the optimizer believe the variable can be manipulated arbitrarily. */ #define OPTIMIZER_HIDE_VAR (var) \
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 61/103 nvme: keep ctrl->namespaces ordered
In reply to Greg Kroah-HartmanFrom: Christoph Hellwig <[email protected]>
[ Upstream commit 298ba0e3d4af539cc37f982d4c011a0f07fca48c ]
Various places in the nvme code that rely on ctrl->namespace to be ordered. Ensure that the namespae is inserted into the list at the right position from the start instead of sorting it after the fact.
--- drivers/nvme/host/core.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-)
drivers/nvme/host/core.c +17 -16
@@ -13,7 +13,6 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/backing-dev.h> -#include <linux/list_sort.h> #include <linux/slab.h> #include <linux/types.h> #include <linux/pr.h>
@@ -3801,15 +3800,6 @@ out_unlock:return ret; } -static int ns_cmp (void *priv,const struct list_head *a, -const struct list_head *b) -{ - struct nvme_ns *nsa = container_of(a, struct nvme_ns, list); - struct nvme_ns *nsb = container_of(b, struct nvme_ns, list); - -return nsa->head->ns_id - nsb->head->ns_id; -} -struct nvme_ns *nvme_find_get_ns (struct nvme_ctrl *ctrl,unsigned nsid) {struct nvme_ns *ns, *ret =NULL ;
@@ -3830,6 +3820,22 @@ struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid) }EXPORT_SYMBOL_NS_GPL (nvme_find_get_ns,NVME_TARGET_PASSTHRU ); +/* +* Add the namespace to the controller list while keeping the list ordered. +*/ +static void nvme_ns_add_to_ctrl_list (struct nvme_ns *ns) +{ +struct nvme_ns *tmp; + +list_for_each_entry_reverse (tmp, &ns->ctrl->namespaces, list) { +if (tmp->head->ns_id < ns->head->ns_id) { +list_add (&ns->list, &tmp->list); +return ; + } + } +list_add (&ns->list, &ns->ctrl->namespaces); +} +static void nvme_alloc_ns (struct nvme_ctrl *ctrl,unsigned nsid,struct nvme_ns_ids *ids) {
@@ -3889,9 +3895,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, }down_write (&ctrl->namespaces_rwsem); -list_add_tail (&ns->list, &ctrl->namespaces); +nvme_ns_add_to_ctrl_list (ns);up_write (&ctrl->namespaces_rwsem); -nvme_get_ctrl (ctrl);device_add_disk (ctrl->device, ns->disk, nvme_ns_id_attr_groups);
@@ -4160,10 +4165,6 @@ static void nvme_scan_work(struct work_struct *work)if (nvme_scan_ns_list (ctrl) !=0 )nvme_scan_ns_sequential (ctrl);mutex_unlock (&ctrl->scan_lock); - -down_write (&ctrl->namespaces_rwsem); -list_sort (NULL , &ctrl->namespaces, ns_cmp); -up_write (&ctrl->namespaces_rwsem); }/*
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 62/103 thermal/core: Potential buffer overflow in thermal_build_list_of_policies()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 1bb30b20b49773369c299d4d6c65227201328663 ]
After printing the list of thermal governors, then this function prints a newline character. The problem is that "size" has not been updated after printing the last governor. This means that it can write one character (the NUL terminator) beyond the end of the buffer.
Get rid of the "size" variable and just use "PAGE_SIZE - count" directly.
--- drivers/thermal/thermal_core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/thermal/thermal_core.c +3 -4
@@ -224,15 +224,14 @@ int thermal_build_list_of_policies(char *buf) {struct thermal_governor *pos;ssize_t count =0 ; -ssize_t size =PAGE_SIZE ;mutex_lock (&thermal_governor_lock);list_for_each_entry (pos, &thermal_governor_list, governor_list) { - size =PAGE_SIZE - count; - count +=scnprintf (buf + count, size,"%s " , pos->name); + count +=scnprintf (buf + count,PAGE_SIZE - count,"%s " , + pos->name); } - count +=scnprintf (buf + count, size,"\n" ); + count +=scnprintf (buf + count,PAGE_SIZE - count,"\n" );mutex_unlock (&thermal_governor_lock);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 63/103 cifs: fix a sign extension bug
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit e946d3c887a9dc33aa82a349c6284f4a084163f4 ]
The problem is the mismatched types between "ctx->total_len" which is an unsigned int, "rc" which is an int, and "ctx->rc" which is a ssize_t. The code does:
ctx->rc = (rc == 0) ? ctx->total_len : rc;
We want "ctx->rc" to store the negative "rc" error code. But what happens is that "rc" is type promoted to a high unsigned int and 'ctx->rc" will store the high positive value instead of a negative value.
The fix is to change "rc" from an int to a ssize_t.
--- fs/cifs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/file.c +1 -1
@@ -3039,7 +3039,7 @@ static void collect_uncached_write_data(struct cifs_aio_ctx *ctx)struct cifs_tcon *tcon;struct cifs_sb_info *cifs_sb;struct dentry *dentry = ctx->cfile->dentry; -int rc; +ssize_t rc; tcon =tlink_tcon (ctx->cfile->tlink); cifs_sb =CIFS_SB (dentry->d_sb);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 64/103 scsi: qla2xxx: Restore initiator in dual mode
In reply to Greg Kroah-HartmanFrom: Dmitry Bogdanov <[email protected]>
[ Upstream commit 5f8579038842d77e6ce05e1df6bf9dd493b0e3ef ]
In dual mode in case of disabling the target, the whole port goes offline and initiator is turned off too.
Fix restoring initiator mode after disabling target in dual mode.
--- drivers/scsi/qla2xxx/qla_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_init.c +2 -1
@@ -6934,7 +6934,8 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)return 0 ;break ;case QLA2XXX_INI_MODE_DUAL : -if (!qla_dual_mode_enabled (vha)) +if (!qla_dual_mode_enabled (vha) && + !qla_ini_mode_enabled (vha))return 0 ;break ;case QLA2XXX_INI_MODE_ENABLED :
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 55/103 tty: synclink_gt, drop unneeded forward declarations
In reply to Greg Kroah-HartmanFrom: Jiri Slaby <[email protected]>
[ Upstream commit b9b90fe655c0bd816847ac1bcbf179cfa2981ecb ]
Forward declarations make the code larger and rewrites harder. Harder as they are often omitted from global changes. Remove forward declarations which are not really needed, i.e. the definition of the function is before its first use.
--- drivers/tty/synclink_gt.c | 57 +-------------------------------------- 1 file changed, 1 insertion(+), 56 deletions(-)
drivers/tty/synclink_gt.c +1 -56
@@ -137,37 +137,14 @@ MODULE_PARM_DESC(maxframe, "Maximum frame size used by device (4096 to 65535)");*/ static struct tty_driver *serial_driver; -static int open (struct tty_struct *tty,struct file * filp); -static void close (struct tty_struct *tty,struct file * filp); -static void hangup (struct tty_struct *tty); -static void set_termios (struct tty_struct *tty,struct ktermios *old_termios); - -static int write (struct tty_struct *tty,const unsigned char *buf,int count); -static int put_char (struct tty_struct *tty,unsigned char ch); -static void send_xchar (struct tty_struct *tty,char ch);static void wait_until_sent (struct tty_struct *tty,int timeout); -static int write_room (struct tty_struct *tty); -static void flush_chars (struct tty_struct *tty);static void flush_buffer (struct tty_struct *tty); -static void tx_hold (struct tty_struct *tty);static void tx_release (struct tty_struct *tty); -static int ioctl (struct tty_struct *tty,unsigned int cmd,unsigned long arg); -static int chars_in_buffer (struct tty_struct *tty); -static void throttle (struct tty_struct * tty); -static void unthrottle (struct tty_struct * tty); -static int set_break (struct tty_struct *tty,int break_state); -/* -* generic HDLC support and callbacks +* generic HDLC support */ -#if SYNCLINK_GENERIC_HDLC #define dev_to_port (D ) (dev_to_hdlc(D)->priv) -static void hdlcdev_tx_done (struct slgt_info *info); -static void hdlcdev_rx (struct slgt_info *info,char *buf,int size); -static int hdlcdev_init (struct slgt_info *info); -static void hdlcdev_exit (struct slgt_info *info); -#endif /*
@@ -186,9 +163,6 @@ struct cond_wait {wait_queue_entry_t wait;unsigned int data; }; -static void init_cond_wait (struct cond_wait *w,unsigned int data); -static void add_cond_wait (struct cond_wait **head,struct cond_wait *w); -static void remove_cond_wait (struct cond_wait **head,struct cond_wait *w);static void flush_cond_wait (struct cond_wait **head);/*
@@ -443,12 +417,8 @@ static void shutdown(struct slgt_info *info);static void program_hw (struct slgt_info *info);static void change_params (struct slgt_info *info); -static int register_test (struct slgt_info *info); -static int irq_test (struct slgt_info *info); -static int loopback_test (struct slgt_info *info);static int adapter_test (struct slgt_info *info); -static void reset_adapter (struct slgt_info *info);static void reset_port (struct slgt_info *info);static void async_mode (struct slgt_info *info);static void sync_mode (struct slgt_info *info);
@@ -457,14 +427,12 @@ static void rx_stop(struct slgt_info *info);static void rx_start (struct slgt_info *info);static void reset_rbufs (struct slgt_info *info);static void free_rbufs (struct slgt_info *info,unsigned int first,unsigned int last); -static void rdma_reset (struct slgt_info *info);static bool rx_get_frame (struct slgt_info *info);static bool rx_get_buf (struct slgt_info *info);static void tx_start (struct slgt_info *info);static void tx_stop (struct slgt_info *info);static void tx_set_idle (struct slgt_info *info); -static unsigned int free_tbuf_count (struct slgt_info *info);static unsigned int tbuf_bytes (struct slgt_info *info);static void reset_tbufs (struct slgt_info *info);static void tdma_reset (struct slgt_info *info);
@@ -472,26 +440,10 @@ static bool tx_load(struct slgt_info *info, const char *buf, unsigned int count)static void get_signals (struct slgt_info *info);static void set_signals (struct slgt_info *info); -static void enable_loopback (struct slgt_info *info);static void set_rate (struct slgt_info *info,u32 data_rate); -static int bh_action (struct slgt_info *info); -static void bh_handler (struct work_struct *work);static void bh_transmit (struct slgt_info *info); -static void isr_serial (struct slgt_info *info); -static void isr_rdma (struct slgt_info *info);static void isr_txeom (struct slgt_info *info,unsigned short status); -static void isr_tdma (struct slgt_info *info); - -static int alloc_dma_bufs (struct slgt_info *info); -static void free_dma_bufs (struct slgt_info *info); -static int alloc_desc (struct slgt_info *info); -static void free_desc (struct slgt_info *info); -static int alloc_bufs (struct slgt_info *info,struct slgt_desc *bufs,int count); -static void free_bufs (struct slgt_info *info,struct slgt_desc *bufs,int count); - -static int alloc_tmp_rbuf (struct slgt_info *info); -static void free_tmp_rbuf (struct slgt_info *info);static void tx_timeout (struct timer_list *t);static void rx_timeout (struct timer_list *t);
@@ -509,10 +461,6 @@ static int tx_abort(struct slgt_info *info);static int rx_enable (struct slgt_info *info,int enable);static int modem_input_wait (struct slgt_info *info,int arg);static int wait_mgsl_event (struct slgt_info *info,int __user *mask_ptr); -static int tiocmget (struct tty_struct *tty); -static int tiocmset (struct tty_struct *tty, -unsigned int set,unsigned int clear); -static int set_break (struct tty_struct *tty,int break_state);static int get_interface (struct slgt_info *info,int __user *if_mode);static int set_interface (struct slgt_info *info,int if_mode);static int set_gpio (struct slgt_info *info,struct gpio_desc __user *gpio);
@@ -526,9 +474,6 @@ static int set_xctrl(struct slgt_info *info, int if_mode);/* * driver functions */ -static void add_device (struct slgt_info *info); -static void device_init (int adapter_num,struct pci_dev *pdev); -static int claim_resources (struct slgt_info *info);static void release_resources (struct slgt_info *info);/*
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 91/103 sparc: avoid stringop-overread errors
In reply to Greg Kroah-HartmanFrom: Linus Torvalds <[email protected]>
[ Upstream commit fc7c028dcdbfe981bca75d2a7b95f363eb691ef3 ]
The sparc mdesc code does pointer games with 'struct mdesc_hdr', but didn't describe to the compiler how that header is then followed by the data that the header describes.
As a result, gcc is now unhappy since it does stricter pointer range tracking, and doesn't understand about how these things work. This results in various errors like:
arch/sparc/kernel/mdesc.c: In function ‘mdesc_node_by_name’:
arch/sparc/kernel/mdesc.c:647:22: error: ‘strcmp’ reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread]
647 | if (!strcmp(names + ep[ret].name_offset, name))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
which are easily avoided by just describing 'struct mdesc_hdr' better, and making the node_block() helper function look into that unsized data[] that follows the header.
This makes the sparc64 build happy again at least for my cross-compiler version (gcc version 11.2.1).
--- arch/sparc/kernel/mdesc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/sparc/kernel/mdesc.c +2 -1
@@ -39,6 +39,7 @@ struct mdesc_hdr {u32 node_sz;/* node block size */ u32 name_sz;/* name block size */ u32 data_sz;/* data block size */ +char data[]; } __attribute__((aligned(16)));struct mdesc_elem {
@@ -612,7 +613,7 @@ EXPORT_SYMBOL(mdesc_get_node_info);static struct mdesc_elem *node_block (struct mdesc_hdr *mdesc) { -return (struct mdesc_elem *) (mdesc +1 ); +return (struct mdesc_elem *) mdesc->data; }static void *name_block (struct mdesc_hdr *mdesc)
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 100/103 thermal/drivers/int340x: Do not set a wrong tcc offset on resume
In reply to Greg Kroah-HartmanFrom: Antoine Tenart <[email protected]>
commit 8b4bd256674720709a9d858a219fcac6f2f253b5 upstream.
After upgrading to Linux 5.13.3 I noticed my laptop would shutdown due to overheat (when it should not). It turned out this was due to commit fe6a6de6692e ("thermal/drivers/int340x/processor_thermal: Fix tcc setting").
What happens is this drivers uses a global variable to keep track of the tcc offset (tcc_offset_save) and uses it on resume. The issue is this variable is initialized to 0, but is only set in tcc_offset_degree_celsius_store, i.e. when the tcc offset is explicitly set by userspace. If that does not happen, the resume path will set the offset to 0 (in my case the h/w default being 3, the offset would become too low after a suspend/resume cycle).
The issue did not arise before commit fe6a6de6692e, as the function setting the offset would return if the offset was 0. This is no longer the case (rightfully).
Fix this by not applying the offset if it wasn't saved before, reverting back to the old logic. A better approach will come later, but this will be easier to apply to stable kernels.
The logic to restore the offset after a resume was there long before commit fe6a6de6692e, but as a value of 0 was considered invalid I'm referencing the commit that made the issue possible in the Fixes tag instead.
--- drivers/thermal/intel/int340x_thermal/processor_thermal_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/thermal/intel/int340x_thermal/processor_thermal_device.c +3 -2
@@ -185,7 +185,7 @@ static int tcc_offset_update(unsigned inreturn 0 ; } -static unsigned int tcc_offset_save; +static int tcc_offset_save =-1 ; static ssize_t tcc_offset_degree_celsius_store(struct device *dev, struct device_attribute *attr, const char *buf,
@@ -709,7 +709,8 @@ static int proc_thermal_resume(struct de proc_dev =dev_get_drvdata (dev);proc_thermal_read_ppcc (proc_dev); -tcc_offset_update (tcc_offset_save); +if (tcc_offset_save >=0 ) +tcc_offset_update (tcc_offset_save);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 101/103 USB: serial: cp210x: fix dropped characters with CP2102
In reply to Greg Kroah-HartmanFrom: Johan Hovold <[email protected]>
commit c32dfec6c1c36bbbcd5d33e949d99aeb215877ec upstream.
Some CP2102 do not support event-insertion mode but return no error when attempting to enable it.
This means that any event escape characters in the input stream will not be escaped by the device and consequently regular data may be interpreted as escape sequences and be removed from the stream by the driver.
The reporter's device has batch number DCL00X etched into it and as discovered by the SHA2017 Badge team, counterfeit devices with that marking can be detected by sending malformed vendor requests. [1][2]
Tests confirm that the possibly counterfeit CP2102 returns a single byte in response to a malformed two-byte part-number request, while an original CP2102 returns two bytes. Assume that every CP2102 that behaves this way also does not support event-insertion mode (e.g. cannot report parity errors).
[1] https://mobile.twitter.com/sha2017badge/status/1167902087289532418
[2] https://hackaday.com/2017/08/14/hands-on-with-the-shacamp-2017-badge/#comment-3903376
--- drivers/usb/serial/cp210x.c | 46 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+)
drivers/usb/serial/cp210x.c +46 -0
@@ -261,6 +261,7 @@ struct cp210x_serial_private {speed_t min_speed;speed_t max_speed;bool use_actual_rate; +bool no_event_mode; };enum cp210x_event_state {
@@ -1332,12 +1333,16 @@ static void cp210x_change_speed(struct tstatic void cp210x_enable_event_mode (struct usb_serial_port *port) { +struct cp210x_serial_private *priv =usb_get_serial_data (port->serial);struct cp210x_port_private *port_priv =usb_get_serial_port_data (port);int ret;if (port_priv->event_mode)return ; +if (priv->no_event_mode) +return ; + port_priv->event_state =ES_DATA ; port_priv->event_mode = true;
@@ -2087,6 +2092,46 @@ static void cp210x_init_max_speed(struct priv->use_actual_rate = use_actual_rate; } +static void cp2102_determine_quirks (struct usb_serial *serial) +{ +struct cp210x_serial_private *priv =usb_get_serial_data (serial); +u8 *buf; +int ret; + + buf =kmalloc (2 ,GFP_KERNEL ); +if (!buf) +return ; +/* +* Some (possibly counterfeit) CP2102 do not support event-insertion +* mode and respond differently to malformed vendor requests. +* Specifically, they return one instead of two bytes when sent a +* two-byte part-number request. +*/ + ret =usb_control_msg (serial->dev,usb_rcvctrlpipe (serial->dev,0 ), +CP210X_VENDOR_SPECIFIC ,REQTYPE_DEVICE_TO_HOST , +CP210X_GET_PARTNUM ,0 , buf,2 ,USB_CTRL_GET_TIMEOUT ); +if (ret ==1 ) { +dev_dbg (&serial->interface->dev, +"device does not support event-insertion mode\n" ); + priv->no_event_mode = true; + } + +kfree (buf); +} + +static void cp210x_determine_quirks (struct usb_serial *serial) +{ +struct cp210x_serial_private *priv =usb_get_serial_data (serial); + +switch (priv->partnum) { +case CP210X_PARTNUM_CP2102 : +cp2102_determine_quirks (serial); +break ; +default : +break ; + } +} +static int cp210x_attach (struct usb_serial *serial) {int result;
@@ -2107,6 +2152,7 @@ static int cp210x_attach(struct usb_seriusb_set_serial_data (serial, priv); +cp210x_determine_quirks (serial);cp210x_init_max_speed (serial); result =cp210x_gpio_init (serial);
Greg Kroah-Hartman
maintainerPATCH 102/103 xen/balloon: fix balloon kthread freezing
In reply to Greg Kroah-HartmanFrom: Juergen Gross <[email protected]>
commit 96f5bd03e1be606987644b71899ea56a8d05f825 upstream.
Commit 8480ed9c2bbd56 ("xen/balloon: use a kernel thread instead a workqueue") switched the Xen balloon driver to use a kernel thread. Unfortunately the patch omitted to call try_to_freeze() or to use wait_event_freezable_timeout(), causing a system suspend to fail.
--- drivers/xen/balloon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/xen/balloon.c +2 -2
@@ -522,8 +522,8 @@ static int balloon_thread(void *unused) timeout =3600 *HZ ; credit =current_credit (); -wait_event_interruptible_timeout (balloon_thread_wq, -balloon_thread_cond (state, credit), timeout); +wait_event_freezable_timeout (balloon_thread_wq, +balloon_thread_cond (state, credit), timeout);if (kthread_should_stop ())return 0 ;
Greg Kroah-Hartman
maintainerPATCH 103/103 qnx4: work around gcc false positive warning bug
In reply to Greg Kroah-HartmanFrom: Linus Torvalds <[email protected]>
commit d5f6545934c47e97c0b48a645418e877b452a992 upstream.
In commit b7213ffa0e58 ("qnx4: avoid stringop-overread errors") I tried to teach gcc about how the directory entry structure can be two different things depending on a status flag. It made the code clearer, and it seemed to make gcc happy.
However, Arnd points to a gcc bug, where despite using two different members of a union, gcc then gets confused, and uses the size of one of the members to decide if a string overrun happens. And not necessarily the rigth one.
End result: with some configurations, gcc-11 will still complain about the source buffer size being overread:
fs/qnx4/dir.c: In function 'qnx4_readdir':
fs/qnx4/dir.c:76:32: error: 'strnlen' specified bound [16, 48] exceeds source size 1 [-Werror=stringop-overread]
76 | size = strnlen(name, size);
| ^~~~~~~~~~~~~~~~~~~
fs/qnx4/dir.c:26:22: note: source object declared here
26 | char de_name;
| ^~~~~~~because gcc will get confused about which union member entry is actually getting accessed, even when the source code is very clear about it. Gcc internally will have combined two "redundant" pointers (pointing to different union elements that are at the same offset), and takes the size checking from one or the other - not necessarily the right one.
This is clearly a gcc bug, but we can work around it fairly easily. The biggest thing here is the big honking comment about why we do what we do.
--- fs/qnx4/dir.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-)
fs/qnx4/dir.c +27 -9
@@ -20,12 +20,33 @@* depending on the status field in the last byte. The * first byte is where the name start either way, and a * zero means it's empty. +* +* Also, due to a bug in gcc, we don't want to use the +* real (differently sized) name arrays in the inode and +* link entries, but always the 'de_name[]' one in the +* fake struct entry. +* +* See +* +* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c6 +* +* for details, but basically gcc will take the size of the +* 'name' array from one of the used union entries randomly. +* +* This use of 'de_name[]' (48 bytes) avoids the false positive +* warnings that would happen if gcc decides to use 'inode.di_name' +* (16 bytes) even when the pointer and size were to come from +* 'link.dl_name' (48 bytes). +* +* In all cases the actual name pointer itself is the same, it's +* only the gcc internal 'what is the size of this field' logic +* that can get confused. */ union qnx4_directory_entry {struct { -char de_name; -char de_pad[62 ]; -char de_status; +const char de_name[48 ]; +u8 de_pad[15 ]; +u8 de_status; };struct qnx4_inode_entry inode;struct qnx4_link_info link;
@@ -53,29 +74,26 @@ static int qnx4_readdir(struct file *fil ix = (ctx->pos >>QNX4_DIR_ENTRY_SIZE_BITS ) %QNX4_INODES_PER_BLOCK ;for (; ix <QNX4_INODES_PER_BLOCK ; ix++, ctx->pos +=QNX4_DIR_ENTRY_SIZE ) {union qnx4_directory_entry *de; -const char *name; offset = ix *QNX4_DIR_ENTRY_SIZE ; de = (union qnx4_directory_entry *) (bh->b_data + offset); -if (!de->de_name) +if (!de->de_name[0 ])continue ;if (!(de->de_status & (QNX4_FILE_USED |QNX4_FILE_LINK )))continue ;if (!(de->de_status &QNX4_FILE_LINK )) { size =sizeof (de->inode.di_fname); - name = de->inode.di_fname; ino = blknum *QNX4_INODES_PER_BLOCK + ix -1 ; }else { size =sizeof (de->link.dl_fname); - name = de->link.dl_fname; ino = (le32_to_cpu (de->link.dl_inode_blk) -1 ) *QNX4_INODES_PER_BLOCK + de->link.dl_inode_ndx; } - size =strnlen (name, size); + size =strnlen (de->de_name, size);QNX4DEBUG ((KERN_INFO "qnx4_readdir:%.*s\n" , size, name)); -if (!dir_emit (ctx, name, size, ino,DT_UNKNOWN )) { +if (!dir_emit (ctx, de->de_name, size, ino,DT_UNKNOWN )) {brelse (bh);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 92/103 qnx4: avoid stringop-overread errors
In reply to Greg Kroah-HartmanFrom: Linus Torvalds <[email protected]>
[ Upstream commit b7213ffa0e585feb1aee3e7173e965e66ee0abaa ]
The qnx4 directory entries are 64-byte blocks that have different contents depending on the a status byte that is in the last byte of the block.
In particular, a directory entry can be either a "link info" entry with a 48-byte name and pointers to the real inode information, or an "inode entry" with a smaller 16-byte name and the full inode information.
But the code was written to always just treat the directory name as if it was part of that "inode entry", and just extend the name to the longer case if the status byte said it was a link entry.
That work just fine and gives the right results, but now that gcc is tracking data structure accesses much more, the code can trigger a compiler error about using up to 48 bytes (the long name) in a structure that only has that shorter name in it:
fs/qnx4/dir.c: In function ‘qnx4_readdir’:
fs/qnx4/dir.c:51:32: error: ‘strnlen’ specified bound 48 exceeds source size 16 [-Werror=stringop-overread]
51 | size = strnlen(de->di_fname, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from fs/qnx4/qnx4.h:3,
from fs/qnx4/dir.c:16:
include/uapi/linux/qnx4_fs.h:45:25: note: source object declared here
45 | char di_fname[QNX4_SHORT_NAME_MAX];
| ^~~~~~~~which is because the source code doesn't really make this whole "one of two different types" explicit.
Fix this by introducing a very explicit union of the two types, and basically explaining to the compiler what is really going on.
--- fs/qnx4/dir.c | 51 ++++++++++++++++++++++++++++++++++----------------- 1 file changed, 34 insertions(+), 17 deletions(-)
fs/qnx4/dir.c +34 -17
@@ -15,13 +15,27 @@#include <linux/buffer_head.h> #include "qnx4.h" +/* +* A qnx4 directory entry is an inode entry or link info +* depending on the status field in the last byte. The +* first byte is where the name start either way, and a +* zero means it's empty. +*/ +union qnx4_directory_entry { +struct { +char de_name; +char de_pad[62 ]; +char de_status; + }; +struct qnx4_inode_entry inode; +struct qnx4_link_info link; +}; +static int qnx4_readdir (struct file *file,struct dir_context *ctx) {struct inode *inode =file_inode (file);unsigned int offset;struct buffer_head *bh; -struct qnx4_inode_entry *de; -struct qnx4_link_info *le;unsigned long blknum;int ix, ino;int size;
@@ -38,27 +52,30 @@ static int qnx4_readdir(struct file *file, struct dir_context *ctx) } ix = (ctx->pos >>QNX4_DIR_ENTRY_SIZE_BITS ) %QNX4_INODES_PER_BLOCK ;for (; ix <QNX4_INODES_PER_BLOCK ; ix++, ctx->pos +=QNX4_DIR_ENTRY_SIZE ) { +union qnx4_directory_entry *de; +const char *name; + offset = ix *QNX4_DIR_ENTRY_SIZE ; - de = (struct qnx4_inode_entry *) (bh->b_data + offset); -if (!de->di_fname[0 ]) + de = (union qnx4_directory_entry *) (bh->b_data + offset); + +if (!de->de_name)continue ; -if (!(de->di_status & (QNX4_FILE_USED |QNX4_FILE_LINK ))) +if (!(de->de_status & (QNX4_FILE_USED |QNX4_FILE_LINK )))continue ; -if (!(de->di_status &QNX4_FILE_LINK )) - size =QNX4_SHORT_NAME_MAX ; -else - size =QNX4_NAME_MAX ; - size =strnlen (de->di_fname, size); -QNX4DEBUG ((KERN_INFO "qnx4_readdir:%.*s\n" , size, de->di_fname)); -if (!(de->di_status &QNX4_FILE_LINK )) +if (!(de->de_status &QNX4_FILE_LINK )) { + size =sizeof (de->inode.di_fname); + name = de->inode.di_fname; ino = blknum *QNX4_INODES_PER_BLOCK + ix -1 ; -else { - le = (struct qnx4_link_info *)de; - ino = (le32_to_cpu (le->dl_inode_blk) -1 ) * + }else { + size =sizeof (de->link.dl_fname); + name = de->link.dl_fname; + ino = (le32_to_cpu (de->link.dl_inode_blk) -1 ) *QNX4_INODES_PER_BLOCK + - le->dl_inode_ndx; + de->link.dl_inode_ndx; } -if (!dir_emit (ctx, de->di_fname, size, ino,DT_UNKNOWN )) { + size =strnlen (name, size); +QNX4DEBUG ((KERN_INFO "qnx4_readdir:%.*s\n" , size, name)); +if (!dir_emit (ctx, name, size, ino,DT_UNKNOWN )) {brelse (bh);return 0 ; }
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 93/103 parisc: Use absolute_pointer() to define PAGE0
In reply to Greg Kroah-HartmanFrom: Helge Deller <[email protected]>
[ Upstream commit 90cc7bed1ed19f869ae7221a6b41887fe762a6a3 ]
Use absolute_pointer() wrapper for PAGE0 to avoid this compiler warning:
arch/parisc/kernel/setup.c: In function 'start_parisc':
error: '__builtin_memcmp_eq' specified bound 8 exceeds source size 0
--- arch/parisc/include/asm/page.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/include/asm/page.h +1 -1
@@ -184,7 +184,7 @@ extern int npmem_ranges;#include <asm-generic/getorder.h> #include <asm/pdc.h> -#define PAGE0 ((struct zeropage *)__PAGE_OFFSET) +#define PAGE0 ((struct zeropage *)absolute_pointer(__PAGE_OFFSET))/* DEFINITION OF THE ZERO-PAGE (PAG0) */ /* based on work by Jason Eckhardt ([email protected]) */
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 94/103 arm64: Mark __stack_chk_guard as __ro_after_init
In reply to Greg Kroah-HartmanFrom: Dan Li <[email protected]>
[ Upstream commit 9fcb2e93f41c07a400885325e7dbdfceba6efaec ]
__stack_chk_guard is setup once while init stage and never changed after that.
Although the modification of this variable at runtime will usually cause the kernel to crash (so does the attacker), it should be marked as __ro_after_init, and it should not affect performance if it is placed in the ro_after_init section.
--- arch/arm64/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/process.c +1 -1
@@ -60,7 +60,7 @@#if defined(CONFIG_STACKPROTECTOR ) && !defined(CONFIG_STACKPROTECTOR_PER_TASK )#include <linux/stackprotector.h> -unsigned long __stack_chk_guard__read_mostly ; +unsigned long __stack_chk_guard__ro_after_init ;EXPORT_SYMBOL (__stack_chk_guard);#endif
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 95/103 alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
[ Upstream commit 35a3f4ef0ab543daa1725b0c963eb8c05e3376f8 ]
Some drivers pass a pointer to volatile data to virt_to_bus() and virt_to_phys(), and that works fine. One exception is alpha. This results in a number of compile errors such as
drivers/net/wan/lmc/lmc_main.c: In function 'lmc_softreset':
drivers/net/wan/lmc/lmc_main.c:1782:50: error:
passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type
drivers/atm/ambassador.c: In function 'do_loader_command':
drivers/atm/ambassador.c:1747:58: error:
passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type
Declare the parameter of virt_to_phys and virt_to_bus as pointer to volatile to fix the problem.
--- arch/alpha/include/asm/io.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/alpha/include/asm/io.h +3 -3
@@ -60,7 +60,7 @@ extern inline void set_hae(unsigned long new_hae)* Change virtual addresses to physical addresses and vv. */ #ifdef USE_48_BIT_KSEG -static inline unsigned long virt_to_phys (void *address) +static inline unsigned long virt_to_phys (volatile void *address) {return (unsigned long )address -IDENT_ADDR ; }
@@ -70,7 +70,7 @@ static inline void * phys_to_virt(unsigned long address) return (void *) (address + IDENT_ADDR); }#else -static inline unsigned long virt_to_phys (void *address) +static inline unsigned long virt_to_phys (volatile void *address) {unsigned long phys = (unsigned long )address;
@@ -106,7 +106,7 @@ static inline void * phys_to_virt(unsigned long address)extern unsigned long __direct_map_base;extern unsigned long __direct_map_size; -static inline unsigned long __deprecated virt_to_bus (void *address) +static inline unsigned long __deprecated virt_to_bus (volatile void *address) {unsigned long phys =virt_to_phys (address);unsigned long bus = phys + __direct_map_base;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 96/103 net: 6pack: Fix tx timeout and slot time
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
[ Upstream commit 3c0d2a46c0141913dc6fd126c57d0615677d946e ]
tx timeout and slot time are currently specified in units of HZ. On Alpha, HZ is defined as 1024. When building alpha:allmodconfig, this results in the following error message.
drivers/net/hamradio/6pack.c: In function 'sixpack_open':
drivers/net/hamradio/6pack.c:71:41: error:
unsigned conversion from 'int' to 'unsigned char' changes value from '256' to '0'
In the 6PACK protocol, tx timeout is specified in units of 10 ms and transmitted over the wire:
https://www.linux-ax25.org/wiki/6PACK
Defining a value dependent on HZ doesn't really make sense, and presumably comes from the (very historical) situation where HZ was originally 100.
Note that the SIXP_SLOTTIME use explicitly is about 10ms granularity:
mod_timer(&sp->tx_t, jiffies + ((when + 1) * HZ) / 100);
and the SIXP_TXDELAY walue is sent as a byte over the wire.
--- drivers/net/hamradio/6pack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/hamradio/6pack.c +2 -2
@@ -68,9 +68,9 @@#define SIXP_DAMA_OFF 0/* default level 2 parameters */ -#define SIXP_TXDELAY (HZ/4)/* in 1 s */ +#define SIXP_TXDELAY 25/* 250 ms */ #define SIXP_PERSIST 50/* in 256ths */ -#define SIXP_SLOTTIME (HZ/10)/* in 1 s */ +#define SIXP_SLOTTIME 10/* 100 ms */ #define SIXP_INIT_RESYNC_TIMEOUT (3*HZ/2)/* in 1 s */ #define SIXP_RESYNC_TIMEOUT 5*HZ/* in 1 s */
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 97/103 spi: Fix tegra20 build with CONFIG_PM=n
In reply to Greg Kroah-HartmanFrom: Linus Torvalds <[email protected]>
[ Upstream commit efafec27c5658ed987e720130772f8933c685e87 ]
Without CONFIG_PM enabled, the SET_RUNTIME_PM_OPS() macro ends up being empty, and the only use of tegra_slink_runtime_{resume,suspend} goes away, resulting in
drivers/spi/spi-tegra20-slink.c:1200:12: error: ‘tegra_slink_runtime_resume’ defined but not used [-Werror=unused-function]
1200 | static int tegra_slink_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/spi/spi-tegra20-slink.c:1188:12: error: ‘tegra_slink_runtime_suspend’ defined but not used [-Werror=unused-function]
1188 | static int tegra_slink_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~mark the functions __maybe_unused to make the build happy.
This hits the alpha allmodconfig build (and others).
--- drivers/spi/spi-tegra20-slink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-tegra20-slink.c +2 -2
@@ -1201,7 +1201,7 @@ static int tegra_slink_resume(struct device *dev) }#endif -static int tegra_slink_runtime_suspend (struct device *dev) +static int __maybe_unused tegra_slink_runtime_suspend (struct device *dev) {struct spi_master *master =dev_get_drvdata (dev);struct tegra_slink_data *tspi =spi_master_get_devdata (master);
@@ -1213,7 +1213,7 @@ static int tegra_slink_runtime_suspend(struct device *dev)return 0 ; } -static int tegra_slink_runtime_resume (struct device *dev) +static int __maybe_unused tegra_slink_runtime_resume (struct device *dev) {struct spi_master *master =dev_get_drvdata (dev);struct tegra_slink_data *tspi =spi_master_get_devdata (master);
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 98/103 EDAC/synopsys: Fix wrong value type assignment for edac_mode
In reply to Greg Kroah-HartmanFrom: Sai Krishna Potthuri <[email protected]>
commit 5297cfa6bdf93e3889f78f9b482e2a595a376083 upstream.
dimm->edac_mode contains values of type enum edac_type - not the corresponding capability flags. Fix that.
Issue caught by Coverity check "enumerated type mixed with another type."
[ bp: Rewrite commit message, add tags. ]
--- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/synopsys_edac.c +1 -1
@@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_ifor (j =0 ; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; - dimm->edac_mode =EDAC_FLAG_SECDED ; + dimm->edac_mode =EDAC_SECDED ; dimm->mtype = p_data->get_mtype (priv->baseaddr); dimm->nr_pages = (size >>PAGE_SHIFT ) / csi->nr_channels; dimm->grain =SYNPS_EDAC_ERR_GRAIN ;
Greg Kroah-Hartman
maintainerPATCH 99/103 EDAC/dmc520: Assign the proper type to dimm->edac_mode
In reply to Greg Kroah-HartmanFrom: Borislav Petkov <[email protected]>
commit 54607282fae6148641a08d81a6e0953b541249c7 upstream.
dimm->edac_mode contains values of type enum edac_type - not the corresponding capability flags. Fix that.
--- drivers/edac/dmc520_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/dmc520_edac.c +1 -1
@@ -464,7 +464,7 @@ static void dmc520_init_csrow(struct mem dimm->grain = pvt->mem_width_in_bytes; dimm->dtype = dt; dimm->mtype = mt; - dimm->edac_mode =EDAC_FLAG_SECDED ; + dimm->edac_mode =EDAC_SECDED ; dimm->nr_pages = pages_per_rank / csi->nr_channels; } }
Greg Kroah-Hartman
maintainerPATCH 90/103 net: i825xx: Use absolute_pointer for memcpy from fixed memory location
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
[ Upstream commit dff2d13114f0beec448da9b3716204eb34b0cf41 ]
gcc 11.x reports the following compiler warning/error.
drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe':
arch/m68k/include/asm/string.h:72:25: error:
'__builtin_memcpy' reading 6 bytes from a region of size 0 [-Werror=stringop-overread]
Use absolute_pointer() to work around the problem.
--- drivers/net/ethernet/i825xx/82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/i825xx/82596.c +1 -1
@@ -1155,7 +1155,7 @@ struct net_device * __init i82596_probe(int unit) err = -ENODEV ; goto out; } -memcpy (eth_addr, (void *)0xfffc1f2c ,ETH_ALEN );/* YUCK! Get addr from NOVRAM */ +memcpy (eth_addr,absolute_pointer (0xfffc1f2c ),ETH_ALEN );/* YUCK! Get addr from NOVRAM */ dev->base_addr =MVME_I596_BASE ; dev->irq = (unsigned ) MVME16x_IRQ_I596; goto found;
Signature · 1 line
2.33.0
Greg Kroah-Hartman
maintainerPATCH 59/103 nvme-tcp: fix incorrect h2cdata pdu offset accounting
In reply to Greg Kroah-HartmanFrom: Sagi Grimberg <[email protected]>
[ Upstream commit e371af033c560b9dd1e861f8f0b503142bf0a06c ]
When the controller sends us multiple r2t PDUs in a single request we need to account for it correctly as our send/recv context run concurrently (i.e. we get a new r2t with r2t_offset before we updated our iterator and req->data_sent marker). This can cause wrong offsets to be sent to the controller.
To fix that, we will first know that this may happen only in the send sequence of the last page, hence we will take the r2t_offset to the h2c PDU data_offset, and in nvme_tcp_try_send_data loop, we make sure to increment the request markers also when we completed a PDU but we are expecting more r2t PDUs as we still did not send the entire data of the request.
--- drivers/nvme/host/tcp.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/nvme/host/tcp.c +10 -3
@@ -611,7 +611,7 @@ static int nvme_tcp_setup_h2c_data_pdu(struct nvme_tcp_request *req,cpu_to_le32 (data->hdr.hlen + hdgst + req->pdu_len + ddgst); data->ttag = pdu->ttag; data->command_id =nvme_cid (rq); - data->data_offset =cpu_to_le32 (req->data_sent); + data->data_offset = pdu->r2t_offset; data->data_length =cpu_to_le32 (req->pdu_len);return 0 ; }
@@ -937,7 +937,15 @@ static int nvme_tcp_try_send_data(struct nvme_tcp_request *req)nvme_tcp_ddgst_update (queue->snd_hash, page, offset, ret); -/* fully successful last write*/ +/* +* update the request iterator except for the last payload send +* in the request where we don't want to modify it as we may +* compete with the RX path completing the request. +*/ +if (req->data_sent + ret < req->data_len) +nvme_tcp_advance_req (req, ret); + +/* fully successful last send in current PDU */ if (last && ret == len) {if (queue->data_digest) { nvme_tcp_ddgst_final(queue->snd_hash,
@@ -949,7 +957,6 @@ static int nvme_tcp_try_send_data(struct nvme_tcp_request *req) }return 1 ; } -nvme_tcp_advance_req (req, ret); }return -EAGAIN ; }
Signature · 1 line
2.33.0
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Following commit caused the build failures on s390,
Quoted 2 lines
Alexandra Winter <[email protected]>
s390/qeth: fix deadlock during failing recovery
drivers/s390/net/qeth_core_main.c: In function 'qeth_close_dev_handler':drivers/s390/net/qeth_core_main.c:83:9: error: too few arguments to function 'ccwgroup_set_offline'
83 | ccwgroup_set_offline(card->gdev);
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/s390/net/qeth_core.h:44,
from drivers/s390/net/qeth_core_main.c:46:
arch/s390/include/asm/ccwgroup.h:61:5: note: declared here
61 | int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv);
| ^~~~~~~~~~~~~~~~~~~~make[3]: *** [scripts/Makefile.build:280:drivers/s390/net/qeth_core_main.o] Error 1
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Re: [PATCH 5.10 048/103] s390/qeth: fix deadlock during failing recovery
In reply to Greg Kroah-HartmanFollowing commit caused the build failures on s390,
Quoted 91 lines · Greg Kroah-Hartman
From: Alexandra Winter <[email protected]>
[ Upstream commit
d2b59bd4b06d84a4eadb520b0f71c62fe8ec0a62]Commit
0b9902c1fcc5("s390/qeth: fix deadlock during recovery") removed takingdiscipline_mutexinsideqeth_do_reset(), fixing potential deadlocks. An error path was missed though, that still takesdiscipline_mutexand thus has the original deadlock potential.Intermittent deadlocks were seen when a qeth channel path is configured offline, causing a race between
qeth_do_resetandccwgroup_remove. Callqeth_set_offline()directly in theqeth_do_reset()error case and then a new variant ofccwgroup_set_offline(), without takingdiscipline_mutex.Fixes b41b554c1ee7 ("s390/qeth: fix locking for discipline setup / removal")Signed-off-by Alexandra Winter <[email protected]>Reviewed-by Julian Wiedmann <[email protected]>Signed-off-by Julian Wiedmann <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>Signed-off-by Sasha Levin <[email protected]>--- arch/s390/include/asm/ccwgroup.h | 2 +- drivers/s390/cio/ccwgroup.c | 10 ++++++++-- drivers/s390/net/qeth_core_main.c | 3 ++- 3 files changed, 11 insertions(+), 4 deletions(-)arch/s390/include/asm/ccwgroup.h +1
-1@@ -58,7 +58,7 @@ struct ccwgroup_device *get_ccwgroupdev_by_busid(struct ccwgroup_driver *gdrv, char *bus_id);extern int ccwgroup_set_online (struct ccwgroup_device *gdev); -extern int ccwgroup_set_offline (struct ccwgroup_device *gdev); +int ccwgroup_set_offline (struct ccwgroup_device *gdev,bool call_gdrv);extern int ccwgroup_probe_ccwdev (struct ccw_device *cdev);extern void ccwgroup_remove_ccwdev (struct ccw_device *cdev);drivers/s390/cio/ccwgroup.c +8
-2@@ -98,12 +98,13 @@ EXPORT_SYMBOL(ccwgroup_set_online);/** * ccwgroup_set_offline() - disable a ccwgroup device * @gdev: target ccwgroup device +* @call_gdrv: Call the registered gdrv set_offline function * * This function attempts to put the ccwgroup device into the offline state. * Returns: * %0 on success and a negative error value on failure. */ -int ccwgroup_set_offline (struct ccwgroup_device *gdev) +int ccwgroup_set_offline (struct ccwgroup_device *gdev,bool call_gdrv) {struct ccwgroup_driver *gdrv =to_ccwgroupdrv (gdev->dev.driver);int ret = -EINVAL ;@@ -112,11 +113,16 @@ int ccwgroup_set_offline(struct ccwgroup_device *gdev)return -EAGAIN ;if (gdev->state ==CCWGROUP_OFFLINE ) goto out; +if (!call_gdrv) { + ret =0 ; + goto offline; + }if (gdrv->set_offline) ret = gdrv->set_offline (gdev);if (ret) goto out; +offline: gdev->state =CCWGROUP_OFFLINE ; out:atomic_set (&gdev->onoff,0 );@@ -145,7 +151,7 @@ static ssize_t ccwgroup_online_store(struct device *dev,if (value ==1 ) ret =ccwgroup_set_online (gdev);else if (value ==0 ) - ret =ccwgroup_set_offline (gdev); + ret =ccwgroup_set_offline (gdev, true);else ret = -EINVAL ; out:drivers/s390/net/qeth_core_main.c +0
-0
drivers/s390/net/qeth_core_main.c static int qeth_do_reset(void *data) · line 5410
Quoted 6 lines
drivers/s390/net/qeth_core_main.c +2
-1@@ -5406,7 +5406,8 @@ static int qeth_do_reset(void *data)dev_info (&card->gdev->dev,"Device successfully recovered!\n" ); }else { -ccwgroup_set_offline (card->gdev); +qeth_set_offline (card, disc, true); +ccwgroup_set_offline (card->gdev, false);
drivers/s390/net/qeth_core_main.c: In function 'qeth_close_dev_handler':drivers/s390/net/qeth_core_main.c:83:9: error: too few arguments to function 'ccwgroup_set_offline'
83 | ccwgroup_set_offline(card->gdev);
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/s390/net/qeth_core.h:44,
from drivers/s390/net/qeth_core_main.c:46:
arch/s390/include/asm/ccwgroup.h:61:5: note: declared here
61 | int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv);
| ^~~~~~~~~~~~~~~~~~~~make[3]: *** [scripts/Makefile.build:280:drivers/s390/net/qeth_core_main.o] Error 1
Build url:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1626658768#L73
--
Linaro LKFT
https://lkft.linaro.org
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels:
Signature · 1 line
Florian
Re: [PATCH 5.10 048/103] s390/qeth: fix deadlock during failing recovery
In reply to Naresh KambojuQuoted 2 lines · Naresh Kamboju
Following commit caused the build failures on s390,
Also noticed on stable-rc 5.10 and 5.14 branches.
Quoted 35 lines
drivers/s390/net/qeth_core_main.c static int qeth_do_reset(void *data) · line 5410
Quoted 11 lines
drivers/s390/net/qeth_core_main.c +2
-1@@ -5406,7 +5406,8 @@ static int qeth_do_reset(void *data)dev_info (&card->gdev->dev,"Device successfully recovered!\n" ); }else { -ccwgroup_set_offline (card->gdev); +qeth_set_offline (card, disc, true); +ccwgroup_set_offline (card->gdev, false);
drivers/s390/net/qeth_core_main.c: In function 'qeth_close_dev_handler':drivers/s390/net/qeth_core_main.c:83:9: error: too few arguments to function 'ccwgroup_set_offline'83 | ccwgroup_set_offline(card->gdev); | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/s390/net/qeth_core.h:44, from drivers/s390/net/qeth_core_main.c:46: arch/s390/include/asm/ccwgroup.h:61:5: note: declared here 61 | int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv); | ^~~~~~~~~~~~~~~~~~~~make[3]: *** [
scripts/Makefile.build:280:drivers/s390/net/qeth_core_main.o] Error 1Build url:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1626658768#L73--
Linaro LKFT
https://lkft.linaro.org
Hu!
Quoted 4 lines
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
5.10.70-rc1 Successfully Compiled and booted on my Raspberry PI 4b (8g) (bcm2711)
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
75 tests: 75 pass, 0 failLinux version: 5.10.70-rc1-gf5ab3f2ed675
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04Jon
Greg Kroah-Hartman
maintainerRe: [PATCH 5.10 048/103] s390/qeth: fix deadlock during failing recovery
In reply to Naresh KambojuQuoted 5 lines · Naresh Kamboju
Quoted 2 lines · Naresh Kamboju
Following commit caused the build failures on s390,
Also noticed on stable-rc 5.10 and 5.14 branches.
Thanks, now dropped on both branches.
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.70 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.70-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Tested on arm64 and x86 for 5.10.70-rc1,
Kernel repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-5.10.y
Version: 5.10.70-rc1
Commit: f5ab3f2ed675e0ca060bf87466c9ac2406f1d83f
Compiler: gcc version 7.3.0 (GCC)
arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8907
passed: 8907
failed: 0
timeout: 0
--------------------------------------------------------------------
x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8907
passed: 8907
failed: 0
timeout: 0
--------------------------------------------------------------------
Re: [PATCH 5.10 048/103] s390/qeth: fix deadlock during failing recovery
In reply to Naresh KambojuQuoted 9 lines · Naresh Kamboju
Following commit caused the build failures on s390,
Quoted 5 lines · Greg Kroah-Hartman
From: Alexandra Winter <[email protected]>
[ Upstream commit
d2b59bd4b06d84a4eadb520b0f71c62fe8ec0a62]
Yes, this depends on ee909d0b1dac ("s390/qeth: Fix deadlock in remove_discipline").
Quoted 25 lines
drivers/s390/net/qeth_core_main.c: In function 'qeth_close_dev_handler':drivers/s390/net/qeth_core_main.c:83:9: error: too few arguments to function 'ccwgroup_set_offline'83 | ccwgroup_set_offline(card->gdev); | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/s390/net/qeth_core.h:44, from drivers/s390/net/qeth_core_main.c:46: arch/s390/include/asm/ccwgroup.h:61:5: note: declared here 61 | int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv); | ^~~~~~~~~~~~~~~~~~~~make[3]: *** [
scripts/Makefile.build:280:drivers/s390/net/qeth_core_main.o] Error 1Build url:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1626658768#L73--
Linaro LKFT
https://lkft.linaro.org