drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi,low}_bits()
Subsystems (2)
PATCH 1/1 drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi,low}_bits()
clang with W=1 warns:
drivers/gpu/drm/kmb/kmb_dsi.c:812:2: error: unused function 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, ^drivers/gpu/drm/kmb/kmb_dsi.c:824:2: error: unused function 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, ^
2 errors generated.
Remove them, as they have been unused since the driver's introduction in commit 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver").
--- drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- 1 file changed, 28 deletions(-)
drivers/gpu/drm/kmb/kmb_dsi.c +0 -28
@@ -808,34 +808,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no, } } -static inline void -set_test_mode_src_osc_freq_target_low_bits (struct kmb_dsi *kmb_dsi, -u32 dphy_no, -u32 freq) -{ -/* Typical rise/fall time=166, refer Table 1207 databook, -* sr_osc_freq_target[7:0] -*/ -test_mode_send (kmb_dsi, dphy_no,TEST_CODE_SLEW_RATE_DDL_CYCLES , - (freq &0x7f )); -} - -static inline void -set_test_mode_src_osc_freq_target_hi_bits (struct kmb_dsi *kmb_dsi, -u32 dphy_no, -u32 freq) -{ -u32 data; - -/* Flag this as high nibble */ - data = ((freq >>6 ) &0x1f ) | (1 <<7 ); - -/* Typical rise/fall time=166, refer Table 1207 databook, -* sr_osc_freq_target[11:7] -*/ -test_mode_send (kmb_dsi, dphy_no,TEST_CODE_SLEW_RATE_DDL_CYCLES , data); -} -static void mipi_tx_get_vco_params (struct vco_params *vco) {int i;
base-commit: 93ee1a2c0f08345ab17c51198f725d4c95984f4c
Signature · 1 line
2.33.0.591.gddb1055343
Thanks for the patch. Looks good.
Quoted 81 lines
-----Original Message-----
From: Nathan Chancellor <[email protected]>
Sent: Tuesday, September 28, 2021 12:24 PM
To: Chrisanthus, Anitha <[email protected]>; Dea, Edmund J <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>; Nick Desaulniers <[email protected]>; [email protected]; linux- [email protected]; [email protected]; Nathan Chancellor <[email protected]>; lkp <[email protected]>
Subject: [PATCH] drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi,low}_bits()clang with W=1 warns:
drivers/gpu/drm/kmb/kmb_dsi.c:812:2: error: unused function 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_low_bits(structkmb_dsi*kmb_dsi, ^drivers/gpu/drm/kmb/kmb_dsi.c:824:2: error: unused function 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_hi_bits(structkmb_dsi*kmb_dsi, ^
2 errors generated.Remove them, as they have been unused since the driver's introduction in commit
98521f4d4b4c("drm/kmb: Mipi DSI part of the display driver").Reported-by kernel test robot <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- 1 file changed, 28 deletions(-)drivers/gpu/drm/kmb/kmb_dsi.c +0
-26@@ -808,34 +808,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no, } } -static inline void -set_test_mode_src_osc_freq_target_low_bits (struct kmb_dsi *kmb_dsi, -u32 dphy_no, -u32 freq) -{ -/* Typical rise/fall time=166, refer Table 1207 databook, -* sr_osc_freq_target[7:0] -*/ -test_mode_send (kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, - (freq &0x7f )); -} - -static inline void -set_test_mode_src_osc_freq_target_hi_bits (struct kmb_dsi *kmb_dsi, -u32 dphy_no, -u32 freq) -{ -u32 data; - -/* Flag this as high nibble */ - data = ((freq >>6 ) &0x1f ) | (1 <<7 ); - -/* Typical rise/fall time=166, refer Table 1207 databook, -* sr_osc_freq_target[11:7] -*/ - test_mode_send(kmb_dsi, dphy_no,
TEST_CODE_SLEW_RATE_DDL_CYCLES, data);drivers/gpu/drm/kmb/kmb_dsi.c +0
-2-} -static void mipi_tx_get_vco_params (struct vco_params *vco) {int i;base-commit:
93ee1a2c0f08345ab17c51198f725d4c95984f4c--
2.33.0.591.gddb1055343