net/mlx5: Use struct_size() helper in kvzalloc()
Subsystems (4)
PATCH 1/1 net/mlx5: Use struct_size() helper in kvzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worse scenario, could lead to heap overflows.
--- drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c +1 -2
@@ -497,8 +497,7 @@ static struct mlx5_fc_bulk *mlx5_fc_bulk_create(struct mlx5_core_dev *dev) alloc_bitmask =MLX5_CAP_GEN (dev, flow_counter_bulk_alloc); bulk_len = alloc_bitmask >0 ?MLX5_FC_BULK_NUM_FCS (alloc_bitmask) :1 ; - bulk =kvzalloc (sizeof (*bulk) + bulk_len *sizeof (struct mlx5_fc ), -GFP_KERNEL ); + bulk =kvzalloc (struct_size (bulk, fcs, bulk_len),GFP_KERNEL );if (!bulk) goto err_alloc_bulk;
Signature · 1 line
2.27.0
Quoted 8 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.
applied to net-next-mlx5
Quoted 11 lines · Saeed Mahameed
Quoted 8 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.applied to net-next-mlx5
Thanks, Saeed.
--
Gustavo