scsi: pm80xx: Fix misleading log statement in pm8001_mpi_get_nvmd_resp()
Subsystems (2)
PATCH 2/2 scsi: pm80xx: Fix misleading log statement in pm8001_mpi_get_nvmd_resp()
pm8001_mpi_get_nvmd_resp() handles a GET_NVMD_DATA response, not a SET_NVMD_DATA response, as the log statement implies.
Fixes 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp()
race condition")
Reviewed-by Changyuan Lyu <[email protected]>
Signed-off-by Igor Pylypiv <[email protected]>
--- drivers/scsi/pm8001/pm8001_hwi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_hwi.c +1 -1
@@ -3169,7 +3169,7 @@ pm8001_mpi_get_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)* fw_control_context->usrAddr */ complete (pm8001_ha->nvmd_completion); -pm8001_dbg (pm8001_ha,MSG ,"Set nvm data complete!\n" ); +pm8001_dbg (pm8001_ha,MSG ,"Get nvmd data complete!\n" ); ccb->task =NULL ; ccb->ccb_tag =0xFFFFFFFF ;pm8001_tag_free (pm8001_ha, tag);
Signature · 1 line
2.33.0.685.g46640cef36-goog
Quoted 9 lines · Igor Pylypiv
pm8001_mpi_get_nvmd_resp()handles aGET_NVMD_DATAresponse, not aSET_NVMD_DATAresponse, as the log statement implies.Fixes 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp()race condition")
Reviewed-by Changyuan Lyu <[email protected]>Signed-off-by Igor Pylypiv <[email protected]>
Acked-by Jack Wang <[email protected]>
Quoted 20 lines
--- drivers/scsi/pm8001/pm8001_hwi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/pm8001/pm8001_hwi.c +1
-2@@ -3169,7 +3169,7 @@ pm8001_mpi_get_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)* fw_control_context->usrAddr */ complete (pm8001_ha->nvmd_completion); -pm8001_dbg (pm8001_ha,MSG ,"Set nvm data complete!\n" ); +pm8001_dbg (pm8001_ha,MSG ,"Get nvmd data complete!\n" ); ccb->task =NULL ; ccb->ccb_tag =0xFFFFFFFF ;pm8001_tag_free (pm8001_ha, tag); --2.33.0.685.g46640cef36-goog
Martin K. Petersen
AppliedQuoted 8 lines · Igor Pylypiv
pm8001_mpi_get_nvmd_resp()handles aGET_NVMD_DATAresponse, not aSET_NVMD_DATAresponse, as the log statement implies.Fixes 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp()race condition")
[...]
Applied to 5.16/scsi-queue, thanks!
[2/2] scsi: pm80xx: Fix misleading log statement in pm8001_mpi_get_nvmd_resp()
https://git.kernel.org/mkp/scsi/c/4084a7235d38
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering