af_unix: add missing annotation at bpf_iter_unix_seq_stop()
Subsystems (4)
PATCH 1/1 af_unix: add missing annotation at bpf_iter_unix_seq_stop()
Sparse reports a warning at bpf_iter_unix_seq_stop() The root cause is a missing annotation at bpf_iter_unix_seq_stop()
Add the missing __releases(unix_table_lock) annotation
--- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+)
net/unix/af_unix.c +1 -0
@@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) }static void bpf_iter_unix_seq_stop (struct seq_file *seq,void *v) +__releases (unix_table_lock) {struct bpf_iter_meta meta;struct bpf_prog *prog;
Signature · 1 line
2.32.0
Jakub Kicinski
maintainerQuoted 15 lines · On Sat, 2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
Sparse reports a warning at
bpf_iter_unix_seq_stop()The root cause is a missing annotation atbpf_iter_unix_seq_stop()Add the missing
__releases(unix_table_lock)annotationSigned-off-by Jules Irenge <[email protected]>--- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+)net/unix/af_unix.c +0
-0
net/unix/af_unix.c static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) · line 3297
Quoted 7 lines
net/unix/af_unix.c +1
-0@@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) }static void bpf_iter_unix_seq_stop (struct seq_file *seq,void *v) +__releases (unix_table_lock) {struct bpf_iter_meta meta;struct bpf_prog *prog;
You need to CC bpf@vger... and netdev@vger...
You can drop the CC for linux-kernel@, approximately nobody reads that.
Kuniyuki Iwashima
Acked-byDate: Fri, 1 Oct 2021 18:04:39 -0700 From: Jakub Kicinski <[email protected]>
Quoted 7 lines · On Sat, 2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
Quoted 6 lines
Sparse reports a warning at
bpf_iter_unix_seq_stop()The root cause is a missing annotation atbpf_iter_unix_seq_stop()Add the missing
__releases(unix_table_lock)annotationSigned-off-by Jules Irenge <[email protected]>
I completely missed that...
Thanks!
Quoted 19 lines
Quoted 9 lines
--- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+)net/unix/af_unix.c +0
-0net/unix/af_unix.c static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) · line 3297
Quoted 7 lines
net/unix/af_unix.c +1
-0@@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) }static void bpf_iter_unix_seq_stop (struct seq_file *seq,void *v) +__releases (unix_table_lock) {struct bpf_iter_meta meta;struct bpf_prog *prog;You need to CC bpf@vger... and netdev@vger...
Quoted 1 line
You can drop the CC for linux-kernel@, approximately nobody reads that.
Added bpf and netdev, and dropped linux-kernel.
Thank you.