Skip to contentSkip to conversation

Bluetooth: hci_vhci: Fix to set force_wakeup value

RFC PATCH Superseded Tedd Ho-Jeong An 3 participants 3 messages Oct 2, 2021 – Oct 4, 2021 Bluetooth drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Bluetooth: hci_vhci: Fix to set force_wakeup value

From: Tedd Ho-Jeong An <[email protected]>

This patch sets the wakeup value in the vhci driver data after reading the value.

---
 drivers/bluetooth/hci_vhci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bluetooth/hci_vhci.c +2 -0
index b45db0db347c..5fd91106e853 100644
@@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
 	if (data->wakeup == enable)
 		return -EALREADY;
 
+	data->wakeup = enable;
+
 	return count;
 }
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Hi Tedd,

Quoted 13 lines

This patch sets the wakeup value in the vhci driver data after reading the value.

---
drivers/bluetooth/hci_vhci.c | 2 ++

1 file changed, 2 insertions(+)
drivers/bluetooth/hci_vhci.c +0 -0
index b45db0db347c..5fd91106e853 100644

drivers/bluetooth/hci_vhci.c static ssize_t force_wakeup_write(struct file *file, · line 181

Quoted 6 lines
drivers/bluetooth/hci_vhci.c +2 -0
@@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
 	if (data->wakeup == enable)
 		return -EALREADY;
 
+	data->wakeup = enable;
+
 	return count;

patch looks good, but the commit message is confusing.

Regards

Marcel

#2 lore raw

Hi Marcel, Tedd,

Quoted 19 lines · Marcel Holtmann

Hi Tedd,

Quoted 16 lines

This patch sets the wakeup value in the vhci driver data after reading the value.

---
drivers/bluetooth/hci_vhci.c | 2 ++

1 file changed, 2 insertions(+)
drivers/bluetooth/hci_vhci.c +0 -0
index b45db0db347c..5fd91106e853 100644
@@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
      if (data->wakeup == enable)
              return -EALREADY;
 
Quoted 5 lines

drivers/bluetooth/hci_vhci.c static ssize_t force_wakeup_write(struct file *file, · line 181

Quoted 3 lines
drivers/bluetooth/hci_vhci.c +2 -0
+     data->wakeup = enable;
+
      return count;

patch looks good, but the commit message is confusing.

Ive ended up fixing the original patch since I had to force push due to the pull request problem with committer/sign-off problem.

Quoted 4 lines

Regards

Marcel

Signature · 1 line
Luiz Augusto von Dentz