drm/fbdev: Clamp fbdev surface size if too large
Subsystems (3)
Thomas Zimmermann
maintainerPATCH v2 1/1 drm/fbdev: Clamp fbdev surface size if too large
Clamp the fbdev surface size of the available maximumi height to avoid failing to init console emulation. An example error is shown below.
bad framebuffer height 2304, should be >= 768 && <= 768 [drm] Initialized simpledrm 1.0.0 20200625 for simple-framebuffer.0 on minor 0 simple-framebuffer simple-framebuffer.0: [drm] *ERROR* fbdev: Failed to setup generic emulation (ret=-22)
This is especially a problem with drivers that have very small screen sizes and cannot over-allocate at all.
v2:
* reduce warning level (Ville)
--- drivers/gpu/drm/drm_fb_helper.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_fb_helper.c +6 -0
@@ -1508,6 +1508,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, {struct drm_client_dev *client = &fb_helper->client;struct drm_device *dev = fb_helper->dev; +struct drm_mode_config *config = &dev->mode_config;int ret =0 ;int crtc_count =0 ;struct drm_connector_list_iter conn_iter;
@@ -1665,6 +1666,11 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,/* Handle our overallocation */ sizes.surface_height *= drm_fbdev_overalloc; sizes.surface_height /=100 ; +if (sizes.surface_height > config->max_height) { +drm_dbg_kms (dev,"Fbdev over-allocation too large; clamping height to %d\n" , + config->max_height); + sizes.surface_height = config->max_height; + }/* push down into drivers */ ret = (*fb_helper->funcs->fb_probe)(fb_helper, &sizes);
Signature · 1 line
2.33.0
Quoted 13 lines · Thomas Zimmermann
Clamp the fbdev surface size of the available maximumi height to avoid failing to init console emulation. An example error is shown below.
bad framebuffer height 2304, should be >= 768 && <= 768 [drm] Initialized simpledrm 1.0.0 20200625 for simple-framebuffer.0 on minor 0 simple-framebuffer simple-framebuffer.0: [drm] *ERROR* fbdev: Failed to setup generic emulation (ret=-22)This is especially a problem with drivers that have very small screen sizes and cannot over-allocate at all.
v2:
* reduce warning level (Ville)
Quoted 9 lines
Signed-off-by Thomas Zimmermann <[email protected]>Fixes 11e8f5fd223b ("drm: Add simpledrm driver")Reported-by Amanoel Dawod <[email protected]>Reported-by Zoltán Kővágó <[email protected]>Reported-by Michael Stapelberg <[email protected]>Cc Daniel Vetter <[email protected]>Cc Maxime Ripard <[email protected]>Cc <[email protected]> # v5.14+
Looks sane.
Quoted 30 lines
--- drivers/gpu/drm/drm_fb_helper.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/drm_fb_helper.c +6
-0@@ -1508,6 +1508,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, {struct drm_client_dev *client = &fb_helper->client;struct drm_device *dev = fb_helper->dev; +struct drm_mode_config *config = &dev->mode_config;int ret =0 ;int crtc_count =0 ;struct drm_connector_list_iter conn_iter;@@ -1665,6 +1666,11 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,/* Handle our overallocation */ sizes.surface_height *= drm_fbdev_overalloc; sizes.surface_height /=100 ; +if (sizes.surface_height > config->max_height) { +drm_dbg_kms (dev,"Fbdev over-allocation too large; clamping height to %d\n" , + config->max_height); + sizes.surface_height = config->max_height; + }/* push down into drivers */ ret = (*fb_helper->funcs->fb_probe)(fb_helper, &sizes);Signature · 1 line
2.33.0
Signature · 2 lines
Ville Syrjälä Intel
Quoted 14 lines · Thomas Zimmermann
Clamp the fbdev surface size of the available maximumi height to avoid failing to init console emulation. An example error is shown below.
bad framebuffer height 2304, should be >= 768 && <= 768 [drm] Initialized simpledrm 1.0.0 20200625 for simple-framebuffer.0 on minor 0 simple-framebuffer simple-framebuffer.0: [drm] *ERROR* fbdev: Failed to setup generic emulation (ret=-22)This is especially a problem with drivers that have very small screen sizes and cannot over-allocate at all.
v2:
* reduce warning level (Ville)
Quoted 9 lines
Signed-off-by Thomas Zimmermann <[email protected]>Fixes 11e8f5fd223b ("drm: Add simpledrm driver")Reported-by Amanoel Dawod <[email protected]>Reported-by Zoltán Kővágó <[email protected]>Reported-by Michael Stapelberg <[email protected]>Cc Daniel Vetter <[email protected]>Cc Maxime Ripard <[email protected]>Cc <[email protected]> # v5.14+
Quoted 31 lines
--- drivers/gpu/drm/drm_fb_helper.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/drm_fb_helper.c +6
-1@@ -1508,6 +1508,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, {struct drm_client_dev *client = &fb_helper->client;struct drm_device *dev = fb_helper->dev; +struct drm_mode_config *config = &dev->mode_config;int ret =0 ;int crtc_count =0 ;struct drm_connector_list_iter conn_iter;@@ -1665,6 +1666,11 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,/* Handle our overallocation */ sizes.surface_height *= drm_fbdev_overalloc; sizes.surface_height /=100 ; +if (sizes.surface_height > config->max_height) { +drm_dbg_kms (dev,"Fbdev over-allocation too large; clamping height to %d\n" , + config->max_height); + sizes.surface_height = config->max_height; + }/* push down into drivers */ ret = (*fb_helper->funcs->fb_probe)(fb_helper, &sizes); --2.33.0