serial: 8250_dw: Drop wrong use of ACPI_PTR()

PATCH New Andy Shevchenko 1 participant 1 message Oct 5, 2021

Subsystems (3)

TTY layer and serial drivers Intel LPSS (Low Power SubSystem) drivers Synopsys DesignWare 8250 UART driver

lore

Share & tools

lore

Andy Shevchenko

author reviewer

2021-10-05 14:06 UTC #0 lore raw

PATCH 1/1 serial: 8250_dw: Drop wrong use of ACPI_PTR()

ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused which is not what we want.

Instead of adding ifdeffery here and there, drop ACPI_PTR().

Fixes 6a7320c4669f ("serial: 8250_dw: Add ACPI 5.0 support")

Reported-by Daniel Palmer <[email protected]>

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/tty/serial/8250/8250_dw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/tty/serial/8250/8250_dw.c +1 -1

index d13c2e58f50f..cf87022e73e4 100644
@@ -722,7 +722,7 @@ static struct platform_driver dw8250_platform_driver = {
 		.name		= "dw-apb-uart",
 		.pm		= &dw8250_pm_ops,
 		.of_match_table	= dw8250_of_match,
-		.acpi_match_table = ACPI_PTR(dw8250_acpi_match),
+		.acpi_match_table = dw8250_acpi_match,
 	},
 	.probe			= dw8250_probe,
 	.remove			= dw8250_remove,

Signature · 1 line

2.33.0