Skip to contentSkip to conversation

inkscape 1.1.1 issue

RFC PATCH Applied Antony Pavlov 5 participants 7 messages Oct 6, 2021 – Oct 11, 2021

lore
Share & tools
lore
#0 lore raw

Hi!

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

During barebox sandbox build process I have faced with unexpected inkscape dialog. Also the '--without-gui=' option is depricated. See my build log

barebox$ make
...
Warning: Option --without-gui= is deprecated Unable to init server: Could not connect: Connection refused Background RRGGBBAA: ffffff00
Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
LOGO.S lib/logo/barebox-logo-w640.bblogo.S

  AS      lib/logo/barebox-logo-w640.bblogo.o
  AR      lib/logo/built-in.a
  AR      lib/built-in.a
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      common/version.o
  CC      common/imd-barebox.o
  AR      common/built-in.a
  LD      barebox
  SYSMAP  System.map
  OBJCOPY barebox.bin
  CHKFILESIZE barebox.bin
  LN      barebox-flash-image
antony@cinco:~/barebox$ dpkg -l | grep inkscape
ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
Signature · 7 lines
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Hello Antony,

Quoted 4 lines · Antony Pavlov

Hi!

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

I ran into issues as well when going from 0.92.4 to 1.0.1. Instead of adding another quirk, maybe we should use something else for SVG to PNG that is actually stable.

Any suggestions?

Quoted 29 lines

During barebox sandbox build process I have faced with unexpected inkscape dialog. Also the '--without-gui=' option is depricated. See my build log

barebox$ make
...
Warning: Option --without-gui= is deprecated Unable to init server: Could not connect: Connection refused Background RRGGBBAA: ffffff00
Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
LOGO.S lib/logo/barebox-logo-w640.bblogo.S

  AS      lib/logo/barebox-logo-w640.bblogo.o
  AR      lib/logo/built-in.a
  AR      lib/built-in.a
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      common/version.o
  CC      common/imd-barebox.o
  AR      common/built-in.a
  LD      barebox
  SYSMAP  System.map
  OBJCOPY barebox.bin
  CHKFILESIZE barebox.bin
  LN      barebox-flash-image
antony@cinco:~/barebox$ dpkg -l | grep inkscape
ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw
Quoted 5 lines · Ahmad Fatoum

Hello Antony,

Quoted 2 lines · Antony Pavlov

Hi!

Quoted 8 lines
Quoted 2 lines

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

I ran into issues as well when going from 0.92.4 to 1.0.1. Instead of adding another quirk, maybe we should use something else for SVG to PNG that is actually stable.

Any suggestions?

Perhaps rsvg-convert?

In Debian and Ubuntu, it is part of the librsvg2-bin package.

Signature · 9 lines
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw
In reply to Ahmad Fatoum

Hi,

Quoted 5 lines · Ahmad Fatoum

Hello Antony,

Quoted 2 lines · Antony Pavlov

Hi!

Quoted 8 lines
Quoted 2 lines

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

I ran into issues as well when going from 0.92.4 to 1.0.1. Instead of adding another quirk, maybe we should use something else for SVG to PNG that is actually stable.

Any suggestions?

Maybe using imagemagick's convert ?

How can I see the result of the current solution ?

Quoted 21 lines
Quoted 21 lines

During barebox sandbox build process I have faced with unexpected inkscape dialog. Also the '--without-gui=' option is depricated. See my build log

barebox$ make
...
Warning: Option --without-gui= is deprecated Unable to init server: Could not connect: Connection refused Background RRGGBBAA: ffffff00
Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
LOGO.S lib/logo/barebox-logo-w640.bblogo.S

  AS      lib/logo/barebox-logo-w640.bblogo.o
  AR      lib/logo/built-in.a
  AR      lib/built-in.a
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      common/version.o
  CC      common/imd-barebox.o
  AR      common/built-in.a
Quoted 9 lines
Quoted 8 lines

LD barebox
SYSMAP System.map
OBJCOPY barebox.bin
CHKFILESIZE barebox.bin
LN barebox-flash-image

antony@cinco:~/barebox$ dpkg -l | grep inkscape
ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#4 lore raw

Hello Jules

Quoted 11 lines · Jules Maselbas

Hi,

Quoted 8 lines · Ahmad Fatoum

Hello Antony,

Quoted 4 lines · Antony Pavlov

Hi!

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

Quoted 8 lines
Quoted 5 lines

I ran into issues as well when going from 0.92.4 to 1.0.1. Instead of adding another quirk, maybe we should use something else for SVG to PNG that is actually stable.

Any suggestions?

Maybe using imagemagick's convert ?

How can I see the result of the current solution ?

Build for ARCH=sandbox and look into /logo.
If you enable CONFIG_DRIVER_VIDEO_SDL, you can display the PNGs with e.g. fb0.enable=1 splash /logo/barebox-logo-640.png

Quoted 35 lines
Quoted 30 lines
Quoted 29 lines

During barebox sandbox build process I have faced with unexpected inkscape dialog. Also the '--without-gui=' option is depricated. See my build log

barebox$ make
...
Warning: Option --without-gui= is deprecated Unable to init server: Could not connect: Connection refused Background RRGGBBAA: ffffff00
Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
LOGO.S lib/logo/barebox-logo-w640.bblogo.S

  AS      lib/logo/barebox-logo-w640.bblogo.o
  AR      lib/logo/built-in.a
  AR      lib/built-in.a
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      common/version.o
  CC      common/imd-barebox.o
  AR      common/built-in.a
  LD      barebox
  SYSMAP  System.map
  OBJCOPY barebox.bin
  CHKFILESIZE barebox.bin
  LN      barebox-flash-image
antony@cinco:~/barebox$ dpkg -l | grep inkscape
ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#5 lore raw

RFC PATCH 1/1 logo: Makefile: Replace inkscape with convert

In reply to Antony Pavlov

The uses of inkscape to convert svg to png hasn't been very stable from one version to another, and required quirks from one version to another.

I hope that convert from imagemagick will be a more stable solution.

---
 lib/logo/Makefile | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)
lib/logo/Makefile +8 -11
index 4149d4ff6c..f08beef76b 100644
@@ -1,17 +1,17 @@
 
-OPTS_barebox-logo-w64.bblogo = --export-width=64
+OPTS_barebox-logo-w64.bblogo = -resize 64
 bblogo-$(CONFIG_BAREBOX_LOGO_64) += barebox-logo-w64
 
-OPTS_barebox-logo-w240.bblogo = --export-width=240
+OPTS_barebox-logo-w240.bblogo = -resize 240
 bblogo-$(CONFIG_BAREBOX_LOGO_240) += barebox-logo-w240
 
-OPTS_barebox-logo-w320.bblogo = --export-width=320
+OPTS_barebox-logo-w320.bblogo = -resize 320
 bblogo-$(CONFIG_BAREBOX_LOGO_320) += barebox-logo-w320
 
-OPTS_barebox-logo-w400.bblogo = --export-width=400
+OPTS_barebox-logo-w400.bblogo = -resize 400
 bblogo-$(CONFIG_BAREBOX_LOGO_400) += barebox-logo-w400
 
-OPTS_barebox-logo-w640.bblogo = --export-width=640
+OPTS_barebox-logo-w640.bblogo = -resize 640
 bblogo-$(CONFIG_BAREBOX_LOGO_640) += barebox-logo-w640
 
 obj-y += $(patsubst %,%.bblogo.o,$(bblogo-y))
@@ -38,15 +38,12 @@ cmd_logo_S =							\
 %.bblogo.S: %.bblogo FORCE
 	$(call if_changed,logo_S)
 
-# Inkscape 0.92.4 supports -z -e but Inkscape 1.0 uses --export-type=png
-INKSCAPEOPTS += $(call try-run, inkscape -z -e -,-z -e -,--export-type=png)
-# Inkscape 1.0 supports -o -
-INKSCAPEOPTS += $(call try-run, inkscape -o -,-o -,)
+CONVERTOPTS += -background none
 
-quiet_cmd_logo = LOGO.S  $@
+quiet_cmd_logo = PNG     $@
 cmd_logo =							\
 (								\
-	inkscape $(OPTS_$(@F)) $(INKSCAPEOPTS) $< > $@; \
+	convert $(OPTS_$(@F)) $(CONVERTOPTS) $< png:$@; \
 )
 
 %.bblogo: $(srctree)/Documentation/barebox.svg FORCE
Signature · 7 lines
2.17.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#6 lore raw

Re: [RFC PATCH] logo: Makefile: Replace inkscape with convert

Quoted 9 lines · Jules Maselbas

The uses of inkscape to convert svg to png hasn't been very stable from one version to another, and required quirks from one version to another.

I hope that convert from imagemagick will be a more stable solution.

---
 lib/logo/Makefile | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

I applied this one to the tree, thanks for the effort. Inkscape was mentioned in the Kconfig entry, I changed this to ImageMagick.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox