Skip to contentSkip to conversation

scripts: update the comments of kallsyms support

PATCH In review Hui Su 2 participants 2 messages Oct 8, 2021 – Oct 12, 2021 Kbuild

lore
Share & tools
lore

Hui Su

author
#0 lore raw

PATCH 1/1 scripts: update the comments of kallsyms support

update the comments of kallsyms support

---
 scripts/link-vmlinux.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/link-vmlinux.sh +3 -3
index d74cee5c4326..a98c4f045302 100755
@@ -369,14 +369,14 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then
 	# kallsyms support
 	# Generate section listing all symbols and add it into vmlinux
 	# It's a three step process:
-	# 1)  Link .tmp_vmlinux1 so it has all symbols and sections,
+	# 1)  Link .tmp_vmlinux.kallsyms1 so it has all symbols and sections,
 	#     but __kallsyms is empty.
 	#     Running kallsyms on that gives us .tmp_kallsyms1.o with
 	#     the right size
-	# 2)  Link .tmp_vmlinux2 so it now has a __kallsyms section of
+	# 2)  Link .tmp_vmlinux.kallsyms2 so it now has a __kallsyms section of
 	#     the right size, but due to the added section, some
 	#     addresses have shifted.
-	#     From here, we generate a correct .tmp_kallsyms2.o
+	#     From here, we generate a correct .tmp_vmlinux.kallsyms2.o
 	# 3)  That link may have expanded the kernel image enough that
 	#     more linker branch stubs / trampolines had to be added, which
 	#     introduces new names, which further expands kallsyms. Do another
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Hui Su

update the comments of kallsyms support

---

I added

Fixes af73d78bd384 ("kbuild: Remove debug info from kallsyms linking")

Applied to linux-kbuild. Thanks.

Quoted 29 lines
 scripts/link-vmlinux.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/link-vmlinux.sh +3 -4
index d74cee5c4326..a98c4f045302 100755
@@ -369,14 +369,14 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then
        # kallsyms support
        # Generate section listing all symbols and add it into vmlinux
        # It's a three step process:
-       # 1)  Link .tmp_vmlinux1 so it has all symbols and sections,
+       # 1)  Link .tmp_vmlinux.kallsyms1 so it has all symbols and sections,
        #     but __kallsyms is empty.
        #     Running kallsyms on that gives us .tmp_kallsyms1.o with
        #     the right size
-       # 2)  Link .tmp_vmlinux2 so it now has a __kallsyms section of
+       # 2)  Link .tmp_vmlinux.kallsyms2 so it now has a __kallsyms section of
        #     the right size, but due to the added section, some
        #     addresses have shifted.
-       #     From here, we generate a correct .tmp_kallsyms2.o
+       #     From here, we generate a correct .tmp_vmlinux.kallsyms2.o
        # 3)  That link may have expanded the kernel image enough that
        #     more linker branch stubs / trampolines had to be added, which
        #     introduces new names, which further expands kallsyms. Do another
--

2.25.1

Signature · 2 lines
Best Regards
Masahiro Yamada