drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy head: c815d60a6292c90ea228c635b4150f022322908b commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors config: arm64-randconfig-r026-20211010 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 02 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165 :::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <[email protected]>
:::::: CC: Marc Zyngier <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Quoted 26 lines · kernel test robot
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
timers/tval-ectomy
head:c815d60a6292c90ea228c635b4150f022322908b
commit:9c6e4aa680ebd5ad816fc8f97858ec6057362c9e[2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm64-randconfig-r026-20211010 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project30caca39f401ae17927439c0a0bd6d1b1916dd6a)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu
#
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy git checkout9c6e4aa680ebd5ad816fc8f97858ec6057362c9e# save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=arm64
Quoted 2 lines
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>
This is *not* an issue, see below.
Quoted 57 lines
All warnings (new ones prefixed by >>):
Quoted 3 lines
Quoted 3 lines
drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]default: ^~~~~~~ drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here return val; ^~~ drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~~~~~ drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here return val; ^~~ drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning u32 val; ^ = 02 warnings generated.
vim +/val +156
drivers/clocksource/arm_arch_timer.cf4e00a1a55c7f9 Marc Zyngier 2017-01-20 134 f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg, f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk) f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 { f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val; f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140 f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) { f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk); f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) { f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL: f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL); f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break; 0bc2c9327c236c Marc Zyngier 2021-09-20 147 default: 0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG(); f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 } f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access ==
ARCH_TIMER_MEM_VIRT_ACCESS) {f4e00a1a55c7f9Marc Zyngier 2017-01-20 151 structarch_timer
*timer =to_arch_timer(clk);
Quoted 8 lines
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case
ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val =
readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();If you hit this case, which results in a compilation failure...
Quoted 7 lines
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val =
arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;... how can you return anything the first place?
Quoted 2 lines
f4e00a1a55c7f9Marc Zyngier 2017-01-20 164 }f4e00a1a55c7f9Marc Zyngier 2017-01-20 165
I think the problem squarely lies with the compiler (or the way it interprets the BUILD_BUG helper). If it cannot see that BUILD_BUG() trumps the control flow analysis, then this warning is totally useless.
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 5 lines · Marc Zyngier
I think the problem squarely lies with the compiler (or the way it interprets the
BUILD_BUGhelper). If it cannot see thatBUILD_BUG()trumps the control flow analysis, then this warning is totally useless.
The fake, generated __compiletime_assert should be annotated __noreturn. That gives enough information to the compiler to avoid the warning: https://godbolt.org/z/x1v69jjYY
And we should also move __compiletime_{error,warning} to compiler attributes since Clang trunk has it now, so that we catch the error
earlier: https://godbolt.org/z/jd8Eb9Mf1
I will send a couple patches.
Cheers,
Miguel
Quoted 11 lines · Miguel Ojeda
Quoted 5 lines · Marc Zyngier
I think the problem squarely lies with the compiler (or the way it interprets the
BUILD_BUGhelper). If it cannot see thatBUILD_BUG()trumps the control flow analysis, then this warning is totally useless.The fake, generated
__compiletime_assertshould be annotated__noreturn. That gives enough information to the compiler to avoid the warning: https://godbolt.org/z/x1v69jjYY
SGTM, please do.
Quoted 4 lines
And we should also move
__compiletime_{error,warning}to compiler attributes since Clang trunk has it now, so that we catch the error
earlier: https://godbolt.org/z/jd8Eb9Mf1
Didn't I send a patch for that?b83a908498d68fafca931e1276e145b339cac5fb
is in mainline.
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 2 lines · Nick Desaulniers
SGTM, please do.
https://lore.kernel.org/lkml/20211014132331.GA4811(a)kernel.org/
Quoted 3 lines
Didn't I send a patch for that?
b83a908498d68fafca931e1276e145b339cac5fb
is in mainline.
That explains my déjà vu feeling -- I guess I didn't click on the -rc's in Elixir :)
Cheers,
Miguel