staging: r8188eu: Use zeroing allocator in wpa_set_encryption()

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 12, 2021 Staging

lore

Share & tools

lore

Gustavo A. R. Silva

author

2021-10-12 02:42 UTC #0 lore raw

PATCH 1/1 staging: r8188eu: Use zeroing allocator in wpa_set_encryption()

Use zeroing allocator rather than allocator followed by memset with 0.

This issue was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/staging/r8188eu/os_dep/ioctl_linux.c +1 -2

index e8fadbfcb3a9..8a125c869c27 100644
@@ -419,11 +419,10 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
 		if (wep_key_len > 0) {
 			wep_key_len = wep_key_len <= 5 ? 5 : 13;
 			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial);
-			pwep = kmalloc(wep_total_len, GFP_KERNEL);
+			pwep = kzalloc(wep_total_len, GFP_KERNEL);
 			if (!pwep)
 				goto exit;
 
-			memset(pwep, 0, wep_total_len);
 			pwep->KeyLength = wep_key_len;
 			pwep->Length = wep_total_len;
 			if (wep_key_len == 13) {

Signature · 1 line

2.27.0