Skip to contentSkip to conversation

media: sir_ir: remove broken driver

PATCH New Sean Young 1 participant 1 message Oct 13, 2021

Subsystems (2)
lore
Share & tools
lore

Sean Young

author maintainer
#0 lore raw

PATCH 1/1 media: sir_ir: remove broken driver

This driver is a port of the lirc_sir driver to rc-core. However, for this driver I could not find any hardware to test, so it was done without testing. This is a mistake.

There are clear bugs in the code. For example the two arguments to ktime_us_delta() are reversed, which means the result is garbage.

The driver has been in the kernel for four years, and noone has ever reported an issue. So, remove this driver.

---
 drivers/media/rc/Kconfig  |   8 -
 drivers/media/rc/Makefile |   1 -
 drivers/media/rc/sir_ir.c | 438 --------------------------------------
 3 files changed, 447 deletions(-)
 delete mode 100644 drivers/media/rc/sir_ir.c
drivers/media/rc/Kconfig +0 -8
index fd5a7a058714..9506baf3c4c1 100644
@@ -453,14 +453,6 @@ config IR_SERIAL_TRANSMITTER
 	help
 	   Serial Port Transmitter support
 
-config IR_SIR
-	tristate "Built-in SIR IrDA port"
-	help
-	   Say Y if you want to use a IrDA SIR port Transceivers.
-
-	   To compile this driver as a module, choose M here: the module will
-	   be called sir-ir.
-
 config RC_XBOX_DVD
 	tristate "Xbox DVD Movie Playback Kit"
 	depends on USB
drivers/media/rc/Makefile +0 -1
index 0db51fad27d6..378d62d21e06 100644
@@ -47,7 +47,6 @@ obj-$(CONFIG_RC_ST) += st_rc.o
 obj-$(CONFIG_IR_SUNXI) += sunxi-cir.o
 obj-$(CONFIG_IR_IMG) += img-ir/
 obj-$(CONFIG_IR_SERIAL) += serial_ir.o
-obj-$(CONFIG_IR_SIR) += sir_ir.o
 obj-$(CONFIG_IR_MTK) += mtk-cir.o
 obj-$(CONFIG_RC_XBOX_DVD) += xbox_remote.o
 obj-$(CONFIG_IR_TOY) += ir_toy.o
drivers/media/rc/sir_ir.c deleted +0 -438

438 lines not on this page · raw message

Signature · 1 line
2.31.1