device property: Add missed header in fwnode.h
Subsystems (3)
Andy Shevchenko
reviewerPATCH 1/1 device property: Add missed header in fwnode.h
When adding some stuff to the header file we must not rely on implicit dependencies that are happen by luck or bugs in other headers. Hence fwnode.h needs to use bits.h directly.
--- include/linux/fwnode.h | 1 + 1 file changed, 1 insertion(+)
include/linux/fwnode.h +1 -0
@@ -11,6 +11,7 @@#include <linux/types.h> #include <linux/list.h> +#include <linux/bits.h> #include <linux/err.h> struct fwnode_operations ;
Signature · 1 line
2.33.0
Quoted 8 lines · Andy Shevchenko
When adding some stuff to the header file we must not rely on implicit dependencies that are happen by luck or bugs in other headers. Hence
fwnode.hneeds to usebits.hdirectly.Fixes c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")Cc Saravana Kannan <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
-Saravana
Quoted 19 lines
--- include/linux/fwnode.h | 1 + 1 file changed, 1 insertion(+)include/linux/fwnode.h +1
-1@@ -11,6 +11,7 @@#include <linux/types.h> #include <linux/list.h> +#include <linux/bits.h> #include <linux/err.h> struct fwnode_operations ; --2.33.0
Rafael J. Wysocki
maintainerQuoted 8 lines · Saravana Kannan
Quoted 5 lines · Andy Shevchenko
When adding some stuff to the header file we must not rely on implicit dependencies that are happen by luck or bugs in other headers. Hence
fwnode.hneeds to usebits.hdirectly.
Quoted 5 lines
Quoted 3 lines
Fixes c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")Cc Saravana Kannan <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Acked-by Saravana Kannan <[email protected]>
I'm going to pick this up, thanks!
Quoted 19 lines
Quoted 19 lines
--- include/linux/fwnode.h | 1 + 1 file changed, 1 insertion(+)include/linux/fwnode.h +1
-1@@ -11,6 +11,7 @@#include <linux/types.h> #include <linux/list.h> +#include <linux/bits.h> #include <linux/err.h> struct fwnode_operations ; --2.33.0
Quoted 10 lines · Rafael J. Wysocki
Quoted 8 lines · Saravana Kannan
Quoted 5 lines · Andy Shevchenko
When adding some stuff to the header file we must not rely on implicit dependencies that are happen by luck or bugs in other headers. Hence
fwnode.hneeds to usebits.hdirectly.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Fixes c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")Cc Saravana Kannan <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Acked-by Saravana Kannan <[email protected]>I'm going to pick this up, thanks!
I think Greg already picked it up.
-Saravana
Greg Kroah-Hartman
maintainerQuoted 15 lines · Saravana Kannan
Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Saravana Kannan
Quoted 8 lines · Andy Shevchenko
When adding some stuff to the header file we must not rely on implicit dependencies that are happen by luck or bugs in other headers. Hence
fwnode.hneeds to usebits.hdirectly.Fixes c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")Cc Saravana Kannan <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Acked-by Saravana Kannan <[email protected]>I'm going to pick this up, thanks!
I think Greg already picked it up.
I did, but multiple people can :)
thanks,
greg k-h