Skip to contentSkip to conversation

of: kobj: make of_node_is_(initialized|attached) parameters const

PATCH Applied Nathan Lynch 2 participants 2 messages Oct 14, 2021 – Oct 20, 2021 Device tree

lore
Share & tools
lore

Nathan Lynch

author
#0 lore raw

PATCH 1/1 of: kobj: make of_node_is_(initialized|attached) parameters const

of_node_is_initialized() and of_node_is_attached() don't modify the node objects passed to them, so those parameters should be const.

Signed-off-by Nathan Lynch <[email protected]>
---
 drivers/of/kobj.c       | 4 ++--
 drivers/of/of_private.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/of/kobj.c +2 -2
index 6675b5e56960..7d3853a5a09a 100644
@@ -5,13 +5,13 @@
 #include "of_private.h"
 
 /* true when node is initialized */
-static int of_node_is_initialized(struct device_node *node)
+static int of_node_is_initialized(const struct device_node *node)
 {
 	return node && node->kobj.state_initialized;
 }
 
 /* true when node is attached (i.e. present on sysfs) */
-int of_node_is_attached(struct device_node *node)
+int of_node_is_attached(const struct device_node *node)
 {
 	return node && node->kobj.state_in_sysfs;
 }
drivers/of/of_private.h +1 -1
index 75e67b8bb826..9324483397f6 100644
@@ -60,7 +60,7 @@ static inline int of_property_notify(int action, struct device_node *np,
 #endif /* CONFIG_OF_DYNAMIC */
 
 #if defined(CONFIG_OF_KOBJ)
-int of_node_is_attached(struct device_node *node);
+int of_node_is_attached(const struct device_node *node);
 int __of_add_property_sysfs(struct device_node *np, struct property *pp);
 void __of_remove_property_sysfs(struct device_node *np, struct property *prop);
 void __of_update_property_sysfs(struct device_node *np, struct property *newprop,
Signature · 1 line
2.31.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Nathan Lynch

of_node_is_initialized() and of_node_is_attached() don't modify the node objects passed to them, so those parameters should be const.

Signed-off-by Nathan Lynch <[email protected]>
---
 drivers/of/kobj.c       | 4 ++--
 drivers/of/of_private.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks!