] selftests/bpf: Some more atomic tests
Subsystems (3)
PATCH 1/1 ] selftests/bpf: Some more atomic tests
Some new verifier tests that hit some important gaps in the parameter space for atomic ops.
There are already exhaustive tests for the JIT part in lib/test_bpf.c, but these exercise the verifier too.
Signed-off-by Brendan Jackman <[email protected]>
--- .../selftests/bpf/verifier/atomic_cmpxchg.c | 38 +++++++++++++ .../selftests/bpf/verifier/atomic_fetch.c | 57 +++++++++++++++++++ .../selftests/bpf/verifier/atomic_invalid.c | 25 ++++++++ 3 files changed, 120 insertions(+) create mode 100644 tools/testing/selftests/bpf/verifier/atomic_fetch.c create mode 100644 tools/testing/selftests/bpf/verifier/atomic_invalid.c
tools/testing/selftests/bpf/verifier/atomic_cmpxchg.c +38 -0
@@ -119,3 +119,41 @@ }, .result = ACCEPT, }, +{ + "Dest pointer in r0 - fail", + .insns = { +/* val = 0; */ +BPF_ST_MEM (BPF_DW ,BPF_REG_10 ,-8 ,0 ), +/* r0 = &val */ +BPF_MOV64_REG (BPF_REG_0 ,BPF_REG_10 ), +/* r0 = atomic_cmpxchg(&val, r0, 1); */ +BPF_MOV64_IMM (BPF_REG_1 ,1 ), +BPF_ATOMIC_OP (BPF_DW ,BPF_CMPXCHG ,BPF_REG_10 ,BPF_REG_1 ,-8 ), +/* if (r0 != 0) exit(1); */ +BPF_JMP_IMM (BPF_JEQ ,BPF_REG_0 ,0 ,2 ), +BPF_MOV64_IMM (BPF_REG_0 ,1 ), +BPF_EXIT_INSN (), +/* exit(0); */ +BPF_MOV64_IMM (BPF_REG_0 ,0 ), + BPF_EXIT_INSN(), + }, + .result =ACCEPT , +}, +{ +"Dest pointer in r0 - succeed" , + .insns = { +/* r0 = &val */ +BPF_MOV64_REG (BPF_REG_0 ,BPF_REG_10 ), +/* val = r0; */ +BPF_STX_MEM (BPF_DW ,BPF_REG_10 ,BPF_REG_0 ,-8 ), +/* r0 = atomic_cmpxchg(&val, r0, 0); */ +BPF_MOV64_IMM (BPF_REG_1 ,0 ), +BPF_ATOMIC_OP (BPF_DW ,BPF_CMPXCHG ,BPF_REG_10 ,BPF_REG_1 ,-8 ), +/* r1 = *r0 */ +BPF_LDX_MEM (BPF_DW ,BPF_REG_1 ,BPF_REG_0 ,-8 ), +/* exit(0); */ +BPF_MOV64_IMM (BPF_REG_0 ,0 ), + BPF_EXIT_INSN(), + }, + .result = ACCEPT, +},
tools/testing/selftests/bpf/verifier/atomic_fetch.c new file +57 -0
57 lines not on this page · raw message
tools/testing/selftests/bpf/verifier/atomic_invalid.c new file +25 -0
@@ -0,0 +1,25 @@ +#define __INVALID_ATOMIC_ACCESS_TEST (op) \ + { \ + "atomic " #op " access through non-pointer ", \ + .insns = { \ + BPF_MOV64_IMM(BPF_REG_0, 1), \ + BPF_MOV64_IMM(BPF_REG_1, 0), \ + BPF_ATOMIC_OP(BPF_DW, op, BPF_REG_1, BPF_REG_0, -8), \ + BPF_MOV64_IMM(BPF_REG_0, 0), \ + BPF_EXIT_INSN(), \ + }, \ + .result = REJECT, \ + .errstr = "R1 invalid mem access 'inv'" \ + } +__INVALID_ATOMIC_ACCESS_TEST (BPF_ADD ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_ADD |BPF_FETCH ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_ADD ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_ADD |BPF_FETCH ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_AND ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_AND |BPF_FETCH ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_OR ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_OR |BPF_FETCH ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_XOR ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_XOR |BPF_FETCH ), +__INVALID_ATOMIC_ACCESS_TEST (BPF_XCHG ), +__INVALID_ATOMIC_ACCESS_TEST(BPF_CMPXCHG),
Signature · 1 line
2.33.0.1079.g6e70778dc9-goog
Quoted 8 lines · Brendan Jackman
Some new verifier tests that hit some important gaps in the parameter space for atomic ops.
There are already exhaustive tests for the JIT part in
lib/test_bpf.c, but these exercise the verifier too.Signed-off-by Brendan Jackman <[email protected]>
Applied and fixed subj.