Skip to contentSkip to conversation

webkitgtk: add gperf-native to DEPENDS to fix build

PATCH In review Andreas Müller 4 participants 7 messages Oct 17, 2021 – Oct 18, 2021 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkitgtk: add gperf-native to DEPENDS to fix build

|   Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least
|   version "3.0.1")
---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +1 -0
index 25e1d422cc..a8e067147c 100644
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \
Signature · 1 line
2.31.1
#1 lore raw
Quoted 14 lines · Andreas Müller
Quoted 2 lines

  Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +

 1 file changed, 1 insertion(+)
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
Quoted 7 lines


 DEPENDS = " \
           ruby-native \
+ gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

Cheers,

Richard

#2 lore raw
Quoted 17 lines · Richard Purdie
Quoted 15 lines · Andreas Müller
Quoted 2 lines

Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
Quoted 9 lines

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb CVE_PRODUCT = "webkitgtk webkitgtk\+" · line 38

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +1 -0
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

Asked myself same but did not find an answer. My build should use default PACKAGECONFIGs. Was off for a while so now pulled master (meta-openembedded master-next for mozjs upgrade) and started a build. Not helpful exactly - sorry...

Andreas

#3 lore raw
In reply to Richard Purdie
Quoted 18 lines · Richard Purdie
Quoted 1 line · Andreas Müller
Quoted 1 line

Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at

least

Review

Quoted 8 lines
Quoted 1 line

version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/meta/recipes-

Quoted 6 lines

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
Quoted 9 lines

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb CVE_PRODUCT = "webkitgtk webkitgtk\+" · line 38

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +1 -0
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it isn't because of gperf, but:

| CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
|   Either GLX or EGL is needed.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:220 (include)
|   CMakeLists.txt:20 (include)

possibly because the default setup in oe-core doesn't have opengl in DISTRO_FEATUES while all builds on autobuilder have opengl enabled with poky?

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 40 lines · Martin Jansa via lists.openembedded.org
Quoted 18 lines · Richard Purdie
Quoted 1 line · Andreas Müller
Quoted 1 line

Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at

least

Review

Quoted 8 lines
Quoted 1 line

version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/meta/recipes-

Quoted 6 lines

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
Quoted 9 lines

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb CVE_PRODUCT = "webkitgtk webkitgtk\+" · line 38

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +1 -0
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it isn't because of gperf, but:

| CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
|   Either GLX or EGL is needed.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:220 (include)
|   CMakeLists.txt:20 (include)
Quoted 4 lines

possibly because the default setup in oe-core doesn't have opengl in DISTRO_FEATUES while all builds on autobuilder have opengl enabled with poky?

I've sent a fix for build for default oe-core setup (without opengl in DISTRO_FEATURES).

In my build gperf-native was found in older 2.32.3 from native sysroot:

CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot-native/usr/bin /gperf
CMakeCache.txt.2.32.3-r0://Details about finding Gperf CMakeCache.txt.2.32.3-r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2-foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys root-native/usr/bin/gperf][v(3.0.1)]
CMakeCache.txt.2.32.3-r0://ADVANCED property for variable: GPERF_EXECUTABLE
CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1

and it's found there through as transitive dependency from:

"fontconfig.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "libcap-native.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"

with some other combination of DISTRO_FEATURES it might be missing as in Andreas case and as it's direct dependency of webkitgtk I think removing it in:
https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2
wasn't correct, maybe other dependencies removed here have similar issue and successful pass on autobuilder tests only very limited set of combinations (understandably).

Regards,

#6 lore raw
Quoted 75 lines · Martin Jansa
Quoted 40 lines · Martin Jansa via lists.openembedded.org
Quoted 10 lines · Richard Purdie
Quoted 9 lines · Andreas Müller
Quoted 3 lines

  Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is at least
  version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +

 1 file changed, 1 insertion(+)
Quoted 17 lines
Quoted 7 lines
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
Quoted 7 lines


 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing isn't?

FWIW: I'm also seeing webkitgtk failures since last upgrade, but for me it isn't because of gperf, but:

| CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
|   Either GLX or EGL is needed.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:220 (include)
|   CMakeLists.txt:20 (include)
Quoted 4 lines

possibly because the default setup in oe-core doesn't have opengl in DISTRO_FEATUES while all builds on autobuilder have opengl enabled with poky?

I've sent a fix for build for default oe-core setup (without opengl in DISTRO_FEATURES).

In my build gperf-native was found in older 2.32.3 from native sysroot:

CMakeCache.txt.2.32.3- r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy- kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot- native/usr/bin
/gperf
CMakeCache.txt.2.32.3-r0://Details about finding Gperf CMakeCache.txt.2.32.3- r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2 -foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys root-native/usr/bin/gperf][v(3.0.1)] CMakeCache.txt.2.32.3-r0://ADVANCED property for variable: GPERF_EXECUTABLE CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1

and it's found there through as transitive dependency from:

"fontconfig.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "libcap-native.do_prepare_recipe_sysroot" -> "gperf- native.do_populate_sysroot"
"libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"

Quoted 7 lines

with some other combination of DISTRO_FEATURES it might be missing as in Andreas case and as it's direct dependency of webkitgtk I think removing it in:
https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2
wasn't correct, maybe other dependencies removed here have similar issue and successful pass on autobuilder tests only very limited set of combinations (understandably).

We could put gperf-native into the same class of dependencies as pkgconfig- native which should expose all the missing dependencies at the risk of causing work in needing to correctly mark up the recipes.

I'm at least happier now I understand why this was being masked.

Cheers,

Richard

#7 lore raw

But I still don't understand this. How can this be reproduced?

Alex

Quoted 117 lines · Richard Purdie
Quoted 6 lines · Martin Jansa
Quoted 4 lines · Martin Jansa via lists.openembedded.org
Quoted 2 lines · Richard Purdie
Quoted 1 line · Andreas Müller
Quoted 1 line

Could NOT find Gperf (missing: GPERF_EXECUTABLE) (Required is

at

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 2 lines

least
version "3.0.1")

---
 meta/recipes-sato/webkit/webkitgtk_2.34.0.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0

sato/webkit/webkitgtk_2.34.0.bb
index 25e1d422cc..a8e067147c 100644

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +0 -0
@@ -32,6 +32,7 @@ CVE_PRODUCT = "webkitgtk webkitgtk\+"
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

meta/recipes-sato/webkit/webkitgtk_2.34.0.bb CVE_PRODUCT = "webkitgtk webkitgtk\+" · line 38

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.34.0.bb +1 -0
 DEPENDS = " \
           ruby-native \
+          gperf-native \
           cairo \
           harfbuzz \
           jpeg \

Out of interest, why are you seeing that and the automated testing

isn't?

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

FWIW: I'm also seeing webkitgtk failures since last upgrade, but for

me it

Quoted 19 lines
Quoted 8 lines

isn't because of gperf, but:

| CMake Error at Source/cmake/OptionsGTK.cmake:353 (message):
|   Either GLX or EGL is needed.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:220 (include)
|   CMakeLists.txt:20 (include)
Quoted 4 lines

possibly because the default setup in oe-core doesn't have opengl in DISTRO_FEATUES while all builds on autobuilder have opengl enabled with poky?

I've sent a fix for build for default oe-core setup (without opengl in DISTRO_FEATURES).

In my build gperf-native was found in older 2.32.3 from native sysroot:

Quoted 8 lines

CMakeCache.txt.2.32.3- r0:GPERF_EXECUTABLE:FILEPATH=/jenkins/mjansa/build/ros/ros2-foxy- kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sysroot- native/usr/bin
/gperf
CMakeCache.txt.2.32.3-r0://Details about finding Gperf CMakeCache.txt.2.32.3-

r0:FIND_PACKAGE_MESSAGE_DETAILS_Gperf:INTERNAL=[/jenkins/mjansa/build/ros/ros2

Quoted 3 lines

-foxy-kirkstone/tmp-glibc/work/core2-64-oe-linux/webkitgtk/VER/recipe-sys root-native/usr/bin/gperf][v(3.0.1)] CMakeCache.txt.2.32.3-r0://ADVANCED property for variable:

GPERF_EXECUTABLE

Quoted 5 lines

CMakeCache.txt.2.32.3-r0:GPERF_EXECUTABLE-ADVANCED:INTERNAL=1

and it's found there through as transitive dependency from:

"fontconfig.do_prepare_recipe_sysroot" ->

"gperf-native.do_populate_sysroot"

Quoted 8 lines

"glibc.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "libcap-native.do_prepare_recipe_sysroot" -> "gperf- native.do_populate_sysroot" "libcap.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot" "systemd.do_prepare_recipe_sysroot" -> "gperf-native.do_populate_sysroot"

with some other combination of DISTRO_FEATURES it might be missing as in Andreas case and as it's direct dependency of webkitgtk I think removing

it

Quoted 2 lines

in:

https://git.openembedded.org/openembedded-core/commit/?id=a5b6f978ef4aef6d484acc6e3c4558df7fec65d2

Quoted 1 line

wasn't correct, maybe other dependencies removed here have similar issue

and

Quoted 1 line

successful pass on autobuilder tests only very limited set of

combinations

Quoted 1 line

(understandably).

We could put gperf-native into the same class of dependencies as pkgconfig- native which should expose all the missing dependencies at the risk of causing
work in needing to correctly mark up the recipes.

I'm at least happier now I understand why this was being masked.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#157063):
https://lists.openembedded.org/g/openembedded-core/message/157063
Mute This Topic: https://lists.openembedded.org/mt/86389188/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-