Skip to contentSkip to conversation

pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'

PATCH In review [email protected] 2 participants 3 messages Oct 18, 2021 – Oct 31, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'

From: Luiz Angelo Daros de Luca <[email protected]>

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

---
 drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-mt7620.c +1 -0
index 425d55a2ee19..6853b5b8b0fe 100644
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <asm/mach-ralink/ralink_regs.h>
 #include <asm/mach-ralink/mt7620.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.33.0
#1 lore raw

Hi Luiz,

Thanks for your patch. I thought I had reviewed all of this since the kernel test robot complains once for something similar but it seems I missed this one :).

Quoted 23 lines · On Mon, Oct 18, 2021 at 2:59 AM <[email protected]> wrote:

From: Luiz Angelo Daros de Luca <[email protected]>

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

---
 drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-mt7620.c +1 -1
index 425d55a2ee19..6853b5b8b0fe 100644
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <asm/mach-ralink/ralink_regs.h>
 #include <asm/mach-ralink/mt7620.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
--
Quoted 2 lines

2.33.0

Can you please add the "Fixes" tag and CC also stable linux? With those two added, please send v2.

Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config

into a new 'pinctrl-mt7620.c' file")
Cc: [email protected]

Thanks,
Sergio Paracuellos

#2 lore raw
Quoted 37 lines · Sergio Paracuellos

Hi Luiz,

Thanks for your patch. I thought I had reviewed all of this since the kernel test robot complains once for something similar but it seems I missed this one :).

Quoted 23 lines · On Mon, Oct 18, 2021 at 2:59 AM <[email protected]> wrote:

From: Luiz Angelo Daros de Luca <[email protected]>

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

---
 drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-mt7620.c +1 -1
index 425d55a2ee19..6853b5b8b0fe 100644
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <asm/mach-ralink/ralink_regs.h>
 #include <asm/mach-ralink/mt7620.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
--
Quoted 2 lines

2.33.0

Can you please add the "Fixes" tag and CC also stable linux? With those two added, please send v2.

Quoted 3 lines
Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config

into a new 'pinctrl-mt7620.c' file")
Cc: [email protected]

I have already sent v2 of this patch including by myself what I was asking you to do, since no answer at all came from your side.

Thanks,
Sergio Paracuellos

Quoted 3 lines

Thanks,
Sergio Paracuellos