Skip to contentSkip to conversation

aha1542: use memcpy_{from,to}_bvec

PATCH Applied Christoph Hellwig 2 participants 3 messages Oct 18, 2021 – Oct 21, 2021 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aha1542: use memcpy_{from,to}_bvec

Use the memcpy_{from,to}_bvec helpers instead of open coding them.

---
 drivers/scsi/aha1542.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/aha1542.c +2 -4
index 584a59522038b..07efdad1ae378 100644
@@ -268,8 +268,7 @@ static void aha1542_free_cmd(struct scsi_cmnd *cmd)
 		struct bio_vec bv;
 
 		rq_for_each_segment(bv, rq, iter) {
-			memcpy_to_page(bv.bv_page, bv.bv_offset, buf,
-				       bv.bv_len);
+			memcpy_to_bvec(&bv, buf);
 			buf += bv.bv_len;
 		}
 	}
@@ -454,8 +453,7 @@ static int aha1542_queuecommand(struct Scsi_Host *sh, struct scsi_cmnd *cmd)
 		struct bio_vec bv;
 
 		rq_for_each_segment(bv, rq, iter) {
-			memcpy_from_page(buf, bv.bv_page, bv.bv_offset,
-					 bv.bv_len);
+			memcpy_from_bvec(buf, &bv);
 			buf += bv.bv_len;
 		}
 	}
Signature · 1 line
2.30.2
#1 lore raw

Christoph,

Quoted 1 line

Use the memcpy_{from,to}_bvec helpers instead of open coding them.

Applied to 5.16/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering