Skip to contentSkip to conversation

ARM: dts: am335x: add rtc system-power-controller

PATCH In review Drew Fustini 3 participants 5 messages Oct 18, 2021 – Dec 9, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: am335x: add rtc system-power-controller

Johan pointed out when I submitted "ARM: dts: am335x: Add rtc node as system-power-controller" [1] that mentioning am335x-evm and boneblack in the commit message was incorrect. system-power-controller is already present in am335x-boneblack-common.dtsi and am335x-evm would need the property added directly to the dts file.

These are the dts files that currently include either am335x-bone-common.dtsi or am335x-boneblack-common.dtsi:

    am335x-bone.dts
	am335x-bone-common.dtsi

    am335x-boneblack.dts
        am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-boneblack-wireless.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-bonegreen.dts
	am335x-bone-common.dtsi

    am335x-bonegreen-wireless.dts
	am335x-bone-common.dtsi

    am335x-sancloud-bbe.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-sancloud-bbe-lite.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

am335x-boneblack, am335x-boneblack-wireless, am335x-sancloud-bbe and am335x-sancloud-bbe-lite currently get the system-power-controller property from am335x-boneblack-common.dtsi. Moving that property to am335x-bone-common.dtsi would have no change for these boards as they include that dtsi file too.

This change would result in the addition of system-power-controller to bone, bonegreen and bonegreen-wireless. These boards all have PMIC_POWR_EN (ZCZ ball C6) connected to PWR_EN on the TPS65217B PMIC. Thus system-power-controller is a valid property for them too.

In addition to BeagleBone, I have reviewed the TI AM335x eval boards:

am335x-evm.dts should _not_ have the system-power-controller property as the PMIC_POWER_EN is not connected on the TMDXEVM3358 board [2]. The ball would be connected to SLEEP (pin 37) on the TPS65910A3 PMIC but R65 is marked as do not populate.

am335x-evmsk.dts should _not_ have system-power-controller property as PMIC_POWER_EN is not connected on the TMDSSK3358 board [3].

am335x-icev2.dts should have the system-power-controller property as the PMIC_POWER_EN (ZCZ ball C6) is connected to PWRHOLD (pin 1) of the TPS65910A3 PMIC on the TMDSICE3359 board [4].

Cc Jason Kridner <[email protected]>
Cc Dave Gerlach <[email protected]>
Cc Keerthy <[email protected]>
Cc Johan Hovold <[email protected]>

[1] https://lore.kernel.org/linux-omap/[email protected]/
[2] https://www.ti.com/tool/TMDXEVM3358
[3] https://www.ti.com/tool/TMDSSK3358
[4] https://www.ti.com/tool/TMDSICE3359

Drew Fustini (2):
ARM: dts: am335x-boneblack-common: move system-power-controller
ARM: dts: am335x-icev2: Add system-power-controller to RTC node

 arch/arm/boot/dts/am335x-bone-common.dtsi      | 1 +
 arch/arm/boot/dts/am335x-boneblack-common.dtsi | 4 ----
 arch/arm/boot/dts/am335x-icev2.dts             | 4 ++++
 3 files changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/2 ARM: dts: am335x-boneblack-common: move system-power-controller

Move the rtc node system-power-controller property from am335x-boneblack-common.dtsi to am335x-bone-common.dtsi.

am335x-boneblack-common.dtsi is included by am335x-boneblack.dts, am335x-boneblack-wireless.dts, am335x-sancloud-bbe.dts and am335x-sancloud-bbe-lite.dts. All of these dts files also include am335x-bone-common.dtsi and thus will retain the rtc node system-power-controller property.

am335x-bone-common.dtsi is also included by am335x-bone.dts [1], am335x-bonegreen.dts [2] and am335x-bonegreen-wireless.dts [3]. These boards will now have the rtc node system-power-controller property too. This is valid as they also have PMIC_POWR_EN (ZCZ C6) connected to PWR_EN on the TPS65217B PMIC.

Based on 15c7be47fb7c ("ARM: dts: am335x: Add rtc node as system-power-controller") by Keerthy in ti-linux-5.4.y branch [4].

[1] https://beagleboard.org/static/beaglebone/BEAGLEBONE_SCHEM_A3.pdf
[2] https://github.com/SeeedDocument/BeagleBone_Green/blob/master/resources/BEAGLEBONE_GREEN_V1.pdf
[3] https://github.com/SeeedDocument/BeagleBone_Green_Wireless/blob/master/resources/BeagleBone_Green%20Wireless_V1.0_SCH_20160314.pdf
[4] git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git

---
 arch/arm/boot/dts/am335x-bone-common.dtsi      | 1 +
 arch/arm/boot/dts/am335x-boneblack-common.dtsi | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
arch/arm/boot/dts/am335x-bone-common.dtsi +1 -0
index 0ccdc7cd463b..56ae5095a5b8 100644
@@ -399,6 +399,7 @@ &sham {
 &rtc {
 	clocks = <&clk_32768_ck>, <&clk_24mhz_clkctrl AM3_CLK_24MHZ_CLKDIV32K_CLKCTRL 0>;
 	clock-names = "ext-clk", "int-clk";
+	system-power-controller;
 };
 
 &pruss_tm {
arch/arm/boot/dts/am335x-boneblack-common.dtsi +0 -4
index 10494c4431b9..a7a8c61ef9b2 100644
@@ -22,10 +22,6 @@ &mmc2 {
 	non-removable;
 };
 
-&rtc {
-	system-power-controller;
-};
-
 / {
 	memory@80000000 {
 		device_type = "memory";
Signature · 1 line
2.27.0
#2 lore raw

PATCH 2/2 ARM: dts: am335x-icev2: Add system-power-controller to RTC node

In reply to Drew Fustini

On the am335x-icev2 board [1], AM3359 PMIC_PWR_EN (ZCZ ball C6) is connected to PWRHOLD (pin 1) on the TPS65910A3 PMIC. The addition of system-power-controller to the rtc node will enable the capability of the RTC driver to poweroff the board.

Based on 15c7be47fb7c ("ARM: dts: am335x: Add rtc node as system-power-controller") by Keerthy in ti-linux-5.4.y branch [2].

[1] https://www.ti.com/tool/TMDSICE3359
[2] git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git

---
 arch/arm/boot/dts/am335x-icev2.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/am335x-icev2.dts +4 -0
index e5ce89c8f54d..5835c0cdda50 100644
@@ -512,3 +512,7 @@ ethphy1: ethernet-phy@3 {
 &pruss_tm {
 	status = "okay";
 };
+
+&rtc {
+	system-power-controller;
+};
Signature · 1 line
2.27.0
Reviewed-by on the v1 series
#3 lore raw
In reply to Drew Fustini
Quoted 70 lines · Drew Fustini

Johan pointed out when I submitted "ARM: dts: am335x: Add rtc node as system-power-controller" [1] that mentioning am335x-evm and boneblack in the commit message was incorrect. system-power-controller is already present in am335x-boneblack-common.dtsi and am335x-evm would need the property added directly to the dts file.

These are the dts files that currently include either am335x-bone-common.dtsi or am335x-boneblack-common.dtsi:

    am335x-bone.dts
	am335x-bone-common.dtsi

    am335x-boneblack.dts
        am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-boneblack-wireless.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-bonegreen.dts
	am335x-bone-common.dtsi

    am335x-bonegreen-wireless.dts
	am335x-bone-common.dtsi

    am335x-sancloud-bbe.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

    am335x-sancloud-bbe-lite.dts
	am335x-bone-common.dtsi
	am335x-boneblack-common.dtsi

am335x-boneblack, am335x-boneblack-wireless, am335x-sancloud-bbe and am335x-sancloud-bbe-lite currently get the system-power-controller property from am335x-boneblack-common.dtsi. Moving that property to am335x-bone-common.dtsi would have no change for these boards as they include that dtsi file too.

This change would result in the addition of system-power-controller to bone, bonegreen and bonegreen-wireless. These boards all have PMIC_POWR_EN (ZCZ ball C6) connected to PWR_EN on the TPS65217B PMIC. Thus system-power-controller is a valid property for them too.

In addition to BeagleBone, I have reviewed the TI AM335x eval boards:

am335x-evm.dts should _not_ have the system-power-controller property as the PMIC_POWER_EN is not connected on the TMDXEVM3358 board [2]. The ball would be connected to SLEEP (pin 37) on the TPS65910A3 PMIC but R65 is marked as do not populate.

am335x-evmsk.dts should _not_ have system-power-controller property as PMIC_POWER_EN is not connected on the TMDSSK3358 board [3].

am335x-icev2.dts should have the system-power-controller property as the PMIC_POWER_EN (ZCZ ball C6) is connected to PWRHOLD (pin 1) of the TPS65910A3 PMIC on the TMDSICE3359 board [4].

Cc Jason Kridner <[email protected]>
Cc Dave Gerlach <[email protected]>
Cc Keerthy <[email protected]>
Cc Johan Hovold <[email protected]>

[1] https://lore.kernel.org/linux-omap/[email protected]/
[2] https://www.ti.com/tool/TMDXEVM3358
[3] https://www.ti.com/tool/TMDSSK3358
[4] https://www.ti.com/tool/TMDSICE3359

Quoted 3 lines

Drew Fustini (2):
ARM: dts: am335x-boneblack-common: move system-power-controller
ARM: dts: am335x-icev2: Add system-power-controller to RTC node

Nice work. I trust your review of the schematics, and only double-checked sancloud-bbe. The patches look good.

For the series:

Johan

#4 lore raw
Quoted 6 lines · Johan Hovold
Quoted 5 lines · Drew Fustini

Johan pointed out when I submitted "ARM: dts: am335x: Add rtc node as system-power-controller" [1] that mentioning am335x-evm and boneblack in the commit message was incorrect. system-power-controller is already present in am335x-boneblack-common.dtsi and am335x-evm would need the property added directly to the dts file.

...

Quoted 10 lines
Quoted 3 lines

Drew Fustini (2):
ARM: dts: am335x-boneblack-common: move system-power-controller
ARM: dts: am335x-icev2: Add system-power-controller to RTC node

Nice work. I trust your review of the schematics, and only double-checked sancloud-bbe. The patches look good.

For the series:

Thanks applying both into omap-for-v5.17/dt.

Regards,

Tony