Skip to contentSkip to conversation

lib/i915: Return actual submission method from gem_submission_method

PATCH In review Ashutosh Dixit 3 participants 5 messages Oct 19, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/i915: Return actual submission method from gem_submission_method

gem_submission_method() purports to return the currently used submission method by the driver, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.

---
 lib/i915/gem_submission.c   | 2 +-
 tests/i915/gem_ctx_shared.c | 2 +-
 tests/i915/gem_watchdog.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
lib/i915/gem_submission.c +1 -1
index 2627b802cfb..b037d04cc4a 100644
@@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
 		return 0;
 
 	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		flags |= GEM_SUBMISSION_GUC;
 		goto out;
 	}
 
tests/i915/gem_ctx_shared.c +1 -1
index ea1b5dd1b8c..f50ef13263f 100644
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	/*
 	 * Each context, although they share a vm, are expected to be
tests/i915/gem_watchdog.c +1 -1
index db562335a2a..21c7710a806 100644
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
 	const intel_ctx_t *ctx[num_engines];
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	igt_debug("%u virtual engines\n", num_engines);
 	igt_require(num_engines);
Signature · 1 line
2.33.0
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/i915: Return actual submission method from gem_submission_method (rev2)

== Series Details ==

== Series Details ==

Series: lib/i915: Return actual submission method from gem_submission_method (rev2)
URL : https://patchwork.freedesktop.org/series/95906/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10754 -> IGTPW_6330
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6330:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@gt_timelines:
- {fi-jsl-1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/fi-jsl-1/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-jsl-1/igt@i915_selftest@live@gt_timelines.html

Known issues
------------

Here are the changes found in IGTPW_6330 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> [SKIP][3] ([fdo#109271]) +33 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-skl-6700k2/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-skl-6700k2: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-skl-6700k2/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][5] -> [INCOMPLETE][6] ([i915#3921])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/fi-snb-2600/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6700k2: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#533])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-skl-6700k2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [FAIL][8] ([i915#1888]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/fi-tgl-1115g4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [SKIP][10] ([fdo#109271]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/fi-kbl-guc/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/fi-kbl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Participating hosts (39 -> 36)
------------------------------

Missing (3): fi-bdw-samus fi-bsw-cyan bat-dg1-6

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6254 -> IGTPW_6330

CI-20190529: 20190529
CI_DRM_10754: f89e7e0028f9effd0044258d7cf8d3acb32c57b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6330: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/index.html
IGT_6254: 51792e987da03ba2a6faf5857c12f1d173c87def @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/index.html

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/i915: Return actual submission method from gem_submission_method (rev2)

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: lib/i915: Return actual submission method from gem_submission_method (rev2)
URL : https://patchwork.freedesktop.org/series/95906/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10754_full -> IGTPW_6330_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/index.html

Known issues
------------

Here are the changes found in IGTPW_6330_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][1] ([i915#1839])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb8/igt@[email protected]

* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl2/igt@[email protected]

* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][3] ([fdo#109314])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][4] ([fdo#109314])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@[email protected]

* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb6/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [TIMEOUT][6] ([i915#2369] / [i915#3063] / [i915#3648])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-kbl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl2/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-tglb3/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-glk5/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][13] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][14] -> [SKIP][15] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-kbl6/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-kbl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl3/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][18] ([i915#2658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb5/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][19] ([i915#2658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb8/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][20] ([i915#2658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl2/igt@[email protected]
- shard-apl: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@[email protected]
- shard-glk: NOTRUN -> [WARN][23] ([i915#2658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk1/igt@[email protected]

* igt@gem_pxp@create-regular-context-2:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#4270]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#4270]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@[email protected]

* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#768]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#3297]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb4/igt@[email protected]

* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3297])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb8/igt@[email protected]

* igt@gen3_render_mixed_blits:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109289]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@gen3_render_mixed_blits.html

* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2856])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb6/igt@[email protected]

* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271]) +435 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb5/igt@[email protected]

* igt@gen9_exec_parse@bb-secure:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#2856]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][34] -> [FAIL][35] ([i915#4275])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-iclb6/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb7/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#1937])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl3/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#1902])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111644] / [i915#1397] / [i915#2411])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#110892])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@[email protected]

* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111614]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#110725] / [fdo#111614])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb7/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl7/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111615]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3777]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk1/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#2705])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#2705])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@kms_bw@linear-tiling-2-displays-1920x1080p:
- shard-kbl: NOTRUN -> [DMESG-FAIL][48] ([i915#4298]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl6/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][49] ([i915#1385])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@[email protected]

* igt@kms_bw@linear-tiling-2-displays-2560x1440p:
- shard-snb: NOTRUN -> [FAIL][50] ([i915#4299]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb7/igt@[email protected]

* igt@kms_bw@linear-tiling-3-displays-2560x1440p:
- shard-kbl: NOTRUN -> [FAIL][51] ([i915#4299]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109278] / [i915#3886]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3886]) +10 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3886]) +13 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#3689] / [i915#3886]) +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3689]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_cdclk@plane-scaling:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3742])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#109284] / [fdo#111827]) +15 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +18 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +9 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk1/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +7 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb6/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +21 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +22 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb5/igt@[email protected]

* igt@kms_content_protection@content_type_change:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#111828]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@kms_content_protection@content_type_change.html

* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][66] ([i915#1319]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109300] / [fdo#111066])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb6/igt@[email protected]
- shard-kbl: NOTRUN -> [TIMEOUT][68] ([i915#1319])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3319]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109278] / [fdo#109279]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#3359]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x256-random:
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271]) +61 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk1/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x512-offscreen:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109279] / [i915#3359]) +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109274] / [fdo#109278]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb6/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3528])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][77] -> [FAIL][78] ([i915#1888] / [i915#3451])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-glk9/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk4/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111825]) +33 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109274]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb8/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][81] ([i915#180]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][82] -> [SKIP][83] ([i915#3701])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-iclb8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280]) +13 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271]) +183 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [PASS][86] -> [INCOMPLETE][87] ([i915#2411] / [i915#456])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-tglb5/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb7/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][88] -> [SKIP][89] ([i915#433])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-tglb8/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][90] ([i915#180])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#533]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][92] ([fdo#108145] / [i915#265]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][93] ([i915#265])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][94] ([fdo#108145] / [i915#265]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-d-constant-alpha-max:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278]) +16 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb5/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#3536]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb5/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#1836])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb8/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2920]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#658]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl3/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#658]) +4 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl7/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-glk: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk4/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#658])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb4/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][103] -> [SKIP][104] ([fdo#109441])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_cursor_plane_move:
- shard-tglb: NOTRUN -> [FAIL][105] ([i915#132] / [i915#3467])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109441])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][107] ([i915#31])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-snb5/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-kbl: NOTRUN -> [FAIL][108] ([IGT#2])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl1/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][109] ([i915#2828] / [i915#794])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl2/igt@[email protected]

* igt@kms_vrr@flip-basic:
- shard-tglb: NOTRUN -> [SKIP][110] ([fdo#109502])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#2437])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb3/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#2530]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb2/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][113] ([fdo#109271]) +225 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl6/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-rg:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#2530])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb4/igt@[email protected]

* igt@perf@unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109289]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb1/igt@[email protected]

* igt@prime_nv_api@i915_nv_double_import:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109291]) +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb6/igt@prime_nv_api@i915_nv_double_import.html

* igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][117] ([fdo#109291])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb8/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html

* igt@prime_vgem@basic-userptr:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#3301])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-apl3/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#2994]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb8/igt@[email protected]

* igt@sysfs_clients@fair-7:
- shard-glk: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk2/igt@[email protected]

* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl4/igt@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109307])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb2/igt@tools_test@sysfs_l3_parity.html
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#109307])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb6/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [DMESG-WARN][125] ([i915#180]) -> [PASS][126] +5 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-kbl4/igt@gem_ctx_isolation@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][127] ([i915#2842]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-iclb6/igt@gem_exec_fair@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][129] ([i915#2842]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-glk5/igt@gem_exec_fair@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][131] ([i915#2842]) -> [PASS][132] +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10754/shard-tglb5/igt@gem_exec_fair@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/shard-tglb1/igt@gem_exec_fair@[email protected]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6330/index.html

#3 lore raw
In reply to Ashutosh Dixit
Quoted 7 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the driver, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

The thought occurs that while the behaviour might now match the description (and the naming of the underlying flag), the function name really matches the old behaviour. Maybe the function should also be renamed to gem_has_execlist_submission()? Maybe even rename both to gem_using_(execlist|guc)_submission() to be properly accurate?

Or is that just over polishing things?

Quoted 31 lines

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.

---
  lib/i915/gem_submission.c   | 2 +-
  tests/i915/gem_ctx_shared.c | 2 +-
  tests/i915/gem_watchdog.c   | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
lib/i915/gem_submission.c +1 -1
index 2627b802cfb..b037d04cc4a 100644
@@ -86,7 +86,7 @@ unsigned gem_submission_method(int fd)
  		return 0;
 
  	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		flags |= GEM_SUBMISSION_GUC;
  		goto out;
  	}
 
tests/i915/gem_ctx_shared.c +0 -0
index ea1b5dd1b8c..f50ef13263f 100644

tests/i915/gem_ctx_shared.c static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg) · line 162

Quoted 5 lines
tests/i915/gem_ctx_shared.c +1 -1
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
  	uint32_t plug;
  	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));

I believe Tvrtko is suggesting this one should be a different test entirely:

Quoted 2 lines
tests/i915/gem_ctx_shared.c +0 -0
 Gem_ctx_shared/disjoint-timlines could perhaps use gem_uses_ppgtt() (for create vm)

and gem_scheduler_enabled() for context re-ordering

John.

Quoted 16 lines

/*
* Each context, although they share a vm, are expected to be

tests/i915/gem_watchdog.c +1 -1
index db562335a2a..21c7710a806 100644
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
  	const intel_ctx_t *ctx[num_engines];
  	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
  	igt_debug("%u virtual engines\n", num_engines);
  	igt_require(num_engines);
#4 lore raw
Quoted 10 lines · John Harrison
Quoted 7 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the driver, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

Quoted 7 lines

The thought occurs that while the behaviour might now match the description (and the naming of the underlying flag), the function name really matches the old behaviour. Maybe the function should also be renamed to gem_has_execlist_submission()? Maybe even rename both to gem_using_(execlist|guc)_submission() to be properly accurate?

Or is that just over polishing things?

No I agree, might as well change the names too while we are at it. We could probably have both _has_ and _using_ but I am not see much use for _has_ so will probably just keep _using_ as you suggest.

Quoted 12 lines

tests/i915/gem_ctx_shared.c static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg) · line 163

Quoted 10 lines

diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
index ea1b5dd1b8c..f50ef13263f 100644

tests/i915/gem_ctx_shared.c +1 -0
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
  -	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) ||
 gem_has_guc_submission(i915));

I believe Tvrtko is suggesting this one should be a different test entirely:

Quoted 3 lines
Quoted 1 line

Gem_ctx_shared/disjoint-timlines could perhaps use gem_uses_ppgtt() (for

create vm)

Quoted 1 line

and gem_scheduler_enabled() for context re-ordering

OK, let me go through the mails and see what I come up with in the next version. Thanks.